fb29d0e96d
Move async_minitest to package:async_helper.
...
This allows to break a circular dependency between package:expect and
package:async_helper, which will simplify the support for modular tests using
package:modular_test.
Change-Id: Ie48723d3f35d51a8fbe622e0158450e8104fe3f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102140
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-05-10 19:43:58 +00:00
ffee99d79b
Add asyncExpectThrows<T>() to async_helper.
...
This lets you test that a callback returns a Future that completes to
a given error. Like Expect.throws(), but async.
At first, I added support for this directly to Expect.throws(), but I
think it's better to minimize the amount of dynamic logic going on in
the language test framework.
I was worried about having to duplicate all of the Expect.throws___()
convenience functions but now that we have generic methods, those
functions aren't that much more convenient.
Change-Id: I8b288945611fa16f8d27056f3cf79181fc22d256
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97881
Reviewed-by: William Hesse <whesse@google.com >
2019-03-27 18:26:15 +00:00
9727a4a4ef
Fix #33415 no error for awaiting a void expression.
...
Bug: 33415
Change-Id: I4d4e81fef79a5bc5162e37ab07a8fe99e50c8dfc
Reviewed-on: https://dart-review.googlesource.com/60522
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-07-24 19:31:57 +00:00
dc76aa34c7
Stop using a port to keep the isolate alive in async_helper.
...
Addresses issue #33067 .
Bug: http://dartbug.com/33067
Change-Id: Id9e60e930a8f289a51063f609e13fb998f6907c3
Reviewed-on: https://dart-review.googlesource.com/55662
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-05-18 09:33:27 +00:00
8dc7d5e907
Update language_2/await_test.dart to use async_helper.
...
Add more tests.
See #31535 .
Bug: http://dartbug.com/31535
Change-Id: I1db9ecb84d9ed87f1111e3fdc9637143cf46fa33
Reviewed-on: https://dart-review.googlesource.com/26220
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2017-12-06 12:05:59 +00:00
de54e18369
Run dartfmt on remaining unformated pkg packages
...
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2743423009 .
2017-03-21 18:21:32 -07:00
3a66c29a6d
Add cleanUp function to Future.wait.
...
The cleanUp function is called on the values of successful futures,
so it can release any resources that were successfully allocated.
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//815773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42730 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 10:52:15 +00:00
776bd8ef05
Call asyncEnd only on success.
...
BUG=
R=ahe@google.com , kustermann@google.com
Review URL: https://codereview.chromium.org//23512008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27465 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-13 07:36:02 +00:00
4c7b97d041
Remove reference to unimported Future.
...
BUG=
Review URL: https://codereview.chromium.org//23551007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27030 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 08:28:11 +00:00
3d22a350b3
First pass at asynchronous input loading in dart2js.
...
R=ahe@google.com , johnniwinther@google.com
Review URL: https://codereview.chromium.org//17759007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27028 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 08:04:38 +00:00
a1a91eb915
Add async_helper package.
...
This package is private and should not be published to pub (nor should
its documentation be published to api.dartlang.org).
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23547005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26774 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 09:24:50 +00:00
Sigmund Cherem