dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

448 Commits

Author SHA1 Message Date
Devon Carew 6e9adf2624 Remove older deprecated flags; more cleanup to the cli help args. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2692203010 .
 2017-02-17 13:30:37 -08:00
Devon Carew e1fb256694 Fix an arg parser test for the analyzer cli. 
BUG=

Review-Url: https://codereview.chromium.org/2696703011 .
 2017-02-17 06:56:33 -08:00
Devon Carew b4be2c9b1f Options cleanup for the command-line analyzer. 
BUG=
R=pquitslund@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2695923012 .
 2017-02-17 06:18:55 -08:00
Konstantin Shcheglov e8c2978437 Use only MemoryByteStore in analyzer_cli. 
Unfortunately evicting from cache makes it slow to use in potentially
short running cli tool.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2698993002 .
 2017-02-16 14:07:42 -08:00
Konstantin Shcheglov b7f17423da Revert "Revert "Reapply "Switch to the new analysis driver in analyzer_cli.""" 
This reverts commit 64df435361.

Originally landed as https://github.com/dart-lang/sdk/commit/cda7520e5c19425637351be5eae04af7e3136111
No new changes.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2698263002 .
 2017-02-16 09:43:31 -08:00
Konstantin Shcheglov 72463adf20 If the state location is not accessible, use MemoryByteStore. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2697653004 .
 2017-02-15 08:37:22 -08:00
Zach Anderson 64df435361 Revert "Reapply "Switch to the new analysis driver in analyzer_cli."" 
This reverts commit 623d2868a9.

Review-Url: https://codereview.chromium.org/2692073004 .
 2017-02-14 15:21:53 -08:00
Konstantin Shcheglov 623d2868a9 Reapply "Switch to the new analysis driver in analyzer_cli." 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2696083002 .
 2017-02-14 14:41:42 -08:00
Konstantin Shcheglov 25bc8ddd68 Fix for reporting not analyzed parts with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2695863003 .
 2017-02-14 14:18:03 -08:00
Konstantin Shcheglov 7e9f4ba34c Make the test's dart:core import dart:async in tests. 
SDK's version does it, and we probably don't want to protect aginst
something what happens only in tests, but is not expected actually.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2696013004 .
 2017-02-14 13:31:18 -08:00
Konstantin Shcheglov e97042bec3 Revert "Switch to the new analysis driver in analyzer_cli." 
This reverts commit cda7520e5c.

There is a couple of integration tests for embedder analyzer_cli which
are failing, and I cannot find the solution quickly.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2695823005 .
 2017-02-14 12:35:46 -08:00
Konstantin Shcheglov cda7520e5c Switch to the new analysis driver in analyzer_cli. 
Our internal users use the new analysis driver, and we're enabling it
for everyone in 1.23, AFAIK.

We disable using the file system byte store during internal testing
because we don't want accidentally change analyzer code, run tests
and get all green only because we forgot to update DATA_VERSION.

R=brianwilkerson@google.com, whesse@google.com
BUG=

Review-Url: https://codereview.chromium.org/2694083002 .
 2017-02-14 09:04:26 -08:00
Devon Carew d60a930ccd Commit updated metadata; this should reduce scm churn. 
BUG=
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2692573005 .
 2017-02-10 15:31:27 -08:00
Konstantin Shcheglov f120d02f92 Enable Dart for all modules. 
R=devoncarew@google.com
BUG=

Review-Url: https://codereview.chromium.org/2686183004 .
 2017-02-10 13:27:55 -08:00
Devon Carew 86a235e219 Add intellij metadata to the repo. 
BUG=
R=pquitslund@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2689673003 .
 2017-02-10 12:47:06 -08:00
Leaf Petersen 0c2bf046f1 Add FutureOr to analyzer_cli test async.dart. 
Fixes https://github.com/dart-lang/sdk/issues/28653 .

BUG=
R=brianwilkerson@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2675203006 .
 2017-02-06 17:08:33 -08:00
danrubel 167107e94c fix dartanalyzer sdk setup 
Separate analysis options initialization from context setup
so that analysis options can be used to correctly setup the SDK
in strong mode.

Fix https://github.com/dart-lang/sdk/issues/28507

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2678633002 .
 2017-02-04 12:08:53 -05:00
Konstantin Shcheglov 39a5e660cd Call addFile() before getErrors() to actually get errors. 
With this change we have only 7 failing shared tests.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2662693002 .
 2017-01-27 15:11:09 -08:00
Konstantin Shcheglov 8cca41772d Implement AnalysisDriver.getSourceKind() and use it in analyzer-cli. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2658983004 .
 2017-01-27 14:29:44 -08:00
Konstantin Shcheglov 6bb8a923d3 Use AnalysisDriver.getErrors() to get cached errors for already analyzed files. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2656233004 .
 2017-01-27 13:26:45 -08:00
Konstantin Shcheglov a3cc5fe7f7 Implement using AnalysisDriver in analyzer_cli. Disabled. 
It's not ready to be enabled yet.

There are 11 failing tests in tests/language, and 174 in tests/co19.

It also works about 5 times slower.

But I'd like to land it to make parallel changes to AnalysisDriver and
analyzer_cli to make it pass more tests and be faster.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2657903006 .
 2017-01-26 10:16:52 -08:00
Konstantin Shcheglov 15cf5cb017 Run analyzer_cli asynchronously. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2658863002 .
 2017-01-26 09:42:51 -08:00
Konstantin Shcheglov d142d80af7 Make analyzer_cli batch mode asynchronous. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2659463003 .
 2017-01-26 07:25:23 -08:00
Konstantin Shcheglov b206c84210 Reland c9e1b88 and 56726fc with a DDC fix. 
Revert "Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider.""

This reverts commit b701ad6453.

R=brianwilkerson@google.com, vsm@google.com
BUG=

Review-Url: https://codereview.chromium.org/2647323006 .
 2017-01-24 09:13:26 -08:00
Vijay Menon b701ad6453 Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider." 
This reverts commit c9e1b888a3.

Revert "Remove parent from SummaryResynthesizer."

This reverts commit 56726fcce0.

TBR=scheglov@google.com

Review-Url: https://codereview.chromium.org/2648213007 .
 2017-01-24 06:21:38 -08:00
Konstantin Shcheglov c9e1b888a3 Use single InputPackagesResultProvider, without SdkSummaryResultProvider. 
Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.

For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.

R=brianwilkerson@google.com, paulberry@google.com, vsm@google.com
BUG=

Review-Url: https://codereview.chromium.org/2652823002 .
 2017-01-23 16:54:17 -08:00
Dan Rubel 13bd1ad0bf DDC/AnalyzerCLI common cmdline option processing 
Refactor DDC and Analyzer CLI command line option processing
to use common createContextBuilderOptions method
and ContextBuilderOptions to hold common options.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2584293003 .
 2016-12-19 16:24:20 -05:00
danrubel a105d89e2b refactor DDC and Analyzer CLI parser option declaration 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2580933002 .
 2016-12-15 14:10:09 -05:00
danrubel e321439470 cleanup Analyzer CLI and DDC arg parsing 
This removes the need to split arguments on '='
before calling the extractDefinedVariables method.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2581723002 .
 2016-12-15 12:16:20 -05:00
danrubel 5b84611856 refactor DDC to support --ignore-unrecognized-flags 
* add --ignore-unrecognized-flags to DDC
* refactor Analyzer CLI to use same filterUnknownArguments functionality
* remove now unused CommandLineParser and associated tests

R=brianwilkerson@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2578113002 .
 2016-12-15 10:46:09 -05:00
danrubel 2c62510f5f move CommandLineParser into analyzer for reuse by DDC 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2578733002 .
 2016-12-14 16:31:45 -05:00
danrubel 1417eec66e move extractDefinedVariables from analyzer cli to analyzer 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2571583007 .
 2016-12-14 13:22:41 -05:00
Dan Rubel 5aa30397d7 update DDC and analyzer cli preprocessArgs 
* refactor Analyzer CLI and DDC to use common preprocessArgs method
* throw clear exception if trailing @file not found or cannot be read
* update preprocessArgs method to always return new list

R=brianwilkerson@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2572813002 .
 2016-12-13 14:37:22 -05:00
Dan Rubel 665a12d1b5 add verbose option to show hidden options 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2570053002 .
 2016-12-13 11:17:23 -05:00
Brian Wilkerson 756cfc963d Fix warnings 
Review-Url: https://codereview.chromium.org/2564323002 .
 2016-12-11 16:53:13 -08:00
Brian Wilkerson 86c62a6bad Remove the command-line plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2565993002 .
 2016-12-11 10:59:19 -08:00
Brian Wilkerson a01afcd1d1 Remove the options plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2569603002 .
 2016-12-11 08:38:29 -08:00
Brian Wilkerson ebf5fbcd0e Remove references to the linter plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2567863002 .
 2016-12-10 10:00:20 -08:00
YoungSeok Yoon 82ee421bb0 Use the new path to the linter package (#28062) 2016-12-09 21:52:32 -08:00
Brian Wilkerson 0ea654a068 Remove the AnalysisOptionsProcessor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559523005 .
 2016-12-07 10:51:33 -08:00
Brian Wilkerson 20baedc660 Reapply "Move the linter core to the analyzer package" 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559773002 .
 2016-12-07 09:57:17 -08:00
Paul Berry 1a172e935b Revert "Move the linter core to the analyzer package" 
This reverts commit 6d9d5f53a1, which
was causing analysis server unit tests to fail.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2561573003 .
 2016-12-07 05:36:46 -08:00
Brian Wilkerson 6d9d5f53a1 Move the linter core to the analyzer package 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2553203002 .
 2016-12-06 09:42:26 -08:00
Dan Rubel aff6b796f3 update analyzer cli to support include directive in analysis options file 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2541933002 .
 2016-11-30 15:16:55 -05:00
Brian Wilkerson 7e067a6fc8 Enable read-only access to initializing formals (issue 27895) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2532953004 .
 2016-11-29 07:46:28 -08:00
Brian Wilkerson 5b1236cfe7 Fix the setting of analysis options when there is an embedded SDK 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2523313002 .
 2016-11-23 15:48:42 -08:00
Brian Wilkerson e63105555b Remove uses of configuration data 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522543007 .
 2016-11-22 11:26:08 -08:00
Adam Barth 60b3ac9712 Added a build file for analyzer_cli. 
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2492263003 .
 2016-11-21 11:01:11 -08:00
Brian Wilkerson 96750cd5cb Split out options from ContextBuilder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2425423009 .
 2016-10-20 11:03:11 -07:00
Brian Wilkerson 3121296942 (TBR) Fix failing tests 
Review URL: https://codereview.chromium.org/2426703002 .
 2016-10-17 11:55:31 -07:00