dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

25 Commits

Author SHA1 Message Date
Brian Wilkerson 0b8aee98b8 Remove tests from analyzer-cli that do not test code in that package 
Change-Id: Icfa56ba8bc29aca2c780252683e904bacffdaf6f
Reviewed-on: https://dart-review.googlesource.com/c/82801
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-04 19:57:38 +00:00
danrubel a82e025739 Move dartfix to its own package 
Fix https://github.com/dart-lang/sdk/issues/34765

Change-Id: I44b3ccc4861b383601fea1b006f1fd4726b11062
Reviewed-on: https://dart-review.googlesource.com/c/81080
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-10-22 17:50:25 +00:00
Brian Wilkerson a342cecffd Disable support for the old super mixins 
Change-Id: I8f8074b67ea43249fcc10deddd2325938996d529
Reviewed-on: https://dart-review.googlesource.com/c/79469
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-22 16:02:01 +00:00
Dan Rubel 746034785d Update dartfix to separate targets from analysis roots 
Change-Id: I6e6435df9ffe593d797c43723bd61701e204897a
Reviewed-on: https://dart-review.googlesource.com/c/78720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-09 15:48:08 +00:00
Devon Carew 6346b18028 Restore a strong mode analyzer cli test. 
Bug:
Change-Id: If9b459d99a3120071ba8f3a7bd9aa1d2e776bbd6
Reviewed-on: https://dart-review.googlesource.com/29443
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2017-12-13 22:26:56 +00:00
Devon Carew 5d0056df88 Make the exit code for dartanalyzer more deterministic. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2857203002 .
 2017-05-03 11:38:35 -07:00
danrubel abee739921 rework analyzer_cli to use ContextBuilder getAnalysisOptions 
This is a follow on to https://codereview.chromium.org/2716693003
that refactors analyzer_cli to use ContextBuilder.
As a result, dartanalyzer now correctly finds the default
flutter analysis options when the project references package:flutter
but does not contain an analysis options file.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2710313002 .
 2017-02-23 16:52:26 -05:00
Devon Carew 46cacfeae9 Some improvements to the command-line analyzer's output. 
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2704103002 .
 2017-02-22 12:35:09 -08:00
Brian Wilkerson 0ea654a068 Remove the AnalysisOptionsProcessor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559523005 .
 2016-12-07 10:51:33 -08:00
pq 31a03ec31b Skip SDK summaries in the presence of SDK extenders (#26448). 
Works around crash provoked by mojo: https://github.com/dart-lang/sdk/issues/26448.

The rub is that using SDK summaries in the presence of SDK extenders (and embedders) is unsafe.

Greater context: https://github.com/dart-lang/sdk/issues/26467.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1990463002 .
 2016-05-17 11:10:43 -07:00
pq 7937623063 Don't use SDK summaries with embedders (#26448). 
Addresses the issue seen in https://github.com/dart-lang/sdk/issues/26448.

Ultimately we want a better story for summaries in the presence of embedded SDKs; in the short-term this simply disables them.

The trick (and reason for all of the changes here) is that there is *a lot* of temporal coupling in the initiailization of contexts, sdks, resolvers, etc.  With this change, embedder processing is pulled out to where it can be done before the SDK is configured.  Hopefully this even makes this a bit more clear as resolver setup is less complex.

Open question: I think the logic that calls `pub list-dirs` is dead and can safely be removed.  Comments there welcome.

Thanks!

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1984733003 .
 2016-05-16 14:13:40 -07:00
Jacob MacDonald d2e2241fc1 update to use bazel_worker package 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1885073002 .
 2016-04-14 07:46:33 -07:00
Jacob MacDonald 92419d092b Update worker mode to use the bazel protos directly instead of json 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1868663002 .
 2016-04-06 13:49:32 -07:00
Konstantin Shcheglov 6347b4cca7 Support --persistent_worker flag in --build-mode. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1848543002 .
 2016-03-30 12:31:09 -07:00
Brian Slesinsky 9e21594c2a add --x-package-warnings-prefix option to dartanalyzer 
This is similar to --package-warnings, except that diagnostics will
only be reported for Dart packages matching the given prefix.

Also added the number of source files analyzed and the number of
errors generated to performance report.

Cleanup: simplified code for triggering diet parsing.

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1806263004 .
 2016-03-21 11:37:49 -07:00
pq 1dcec8c35f Bootloader cleanup. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1570603004 .
 2016-01-11 14:13:44 -08:00
Brian Slesinsky ba1b82b240 Add --x-perf-report flag to the dartanalyzer command 
Also added a couple of performance tags to catch time spent in the driver.

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org/1524413002 .
 2015-12-17 11:40:15 -08:00
pq 5a57d6e8dc CLI driver test re-enablement (#25001). 
Another stab.  The rub, I *think*, to our failures are unexpected calls to `exit()` on the bots (that are not reproducing locally).  These fixes should address that (and fix error stream handling along the way).

* fixes test setup and teardown to ensure exit handling is properly managed.
* fixes driver source to use the `exitHandler` and `errorSink` consistently

BUG=
R=keertip@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1525623003 .
 2015-12-14 13:08:47 -08:00
pq 1c3df7f4ec Revert "Make analyzer_cli tests bot-friendly (#25001)." 
This reverts commit e67affe6b6.

R=keertip@google.com

Review URL: https://codereview.chromium.org/1524493002 .
 2015-12-11 14:57:01 -08:00
pq e67affe6b6 Make analyzer_cli tests bot-friendly (#25001). 
* re-enables a host of tests that were breaking on the bots due to path issues

Bug: https://github.com/dart-lang/sdk/issues/25001

R=keertip@google.com

Review URL: https://codereview.chromium.org/1516353003 .
 2015-12-11 14:13:30 -08:00
Brian Wilkerson ea3ba0e31f Remove deprecated code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1502213002 .
 2015-12-07 10:24:36 -08:00
pq c58e064b67 Remove bot-unfriendly tests (#25001). 
Remove tests pending update.

Background: https://github.com/dart-lang/sdk/issues/25001

BUG=25001

Review URL: https://codereview.chromium.org/1459083005 .
 2015-11-19 16:15:18 -08:00
pq 9ae1265ff5 analyzer_cli move to SDK. 
Tracking bug: https://github.com/dart-lang/sdk/issues/24731

Note, dartium build changes are in a separate CL: https://codereview.chromium.org/1453413006/

Some tests had to be disabled for want of mockito in the SDK; tracking their reimplementation is here: https://github.com/dart-lang/sdk/issues/24994

BUG=24731
R=whesse@google.com

Review URL: https://codereview.chromium.org/1459683003 .
 2015-11-19 14:52:54 -08:00
pq 5cc9a288bb Revert "Move analyzer_cli into the SDK." 
This reverts commit a573ed31f1.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1462143002 .
 2015-11-19 11:28:52 -08:00
pq a573ed31f1 Move analyzer_cli into the SDK. 
Build changes to follow.

Tracking bug: https://github.com/dart-lang/sdk/issues/24731

BUG=24731
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1464553003 .
 2015-11-19 11:11:17 -08:00