239bd1383b
Report MEMBER_WITH_CLASS_NAME for static getter/setter with the enclosing class name.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/34289
Change-Id: I8b593b4a652547e54ed06c80e34e82c11a14d7e8
Reviewed-on: https://dart-review.googlesource.com/73241
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-09-05 18:11:00 +00:00
b443c9f72f
Parse static get/set with name of the enclosing class as getters/setters.
...
R=brianwilkerson@google.com , danrubel@google.com
Change-Id: I97015fbc3bc49c70a022a2edabf4fcdcc34405ad
Reviewed-on: https://dart-review.googlesource.com/73020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-05 15:43:48 +00:00
0898620787
Fix constant computing for negative shift left/right and remainder.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/33481
Change-Id: I0cc1b07b222f1fe739df6c720d7357a2453ee1b9
Reviewed-on: https://dart-review.googlesource.com/73040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-05 15:41:58 +00:00
dcf1f0a145
Revert "Remove addCompileTimeError in favor of addProblem"
...
This reverts commit f872c17a85https://dart-review.googlesource.com/73100
> Commit-Queue: Peter von der Ahé <ahe@google.com >
> Reviewed-by: Jens Johansen <jensj@google.com >
TBR=ahe@google.com ,jensj@google.com
Change-Id: I3ea736a9752805adb3bacc8b67e8eb1435c1bf69
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/73181
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2018-09-05 14:13:48 +00:00
f872c17a85
Remove addCompileTimeError in favor of addProblem
...
Replace most methods with names containing CompileTimeError with corresponding
Problem methods.
Also make Severity.error the default severity.
Change-Id: I85a340168848cd3b4375b3f53cb0361251ed6e5d
Reviewed-on: https://dart-review.googlesource.com/73100
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-09-05 13:47:23 +00:00
2b995b2654
Drop SummaryBuilder constructor's optional "strong" parameter.
...
Note that although this change is inside analyzer/lib/src, in practice
it is a breaking change to the analyzer API, since several clients
invoke the SummaryBuilder constructor. Fortunately we can make
breaking changes now since we have not yet published version 0.33.* of
the analyzer.
To my knowledge, all clients that we care about keeping synchronized
to the bleeding edge version of the analyzer have been modified so
that they no longer pass in the optional parameter. The remaining
clients shouldn't be affected since their pubspecs still point to
analyzer version 0.32.*.
Change-Id: I627bb7b1242e8e36ec82927ed8fe722b5b249fd6
Reviewed-on: https://dart-review.googlesource.com/73000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-09-04 21:57:56 +00:00
eedc31e111
Fix for for-in when iterable does not have a type.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/33370
Change-Id: I22ee3c5861ecaa3e6b2bc0f00e7f04191bcd7e78
Reviewed-on: https://dart-review.googlesource.com/72960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-04 21:19:39 +00:00
48a1504b2f
Stop reporting CONFLICTING_INSTANCE_GETTER_AND_SUPERCLASS_MEMBER and CONFLICTING_INSTANCE_SETTER_AND_SUPERCLASS_MEMBER.
...
These errors were removed from the spec.
See also https://github.com/dart-lang/sdk/issues/33235
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/34331
Change-Id: Ibc675aa48165300ddac32a8d6ddef4d84d41952a
Reviewed-on: https://dart-review.googlesource.com/72903
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-04 20:29:06 +00:00
d65a0ee361
Report more errors for mixin declarations.
...
I added a fix for parsing static methods in mixins.
R=brianwilkerson@google.com , danrubel@google.com
Change-Id: Ib3c91f6cd5a2eb333f88102609f709fcac1ab9e7
Reviewed-on: https://dart-review.googlesource.com/72901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-04 19:41:25 +00:00
a52b40041b
Report MIXIN_DECLARES_CONSTRUCTOR and FINAL_NOT_INITIALIZED for mixins.
...
I renamed the previous error const to MIXIN_CLASS_DECLARES_CONSTRUCTOR.
R=brianwilkerson@google.com
Change-Id: If06f264e61b7d3e7c254eb457f4b2dc45ef76174
Reviewed-on: https://dart-review.googlesource.com/72860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-09-04 17:17:07 +00:00
35eacd1afc
Type arguments to a constructor is an error.
...
Fixes https://github.com/dart-lang/sdk/issues/34159
Change-Id: Ib4cca43f4181f2557560fa45ca41dd059c8b5b06
Reviewed-on: https://dart-review.googlesource.com/71521
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Daniel Hillerström <hillerstrom@google.com >
2018-09-04 12:06:14 +00:00
7a7ab6410d
Resolve using mixin(s) in 'with' clauses.
...
This also allows searching for mixin(s), which we test now.
R=brianwilkerson@google.com
Change-Id: I6c1944db0e6ecbc0f7352188968e53ef38603426
Reviewed-on: https://dart-review.googlesource.com/72554
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-09-04 01:02:13 +00:00
4cd69887e3
Fix parsing postfix expressions with type parameters
...
Fix https://github.com/dart-lang/sdk/issues/34315
Change-Id: Id6b1749070473ed5a04a3f024276f9985f82da6e
Reviewed-on: https://dart-review.googlesource.com/72560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-09-02 18:51:31 +00:00
6c197f7bb1
Address comments
...
address comments in https://dart-review.googlesource.com/c/sdk/+/72123
Change-Id: I0752369d4e41e72dc772cd63cf62625e2e3988ba
Reviewed-on: https://dart-review.googlesource.com/72500
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-09-01 16:16:39 +00:00
7cf078c05d
Index and search for mixins.
...
R=brianwilkerson@google.com
Change-Id: I5399507dc5a9688ee5944f6554167a6b1e8692b6
Reviewed-on: https://dart-review.googlesource.com/72525
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-31 21:38:26 +00:00
a4a80a0bf1
Start reporting errors for mixin super-class constraints and implements clauses.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I6e6e3edc16737b1d3f665982f7560b46d8b71f01
Reviewed-on: https://dart-review.googlesource.com/72522
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-31 20:25:35 +00:00
0fae13e6bf
Support for mixins in search.getElementDeclarations.
...
R=brianwilkerson@google.com
Change-Id: I88e90159ae28a2585fdbaacca2c4caab15891b83
Reviewed-on: https://dart-review.googlesource.com/72523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-31 20:19:18 +00:00
e96652352d
Resolve mixin declarations.
...
Errors for onClause are not correct yet, and not tested yet.
R=brianwilkerson@google.com
Change-Id: I9a1f2b4734661baac85a9d1b9311d21104c7c495
Reviewed-on: https://dart-review.googlesource.com/72360
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-31 16:11:21 +00:00
05ab41c99b
Refactor summary tests in preparation for adding a one-phase summary API.
...
I will soon be adding an API for generating summaries that generates
them in one phase, as opposed to the current two-phase approach of
building unlinked summaries and then linking them together. This is
will be needed in order to support full type inference of summaries,
since full type inference requires examining the contents of
block-bodied closures, and it's not worth the effort of trying
serialize the contents of block-bodied closures into unlinked
summaries.
To prepare for this, the summary tests need to be generalized so that
during the transition period they will be able to be run with either
API.
This CL introduces several classes in a new `test_strategies.dart` file:
- Interfaces `SummaryBaseTestStrategy`, `SummaryBlackBoxTestStrategy`,
and `SummaryLinkerTestStrategy`. These interfaces define the
methods that can be invoked by tests of the summary mechanism.
- Implementations of those interfaces:
`SummaryBlackBoxTestStrategyPrelink`,
`SummaryBlackBoxTestStrategyTwoPhase`, and
`SummaryLinkerTestStrategyTwoPhase`. These classes provide the
ability to drive the summary mechanism in various ways. When the
one-phase API is added, more classes will be added to drive it.
- A few private classes occupying intermediate positions in the class
hierarchy, as well as auxiliary data structures needed by the above
classes.
The tests themselves have been moved into mixin classes so that they
can be applied to any of the implementations above.
Change-Id: Iac3585944297f78f184d35de544aa4c8d8abe99a
Reviewed-on: https://dart-review.googlesource.com/72320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-08-31 13:25:08 +00:00
02b2deefd6
Remove StaticWarningCode.isStrongModeError flag.
...
It is not used internally outside Analyzer itself.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Iec2b45ebaeb49400e9f61a137a85170657856016
Reviewed-on: https://dart-review.googlesource.com/72300
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-08-31 01:19:24 +00:00
fa759513ac
Add mixin header recovery
...
Along with the new recovery, there are two new error codes
and their corresponding CFE counterparts:
* ParserErrorCode.IMPLEMENTS_BEFORE_ON
* ParserErrorCode.MULTIPLE_ON_CLAUSES
* ImplementsBeforeOn
* MultipleOnClauses
Change-Id: If9055c9ffa5d56495acf00889236a3a8f6d741ca
Reviewed-on: https://dart-review.googlesource.com/72123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-08-31 00:25:16 +00:00
ce117b0f92
Revert "Add support in analysis options file for new mixin declaration"
...
Change-Id: If051da5a77ce697525e11c33d33a1e88e7c42832
Reviewed-on: https://dart-review.googlesource.com/72280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-08-30 22:11:04 +00:00
584199eff4
Make the relink() method private.
...
It's not used by any code except the linker.
Change-Id: Ia2f145279261e42deb9f355898bb429eef0f5413
Reviewed-on: https://dart-review.googlesource.com/72243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-08-30 22:09:31 +00:00
c9d1c4a3b7
Suite of source code based resolution tests.
...
As opposite to constructing AST nodes and calling partial resolvers.
Also the set of tests that we created for CFE integration is too large,
so I started splitting it into pieces and cleaning up to use findNode,
fincElement, and assertElement/Type().
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ide4f0bee9e89eb2daf2317d1d92303a992847f1b
Reviewed-on: https://dart-review.googlesource.com/72240
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-30 21:49:44 +00:00
db8b6bc549
Don't report StaticWarningCode.CONFLICTING_DART_IMPORT.
...
The warning was removed from the language specification.
Plus some optimization for import scope and conflicts.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I78b6924f9095dce89324f4093e78c948611f8493
Reviewed-on: https://dart-review.googlesource.com/72064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-30 20:56:41 +00:00
8c6259fbe8
Add support in analysis options file for new mixin declaration
...
Change-Id: I0e991ea2c52442ff8a30dc5190d2b37cf14adebf
Reviewed-on: https://dart-review.googlesource.com/72180
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-08-30 19:12:04 +00:00
8c7e83aed2
Remove generic method comment support
...
Change-Id: I1149ff9c61748fe8d3a51c95e40c02ec5115b0e7
Reviewed-on: https://dart-review.googlesource.com/72122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-08-30 17:52:40 +00:00
a207d36fc2
Remove generic method comment from old parser
...
Change-Id: I48ae219a238661d042815370960647a0c8b17164
Reviewed-on: https://dart-review.googlesource.com/72121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-08-30 17:34:52 +00:00
bd9645abad
Convert FOR_IN_WITH_CONST_VARIABLE to using message.
...
Analyzer reports it, so it should not be fromFasta().
R=brianwilkerson@google.com
Change-Id: Id0db50e5f770bbae60d1955a05e632f548a104e3
Reviewed-on: https://dart-review.googlesource.com/72140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-30 16:50:40 +00:00
171747a8e5
Resynthesize mixin declarations.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Icb7a122cb39502625ecd253eb53cfb50a82e5da0
Reviewed-on: https://dart-review.googlesource.com/72070
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-30 16:14:09 +00:00
ba0d814336
Remove obsolete parser tests
...
Change-Id: I74f0f65e0888a185644f9908e5a25e0c550113ec
Reviewed-on: https://dart-review.googlesource.com/72120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-08-30 15:37:44 +00:00
e76d37f307
Remove strong mode booleans related to summary linking.
...
The analyzer always runs in strong mode now, so these booleans aren't
needed.
Change-Id: Ic16ca9f37f8befead5aee85140fb70395a1d3511
Reviewed-on: https://dart-review.googlesource.com/71622
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-30 13:54:42 +00:00
d04d304909
Stop using/generating spec.sum file.
...
For some time now, this file has had the same contents as strong.sum.
There's no point in keeping it around.
Change-Id: I793a41ca6cb1c47c68357f549d299fa95b96c4c5
Reviewed-on: https://dart-review.googlesource.com/71701
Reviewed-by: Zach Anderson <zra@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-08-30 12:32:52 +00:00
f5f33776a4
Revert "Store code ranges for formal parameters."
...
This reverts commit 5b9a42de29https://dart-review.googlesource.com/72100
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-08-30 10:20:18 +00:00
d659022f08
Build elements for MixinDeclaration(s).
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ica9912b795bbdfeea2dd46130e30bde3bdc4cef3
Reviewed-on: https://dart-review.googlesource.com/72067
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-29 21:05:35 +00:00
9c642328ac
Summarize mixin declarations.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I2aecbe4e3c5548a8034c51191f58eaf3439b9d76
Reviewed-on: https://dart-review.googlesource.com/71928
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-29 19:08:56 +00:00
ecfc82c05d
Re-enable two tests.
...
Change-Id: I9e829ae84556b9b7caa6d5b12bfd710ccab3a443
Reviewed-on: https://dart-review.googlesource.com/71925
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-08-29 18:35:32 +00:00
1f52372bfa
Remove CFE integration from analyzer, analysis_server, and analyzer_cli.
...
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.
Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-29 13:46:45 +00:00
94dabdaae7
Error when importing a part
...
Fixes https://github.com/dart-lang/sdk/issues/33650
Change-Id: I2fb5f4bf7c20309c2da9660911b7ce2088e7efea
Reviewed-on: https://dart-review.googlesource.com/71820
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-08-29 12:19:17 +00:00
3ea3b21e3c
Deprecate summary field PackageBundle.unlinkedUnitHashes.
...
No code has attempted to read these hashes from summaries for a long
time, so there is no point in writing them out.
Change-Id: I96854d4d5438fb6d5b4ab81b495407e2fc36d82f
Reviewed-on: https://dart-review.googlesource.com/71702
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-08-29 05:36:26 +00:00
1b8f3026bf
Remove most of isStrongModeError: false, update language_2 tests.
...
https://github.com/dart-lang/sdk/issues/33022
https://github.com/dart-lang/sdk/issues/28823
https://github.com/dart-lang/sdk/issues/11124
Change-Id: I44427cdab25aae356ec89d677fa142d23d7b42c7
Reviewed-on: https://dart-review.googlesource.com/71428
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-08-29 02:06:45 +00:00
68e66d4ef5
Parser test cleanup
...
Change-Id: I93c6a019267d3538e2874acdd06041a330b2cb09
Reviewed-on: https://dart-review.googlesource.com/71900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-08-28 23:00:16 +00:00
f40ff153a9
Enable --use-fasta-parser with the analyzer by default.
...
Based on Devon's change at:
https://dart-review.googlesource.com/c/sdk/+/67090
Change-Id: I80b7943826e248bf37d9bbbb769330d24b0dd6ae
Reviewed-on: https://dart-review.googlesource.com/70160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2018-08-28 19:29:17 +00:00
07fb992964
Report CompileTimeErrorCode.FOR_IN_WITH_CONST_VARIABLE
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/25161
Change-Id: I27ebc09fd9fcd6d6d992268f158e80477c41d042
Reviewed-on: https://dart-review.googlesource.com/71424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-26 20:09:46 +00:00
04e2ada09b
Report StaticTypeWarningCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS for dynamic and type parmaeters.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/28813
Change-Id: Iae43c0bb913bfd06fa09ddeacd6fdb8f81eccf9a
Reviewed-on: https://dart-review.googlesource.com/71423
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-26 03:42:31 +00:00
5424289f95
Analyzer test cleanup: remove unnecessary getter includeInformative
...
This getter appears to have been introduced in anticipation of
refactoring the summary mechanism to avoid populating summaries with
unnecessary "informative" data (see
da6a26966ehttps://dart-review.googlesource.com/71427
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-08-24 22:05:21 +00:00
aa6945d5e9
First cut basic mixin declaration parsing support
...
... with parser recovery added in subsequent CLs.
Change-Id: I7a73e8e2a4dee961920fe9854bcd108bb1041b20
Reviewed-on: https://dart-review.googlesource.com/70882
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-08-24 21:58:55 +00:00
e91d30e904
Analyzer test cleanup: remove unnecessary getter skipNonConstInitializers
...
The getter used to be used to skip certain tests when testing the code
that computed summaries from the element model. That code was removed
nearly two years ago (d13a887292https://dart-review.googlesource.com/71440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-08-24 21:57:14 +00:00
6e63df3bfb
Revert "Avoid the deprecated input error in source_loader"
...
Reverted because of failures on the VM reload tests.
Change-Id: I880523a5f3e14cc6d318d4493f037b79515b1dce
Reviewed-on: https://dart-review.googlesource.com/71401
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Kevin Millikin <kmillikin@google.com >
2018-08-24 11:03:28 +00:00
0eb0f700b8
Avoid the deprecated input error in source_loader
...
Avoid using deprecated errors by hadling them on a case-by-case basis.
This is a version of https://dart-review.googlesource.com/c/sdk/+/63144
with merge conflicts resolved.
Fixes #33686
Change-Id: I726740af2db5d32f15c8103c903376bc8ea948e6
Reviewed-on: https://dart-review.googlesource.com/71161
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Kevin Millikin <kmillikin@google.com >
2018-08-24 09:14:15 +00:00
Konstantin Shcheglov