Commit Graph

7628 Commits

Author SHA1 Message Date
Brian Wilkerson c10da25d48 Mark the toString method from enum declarations as being synthetic
Change-Id: If8f3e0692ac5ff79fb61be613d59d6dae726bf0d
Reviewed-on: https://dart-review.googlesource.com/c/88041
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-23 18:03:11 +00:00
Brian Wilkerson 074627f170 Clean up the fasta-related tests
Change-Id: I6cec24bc5b07bb6f4673a3f5586c9477377dd748
Reviewed-on: https://dart-review.googlesource.com/c/87983
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-21 21:15:29 +00:00
danrubel f0377b2f92 Add support for parsing simple nullable types
... as part of adding NNBD as outlined in
https://github.com/dart-lang/language/issues/110

This only supports parsing simple nullable types
such as int? and List<int>? while subsequent CLs
will add support for parsing more complex types.

Due to current parser limitations, it also only supports
nullable types in a limited number of statements such as

T? t;
if (x is String?) {}

In addition, address comments in
* https://dart-review.googlesource.com/c/sdk/+/87880
* https://dart-review.googlesource.com/c/sdk/+/87881

Change-Id: Ife4afadc0b72906fc0c4e9b1977ad838041c2a84
Reviewed-on: https://dart-review.googlesource.com/c/87920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-21 12:36:07 +00:00
Dan Rubel 096e734b05 Replace //@NNBD with @pragma(analyzer:non-nullable*)
Change-Id: I90a8a23601c7939e400ecadd5f14ac0b4caf2e39
Reviewed-on: https://dart-review.googlesource.com/c/87881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-20 21:13:37 +00:00
Dan Rubel a80d93c81f Add global analyzer non-nullable flag
... and plumb that flag through to the AstBuilder.

In addition, remove parser.parseSetLiterals flag in favor of enableSetLiterals
and update callsites

Change-Id: I10dcac0b3df3d0888844e4bf56977c80e03d6334
Reviewed-on: https://dart-review.googlesource.com/c/87880
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-20 21:06:17 +00:00
Sam Rawlins f69aabdb62 Move the check for INVALID_SEALED to the BestPracticesVerifier
Change-Id: I974196f7cd1c2b7c24df1d759774faed9f8a2581
Reviewed-on: https://dart-review.googlesource.com/c/87705
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-12-19 23:40:06 +00:00
Sam Rawlins ac506a9d92 Check for @immutable on mixin application. Fixes #35458
Bug: https://github.com/dart-lang/sdk/issues/35458

Change-Id: I884a64784dea370cf7f8df65a6e44d2287178677
Reviewed-on: https://dart-review.googlesource.com/c/87708
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2018-12-19 23:38:16 +00:00
Konstantin Shcheglov 2a323d6afe Fix adding implicit casts when the target method is in a superclass.
This fixes the internal failure with DDC and Angular components.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I3dac518be9f2f6b1b05149a471ca81fe544379ce
Reviewed-on: https://dart-review.googlesource.com/c/87702
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-12-19 21:59:44 +00:00
Brian Wilkerson 2bd60aa109 Clean up uses of DartType.flattenFutures
Change-Id: I21a950f8be4035a1aacda0c46b64754d22dc60f6
Reviewed-on: https://dart-review.googlesource.com/c/87610
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-18 23:03:15 +00:00
Paul Berry 6ece9f910c Prepare to publish analyzer version 0.34.1.
Change-Id: I81a9053e4ab3dacd1dcbb8e72d2b80f19752b758
Reviewed-on: https://dart-review.googlesource.com/c/87609
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-18 23:02:44 +00:00
Brian Wilkerson 8905876e82 Create a double value from an int literal when it was promoted
Change-Id: I17b076e1b4e4d11ac35cc2e5d6750ec5c5fab548
Reviewed-on: https://dart-review.googlesource.com/c/87607
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
2018-12-18 22:39:11 +00:00
Brian Wilkerson 554f0c9d36 Clean up the use of the experimental flags in tests
Change-Id: Idef19865c1ce8b514cd2520ad030f56be11c0d5a
Reviewed-on: https://dart-review.googlesource.com/c/87604
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-12-18 21:18:06 +00:00
Konstantin Shcheglov b4a7255684 Issue 35438. When no linked library, fill also _resynthesizedUnits when creating a synthetic library.
There are no linked library because LibraryContext does not add it
if FileState.exists is false. I'm not quite satisfied that we do this,
because everywhere else we pretend that any file exists, but possibly
with empty content.  However we use absence of the linked library
as a signal that `LibraryElement.isSynthetic` should be set. So, we
would need to signal not existing library to resynthesizer in some
other way, or make changes in places where we use `isSynthetic` to
decide whether to report errors.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35438
Change-Id: I39ad7d173b85a2e0bc7333bb7bee9fad709e0dea
Reviewed-on: https://dart-review.googlesource.com/c/87603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-12-18 20:43:52 +00:00
Brian Wilkerson b2d6a2327c Convert two uses of the old type algebra API to the new
Change-Id: I93b91622915aa96b0f1791096b76ca084725428d
Reviewed-on: https://dart-review.googlesource.com/c/87600
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-18 18:51:00 +00:00
Brian Wilkerson f94aa6e329 Make the internal TypeSystem implement the public TypeSystem
Change-Id: I38731f0bc560134c7ad0b0a339ea4e0528e5f6ab
Reviewed-on: https://dart-review.googlesource.com/c/87602
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-18 18:20:28 +00:00
danrubel 4163478f9b Update AstBuilder to build AST with nullable types
... as part of adding NNBD as outlined in
https://github.com/dart-lang/language/issues/110

This CL updates the parser to recognize two specialized comments at the
beginning of a library of the form '//@NNBD' and '//@NNBD*' for use
by the analyzer to aid developers when converting their libraries
to be non-nullable by default.

In addition, the AstBuilder now populates the generated analyzer AST
with nullable type information.

Change-Id: I80d221dd138973aa32f05bde631245d9ac6ee10f
Reviewed-on: https://dart-review.googlesource.com/c/87540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-18 16:31:13 +00:00
Konstantin Shcheglov a9c1c056a7 Use the first two key characters for sharding in FileByteStore.
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/28383
Change-Id: I177e9bedef79627d7b21e565684004054cef1e54
Reviewed-on: https://dart-review.googlesource.com/c/87521
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-18 15:40:55 +00:00
Brian Wilkerson 0fb5974ba0 Improve the error reporting when the same-named types are used as type arguments (issue 33946)
Change-Id: Ic83dea89e4ad51d923f1d147fe4c54e129549fa8
Reviewed-on: https://dart-review.googlesource.com/c/87425
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-12-17 21:10:34 +00:00
Mike Fairhurst 457222053a Remove two unused imports
Change-Id: I6fc676fd7c70076048d07d1d6e0f53ef6e0bb0f9
Reviewed-on: https://dart-review.googlesource.com/c/87481
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
2018-12-17 20:58:54 +00:00
danrubel e54ae42106 Add more conditional expression parser tests
This also addresses a comment in https://dart-review.googlesource.com/c/sdk/+/87083

Change-Id: Id2398bdf0e2ece76c74e0b0afdb6aa166dd687ac
Reviewed-on: https://dart-review.googlesource.com/c/87340
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-17 03:23:06 +00:00
Mike Fairhurst 91cd0b4b83 Test that e2e constant is check works, pass experiments around more
Change-Id: I6252d9215ab322c75a5b83ac0a3047a9dc90a360
Reviewed-on: https://dart-review.googlesource.com/c/87420
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-15 00:15:47 +00:00
Konstantin Shcheglov fd4ae6eda6 Augment AST/element type matchers to include (almost) all types.
R=brianwilkerson@google.com

Change-Id: I6650ed6fd40ca794b04bacb643bef2c3a578ba43
Reviewed-on: https://dart-review.googlesource.com/c/87270
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-12-14 19:04:34 +00:00
Konstantin Shcheglov 6146095f73 Make FindElement more self-consistent.
R=brianwilkerson@google.com

Change-Id: I74bc21a5e6ead36c9a631fc529497108001947ef
Reviewed-on: https://dart-review.googlesource.com/c/87269
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-12-14 18:50:40 +00:00
Konstantin Shcheglov 162d0d12b0 Remove EngineTestCase.assertInstanceOf and extract ast/element TypeMatcher(s).
R=brianwilkerson@google.com

Change-Id: I9c47b4a7426dccafb8d3ffc1b0652da0106f2184
Reviewed-on: https://dart-review.googlesource.com/c/87302
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-14 17:51:27 +00:00
danrubel e2007126eb Revert support for simple nullable type return value in generalized function type
This reverts commit 11d081d115

Reason for revert: Breaks parsing less common conditionals (e.g. b ? c = true : g();)

Original change's description:
> Add support for simple nullable type return value in generalized function type
>
> This only supports nullable return values of the form
>
> <identifier> '?' 'Function' '(' ...
>
> This is an increment CL in the ongoing effort to add nullable type support
> as outlined in https://github.com/dart-lang/language/issues/110

Change-Id: I99bce29619d4e448193e3c81fa86a982791b1f77
Reviewed-on: https://dart-review.googlesource.com/c/87283
Reviewed-by: Dan Rubel <danrubel@google.com>
2018-12-14 16:48:18 +00:00
Dan Rubel 6376482e20 Revert "Add support for prefixed nullable type"
This reverts commit 7720689931.

Reason for revert: Breaks parsing less common conditionals (e.g. b ? c = true : g();)

Original change's description:
> Add support for prefixed nullable type
> 
> This adds support for nullable types of the form
> 
> <identifier> '.' <identifier> '?'
> 
> and
> 
> <identifier> '.' <identifier> '?' 'Function' '(' ...
> 
> This is an increment CL in the ongoing effort to add nullable type support
> as outlined in https://github.com/dart-lang/language/issues/110
> 
> Change-Id: I526aecbe64bacbd442cea0b4c52d36ff23b0443b
> Reviewed-on: https://dart-review.googlesource.com/c/87083
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Dan Rubel <danrubel@google.com>

TBR=brianwilkerson@google.com,danrubel@google.com

Change-Id: Ib5e74b4aad239f561a33eae9d95dffa2693037f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/87282
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-14 15:12:51 +00:00
danrubel 7720689931 Add support for prefixed nullable type
This adds support for nullable types of the form

<identifier> '.' <identifier> '?'

and

<identifier> '.' <identifier> '?' 'Function' '(' ...

This is an increment CL in the ongoing effort to add nullable type support
as outlined in https://github.com/dart-lang/language/issues/110

Change-Id: I526aecbe64bacbd442cea0b4c52d36ff23b0443b
Reviewed-on: https://dart-review.googlesource.com/c/87083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-13 23:24:04 +00:00
Paul Berry 28c78b9d46 Add an assertion to check consistency of ExperimentalFeature constants.
This uncovered a bug in dev_compiler that was showing up at compile
time--it was defaulting the enableAsserts flag to null, causing a null
pointer exception during kernel constant evaluation.

Change-Id: I2c75ffdc494f8d768aa98d67ef8257a20e74b9cd
Reviewed-on: https://dart-review.googlesource.com/c/86982
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-12-13 21:53:34 +00:00
Brian Wilkerson bf528959af Proposed public API for the type system
Change-Id: I1980ffe05f246430e9dcb637eb3ac984ae1f4b1e
Reviewed-on: https://dart-review.googlesource.com/c/87240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-13 20:42:17 +00:00
Sam Rawlins 0028491fdd Make package_build tests work on Windows
Make package_build tests work on Windows

Change-Id: I136aa4120aea5c55b125f4866b4c5f24e8d15812
Reviewed-on: https://dart-review.googlesource.com/c/87243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2018-12-13 19:02:57 +00:00
Brian Wilkerson 7a968ae283 Add a question mark to type annotations in the AST
Change-Id: Icb2e6e4a52d91d3ecf3c4e8a44a2d8f2a3d7a204
Reviewed-on: https://dart-review.googlesource.com/c/87167
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-13 17:11:02 +00:00
Sam Rawlins b7fc0208b0 Add WorkspacePackage and various implementations, for determining whether two files are in the "same package."
This includes _BasicWorkspacePackage for _BasicWorkspace, BazelWorkspacePackage
for BazelWOrkspace, GnWorkspacePackage for GnWorkspace, and
PackageBuildWorkspacePackage for PackageBuildWorkspace.

Bug: https://github.com/dart-lang/sdk/issues/34232
Change-Id: I686b529f460a108b8477d109d07fb29563dd7314
Reviewed-on: https://dart-review.googlesource.com/c/81523
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-13 16:44:31 +00:00
pq ab27830ee8 hint for duplicated lint rules
Change-Id: Ieee5add24bc3517e61fdf4c1f90fb217f8321295
Reviewed-on: https://dart-review.googlesource.com/c/87140
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-13 04:10:05 +00:00
Dan Rubel 11d081d115 Add support for simple nullable type return value in generalized function type
This only supports nullable return values of the form

<identifier> '?' 'Function' '(' ...

This is an increment CL in the ongoing effort to add nullable type support
as outlined in https://github.com/dart-lang/language/issues/110

Change-Id: I42febae9f88f7e4d8b05907988deab97c7a7425c
Reviewed-on: https://dart-review.googlesource.com/c/87081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-12 19:13:24 +00:00
Brian Wilkerson 075ff39ed7 Attept to fix failing test on Windows
Change-Id: Ib1b94f0ddc2a45011782273c9d63c0a0dcb52ef2
Reviewed-on: https://dart-review.googlesource.com/c/87100
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-12 16:55:34 +00:00
Dan Rubel 1ff82c5081 Update endFunctionType event to take questionMark token
... which in this CL will always null.
This is another step when adding NNDB support as outlined in
https://github.com/dart-lang/language/issues/110

Change-Id: I3974fcb885c63be4af9d1007258383f3f8191ae0
Reviewed-on: https://dart-review.googlesource.com/c/87080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-12 16:10:23 +00:00
pq ca70671e85 update linter io url
Change-Id: I7370957023f040800da99a5c0dafd8e1bd1c63eb
Reviewed-on: https://dart-review.googlesource.com/c/87021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-12-11 23:02:34 +00:00
Konstantin Shcheglov 5632d62ad5 Record references for AssertInitializer.
R=brianwilkerson@google.com

Change-Id: Ic8d354781d4298c79edbd41d7ae9448462814931
Reviewed-on: https://dart-review.googlesource.com/c/86984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-11 20:15:58 +00:00
Brian Wilkerson 6fe24162eb Implement downward inference for set literals
Change-Id: I21458e79a2c7127675c7d50ba0726c7b0bd29493
Reviewed-on: https://dart-review.googlesource.com/c/86980
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-11 20:01:08 +00:00
Konstantin Shcheglov 2d2ed59671 Set 'enclosingClass' for class members and type parameters.
R=brianwilkerson@google.com

Change-Id: I932f327da2b3eba196150840a60625b5780359e4
Reviewed-on: https://dart-review.googlesource.com/c/86983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-11 19:40:52 +00:00
Mike Fairhurst 295b749778 Remove unused import
Change-Id: If46b7c4dc0bb0fa621e650dc16d2200f882a8a72
Reviewed-on: https://dart-review.googlesource.com/c/86944
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
2018-12-11 19:30:31 +00:00
Konstantin Shcheglov f9fb87558c Collect references for constructor initializers and redirectors.
R=brianwilkerson@google.com

Change-Id: I7b18132697aed3adf21373177edbfaa4ece9e396
Reviewed-on: https://dart-review.googlesource.com/c/86946
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-11 19:06:23 +00:00
Konstantin Shcheglov 237fcba9b6 Support for FieldFormalParameter.
R=brianwilkerson@google.com

Change-Id: Iab871451cabc3136e1c6e0234fa6c73b0796577b
Reviewed-on: https://dart-review.googlesource.com/c/86829
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-12-11 17:25:54 +00:00
danrubel 2a85a3433e Update handleType event to take questionMark token
... which in this CL will always null.
This is the first step when adding NNDB support as outlined in
https://github.com/dart-lang/language/issues/110

Change-Id: If3810bcaf1b73e70924f09d619e2a84e7d5ba8d6
Reviewed-on: https://dart-review.googlesource.com/c/86860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-11 16:21:05 +00:00
Brian Wilkerson 68889c97ae Rework the file system tests so that most tests are shared
Change-Id: Ibeee593ebd3e240dca5ac86a50a3179d72c5ba61
Reviewed-on: https://dart-review.googlesource.com/c/86827
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-11 13:49:21 +00:00
Konstantin Shcheglov f0d85bb914 Don't record references to the name of this node or the name of the enclosing class.
R=brianwilkerson@google.com

Change-Id: Iaf66c2995cb39039f508f55e8920c59b2afec04c
Reviewed-on: https://dart-review.googlesource.com/c/86825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-12-11 02:38:23 +00:00
Paul Berry 5768e513f8 Rework analyzer representation of experimental flags to prepare for codegen.
This CL introduces
pkg/analyzer/lib/src/dart/analysis/experiments_generated.dart, which
will eventually be code generated from a YAML description of the
currently-allowed set of experimental flags.

Change-Id: Iabbefa8e5037573d4b4e7b7b4eb661c1698bd673
Reviewed-on: https://dart-review.googlesource.com/c/86220
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-10 22:32:24 +00:00
Paul Berry bfb011ee14 Only enable set literals for the reference collector test that requires it.
Change-Id: If6e02ac50109b7f88b91c658cb55898638b5afe6
Reviewed-on: https://dart-review.googlesource.com/c/86601
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-12-10 21:20:41 +00:00
Konstantin Shcheglov 79eb965d8f Replace FileContentOverlay with OverlayResourceProvider in AnalysisServer.
R=brianwilkerson@google.com

Change-Id: Ic2fc13f4eacd94471fc8dccc1102e6fdbe59342d
Reviewed-on: https://dart-review.googlesource.com/c/86785
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-12-10 21:00:57 +00:00
Brian Wilkerson 3875d8bfa2 Deprecate TypeSystem.isStrong
Change-Id: Ia49d78ff41bbe00bfc3c47a790b0492ba9619e41
Reviewed-on: https://dart-review.googlesource.com/c/86505
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-10 19:16:47 +00:00