dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

7628 Commits

Author SHA1 Message Date
Dan Rubel bc53c4dcda Update AstBuilder unified collection parsing to reduce error messages 
Change-Id: Ib1af352a7f957c775064eeaa946a401e1024c90d
Reviewed-on: https://dart-review.googlesource.com/c/93847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-21 18:14:09 +00:00
Sam Rawlins 372537f1e4 Add first support for strict-inference as an analysis option. 
The first code is HintCode.INFERENCE_FAILURE_ON_UNINITIALIZED_VARIABLE:

```dart
var a;  // Hint: The type of v1 cannot be inferred without a type or initializer
dynamic b;  // OK
var c = 7;  // OK
```

This is currently only enabled via an analysis options file:

```yaml
analyzer:
  language:
    strict-inference: true
```

I could add it as a flag as well, but to start using this internally at Google,
we only need support in the analysis options file.

Bug: https://github.com/dart-lang/sdk/issues/33749
Change-Id: Id2a6afa7c3d724b44c20576c7f48869abcf4255c
Reviewed-on: https://dart-review.googlesource.com/c/93700
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-21 17:28:19 +00:00
Konstantin Shcheglov c49537e743 Support for 'double' fields in summaries. 
We already can store List<double>, but not `double` itself.

The LinkedConstantValue data structure I'm working on will have a
field of type `double`, so I need to support in in the generator.

R=paulberry@google.com

Change-Id: Ic5aa3a9a7266afabe6c64214fd68097fbebda4e8
Reviewed-on: https://dart-review.googlesource.com/c/93820
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-21 17:06:49 +00:00
Brian Wilkerson 9cdc189280 Fix bugs in list literals and add some inference tests 
Change-Id: Ia0921b6a7e4ae944587b85b4601cbe88c654c3b3
Reviewed-on: https://dart-review.googlesource.com/c/93821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-21 13:44:29 +00:00
Konstantin Shcheglov f5d43c45ea Include 'linterVersion' into AnalysisOption signature. 
BTW, I'm in doubt about using global variable in AnalysisOption directly.

Maybe make it a writable option, like `lintRules`, so that we don't use
static data? I realize that most probably we set `lintRules` into
AnalysisOptions just because it is just convenient to separate registry
and enable rules, not because we want separation from static data.


R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/linter/issues/1440
Change-Id: I44f5c8cdc41eaead926fbbe250063c41bd888a78
Reviewed-on: https://dart-review.googlesource.com/c/93844
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-21 04:17:19 +00:00
pq 371d244273 linter version support 
See: https://github.com/dart-lang/linter/issues/1440

Change-Id: I0198ea52fb9d5680e76a462d25d7302cd4aa6be8
Reviewed-on: https://dart-review.googlesource.com/c/93882
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-02-21 00:58:08 +00:00
Konstantin Shcheglov 8ac6114028 Sort AvailableDeclaration fields. 
IntelliJ had a regression for a short time, so sorting did not work.

R=brianwilkerson@google.com

Change-Id: I0b631e8061bc3139f0848492e35c583b6bfb4ec4
Reviewed-on: https://dart-review.googlesource.com/c/93747
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-20 22:51:58 +00:00
Mike Fairhurst 48a9eb87ba [analyzer] Add hint for unnecessary ?. 
Change-Id: I7a8532d353b1840332b7583a1884e6487a7656bf
Reviewed-on: https://dart-review.googlesource.com/c/92381
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-20 22:35:49 +00:00
Mike Fairhurst ccb2e2d293 [analyzer] Report dead code for x ?? y where x is non-null 
Change-Id: I2946c5c9b8136151895a458b8ff44da66c96671a
Reviewed-on: https://dart-review.googlesource.com/c/92384
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-20 22:33:09 +00:00
Konstantin Shcheglov 004dd969b0 Remove mock_type.dart, it looks that it is not used. 
R=brianwilkerson@google.com

Change-Id: Ic3e44afbc7be19536341781eb41bf725934d1aa3
Reviewed-on: https://dart-review.googlesource.com/c/93802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-20 22:03:42 +00:00
Paul Berry 7ebd02cdaa Work around for #35908. 
As a temporary workaround, we ignore types when comparing default values for overrides.

See https://github.com/dart-lang/sdk/issues/35908 for a more detailed
explanation for why this is necessary.  Once summaries properly record
types of constant values, we will be able to revert this hack.

Change-Id: I04728231338274a088656a629e303c0f1745466d
Reviewed-on: https://dart-review.googlesource.com/c/93642
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-20 20:20:05 +00:00
danrubel 8b0dd94e11 Revise AstBuilder to generate the new set-or-map AST structure 
This is the first of several CLs updating the parser and its listeners
to conform to the unified collection spec:
https://github.com/dart-lang/language/pull/200

Change-Id: I7750bc4b029f3963b2df77dab3630775ce921bba
Reviewed-on: https://dart-review.googlesource.com/c/93740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-20 19:49:45 +00:00
Konstantin Shcheglov 1699562dfc Remove unused AbstractSingleUnitTest. 
R=brianwilkerson@google.com

Change-Id: Ia705957e91214f6972089c81e38b441a9f711817
Reviewed-on: https://dart-review.googlesource.com/c/93378
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-20 18:14:05 +00:00
Konstantin Shcheglov 45cb49108f Issue 3204. Include mixin(s) into top-level declaration for import Quick Fix. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/3204
Change-Id: Ia80fca430c9cbe710ccaf74b97a1b025634b85b1
Reviewed-on: https://dart-review.googlesource.com/c/93641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-20 03:05:21 +00:00
Konstantin Shcheglov 5722ca3126 Include defaultArgumentListString / defaultArgumentListTextRanges into AvailableSuggestion(s). 
R=brianwilkerson@google.com

Change-Id: I114c3c53de5782fa72d033a39e0d96fa5134ea1c
Reviewed-on: https://dart-review.googlesource.com/c/93600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-20 00:15:21 +00:00
Konstantin Shcheglov 1ed9a34513 Add defaultArgumentListString / defaultArgumentListTextRanges to Declaration. 
R=brianwilkerson@google.com

Change-Id: I1ce920bf3373634674f12b6e710f702214335e83
Reviewed-on: https://dart-review.googlesource.com/c/93371
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-19 21:17:31 +00:00
Brian Wilkerson bcd2c7fb96 Fix ListLiteral construction and add comments 
Change-Id: I52c925f3457ea039e08b59689f850cb1d1b8ab4a
Reviewed-on: https://dart-review.googlesource.com/c/93461
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-19 16:37:30 +00:00
Konstantin Shcheglov c9ef5be8d7 Issue 124524319. Improve getElementDeclaration to support invalid code with synthetic names. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/124524319
Change-Id: Ie80cc66d580aa1c84892df6f839480d6d0501210
Reviewed-on: https://dart-review.googlesource.com/c/93484
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-19 03:36:54 +00:00
Brian Wilkerson 03932bb852 Convert more diagnostic tests to DriverResolutionTest 
Change-Id: Ia3aaf54d2142300180b66c7fd18245fb492f8176
Reviewed-on: https://dart-review.googlesource.com/c/93480
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-18 19:53:33 +00:00
Brian Wilkerson f20ee58aa7 Remove references to the set-literals experiment 
Change-Id: I3e151da8ea5c160a0945199f34ca3c0c9d949a3b
Reviewed-on: https://dart-review.googlesource.com/c/93464
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-16 15:42:48 +00:00
Paul Berry ab38cf7897 Allow non-nullable usage to imply non-null intent. 
If a method parameter is used in unconditional control flow in a way
that a `null` value would directly lead to an exception (i.e. by
dereferencing it, or by passing it to a method that requires a
non-nullable value), this is treated as implying that the method
parameter is intended to be non-nullable.

Change-Id: I4f55e4c95b3cfaee0a2ba9367b47d51083e0b7b1
Reviewed-on: https://dart-review.googlesource.com/c/93363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-16 13:35:48 +00:00
Konstantin Shcheglov 8cb4d00b0b Remove compareXyz() methods from ResynthesizeTestHelpers. 
With task model being removed, there is nothing to compare to.
We now use just textual dumps of library elements.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I5693548b8b71dd1318d761dcacbaf88a376a2f54
Reviewed-on: https://dart-review.googlesource.com/c/93321
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-15 22:32:37 +00:00
Konstantin Shcheglov fd8b546800 Issue 35940. Clear evaluation results for constants in the library being analyzed. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35940
Change-Id: Ife6199d344a197242c50020337d0e2854a72eef9
Reviewed-on: https://dart-review.googlesource.com/c/93340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-15 16:46:46 +00:00
Konstantin Shcheglov 39afa4e555 Revert "Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it." 
This reverts commit 5d6bab4ed2.

Reason for revert: this change is API incompatible when rolling into mono-repo.

Original change's description:
> Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
> 
> Change-Id: I9d87619e05ae769f4df6a6ba26cd7901c7c98510
> Reviewed-on: https://dart-review.googlesource.com/c/93141
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I98d478f56e8aea037cbcc8b6cb940c36edb732fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/93440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-15 16:38:08 +00:00
Brian Wilkerson 122aa43ef6 Convert ListLiteral and remove uses of ListLiteral2 
Change-Id: I6c6f60ae969deb798cdbc8572341f2a51256b194
Reviewed-on: https://dart-review.googlesource.com/c/93341
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-15 16:17:28 +00:00
Konstantin Shcheglov 54dbc0068a Migrate resynthesizer tests from task model. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I2eebe3ee5b9a934e5991d068e0422533545c2e1c
Reviewed-on: https://dart-review.googlesource.com/c/93260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-14 22:09:59 +00:00
Paul Berry 6c96ff0145 Test case reproducing issue #35940 
Change-Id: I6ec0556c0ec42971dee67a784c7c5f884862ac03
Reviewed-on: https://dart-review.googlesource.com/c/93284
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-14 20:22:31 +00:00
Konstantin Shcheglov 5d6bab4ed2 Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it. 
Change-Id: I9d87619e05ae769f4df6a6ba26cd7901c7c98510
Reviewed-on: https://dart-review.googlesource.com/c/93141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-14 18:11:18 +00:00
danrubel 69a952b195 remove parseSetLiterals flag from tests 
Change-Id: I1b042f436c2c0dc96317df5d0bba535a9aa605fc
Reviewed-on: https://dart-review.googlesource.com/c/93126
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-14 16:38:09 +00:00
Brian Wilkerson 46aa511b49 Improve the message when using a prefix to reference an undefined name (issue 35936) 
Change-Id: Iae25bdffc992e0a50687ab54c56118cd13dfa26f
Reviewed-on: https://dart-review.googlesource.com/c/93121
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-13 23:37:37 +00:00
Konstantin Shcheglov f4ec983fec Migrate the rest of element_test from task model. 
R=brianwilkerson@google.com

Change-Id: Iebc0b21b96ebef17503bf3ef672fbaf702144368
Reviewed-on: https://dart-review.googlesource.com/c/93142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-13 23:00:02 +00:00
Dan Rubel 94d8e730fb Remove parser enableSetLiterals flag 
Change-Id: I5e806f2e4a1dd368417802f7b4ff18bc1b4d0250
Reviewed-on: https://dart-review.googlesource.com/c/92843
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-13 22:57:12 +00:00
Brian Wilkerson 9b45c14c65 First stage cleanup of MapLiteral2 and SetLiteral2 
Change-Id: I73ec2e6fa4509539f86dd906bcb411e6267c77aa
Reviewed-on: https://dart-review.googlesource.com/c/93143
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-13 22:51:57 +00:00
Brian Wilkerson 7a63d31151 Improve the message when importing a deprecated library (issue 35922) 
Change-Id: Id37c87c0dc007a55c01dfabb2d3b4639f82ea9cc
Reviewed-on: https://dart-review.googlesource.com/c/93066
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-02-13 20:18:56 +00:00
Brian Wilkerson 30f9f5b1c7 Add SetOrMapLiteral to support the code-as-ui features 
Change-Id: I6d3023855fea6da859af0815bfae6857f1546cb9
Reviewed-on: https://dart-review.googlesource.com/c/93062
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-02-13 20:14:24 +00:00
Brian Wilkerson 1c534d852c Clean up the tutorial related to implementing a visitor 
Change-Id: I04b4fc38ecb558edcc946b3fad122febec57ed2a
Reviewed-on: https://dart-review.googlesource.com/c/93065
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-13 19:44:16 +00:00
Konstantin Shcheglov 7f2f840a91 Don't include constants of private enums. 
R=brianwilkerson@google.com

Change-Id: I477db71282da118a74844c7c3d8d7c5b992d61b1
Reviewed-on: https://dart-review.googlesource.com/c/93067
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-13 19:41:06 +00:00
Konstantin Shcheglov c92d5ca288 Migrate ClassElementImplTest from task model. 
R=brianwilkerson@google.com

Change-Id: Idefac96fd017174f5de78e906b91273b9596f494
Reviewed-on: https://dart-review.googlesource.com/c/93100
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-13 19:14:26 +00:00
Konstantin Shcheglov def7e2dac7 Migrate ConstantVisitorTest from task model. 
R=brianwilkerson@google.com

Change-Id: I7822f13a4438e7460e136d56ad3b5abf6fd1b11d
Reviewed-on: https://dart-review.googlesource.com/c/92925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-13 16:43:41 +00:00
Konstantin Shcheglov a31a72521b Don't include declarations of the library itself. 
These declarations are already available through the library element
model.

R=brianwilkerson@google.com

Change-Id: I9d3d274a8bf4ad28c10f04afc30fa11436cd0f6a
Reviewed-on: https://dart-review.googlesource.com/c/92848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-13 05:43:23 +00:00
Konstantin Shcheglov f21fafd411 Migrate SimpleResolverTest from task model. 
R=brianwilkerson@google.com

Change-Id: Icb45287e7f63f5139468eed5b84c45822f6da5ed
Reviewed-on: https://dart-review.googlesource.com/c/92846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-12 23:14:22 +00:00
Paul Berry 3e5a4f1a5d Sort declarations in file inferred_type_test.dart 
Change-Id: I07aaa0604477ec827cac9696832ca83649067c93
Reviewed-on: https://dart-review.googlesource.com/c/92845
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-12 22:23:51 +00:00
Paul Berry 1e72e9c985 Fix tests now that set literal support is enabled by default. 
Fixes #35870.

Change-Id: Ie250961f12a720a4ffbfc114df55a18518bf0426
Reviewed-on: https://dart-review.googlesource.com/c/92864
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-12 22:23:51 +00:00
Konstantin Shcheglov f841096701 Fix for crash if MixinDeclaration has a const constructor. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/124304191
Change-Id: I78f07338c3ac4c254986fb2b19a00bb5fd4201b7
Reviewed-on: https://dart-review.googlesource.com/c/92860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-12 22:16:12 +00:00
danrubel 3f96de7855 Cleanup intermediate control flow collection structures in AstBuilder 
Change-Id: I8aed607943dea39e5fe393ddf5f5ca00eddb1b42
Reviewed-on: https://dart-review.googlesource.com/c/92840
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-12 21:48:28 +00:00
Konstantin Shcheglov 8d5958bd9a Migrate ErrorResolverTest. 
R=brianwilkerson@google.com

Change-Id: I2593ca49a3c8b1a0281bcdc993628e11aa1bc7bf
Reviewed-on: https://dart-review.googlesource.com/c/92842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-12 20:39:14 +00:00
Paul Berry 9d280198a4 Prepare to publish analyzer version 0.35.1. 
Change-Id: Ib3d31fa14ec2144a04d95f33bac385f38a47d6a7
Reviewed-on: https://dart-review.googlesource.com/c/92820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-12 19:39:21 +00:00
Konstantin Shcheglov 135abb41f7 Migrate ElementResolverCodeTest from task model. 
R=brianwilkerson@google.com

Change-Id: I1494934d56476971518c5e002479def1ba231dd7
Reviewed-on: https://dart-review.googlesource.com/c/92765
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-12 19:07:53 +00:00
Konstantin Shcheglov 80e85d06ab Fixes for enum constants in available declarations. 
R=brianwilkerson@google.com

Change-Id: Ic1ad3846ecf82cdd5f1f0b0d0d5a69b0d5c43d81
Reviewed-on: https://dart-review.googlesource.com/c/92763
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-12 17:43:58 +00:00
Brian Wilkerson 5fe0202b0b Unify MapElement and CollectionElement 
Change-Id: Ia1be138d656d07bdf4c11640b79044abbc798986
Reviewed-on: https://dart-review.googlesource.com/c/92762
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-02-12 17:10:58 +00:00