dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

7628 Commits

Author SHA1 Message Date
danrubel f3ac707aea report error for invalid super/this initializer 
This reports an error for two more invalid initializer situations
to address comment in https://dart-review.googlesource.com/c/sdk/+/97404

The comments about error message text will be addressed in a subsequent CL.

Change-Id: I45785ae7de4adfdb63a238383e6accf465bd8a74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-22 13:40:10 +00:00
danrubel 4cd410d6ac add parser listener handleErrorToken event 
Change-Id: I11ae5f8d25248b9cc3586edbc6e49037d99bb5a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97555
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-22 13:36:35 +00:00
Brian Wilkerson f141914e65 Cleanup warnings in the analyzer code base 
Change-Id: Ie01b837243c8c003b334657d8211b4bb35ceae1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97562
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-22 12:39:20 +00:00
Mike Fairhurst 3678efae60 Test that map if elements/else elements keys/values get implicit casts 
Change-Id: I920400f6924a48364d09cfc9f27dfff57bbe9044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97523
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-22 07:17:13 +00:00
Konstantin Shcheglov fa74184b7a Verify that constructor initializers use only potentially constant expressions. 
...but don't evaluate them, because they don't have to be constants.

R=brianwilkerson@google.com

Change-Id: I5bc44a02947c1682da85c1f22b3fc28b52b13370
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97549
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-22 02:50:43 +00:00
danrubel 8b8a8f7b4e Report error for invalid this/super in initializer 
Fix https://github.com/dart-lang/sdk/issues/36262

Change-Id: I20b0997f58a2835b87869952f186fbe83bfe5e3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-22 01:43:13 +00:00
Mike Fairhurst 602ac1226d Check if element conditions for downcasts 
Change-Id: Ie1277f0efd5b327d1d068c0f8ce21f377313ee82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97543
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-21 20:49:12 +00:00
Konstantin Shcheglov 2ffe0c7b7a Report not potential constants in ShortCircuitOperators. 
Also fix getNotPotentiallyConstants() to allow parameters of const
constructors in constructor initializers.

I'n not sure about using new CompileTimeErrorCode.NOT_POTENTIAL_CONSTANT,
it could be generic INVALID_CONSTANT, and report for constant literal
elements errors like NON_CONSTANT_LIST_ELEMENT, or NON_CONSTANT_MAP_KEY.
So, a bit inconsistency maybe, but we give more specific errors.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I88d8db77f7e5521e03e623cc26171a70599ba614
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97522
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-21 20:18:42 +00:00
Paul Berry 61e71e785f Prepare to publish analyzer version 0.36.0 
Change-Id: I858ebe2a1717a467ef1901d5e643fe3e416036f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97544
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-21 19:08:11 +00:00
Mike Fairhurst 40e77d29d5 Tests for implicit cast properties; add cast for <T>[...dynamic]. 
Change-Id: Ia04c75d304dc6673c9f637c9007a8eb60062078c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97461
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-03-21 18:34:47 +00:00
Konstantin Shcheglov 02d5d26b83 Fix for 'int' in const List<void>. 
This is another issue with runtimeTypeMatch(). This time we will use
both, TypeSystem and DartType.isSubtypeOf(), and accept the value if
any of them succeedes.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I77294485e1d62e016e25992ba869e909608b1e42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-21 17:37:27 +00:00
Konstantin Shcheglov ba0147ac07 Resynthesize typedef(s) and generic function types. 
R=brianwilkerson@google.com

Change-Id: I3ee3014ffc615052ef077dbf58947330e4ca5e17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-21 16:11:18 +00:00
danrubel 1d7dcfff97 Cleanup scanner tests 
Change-Id: I9d579b136c6ff8f83cea1715f3e698eeca8692f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97446
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-21 15:01:18 +00:00
Paul Berry 46e0a87008 Add summary support for "for each" elements with declarations. 
Change-Id: I9bdc8027ce002e87e6a34b3e306f6ef27bbfac59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97444
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-21 13:36:52 +00:00
Paul Berry 915b35e463 Add summary support for "for each" elements with identifiers. 
Change-Id: Id75fbf13d2d7063ff1e3e0122f801321adf0ef89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97442
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-21 13:28:32 +00:00
Paul Berry 9b5a956a0e Remove AstTestFactory.forStatement2 
Change-Id: I8738ffbf1579e070c81c732f818c8ac6582debda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-21 12:48:10 +00:00
Paul Berry ecb1bff326 Add summary support for for elements with declarations. 
Change-Id: Icd0bde20772c96c40a09ca302ec3a18f07511a55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-20 23:08:16 +00:00
Paul Berry 7d277c4a32 Introduce methods and classes to replace "2" variants left over from "UI as code" work. 
The AST refactor for "UI as code" left behind a few things whose names
ended in "2".  This CL deprecates those things and creates
replacements that don't end in "2", so that we keep the API clean.  In
a future breaking change release of the analyzer we'll remove the
deprecated things.

The following methods and classes are added:
- ForStatement and ForStatementImpl
- ListLiteral.elements
- SetOrMapLiteral.elements
- AstVisitor.visitForStatement
- AstFactory.forStatement
- NodeLintRegistry.addForStatement

The following methods and classes are deprecated:
- ForStatement2 and ForStatement2Impl
- ListLiteral.elements2
- SetOrMapLiteral.elements2
- AstVisitor.visitForStatement2
- AstFactory.forStatement2
- NodeLintRegistry.addForStatement2

In a similar way to how we did the previous stage of AST migration,
the existing visitors have been modified so that the default
implementation of visitForStatement2 redirects to visitForStatement;
this allows clients to change their overrides of visitForStatement2 to
override visitForStatement instead.  Once all clients have been
migrated we will be able to delete the visitForStatement2 method.

Change-Id: Ife5949071fe4cb50791cd4f2f4b99a1bfaad54c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97360
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-20 22:58:55 +00:00
Paul Berry c79927fdd7 Change type of Expression.precedence to the Precedence class. 
This is a breaking change, however clients that switched to using
`Expression.precedence2` (which was introduced in analyzer release
0.35.3) are unaffected.  After this change, clients may switch back to
using `Expression.precedence`.

Change-Id: Ia952c44001bdea91d32082add0be7e10c9936181
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-20 22:13:15 +00:00
danrubel 24e5f9142a Revise ElementResolver postfix NNBD bang processing 
... to address comments in https://dart-review.googlesource.com/c/sdk/+/97266

Change-Id: I036858d1b0159948c5bd64f6448bc6cd8d0e3e4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-20 20:34:49 +00:00
Mike Fairhurst 2919b5577f [Analyzer] move usage of mostSpecificTypeArgument in resolver 
Change-Id: I8873d8f2c70805d34d259aafe5c9d4d2cc2735f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97279
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-03-20 20:16:19 +00:00
Konstantin Shcheglov d9371f206d Integration test for AstBinaryWriter and AstBinaryReader. 
Write and read every Dart file in pkg/.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I16df3188b3fac85925027b7f0ee385d1a522c31c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97350
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-20 19:52:31 +00:00
Konstantin Shcheglov 6135a81d51 Separate type reference resolution and types building. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ib29468e283ecc808e87537ee283ed2262f438b11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97277
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-20 15:55:45 +00:00
Konstantin Shcheglov 8556e97218 Remove ResultProvider and its implementations. 
R=brianwilkerson@google.com

Change-Id: Ia946a4a68ad8a4da8a2f282a02a75fc809ec980a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97269
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-20 15:43:02 +00:00
Brian Wilkerson 495c319574 Reland "Add hints to check the SDK constraints for both set literals and for the ui-as-code features" 
Change-Id: I511ea50c835c73d7eed518902ebdfa9497d03f9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97267
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-20 15:40:22 +00:00
Paul Berry 416649250f Rework tracking of variables in scope while summarizing expressions. 
The new formulation allows easy popping of variables when leaving
nested scopes.  This should make it easier to support "for" collection
elements that declare variables.

Change-Id: Ib1a3f5085287573de99298eca772ce631837fc04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97287
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-20 14:36:42 +00:00
Paul Berry b18b626d78 Remove deprecated AST structures related to the "UI as code" feature. 
This constitutes a breaking change, so the analyzer major version
number is bumped to 36.  Clients that have stopped using the removed
data structures (and the methods associated with them) should be
unaffected.

Change-Id: Iab68ecf8d10a13013ebb6b1198c54755225d0eb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95704
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-20 03:36:42 +00:00
Jenny Messerly 7fe4253a4e [analyzer] fix #36158, implicit cast missing on covariant return type 
Due to API changes, the implicit cast visitor (CodeChecker) was not
finding the correct substituted member type, so the implicit return
type cast was not inserted.

Also fixes another issue that paulberry@ discovered: covariant return
type casts were overwriting the implicit casts from the context type.
The context type should always take priority; implicit covariance
checks are only needed when there isn't a type cast from the context.

Change-Id: I998e8f87371c15175c57864b7e334449268fe339
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97143
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-03-20 00:33:41 +00:00
Mike Fairhurst 9c8e6dc42c [analyzer] rewrite mostSpecificTypeArgument to use asInstanceOf 
Change-Id: If7c9e9e9cdc1999c6f7d3c74d081a457f9fc229e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97278
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-03-19 22:50:19 +00:00
Mike Fairhurst 337a252c31 [analyzer] UI as code test cleanup 
Change-Id: I73300a2aa5cfa1a9043454e462ac1df2840ee308
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97271
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-03-19 22:00:29 +00:00
Mike Fairhurst d0bdfee041 Fix DDC cast -- cast key/value/element individually & don't clobber names. 
Change-Id: Id5175782667b760545dac15b02c2a41836137571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97178
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-03-19 21:06:48 +00:00
Konstantin Shcheglov 67243e0396 AstTextPrinter that prints AST tokens into their original positions. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I3ca2167c43408c535f61179ec7ea701acd65cc57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-19 20:57:29 +00:00
Konstantin Shcheglov d214646d89 Remove TestAnalysisContext and related. 
R=brianwilkerson@google.com

Change-Id: I94030893b9c65e8f6c854a8453d12734ef08e690
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97270
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-19 20:34:29 +00:00
Mike Fairhurst 040fa0f83c Add undefined identifier test for for loops 
Change-Id: I590a76525c8f50b28dd3a4a4be448806e4b83027
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97264
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-19 19:40:09 +00:00
Konstantin Shcheglov 85e5684863 Remove OptionsWorkManager and GenerateOptionsErrorsTask is not a task. 
R=brianwilkerson@google.com

Change-Id: Ic257c13a553835f78bd7bc0778dd33c327097af9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-19 19:03:03 +00:00
Konstantin Shcheglov 2ceaccf5f6 Report EQUAL_ELEMENTS_IN_CONST_SET. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I6f358c4f78deabc575479070d3ff23efb438ae64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97177
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-19 15:55:18 +00:00
Dan Rubel 0c34bf13ea update ElementResolver postfix NNBD bang processing 
Change-Id: I700bedc55c42da914fab6d25f4f3620a6ce0b022
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97266
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-19 15:35:26 +00:00
Paul Berry 9788949db8 Run dartfmt on pkg/analyzer/test/dart/ast/ast_test.dart 
Change-Id: Id7388677356bc2af20278eb9e8f5df459fe4df85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97282
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-19 15:25:16 +00:00
Konstantin Shcheglov 70e3e67dd7 Expect different errors depending on the state of the spread_collections experiment. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ia12ea33be90ef1d390fd0a6c38fd421c317e6562
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97179
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-19 14:37:26 +00:00
Dan Rubel c85108d2f9 Fix parse expression "a ~ b" 
This fixes an infinite loop that I introduced in the parser
on Wed Feb 27 commit 8f12d634fe
when adding support for the "!" NNBD postfix assert non-null operator.

To the best of my knowledge, this problem only manifests
when parsing the expression "a ~ b".

Fix https://github.com/dart-lang/sdk/issues/36255

Change-Id: If20f45620eee0f7cf9b4b6a93640bd3b921d23b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97265
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-19 14:15:06 +00:00
Paul Berry f890800fb0 Rework tracking of variables in scope while resynthesizing expressions. 
The new formulation allows easy popping of variables when leaving
nested scopes.  This should make it easier to support "for" collection
elements that declare variables.

Change-Id: Ie1dbb11c50677936973acef804b2496a0d00a84a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97172
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-19 14:14:46 +00:00
Paul Berry 527b10879e Begin adding summary support for for elements. 
Change-Id: Icdcfba5caaac34375b65c838dabc97e9b9201ee9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97120
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-18 21:13:10 +00:00
Mike Fairhurst 42ab0a6a63 Handle downcasts for spreads 
Change-Id: If87a384a29399123951384b7474cfc8632a7ad0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97144
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2019-03-18 20:57:10 +00:00
Paul Berry 1c685bf370 Sort declarations in pkg/analyzer/lib/src/dart/ast/ast.dart 
Change-Id: Ic03f94f3e7a2a64d0f19f2240363718082e703f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97164
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-18 16:31:05 +00:00
Brian Wilkerson d7ad6b8c67 Ensure that all tests are run via test_all and add a test to ensure that it stays that way 
Change-Id: I4a531179823a985f14307cbd444b31605d453d23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97161
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-17 19:21:12 +00:00
Konstantin Shcheglov daa6ee6da9 Report NOT_ITERABLE_SPREAD and NOT_MAP_SPREAD. 
R=brianwilkerson@google.com

Change-Id: I6668787b5b88d5125852e38bd9d30010e36c354b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97160
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-17 17:27:03 +00:00
Konstantin Shcheglov d920a2a5ab Report NON_CONSTANT_XYZ in not taken branches of IfElement. 
R=brianwilkerson@google.com

Change-Id: I27e8a3b99140046399cdcc8daaa7ecc28ffa62df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97010
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-16 22:43:34 +00:00
Brian Wilkerson 976b897bd0 Report non-bool conditions in const expressions in evaluation 
Change-Id: I6c0297ba6d06f0487b3419037109517479b1b794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97124
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-16 18:52:11 +00:00
Konstantin Shcheglov 1d9f34963e Use StoreBasedSummaryResynthesizer directly in LibraryContext. 
R=brianwilkerson@google.com

Change-Id: I29583bf4f63bf47b54982688d0f10df02745f7fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97009
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-16 18:22:41 +00:00
Brian Wilkerson 43a31ff24e Report equal keys in maps when the keys come from a spread element 
Change-Id: I92106a53c2e1752e1ffb1073e124268a692e5905
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97146
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-16 15:21:01 +00:00