dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

165 Commits

Author SHA1 Message Date
Brian Wilkerson 5f0de26d48 Clean up the remaining copyright notices 
Change-Id: If099be4f71ba551df0dc3d69815ae6a9f55d1eba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-24 20:11:28 +00:00
Konstantin Shcheglov d214646d89 Remove TestAnalysisContext and related. 
R=brianwilkerson@google.com

Change-Id: I94030893b9c65e8f6c854a8453d12734ef08e690
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97270
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-19 20:34:29 +00:00
Konstantin Shcheglov 927e758e96 Stop using package:html in analyzer. 
Related to https://github.com/dart-lang/sdk/issues/35802

R=brianwilkerson@google.com

Change-Id: I875a8dc657900137c5a7b59f2820b30a81b23405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95480
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-05 18:36:41 +00:00
Brian Wilkerson a342cecffd Disable support for the old super mixins 
Change-Id: I8f8074b67ea43249fcc10deddd2325938996d529
Reviewed-on: https://dart-review.googlesource.com/c/79469
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-22 16:02:01 +00:00
Brian Wilkerson b8ee603eb2 Deprecate the EMPTY_LIST constants in analyzer 
Change-Id: I4c85c8c21207c86003cdb47d499ae9a934606889
Reviewed-on: https://dart-review.googlesource.com/71234
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-23 14:32:20 +00:00
Devon Carew 2dd33c2a6c Have the package:analyzer strong mode option hard coded to on. Delete several spec mode only tests. 
Change-Id: I5dffec68d9845fe75936d55100c03306b6eda363
Reviewed-on: https://dart-review.googlesource.com/64060
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-07-10 05:30:10 +00:00
Brian Wilkerson 7054d92a02 Remove some classes from the analyzer public API 
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-24 15:28:15 +00:00
Brian Wilkerson dd897d35a2 Move the task API out of the public API 
Change-Id: I0fbafb4965ced89fb9a063edb773c3f1cb3a39fa
Reviewed-on: https://dart-review.googlesource.com/51242
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-16 18:18:08 +00:00
Brian Wilkerson 616acb06ec Deprecate the option to enable using a URI in a part-of directive 
Change-Id: Ie9df0d727c0f81c9671ccedf5ba4d21cdbbe65b8
Reviewed-on: https://dart-review.googlesource.com/48892
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-02 16:25:04 +00:00
Paul Berry 421db9c69c Re-land "Implement proper checking for callability of Function class." 
(was reverted in https://dart-review.googlesource.com/c/sdk/+/40980
due to an analyzer bot breakage)

Original commit message:
Implement proper checking for callability of Function class.

There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks.  This flag has been removed, since the new
behavior is now standard in Dart 2.0.

Fixes #31509

Change-Id: Ice5cf38bbc648badf7f2563ff930b69f9a799635
Reviewed-on: https://dart-review.googlesource.com/41120
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-14 11:30:23 +00:00
Paul Berry 35aea15097 Revert "Implement proper checking for callability of Function class." 
This reverts commit 6837dafcc3.

Reason for revert: Broke analyzer bots.

Original change's description:
> Implement proper checking for callability of Function class.
> 
> There was some old (incorrect) logic for doing this, behind the flag
> enableStrictCallChecks.  This flag has been removed, since the new
> behavior is now standard in Dart 2.0.
> 
> Fixes #31509
> 
> Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
> Reviewed-on: https://dart-review.googlesource.com/40509
> Commit-Queue: Paul Berry <paulberry@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Mike Fairhurst <mfairhurst@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com,mfairhurst@google.com

Change-Id: Ib631ad16bc5e937ff914127d1c5330f3fcaff2c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/40980
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-13 19:56:35 +00:00
Paul Berry 6837dafcc3 Implement proper checking for callability of Function class. 
There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks.  This flag has been removed, since the new
behavior is now standard in Dart 2.0.

Fixes #31509

Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
Reviewed-on: https://dart-review.googlesource.com/40509
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2018-02-13 14:19:08 +00:00
Paul Berry 105b170ddb Roll package test to 0.12.29+1 and stack_trace to 1.9.0 
This required some changes to analysis_server, since analysis_server
used to have its own version of pumpEventQueue().  Since
pumpEventQueue() is now provided by the test package, I've removed
analysis_server's version, and I've updated some of the call sites to
pass in "times: 5000" to replicate the old analysis_server behavior.

This also required some changes to analyzer, since the fail() method
is now marked as @alwaysThrows, so no code may follow it without
producing a dead code hint.

Change-Id: Ie5ef3a5cc685c18da02de699e59f63f3bb8865f7
Reviewed-on: https://dart-review.googlesource.com/32683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-01-07 14:22:23 +00:00
Brian Wilkerson 082bbdb6a7 Remove flag and enable asserts in initializers by default 
Change-Id: Ia81f5ec936981dc08ff4c740f3511c6b7c9e6eb6
Reviewed-on: https://dart-review.googlesource.com/10740
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-10-04 18:45:09 +00:00
Brian Wilkerson 4c635b7b85 Initial support for an explicit plugin list 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988343002 .
 2017-08-02 11:30:57 -07:00
Konstantin Shcheglov bf25080cc1 Replace typed_mock with mockito in analyzer. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2991913002 .
 2017-07-27 16:15:17 -07:00
Konstantin Shcheglov 077b6b687d Remove incremental: logger, validator, options. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2968473002 .
 2017-06-29 11:51:12 -07:00
Brian Wilkerson 4fab4a1f52 Clean up type parameters in comments 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2948393002 .
 2017-06-23 12:53:11 -07:00
Konstantin Shcheglov e24b9c218d Remove the limited invalidation feature. 
So, we remove IncrementalCompilationUnitElementBuilder, which was one
of the places that potentially modifies element models.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2834773003 .
 2017-04-21 12:09:28 -07:00
Paul Berry 02fe40c6f7 Simplify how patch files are specified to analyzer. 
After discussion with kmillikin@, sigmund@, and scheglov@, we decided
that specifying the patch files in libraries.dart is more complex (and
less flexible) than we'd like.  This CL changes things so that the
patch files are specified in analysis options using a simple map from
library name (e.g. "dart:core") to a list of patch file paths.

Clients are now allowed to put patch files wherever they want; they
don't need to be inside the sdk directory.

Note that we no longer include the patch configuration in
encodeCrossContextOptions.  This should be ok, since we don't have any
use case in which a single instance of analyzer needs to accommodate
multiple patch configurations.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2560323002 .
 2016-12-12 10:15:18 -08:00
Brian Wilkerson e22a2b4626 Enable messages in asserts by default 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2557513008 .
 2016-12-07 12:23:00 -08:00
Brian Wilkerson 37387de83a Exclude files from analysis when using AnalysisDriver 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2536303002 .
 2016-11-29 13:30:22 -08:00
Brian Wilkerson e63105555b Remove uses of configuration data 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522543007 .
 2016-11-22 11:26:08 -08:00
Konstantin Shcheglov 5455fd0118 Remove 'initializeTestEnvironment' from 'analyzer'. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2399913002 .
 2016-10-06 10:18:54 -07:00
Konstantin Shcheglov 175dad4f15 Switch 'analyzer' to 'package:test' and test_reflective_loader ^0.1.0. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2391423003 .
 2016-10-06 08:46:35 -07:00
Brian Wilkerson ecc84b26a4 Break up another large file 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2342733002 .
 2016-09-15 07:49:27 -07:00
Konstantin Shcheglov e832ab5248 Remove deprecated ChangeSet.deletedSources. 
It is not used internally.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2331753002 .
 2016-09-11 09:37:07 -07:00
Konstantin Shcheglov 9cf47ce04c Remove parseUriWithException() and URISyntaxException. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2321263003 .
 2016-09-09 08:30:01 -07:00
Konstantin Shcheglov e976e692be Replace and remove JavaException(s). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2326813002 .
 2016-09-08 15:56:33 -07:00
Konstantin Shcheglov 7442a85cbb Issue 27130. Fix applying changes to .analysis_options on save. 
This fix partially reverts changes made in https://github.com/dart-lang/sdk/commit/de6925a23ebf29cd587dd5f4e214cb277a7397e4
It is correct that we should ignore applyChanges() for sources with
content overridden in the content cache. But we cannot know what else
happened with results in the analysis cache at this point. So, we
should just let Analysis Server to always run analysis, so that
Driver and WorkManager(s) will decide if there is anything to do.

I believe that the original motivation for the change was to avoid
sending extr 'analysis.implemented' notifications. It does not happen
anymore, probably because we set other shortcuts using source content.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27130

Review URL: https://codereview.chromium.org/2314933003 .
 2016-09-06 13:41:48 -07:00
Konstantin Shcheglov f096f7b985 Flush results when contexts are made idle. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2297343002 .
 2016-08-31 14:03:25 -07:00
Konstantin Shcheglov cc6beaf56d Pull in test_reflective_loader 0.0.4 and switch analyzer to it. 
There are following changes:

1. DEPS to pull in test_reflective_loader 0.0.4
2. Rename runReflectiveTests() to defineReflectiveTests().
3. Remove analyzer's pkg/analyzer/test/reflective_tests.dart
4. Replace reflective_tests.dart imports with package:test_reflective_loader/test_reflective_loader.dart imports.
5. Sort/format and organize imports in the files with imports changes.
6. Fix for a couple of bugs in analysis_server exposed by the new loader.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2298913003 .
 2016-08-31 13:46:39 -07:00
Brian Wilkerson b888675b55 Move embedder locator and convert context builder to use the new API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2208503004 .
 2016-08-04 10:41:53 -07:00
Konstantin Shcheglov ed887c09d1 Validate cache consistency asynchronously. Compute modification times of physical files in a separate isolate. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2132073003 .
 2016-07-08 15:01:05 -07:00
Jaime Wren b7aff9c72f Initial Bazel file resolver support. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2079873002 .
 2016-06-17 14:20:55 -07:00
Brian Wilkerson 5c97a88ddd Remove embedder locator from analysis context 
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2078993002 .
 2016-06-17 09:42:27 -07:00
Brian Wilkerson 7eddfb7394 Fix cross-partition dependency handling (issue 26466) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2008133002 .
 2016-05-25 07:43:01 -07:00
Brian Wilkerson f9b575e5b3 More strong mode changes to analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1855643002 .
 2016-04-01 18:00:04 -07:00
Brian Wilkerson 6dae827b70 More strong mode fixes for analyzer 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1842363004 .
 2016-04-01 09:35:22 -07:00
Konstantin Shcheglov 3af20476d1 Add AnalysisContext.onResultInvalidated(descriptor). 
This method will be used to remove index entries corresponding to
invalidated resolved units.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1776023002 .
 2016-03-08 12:55:06 -08:00
pq e902b07ed4 Engine test fix to keep up with SourceFactory changes. 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1645173002 .
 2016-01-28 12:57:45 -08:00
Brian Wilkerson 21ecb14548 Clean-up imports 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1602803002 .
 2016-01-18 15:42:16 -08:00
Konstantin Shcheglov 78aad4c282 Fix the build - add the new field. 
TBR

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1598183003 .
 2016-01-17 09:41:21 -08:00
Konstantin Shcheglov a2d615e52a Replace ResultProvider with 'aboutToComputeResult'. 
This way we would be able to redirect to the SDK context, or get some
results from packages. Setting ResultProvider into AnalysisDriver does
not allow us to do this.

My quick and dirty experiment with using SDK summaries is broken now,
but I'm going to start updating actual SdkAnalysisContext using
summaries, if the bundle exists in the SDK.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1555073003 .
 2016-01-04 10:19:16 -08:00
Brian Wilkerson 2a190aa11a Fix imports within the analyzer package 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1524893002 .
 2015-12-14 12:25:41 -08:00
Konstantin Shcheglov 72cf3cbe91 Remove unnecessary 'noSuchMethod' declarations. 
Also format these file.
I don't like how the new formatter changed the code :-(

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1507813004 .
 2015-12-08 11:39:37 -08:00
Brian Wilkerson ea3ba0e31f Remove deprecated code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1502213002 .
 2015-12-07 10:24:36 -08:00
Brian Wilkerson b9644af695 Remove the old task model 
Review URL: https://codereview.chromium.org/1490233007 .
 2015-12-03 10:14:06 -08:00
Brian Wilkerson 600fc17de1 Clean-up the registration of plugins 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1487953002 .
 2015-12-02 13:25:28 -08:00
Brian Wilkerson 4ae8540383 Revert "Clean-up the registration of plugins" 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1465983004 .
 2015-11-20 14:04:53 -08:00