2268c65cbe
First subtyping rules for nullable types
...
Change-Id: Ibaaea75f8b5e83f1fb7039332093121854108da8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103548
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-05-29 22:13:11 +00:00
76750c58f2
Issue 35553. Report WRONG_TYPE_PARAMETER_VARIANCE_IN_SUPERINTERFACE.
...
Locally I see that out of 198 language_2/superinterface_variance/ tests:
* With summary2 we pass 197, and fail 1 test.
* With summary1 we pass 165, and Crash in 33 tests.
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/35553
Change-Id: I79b5d7d2931c2d0c42ae6f12c19324deb7af784f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103960
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-29 17:13:30 +00:00
98a4dba4b3
Update Element.appendTo to more closely match Dart syntax
...
Change-Id: I74bf13f3b072c734b018517e6d06e182a0736bb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103961
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-05-29 17:06:40 +00:00
a332c414f1
Switch server to using DeclarationsTracker for 'Import Library' quick fixes.
...
We need this to stop using UnlinkedUnit with summary2.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Iaca2f19e6a168818e171f09e6eeda71a75854232
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-29 16:45:32 +00:00
b1d3a212a7
Fill references to dynamic/Naver in LinkedElementFactory.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I85f61c6322a6332ac6b095aaf8cf4203460babc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-29 01:20:42 +00:00
2e51423c3d
Convert the way function types are displayed to better match the syntax of Dart
...
Change-Id: Id5068bd52b3a35c70cb0d2ccc735469e2f8a0d3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103701
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-28 20:48:51 +00:00
9556a95038
Fix string->bytes encoding in overlay_file_system
...
Change-Id: I2777c09908172c282f59cb2bf0ed5bd208442dd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-28 20:01:05 +00:00
fee615c5a5
consolidate multiple modifier error codes
...
This consolidates the following error codes into MODIFIER_OUT_OF_ORDER
* COVARIANT_AFTER_VAR
* EXTERNAL_AFTER_CONST
* EXTERNAL_AFTER_FACTORY
* EXTERNAL_AFTER_STATIC
* STATIC_AFTER_CONST
* STATIC_AFTER_FINAL
* STATIC_AFTER_VAR
Change-Id: I3f8c41bacc65ebc5d9255806cbee89cddb5ffeb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103880
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-28 17:01:16 +00:00
6aee4f390b
Make analyzer's File.readAsBytesSync() impls return Uint8List
...
As part of the rollout plkan for https://github.com/dart-lang/sdk/issues/36900
Bug: dartbug.com/36900
Change-Id: Ic56cc1054ebae5967a1273b19f886a5e41b9460b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103060
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Todd Volkert <tvolkert@google.com >
2019-05-28 15:02:16 +00:00
527c165426
Deprecate 'abstract' setter in elements, replace with 'isAbstract'.
...
I deprecated 'abstract', but I don't see any uses of it outside of
analyzer, which I have fixed. So, maybe we should remove them right now?
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ifd86a6b0148be49df6455672742f825ffd50f661
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103661
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-05-28 04:16:43 +00:00
d368bb8ecd
Make some fields in LinkedNode informative.
...
R=brianwilkerson@google.com
Change-Id: I76eef7f07678723944e221d65936864d400b561f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-27 21:25:36 +00:00
eff6e95385
Improve code generation for variant classes.
...
Change-Id: Iabaceebdf6efbec80d0026b74f71eac45b742760
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103600
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-24 21:55:16 +00:00
e43d81af5f
Folders containing overlayed files should exist even if they do not exist on disk
...
Change-Id: I511b5075cb10b2594dce9dc33f165b64d9527043
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103565
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-05-24 20:47:46 +00:00
e42d4a1d89
fix missing returns in lambdas
...
Change-Id: I5005ffc057749468844d47e8e5c195871586bd57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103601
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-05-24 19:24:02 +00:00
ec1ddcdb83
improve extension message missing body error message
...
This improves the missing class, mixin, and extension method body
error messages and lays the groundwork for improving other
missing body error messages such as switch statement, finally clause,
and others.
Change-Id: I0a4d1338fe91eee3cfe7d61652e168df1302d212
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103570
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-24 17:03:25 +00:00
9081f28fbb
[analyzer] fix a copy paste doc issue and 2 unused imports
...
Change-Id: I20f4ae5454c2bceafd3b86e279357dee3b321006
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103644
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-05-24 16:31:25 +00:00
3c34c8fa2f
Fix type substitution of "star" types.
...
When performing type substitution, there are three types involved, the
substitution site (`this` in TypeImpl.substitute2), the type we are
replacing (`parameterType` in TypeImpl.substitute2), and the
replacement type (`argumentType` in TypeImpl.substitute2).
Previously, we only handled the nullabilities of `this` and
`argumentType`. This CL adds support for the possibility that
`parameterType` might have nullability "*". This happens because
TypeParameterElement.type returns a star type, so for instance when
subsituting `int` for `T` in `List<T>` to form `List<int>`, we are
actually substituting `int` for `T*` in `List<T*>`.
Change-Id: I0a61fdc47ec8aa205dc0c539c49ea7799ed4ac05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103542
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-24 15:43:45 +00:00
0e5d18f281
Ensure that nullability promotion of the Null type yields Never.
...
Change-Id: I2232f80bbf5c8a9e51f305a603c06ca2b3ad8aea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103573
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-24 14:57:15 +00:00
eca6c8953f
Allow async as an identifier everywhere.
...
Fixes #37063
Bug: http://dartbug.com/37063
Change-Id: I2253c3088fbe33eca1072f2480cf0cf3cc363362
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
2019-05-24 08:21:14 +00:00
22c086fbe5
Remove unsafe uses of TypeImpl.withNullability (use TypeSystem instead).
...
Change-Id: I5df47ca582aa5583055d3700668de992676bc42a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103541
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-24 00:21:29 +00:00
704446d159
Disable implicit casts but keep dynamic casts when NNBD enabled
...
Change-Id: Ia0a3271c9137bc8c7fa4cdbd469cf93d9453b69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103405
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-05-23 23:41:52 +00:00
c4d691064a
Remove unused methods from LinkedUnitContext.
...
R=brianwilkerson@google.com
Change-Id: I5acc7ab0381ac8912b3d4ba6bec89d7554aea43b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103547
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-23 20:42:20 +00:00
4b7c05f2ce
Remove LinkedNodeVariablesDeclaration.
...
We don't need it anymore - we can go up the AST hierarchy to the
enclosing TopLevelVariableDeclaration.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Iadc9985bb5bcaa465c3505794ceac51e7b06a930
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103564
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-05-23 19:39:00 +00:00
7bbd8ea29d
Introduce a representation of the type Never?.
...
This type is equivalent to the existing type `Null`, but we need it
anyway because `Null` can only be accessed via the type provider, and
there are circumstances where we need to create this type and don't
have access to the type provider.
It also may prove beneficial to be able to distinguish between `Null`
and `Never?` in diagnostic messages.
Change-Id: I6118e87c8c4736a508a3f366f2762a96198db7ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103540
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-23 17:15:21 +00:00
d92341be08
first cut parse extension methods
...
This is an incomplete parser implementation of extension methods.
Subsequent CLs will flesh out the details.
Change-Id: I8c891827e97b451388cadc9cedea3afb7a8cf922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-23 10:54:34 +00:00
6edefda065
cleanup token rewriter and clients
...
Change-Id: I05f3549c37abccaa7ce7119c0b9d3a084a381f80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-22 22:11:40 +00:00
4ccf7b865e
Don't set type for StringLiteral(s) in directives.
...
R=brianwilkerson@google.com
Change-Id: Ie34d481c5ef07008d38aee1e89f1beb8a313590a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-22 20:37:31 +00:00
b22cd05c51
Reland fix for #28233 : add hint for missing returns to function expressions
...
The bulk of this change is actually correcting missing returns in the Dart SDK.
Bug: https://github.com/dart-lang/sdk/issues/28233
Change-Id: I52bcbc6c6f4a129d3fc22003f4448a7c3d4487ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100301
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-05-22 18:12:30 +00:00
7d1b54bd47
Add a minimal implementation of ExtensionDeclaration
...
Change-Id: I5a556ea1819b38a3130e801a3cbc4bcbad98dcdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103380
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-22 12:43:02 +00:00
4317c5ff3f
Don't set elements and types during AstRewriteVisitor.
...
Resolution is incomplete at the time when we perform rewriting.
For example, in `C<int>` the type of `int` is not set, so we get
incomplete InterfaceType of `C` with `null` as the type argument.
This was crashing summary2 in one situation internally.
R=brianwilkerson@google.com
Change-Id: Ifcff68f007a90b5694cf3e4e4d3825309c04e2b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-22 03:29:17 +00:00
6457ac1d4b
Test potentially-nullable access errors
...
Change-Id: Ia166dbb6fb353120e30555f60b7bea186537b05b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-22 03:17:00 +00:00
add95652d2
fix AstBuilder invalid getter recovery
...
This fixes the Astbuilder recovery when encountering "get <identifier> :"
in a class body to build a method node rather than a constructor node.
Fix https://github.com/dart-lang/sdk/issues/36961
Change-Id: I48242838d72c3a6c18e78a469b6e07fd1481d0c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-05-22 00:28:55 +00:00
e20da9c220
Fix order of resolving / writing / reading of function / method declarations.
...
Now that we assign indexes to occurred GenericFunctionType nodes, we
need to make the order consistent across all visitors.
R=brianwilkerson@google.com
Change-Id: Ifc9c7bfa35612cef235f000f30130d36116067e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-21 19:40:17 +00:00
cfdcfe2bfe
Update DeclarationsTracker when a context options change.
...
E.g. when .packages changes, we want to re-scan the context for new
available libraries. We also don't want to discard all context, and
resend everything.
R=brianwilkerson@google.com
Bug: https://github.com/Dart-Code/Dart-Code/issues/1723
Change-Id: I19ee71c1d021fb9bcda9d02d86b7cbb078704aa7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-21 18:43:36 +00:00
2b6b0e00d9
Fix resolveToBound for nullability
...
Change-Id: I510c349251588356677d52574f259706ec2047e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103183
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-05-21 17:58:56 +00:00
7c7738a9c7
Proposed AST interface for extension methods
...
Change-Id: I7c85a642eeaa862ecf9c6837c0a488938e8d97e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101225
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-05-21 17:16:38 +00:00
59381cd8d0
Fix summary2 linking when using API summaries, which don't include line starts.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Iee403b154e4ca546ee69ae7cf0a8764d48ac7d34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103081
Reviewed-by: Paul Berry <paulberry@google.com >
2019-05-20 16:58:12 +00:00
59bcb38db7
Report the missing library in LinkedElementFactory.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I0e949f853f90f676f0184acd511ddde880d87a02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103082
Reviewed-by: Paul Berry <paulberry@google.com >
2019-05-20 16:57:56 +00:00
e13b1b6e0c
Build summary2 for SDK.
...
Note, that this will start building it always, regardless of the
state of the useSummary2 flag.
Summary1: 4892680 bytes.
Summary2: 7105744 bytes.
Both: 10748992 bytes.
Time:
Summary1: 2550 ms.
Summary2: 2750 ms.
Both: 4000 ms.
Change-Id: If81367c24654c1d57a4dcdbd42f76d80ae8c4b39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102540
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-19 20:05:01 +00:00
58cf83df4d
Don't crash on during indexing references to named parameters of a generic function types.
...
R=brianwilkerson@google.com
Change-Id: I0da0b1785d7dab2c7c84527317e542b7ef718bd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-19 19:08:31 +00:00
5e5b03881c
Fix for exporting setters.
...
R=brianwilkerson@google.com
Change-Id: Ie67834547a94a480e8ed86df430c40bcb36e37e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-19 17:50:09 +00:00
234103f9d4
Fix for hasImplicitReturnType.
...
R=brianwilkerson@google.com
Change-Id: I94e1e0f8246f3ff0d284ef7b1de6f618ad464592
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-19 17:50:07 +00:00
f930d674ca
Restore old nullability behavior of TypeParameterElement.type.
...
It doesn't work to make TypeParameterElement.type choose
nullability/non-nullability based on the enclosing library, because
for type parameters of synthetic function types, there is no enclosing
library.
Change-Id: Ic74cc639534e3c03f3c46e7eacfb5655ca74019a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102981
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-18 15:05:26 +00:00
ce62987c9d
Remove DynamicState and make NumState an abstract class
...
Change-Id: I6c3ec94a26f6522d24cf964823b739dfe2c42c62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103021
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-05-18 14:18:46 +00:00
9b1c8fca91
More fixes for GenericFunctionType.
...
1. Read GenericFunctionType fully, but in two steps to avoid recursion.
We need to read it fully, because it might be a part of a const
initializer, so the client might request the initializer expression,
and there is no way to him to finish reading. Amnd in general, we
don't read expressions lazily.
2. For consistency we need to set identifiers for all GenericFunctionType
nodes that we want to store. So, DeclarationResolver should be updated
to move the identifier number even though we don't use the same
mechanism for building elements ininitializers, as we use for type
annotations outside expressions.
R=brianwilkerson@google.com
Change-Id: I58faa5408bff5250a8c775249438def7f742594b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102840
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-18 00:20:36 +00:00
cf15dc17e0
With summary2 FunctionTypedFormalParameter has type parameters.
...
This re-applies changes to tests from https://dart-review.googlesource.com/c/sdk/+/100620
R=brianwilkerson@google.com
Change-Id: If6721d2febb39b52277fdb39845bb2486cb6eb47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-17 23:31:16 +00:00
7983fac33b
add "extension" built-in keyword for extension methods
...
Change-Id: I6529fff31f681fd24c22f8c7579d2a35097f4d07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-05-17 22:24:15 +00:00
8d52c0d08e
Store library nullability status in LibraryElement; adjust TypeParameterElement.type based on it.
...
Change-Id: I0a9673b3b2f46bbf5c3aea429e90c6ddafa978e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102224
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-17 21:27:21 +00:00
b4611b9357
add extension-methods experimental feature
...
Change-Id: Iad76a6d0b91ff83fce3dbd963d0c341b3b62eeb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102880
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-05-17 13:15:30 +00:00
1c469617c5
TypeParameter.declaredElement is guaranteed to be a TypeParameterElement
...
Change-Id: Ia6af1109cce334362885e1db150608f38081f064
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-15 15:59:24 +00:00
Mike Fairhurst