dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

6070 Commits

Author SHA1 Message Date
Paul Berry d45a6ec893 Split Variables class into two interface classes and create DecoratedType.forElement constructor. 
The two interface classes make it clearer which methods are intended
to be used by ConstraintGatherer vs. ConstraintVariableGatherer, and
refactoring DecoratedType.forElement paves the way for a future CL
that will handle constraints on inferred types.

Change-Id: Ibd2f22ea9d38df7be1c4da0e4eef2006556b7351
Reviewed-on: https://dart-review.googlesource.com/c/91851
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-03 02:35:16 +00:00
Paul Berry b9c89c9fb5 More test cases for the migration prototype. 
Change-Id: If6cd64ae89ebb76a98160dc60d981c7db7ae82a6
Reviewed-on: https://dart-review.googlesource.com/c/91852
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-03 02:31:56 +00:00
Paul Berry a6e7361fa8 Add documentation comments to the migration prototype. 
Change-Id: Ifad776cadfe9a2abc485c6ab251cdee08671d9ef
Reviewed-on: https://dart-review.googlesource.com/c/91848
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-02 23:21:16 +00:00
Brian Wilkerson 53ba159aa4 Add assists to convert to list, map and set literals 
Change-Id: If8909859ea9c8752ecf0ea05b89f4a27d373fb39
Reviewed-on: https://dart-review.googlesource.com/c/91846
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-02 22:00:55 +00:00
Paul Berry a9c84ab887 Verify nullability of dynamic in DecoratedType constructor. 
This required some clean-up of how the `always` constraint is handled.

Change-Id: I9c1124bf0d41b58b771eb46ee74a52659e0b5b52
Reviewed-on: https://dart-review.googlesource.com/c/91843
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
 2019-02-02 21:54:56 +00:00
Brian Wilkerson af303a277c Add some assists for the code-as-ui features 
Change-Id: Ie01b1875fb35eab1427b2869f9c009a06c048412
Reviewed-on: https://dart-review.googlesource.com/c/91841
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-02 17:37:55 +00:00
danrubel 509ac0648c Update non-nullability migration algorithm to handle missing types 
Change-Id: Ia2bcf923be0cfd1c7e94112e6516a10d13d5a4ca
Reviewed-on: https://dart-review.googlesource.com/c/91861
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-01 20:59:41 +00:00
Konstantin Shcheglov 00c6f6b584 Document InheritanceManager deprecations. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/linter/issues/1405
Change-Id: I27cfe111a65c1844a1bfd9d6479cd89ba30f6cb3
Reviewed-on: https://dart-review.googlesource.com/c/91840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-01 18:03:32 +00:00
Paul Berry 3802a6d7eb Experimental prototype of a non-nullability migration algorithm. 
Change-Id: Idda9b596d612953f4f370f220729f419b1f673e1
Reviewed-on: https://dart-review.googlesource.com/c/91380
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-01 17:55:37 +00:00
Konstantin Shcheglov 931051814c Partial implementation of the 'available suggestion sets' protocol. 
R=brianwilkerson@google.com

Change-Id: I856b6a39c2464caf6750e0b0abb0cfa29311e97c
Reviewed-on: https://dart-review.googlesource.com/c/91769
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-01 17:55:27 +00:00
Paul Berry 20fc81470e Fix override_on_non_overriding_method hint 
Change-Id: I9a53115b5542abe0791324f26449dc210662d096
Reviewed-on: https://dart-review.googlesource.com/c/91763
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-31 18:06:35 +00:00
Kevin Moore ca4978e363 Add pkg:analysis_tool as an SDK-only set of utils 
Reduces the API surface of pkg:analyzer that requires pkg:html

Related to https://github.com/dart-lang/sdk/issues/35802

Change-Id: Icd08d76190d6ab77cd180561cdde6df254b22557
Reviewed-on: https://dart-review.googlesource.com/c/91701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2019-01-31 16:52:05 +00:00
Konstantin Shcheglov e5164be27e Issue 35127. Fixes for mixin implements / overrides. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/35127
Change-Id: I5869175cee13b6e22ce25c2d361b0b1aa52efe48
Reviewed-on: https://dart-review.googlesource.com/c/91690
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-31 16:01:55 +00:00
Brian Wilkerson c31627b778 Remove the unused TypeOverrideManager 
Change-Id: I031c2777e6b9d5cfd46bc0bc1978dfde95a316b7
Reviewed-on: https://dart-review.googlesource.com/c/91692
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-31 15:19:05 +00:00
Sam Rawlins 6c96d8fdaf Fix crashing analysis_server with some defensive null checks 
Bug: https://github.com/dart-lang/sdk/issues/35814
Change-Id: I1536e77adb9fe4699201ca8e0462b0f5154ca127
Reviewed-on: https://dart-review.googlesource.com/c/91686
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-01-30 23:19:19 +00:00
Brian Wilkerson 3b5c1012e9 Update CodeChecker to handle the code-as-ui features 
Change-Id: Iaea7e63b9ee6c5fe7f57da22c0215c9caa316a3e
Reviewed-on: https://dart-review.googlesource.com/c/91685
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-30 22:48:27 +00:00
Konstantin Shcheglov b8fc017778 Replace convertAbsolutePathToUri() with toUriStr(). 
Change-Id: Ib34247ce7457ada7e4705714984034387f09a80c
Reviewed-on: https://dart-review.googlesource.com/c/91684
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-30 20:47:56 +00:00
Konstantin Shcheglov f903ee6dc0 Don't crash on formal parameters without name, exclude private SDK lbiraries. 
R=brianwilkerson@google.com

Change-Id: Ie5d72458c6d19fb250591550d47c4076082dff1e
Reviewed-on: https://dart-review.googlesource.com/c/91683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-30 19:48:28 +00:00
Brian Wilkerson bc2a5a6789 Generate some of the code-as-ui diagnostics; implement more resolution 
Change-Id: I6d5ac14d5b6cb601d6d968a8140bc63435519230
Reviewed-on: https://dart-review.googlesource.com/c/91586
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-01-30 16:40:46 +00:00
Konstantin Shcheglov e8a0a209e3 Include into Declaration data that we will need for pre-cached suggestions. 
R=brianwilkerson@google.com

Change-Id: Ie4419e785c06fa7b3913359e5831e97c611f46a7
Reviewed-on: https://dart-review.googlesource.com/c/91587
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-30 16:31:34 +00:00
danrubel 0bb1aee3ff AstBuilder cleanup 
Change-Id: I83f936d353df8828795b4236655147ea414866b9
Reviewed-on: https://dart-review.googlesource.com/c/91621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-30 15:12:34 +00:00
Paul Berry ec13e61df3 Move question getter from GenericFunctionType and NamedType to their common base class. 
Change-Id: I5f9494a0c354f5b1fc2ec08c7e748dd795671752
Reviewed-on: https://dart-review.googlesource.com/c/91680
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-30 14:59:24 +00:00
Konstantin Shcheglov 2632e201b7 Support for DeclaredIdentifier(s) in new ForEachPartsWithDeclaration/ForElement(s). 
R=brianwilkerson@google.com, danrubel@google.com

Change-Id: I589d427fca83129bf96c78070b05f61fdac74b27
Reviewed-on: https://dart-review.googlesource.com/c/91584
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-30 02:11:14 +00:00
Konstantin Shcheglov b196cd2acb Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden. 
Downgrade INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED and INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL to warnings.

Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I4399839e04135a5d9a557c0ab06f319d9759af23
Reviewed-on: https://dart-review.googlesource.com/c/91460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-29 22:35:15 +00:00
Konstantin Shcheglov 25d8456c48 Small improvements for DeclarationsTracker. 
R=brianwilkerson@google.com

Change-Id: Ic35e7cead9a50b9eb8ae590f9fbf85df0a8f7fc1
Reviewed-on: https://dart-review.googlesource.com/c/91583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-29 22:33:34 +00:00
Mike Fairhurst 081160036a Fix #35306, improper recursion detection. 
Bug: 35306
Change-Id: I28f7a298ebf701f9709cb3f49eff07da4cf01fd4
Reviewed-on: https://dart-review.googlesource.com/c/90880
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-01-29 21:28:49 +00:00
Konstantin Shcheglov 011a1239fc Support for out-of-band worker in AnalysisDriverScheduler. 
It will be used to perform work of searching for available declarations
and sending corresponding completion libraris notifications.

R=brianwilkerson@google.com

Change-Id: I21b23c4fadf1dc679c16ff00a47149d62707ae51
Reviewed-on: https://dart-review.googlesource.com/c/91581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-29 20:09:47 +00:00
Dan Rubel 09e6a689c2 parse nested control flow collection entries 
Change-Id: Id50c0a53a51f076dd75dd5bc13a694663449bc83
Reviewed-on: https://dart-review.googlesource.com/c/91400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-29 17:53:58 +00:00
Dan Rubel 213cfdc85e Update AstBuilder to generate new for statement structure 
... if control flow or spread collection entries are enabled.

Change-Id: I8718c1f7a649b7a2a7c9e376a6bf67c1df0542cf
Reviewed-on: https://dart-review.googlesource.com/c/91320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-29 17:53:58 +00:00
Dan Rubel 93a56336a3 Parse simple for control flow collection entires 
... and address comments in:
https://dart-review.googlesource.com/c/sdk/+/91144
https://dart-review.googlesource.com/c/sdk/+/90901

Change-Id: I7a9288bf28e069832193bd8a196a11f9a407b20d
Reviewed-on: https://dart-review.googlesource.com/c/91300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-29 17:53:58 +00:00
Paul Berry d73d3183a2 Fix dead_code hint 
Change-Id: I30eb074b5346f7c53997e585eda31b374445d807
Reviewed-on: https://dart-review.googlesource.com/c/91500
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-29 14:58:54 +00:00
Sam Rawlins c5a954794b Fix PackageBuildWorkspacePackage's contains 
This implementation did not check whether the path was actually contained
in the package:build workspace. It also made an assumption about how a
resource which is a directory would be treated, which was masked by an
unconditional-and-silenced catch.

The existing test which should have caught this had a hidden exception,
caught by the same unconditional-and-silenced catch. :(

Bug: https://github.com/dart-lang/linter/issues/1393
Change-Id: I0a6ecb584e06877463a47681830eed8f6f914030
Reviewed-on: https://dart-review.googlesource.com/c/91441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-01-29 02:01:51 +00:00
Konstantin Shcheglov 1ba59eb13d Make ERROR the default severity for StaticWarningCode. Remove _StrongModeTypeErrorProcessor. 
As a preparatory step for re-landing https://dart-review.googlesource.com/c/sdk/+/91170
and making these two restored problems to warnings.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I6266632ade84743b5725c54475fe402902576c00
Reviewed-on: https://dart-review.googlesource.com/c/91420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-28 22:08:17 +00:00
Konstantin Shcheglov 95b017a888 Implement changeFile() and recompute available libraries and declarations. 
Some renames in tests.

R=brianwilkerson@google.com

Change-Id: Ia54752c816bbc62f99a200d62658b6f4dfb26480
Reviewed-on: https://dart-review.googlesource.com/c/91381
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-28 18:05:17 +00:00
Paul Berry ec5ba8a252 Revert "Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden." 
This reverts commit 6699384ddd.

Reason for revert: Breakages in Flutter - see https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8923238548150736816/+/steps/analyze_flutter/0/stdout

Original change's description:
> Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Bug: https://github.com/dart-lang/sdk/issues/34437
> Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
> Reviewed-on: https://dart-review.googlesource.com/c/91170
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I07c96c8131c16b2748a403f38d5f15b814131c63
Reviewed-on: https://dart-review.googlesource.com/c/91360
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-01-28 17:09:24 +00:00
Brian Wilkerson 7daa9f65fc Start supporting resolution of the code-as-ui constructs 
Change-Id: I8fba9bfcac2339b113de6bc2954821585e7b8ab4
Reviewed-on: https://dart-review.googlesource.com/c/91240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-01-28 15:12:47 +00:00
Konstantin Shcheglov d927333c52 Add all SDK libraries, and context files belonging to the package / potions of it. 
R=brianwilkerson@google.com

Change-Id: I7e5d6cc12657c92f16d65e89f4b60eacf16c51b6
Reviewed-on: https://dart-review.googlesource.com/c/91260
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-27 22:33:04 +00:00
Konstantin Shcheglov 6699384ddd Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
Reviewed-on: https://dart-review.googlesource.com/c/91170
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-26 20:12:55 +00:00
Paul Berry d0f92e8cc5 Remove StrongTypeSystemImpl. 
It was deprecated in analyzer version 0.34.0, and clients are no
longer using it.

Change-Id: Ib27e9173eb57bcbec700071bd69acbcfaf96e913
Reviewed-on: https://dart-review.googlesource.com/c/91112
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-25 23:31:44 +00:00
Brian Wilkerson 2f3ebf70f6 Update definite assignment for the code-as-ui changes 
Change-Id: Id425fd6eb76402118738da13275224ae2d1905aa
Reviewed-on: https://dart-review.googlesource.com/c/91168
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-25 22:28:05 +00:00
Brian Wilkerson fe285e3e60 Update flow analysis for the code-as-ui changes 
Change-Id: I2bf9ea0beda6bc95556d0e1e75183779433f990f
Reviewed-on: https://dart-review.googlesource.com/c/91169
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-25 22:27:54 +00:00
Brian Wilkerson 6fae43b8af Check exact type for set literals (issue 35742) 
Change-Id: Icce758b13536171dd20201e52ecae8ecda39a336
Reviewed-on: https://dart-review.googlesource.com/c/91166
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-01-25 21:09:42 +00:00
Sam Rawlins eadf9679f3 Fix #35750 by passing a real ContextBuilder to createWorkspace. 
The PackageBuildWorkspace depends on its ContextBuilder to know if a
[findFile] should return null.

Bug: https://github.com/dart-lang/sdk/issues/35750
Change-Id: Ic562314fa87d1333e8f07efbb06a461be769ea32
Reviewed-on: https://dart-review.googlesource.com/c/91161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-01-25 21:07:03 +00:00
Paul Berry 983b77dda7 Remove unused argument allowNullableDereference 
Change-Id: I921344bbfe137c376b5b2314a5c82bb2c2bde128
Reviewed-on: https://dart-review.googlesource.com/c/91111
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-01-25 19:05:22 +00:00
Konstantin Shcheglov f8fef94243 Authomatically add dependencies from pubspec.yaml files. 
In addition to (path, modification) also cache on the content hash.

Implement getLibraries().

R=brianwilkerson@google.com

Change-Id: I263b5479f867aa28d5e43bc0c1bb02702ab6c915
Reviewed-on: https://dart-review.googlesource.com/c/91160
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-25 19:03:51 +00:00
Dan Rubel 874f9d0bdf Refactor for statement parsing 
This CL introduces 2 new parser listener events
in preparation for parsing for control flow structures
in literal lists, sets, and maps.

Change-Id: I230f36cded714a13e4badb401fe5b5906c93a2da
Reviewed-on: https://dart-review.googlesource.com/c/91144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-25 18:15:00 +00:00
Brian Wilkerson 4f9af4cd03 Add evaluation support for code-as-ui features 
Change-Id: I604d03218df8af0f405017367b906f944e877762
Reviewed-on: https://dart-review.googlesource.com/c/91110
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-25 14:20:04 +00:00
danrubel 56123f08b0 Update parser to support simple if/else control flow in literal lists, sets, and maps 
Change-Id: I740beea833ed1ad76582ad5232549bd204981808
Reviewed-on: https://dart-review.googlesource.com/c/90901
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-24 22:22:50 +00:00
Mike Fairhurst 31dc729452 Fix #35305, promoting a type that should not be promoted. 
Bug: 35305
Change-Id: If62e875feed1bed73ec189fa011183fd3e5b4a1b
Reviewed-on: https://dart-review.googlesource.com/c/90881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-01-24 19:10:06 +00:00
Paul Berry c9b1877cbf Disable task model for clients by making WorkItem inconstructible. 
The task model is still allowed in analyzer tests since we still have
some unit tests of non-task-model functionality that rely on the task
model to do their testing (see #35734).

Unit tests whose sole purpose was to test the task model have been
removed.  Test files that now empty have been removed.  Non-empty test
files that now contain no tests of their own have had their `main`
functions removed, and have been renamed so that the testing
infrastructure will no longer attempt to run them.

Change-Id: I8b4d0b2dde9337c4e1fe91e443a2c9da6eee8f4f
Reviewed-on: https://dart-review.googlesource.com/c/90720
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-01-24 16:29:17 +00:00