dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

6070 Commits

Author SHA1 Message Date
Paul Berry 6387b1bc73 Clarify ambiguity handling logic in _inferSetOrMapLiteralType 
Change-Id: Ibb5b66524be129bcd8cbf2453c22047631c0d8d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96140
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-08 20:27:14 +00:00
Paul Berry 8430281a6b Add an implementation of ScopedVisitor.visitForEachPartsWithDeclaration. 
Change-Id: I659609caa84e837801a0a38871c8bb8bb0c8948c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-08 18:58:58 +00:00
danrubel b2cb604b9d improve literal list/map/set control flow recovery 
* new ExpectedElseOrComma parser error code
* update recovery tests to enable control flow recovery
* rework test to call parser.parseLiteralListSuffix rather than parser.parseLiteralListSuffix

Fix https://github.com/dart-lang/sdk/issues/36141

Change-Id: I5bdee19eb3828de8fbdc514a3820afaa1309df99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-08 17:31:33 +00:00
Paul Berry 166c5e4b38 Use subtype rather than assignability to disambiguate maps/sets. 
This causes the implementation to match the spec.  Also, it's an
important distinction because the analyzer allows the user to change
the meaning of assignability checks using the analysis option
"implicit_casts: false".  We don't want this option to change the
meaning of set/map disambiguation.

Change-Id: I2a870209a31b4344c0568ecfe741bf731d9489a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-08 16:20:23 +00:00
Brian Wilkerson 6e359857e4 Move ConstantEvaluationTarget out of the task model 
Change-Id: I961f033e871a05ba38383b79865ed2795a1d452f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95984
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-08 16:03:03 +00:00
Paul Berry 0e054b1c6e Some fixes for UI-as-code type inference 
Change-Id: I72711aad365e95f2f1b20d7f23d7765a9581ff4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-08 15:39:19 +00:00
Dan Rubel 34953ffd7d Cleanup some NNBD flags 
* rename LibraryAnalyzer.isNonNullableMigrated to isNonNullableLibrary
* rename visitors isNonNullableMigrated to isNonNullableUnit

Change-Id: I46a7472a7cf91e1783b95fa4845f54b8f7f8a659
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-07 22:02:16 +00:00
Dan Rubel 6c1a05a388 update non-nullable flag in ErrorVerifier for angular plugin 
Change-Id: Ib4cb1a7426a15402c85ed9ef0fa9932f4b3f40b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-07 18:17:57 +00:00
Brian Wilkerson f44fecbe39 Fix the way type arguments for iterable and map are accessed 
Change-Id: I8d11fd4c10b8a5bc9fde633aba9987dba0ad59a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95742
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-07 18:04:12 +00:00
danrubel 309140693c Revise non-nullable flag from AstBuilder to ErrorVerifier 
This is one step in refactoring non-nullable enablement

* update AstBuilder to record isNonNullable in CompilationUnitImpl
* update ErrorVerifier to pull non-nullable from CompilationUnitImpl

Change-Id: I78e5f529330f10f294ad1c1b3b7ac8b672a5ee9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95426
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-07 13:29:45 +00:00
Brian Wilkerson a7d790bbbe Fix cast exception in resolution 
Change-Id: Iefa49b509bec67522bbd916c41fc301d5d9d3811
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95705
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 23:57:31 +00:00
Paul Berry 0124541d5f Deprecate AST data structures that will be obseleted by the "UI as code" feature 
- ForStatement and ForEachStatement will be replaced by ForStatement2.
- MapLiteral and SetLiteral will be replaced by SetOrMapLiteral.

To ease the transition, the old classes are subtypes of the new
classes, so even though the analyzer still creates instances of the
old classes, clients should be able to start referring to the new
classes in their code.  The analyzer will stop creating instances of
MapLiteral and SetLiteral when the experimental flags for the "UI as
code" feature are turned on, and will stop creating instances of all 4
classes when we bump the major version number (which should happen
sometime in March).

For visitors, we've updated the base classes with the following default methods:
  visitForStatement(node) => visitForStatement2(node);
  visitForEachStatement(node) => visitForStatement2(node);
  visitMapLiteral(node) => visitSetOrMapLiteral(node);
  visitSetLiteral(node) => visitSetOrMapLiteral(node);

So clients should be able to start revising their visitors to override
the new visit methods rather than the old ones, and the visit methods
in the base classes will automatically forward to the new visit
methods.

Change-Id: Ifde3a2aa3c8c49ce4e65dfaabf086db4dabb73f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95665
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-06 21:43:50 +00:00
Brian Wilkerson 17bf9d13b1 Delay disambiguating maps and sets until we know whether there are any conflicts 
Change-Id: If55d8ab011047107f34a05a08e60ee54eabc0b44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95668
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-03-06 20:47:45 +00:00
Brian Wilkerson 079309fcd6 Create curly braces when resynthesizing map and set literals 
Change-Id: I918624f0a07a02c98fdd2725a18fb3fd945eca8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95664
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 20:21:07 +00:00
Konstantin Shcheglov 90b61e2fde Start implementing linker and resynthesizing. 
Change-Id: Id1ad7925082f642d5dad7b01fa02b6c8cb76cf06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-06 17:29:29 +00:00
Konstantin Shcheglov a1226b1490 Write and read almost all nodes. 
CommentReference is not done yet.

Also skipped deprecated:
  visitListLiteral2
  visitMapLiteral2
  visitSetLiteral2

And about to be deprecated?
  visitForEachStatement
  visitForStatement
  visitMapLiteral
  visitSetLiteral


  Now we can resolve, write and read back into AST everything in pkg/.
  Some statistics:

R=brianwilkerson@google.com, paulberry@google.com

totalContent: 34814665 characters
totalWriteTime: 18140 ms
totalWriteBytes: 305675628
totalReadTime: 2761 ms
Change-Id: I2f92bb47c124d5ba040d8f66f762d23603c17609
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 17:20:49 +00:00
Paul Berry ba5644b76c Fix handling of closures containing type promotions in variables with inferred types. 
Promotion analysis requires the localVariableInfo data structures to
be set; these are set by the VariableResolverVisitor.  So we need to
ensure that this visitor runs prior to type inference.

Change-Id: I579301beb101f32a1965f9eb8f07b1196d232b8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95422
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-06 17:16:19 +00:00
Brian Wilkerson fa0d99156f Remove task model initialization 
Change-Id: I1c0bfd80f94b3d0f41a73d4df0fbe1b3514697c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95562
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-06 13:43:46 +00:00
Konstantin Shcheglov 2448445826 Make IfStatementImpl use IfMixin. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I32f967a392a96692b6633f8ee62072404cdeaa11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95425
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-06 02:19:54 +00:00
Paul Berry f112b672e7 Use ListLiteral.elements2 instead of ListLiteral.elements. 
ListLiteral.elements will soon be deprecated.

Change-Id: If61755da665c57d4e226eaebcbe089e14208685b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95424
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-05 23:33:48 +00:00
Paul Berry 4a7f9d7c11 Remove FindNode.setLiteral method. 
I accidentally left this out of 47b417c88e.

Change-Id: Ife4f3e1ceb82417ab7b9246dc4d6d36020e963c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-05 23:33:24 +00:00
Paul Berry 47b417c88e Remove FindNode methods related to AST data structures that will be removed. 
ForStatement and ForEachStatement will be removed in favor of
ForStatement2.  MapLiteral and SetLiteral will be removed in favor of
SetOrMapLiteral.  This CL changes FindNode methods to match, and
adjusts callers.

Change-Id: I89990f63aa277acd31458d485e897ebf0c6cf61f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-05 20:39:41 +00:00
Konstantin Shcheglov 927e758e96 Stop using package:html in analyzer. 
Related to https://github.com/dart-lang/sdk/issues/35802

R=brianwilkerson@google.com

Change-Id: I875a8dc657900137c5a7b59f2820b30a81b23405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95480
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-05 18:36:41 +00:00
danrubel 96e982f054 Improve await-outside-async error recovery 
Fix https://github.com/dart-lang/sdk/issues/36048

Change-Id: If40baa44a0aefa301c042bc1002d92e577bd3b9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95302
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-05 17:08:31 +00:00
Dan Rubel e033b676dd fix parser crash in unterminated string literal inside unterminated interpolation 
Fix https://github.com/dart-lang/sdk/issues/35900

Change-Id: I96d83e0c93d9e9c22d5b30048dc210672b1c003c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95043
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-05 15:35:58 +00:00
Konstantin Shcheglov 24d28e8f48 Write SetOrMapLiteral instead of MapLiteral or SetLiteral. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ib02e203893c3945f17c9ea20486f3dd421d8e94d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95301
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-04 22:42:16 +00:00
Brian Wilkerson c86a9ece5f First cut at upward inference for the ui-as-code features 
Change-Id: I5d63e9433deed3baa1a2df44e04b57782da6c9b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95062
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-04 22:00:46 +00:00
Konstantin Shcheglov 2329fccdb9 Use visitForStatement2() and read as ForStatement2 and its parts. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I57dc7d816d9984a247b4c5e78f1f792230174604
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-04 21:52:20 +00:00
Mike Fairhurst a7a4c95df7 Summarize SetOrMapLiteral 
Change-Id: Ic0356500fc9381a05bc91fb8bd9bead877de01cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94348
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-03-04 21:47:21 +00:00
Paul Berry 7d8ffe0daf Eliminate uses of old AST node types from pkg/analyzer/lib/src/test_utilities 
Change-Id: I5cfa3aa36e97c2fcb0d3969f483c04763bbcc882
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-04 18:12:22 +00:00
Konstantin Shcheglov 2e463506b7 Read more nodes from serialized AST. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I1d271707fc8a7b8ea86a0051efe3429d689c70af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94992
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-04 17:44:41 +00:00
Paul Berry 819f44532c Eliminate uses of old AST node types from pkg/analyzer/lib/src/task/strong 
Change-Id: I2e0dabfcf15a150b52a84be803057a0a9ebeec1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95201
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-04 17:28:01 +00:00
Paul Berry 095e651ff2 Eliminate uses of old AST node types from pkg/analyzer/lib/src/services 
Change-Id: I5aefe213b22e9200aa2e3f24ae065ef9fc0f214c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-04 16:14:16 +00:00
Brian Wilkerson 1e0d514469 Address comments from a previous CL 
Change-Id: I2a0ba9ae0b7c6b1e6e72de6fee5ac2bc7dfc5598
Reviewed-on: https://dart-review.googlesource.com/c/94987
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-03-02 15:59:12 +00:00
Konstantin Shcheglov 156790474e Allocate fieldOffsets once, in computeFieldOffsets(). 
At this point we know exactly how many offsets we have, so we can
allocate it and avoid growing. This make writing large data structures
about 25% faster.

R=paulberry@google.com

Change-Id: I884b0e3633bb4ea19a41ef1ceefaf1b427d0389e
Reviewed-on: https://dart-review.googlesource.com/c/95044
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-02 03:20:51 +00:00
Konstantin Shcheglov 4bd3e4b561 Write more AST nodes to summary. 
There are probably still some nodes missing, but with this we can
write resolved analyzer/lib/ and analysis_server/lib/.

Reading is still mostly unimplemented.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I3c2e8a61a1d0f3ce5fbe8307b52e2094bc96fcb1
Reviewed-on: https://dart-review.googlesource.com/c/95064
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-02 00:24:41 +00:00
Jenny Messerly 5a335957f2 [analyzer] fix #33119, add strict-raw-types flag 
When the flag is enabled, warnings are issued for raw types, for
example `List`.

Raw types (those without explicit type arguments) are allowed if any
of these are true, otherwise they are reported:

- none of the type arguments are `dynamic`.
- the type was inferred from a downwards context.
- the class/typedef has `@optionalTypeArgs` from package:meta.

Change-Id: I1e70dba5b3bf6118b274bbf72843e3578dbaa8fd
Reviewed-on: https://dart-review.googlesource.com/c/75629
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-03-02 00:02:01 +00:00
Paul Berry 5f9bd87689 Eliminate uses of old AST node types from parts of the analyzer 
This CL covers the following subdirectories:
- pkg/analyzer/lib/src/dart/resolver
- pkg/analyzer/lib/src/dart/element

Change-Id: I3b20573b31b933936d1b541e7055ff21d2282288
Reviewed-on: https://dart-review.googlesource.com/c/94988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-01 22:43:31 +00:00
Paul Berry 38d675287c Eliminate uses of old AST node types from parts of the analyzer 
This CL covers the following subdirectories:
- pkg/analyzer/lib/src/dart/analysis/dependency
- pkg/analyzer/lib/src/dart/constant

Note that some uses of MapLiteral and SetLiteral remain in these
directories to support cloning of old AST data structures.

Change-Id: I825ee8923f9d1a5a937f83293370c2628d28f590
Reviewed-on: https://dart-review.googlesource.com/c/95042
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-01 22:35:11 +00:00
Konstantin Shcheglov 298866ed94 Write / read resolved AST to / from flat buffers. 
AstBinaryWriter does not yet support all node types, but a lot of them,
and can successfully write many large Dart files, including itself.
Whether it does it correctly, we cannot say yet, because AstBinaryReader
supports much smaller set of node types. I plan to add all nodes in
following CLs, and run over larger bodies of code.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Iaa2a5c743bd1659ea30c93632028d3a475736bf5
Reviewed-on: https://dart-review.googlesource.com/c/94684
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-01 19:48:02 +00:00
Konstantin Shcheglov 863f7df7aa Include debug info when dart:core is not resolved. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35226
Change-Id: I3064e1f2affae9b6fdd34b3740882cd06f293cba
Reviewed-on: https://dart-review.googlesource.com/c/94983
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-01 19:25:00 +00:00
Brian Wilkerson f00fe7a289 Rework of downward inference for the ui-as-code features 
Change-Id: Idfc815d976343a6ad015beaa6074ca5c979f8c3b
Reviewed-on: https://dart-review.googlesource.com/c/94700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-03-01 19:23:36 +00:00
Paul Berry 644026da51 Eliminate uses of old AST node types from AstFactory 
Change-Id: I6bfb37b9a1e1477a27e5a60ba6120876ae5ecb9d
Reviewed-on: https://dart-review.googlesource.com/c/94804
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-01 18:03:25 +00:00
Mike Fairhurst 15515d86e3 Reland "[analyzer] Constant verifier support for SetOrMapLiteral" 
Original change's description:
> Revert "[analyzer] Constant verifier support for SetOrMapLiteral"
> 
> This reverts commit 9c6315c199.
> 
> Reason for revert: Do not have permission to approve the bot failures.
> 
> Original change's description:
> > [analyzer] Constant verifier support for SetOrMapLiteral
> > 
> > Change-Id: Iaa189aa7ad733af3f702546f1d7a379630b61aa7
> > Reviewed-on: https://dart-review.googlesource.com/c/94581
> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> > Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
> 
> TBR=paulberry@google.com,brianwilkerson@google.com,mfairhurst@google.com
> 
> Change-Id: Id7f48506994cc5b8de506f9830f12d794f186e21
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/94981
> Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>

TBR=paulberry@google.com,brianwilkerson@google.com,mfairhurst@google.com

Change-Id: I7e514b646c1c62532e6f19201db6ea3428cb96d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/95000
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-03-01 08:01:24 +00:00
Mike Fairhurst 9bec44d1e2 Revert "[analyzer] Constant verifier support for SetOrMapLiteral" 
This reverts commit 9c6315c199.

Reason for revert: Do not have permission to approve the bot failures.

Original change's description:
> [analyzer] Constant verifier support for SetOrMapLiteral
> 
> Change-Id: Iaa189aa7ad733af3f702546f1d7a379630b61aa7
> Reviewed-on: https://dart-review.googlesource.com/c/94581
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Auto-Submit: Mike Fairhurst <mfairhurst@google.com>

TBR=paulberry@google.com,brianwilkerson@google.com,mfairhurst@google.com

Change-Id: Id7f48506994cc5b8de506f9830f12d794f186e21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94981
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-03-01 07:43:04 +00:00
Mike Fairhurst 9c6315c199 [analyzer] Constant verifier support for SetOrMapLiteral 
Change-Id: Iaa189aa7ad733af3f702546f1d7a379630b61aa7
Reviewed-on: https://dart-review.googlesource.com/c/94581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-03-01 06:36:17 +00:00
Konstantin Shcheglov 67366ed771 Support for @Variant and @VariantId in generator. 
It also includes a sample how it looks in IDL and generated.
I will remove it before landing.

R=paulberry@google.com

Change-Id: I4c60b33e623cf9c55d46a8dd9624377e5a0f5053
Reviewed-on: https://dart-review.googlesource.com/c/94921
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-03-01 02:43:30 +00:00
Paul Berry c2e48195f0 Rename UiAsCodeVisitorMixin to UIAsCodeVisitorMixin 
To conform to Dart style rules

Change-Id: I1cc7ef76d0d723725f6d0393ca6e2b7538fc2f3e
Reviewed-on: https://dart-review.googlesource.com/c/94900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 21:42:09 +00:00
Paul Berry 39f365f3b9 Sort declarations in parser.dart. 
Change-Id: I000193878307686d52e5b02cd3e6cdaafed68959
Reviewed-on: https://dart-review.googlesource.com/c/94681
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-28 12:48:56 +00:00
Paul Berry 8af83b19d6 Sort declarations in ast_builder.dart. 
No functional change.

Change-Id: If695a7437482aef1de7013aa404260f3602bdc93
Reviewed-on: https://dart-review.googlesource.com/c/94642
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-28 12:48:16 +00:00