Commit Graph

483 Commits

Author SHA1 Message Date
Brian Wilkerson 2ffa8de794 Add notification of analyzed files
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1232393005 .
2015-07-13 15:07:33 -07:00
Brian Wilkerson 10b7db100f Revert "Update Analysis Server highlight API and implementation."
This reverts commit 739847402b.

Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1236433003 .
2015-07-13 09:49:55 -07:00
Konstantin Shcheglov d7c2f4550b Issue 23640. Implement 'analysis.getNavigation' request.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640

Review URL: https://codereview.chromium.org//1232683003 .
2015-07-10 15:31:25 -07:00
guillermooo 1383dd8684 typo 2015-07-09 13:52:12 -07:00
guillermooo d7d272de81 minor changes to comments and strings 2015-07-09 13:52:12 -07:00
Konstantin Shcheglov 739847402b Update Analysis Server highlight API and implementation.
I think this is a good enough compromise between the existing and IDEA granilarity.

Eclipse plugin CL will follow.

(IN)VALID_STRING_ESCAPE are not implemented yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1227143003 .
2015-07-09 11:19:44 -07:00
Paul Berry 9857471f8c Modify analysis server codegen check to tolerate Windows line endings.
Now that the git repository config has been modified to use CR/LF on
Windows machines, our generated files contain different contents on
Windows machines than they do on Mac/Linux machines, so they were
failing the codegen check.  This CL updates the codegen check to
tolerate those differences.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1219493007.
2015-07-01 11:12:26 -07:00
danrubel d6580fd9fb generated analysis server java client code package rename
This changes the generated package name to better reflect our new home
from com.google.dart.server.generated.types
to   org.dartlang.analysis.server.protocol

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1164683003
2015-06-04 17:29:35 -04:00
Brian Wilkerson 07dd6b7649 Add lineLength parameter to edit.format request (issue 23519)
R=jwren@google.com

Review URL: https://codereview.chromium.org//1154303005
2015-06-01 09:39:02 -07:00
paulberry@google.com de0cb1f374 Create a new home for Java code generated by analysis server.
This code used to be generated directly into
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated,
however now that editor is no longer part of this repository that
doesn't work anymore.

Fixes the test pkg/analysis_server/tool/spec/check_all_test.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//1132673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45646 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 16:40:04 +00:00
nweiz@google.com 70a846ad6c Update pubspecs and dependencies to get pkgbuild tests working.
This also removes the vendored copy of Angular, which was an outdated version of
an unstaffed branch.

R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1058283006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45410 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 20:08:53 +00:00
brianwilkerson@google.com 4e0bb57118 Update specification version number
R=jwren@google.com

Review URL: https://codereview.chromium.org//1096693006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45297 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 21:07:29 +00:00
brianwilkerson@google.com 4422b7c01e Fix error handling for formatting and update the spec
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1099633004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45296 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 20:57:33 +00:00
danrubel@google.com f117f67660 add optional importUri to completion suggestion
BUG=dartbug.com/23175
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1097083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45288 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:32:54 +00:00
paulberry@google.com cd1dd1864b Fix additional cases where analysis server might send null, violating protocol.
In addition, modify the code generation so that these protocol
violations will be caught by assertions during unit tests.
Previously, they would only be caught at runtime by client code.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1083223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45211 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 15:41:39 +00:00
paulberry@google.com 4af80fc1e7 Add an analysis server option to enable null-aware-operator support.
The option may be enabled in editor by setting the tracing option
"experimental/nullAwareOperators" (in com.google.dart.tools.core) to
true.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1063613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44909 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 14:53:00 +00:00
brianwilkerson@google.com b396bc4c96 Support refresh of individual analysis roots (issue 22254)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1047733004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44791 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-30 21:07:23 +00:00
danrubel@google.com a8eb426282 add UNKNOWN_SOURCE error code and remove 2 unused legacy error codes
BUG=dartbug.com/23039
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1042403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44787 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-30 20:12:29 +00:00
jwren@google.com 38ff63c77d Anchor and create a link near Notifications and Requests definitions in the Analysis Server Spec
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1033473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44641 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 18:15:34 +00:00
scheglov@google.com 0c21dc284c Add 'containingClassDescription' to HoverInformation.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1003193005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44483 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 22:05:05 +00:00
scheglov@google.com 2e77fcdd11 Add an optional 'typeParameters' to Element.
Also use it in Editor, e.g. in Outline.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//990343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44349 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 22:02:44 +00:00
scheglov@google.com 6c8ed75cae Issue 22465. Mark occurrences only if there are no pending changes.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22465

Review URL: https://codereview.chromium.org//994733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44340 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 20:17:28 +00:00
scheglov@google.com 1183b3b35a When a closure is extracted as a method, it does not have any return type.
But it should not be returned as 'void'.
It should be an empty string, as any other method with unknown return type.
I guess we could improve this in the future, e.g. promote type of a returned expression into the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//970063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44177 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 16:17:33 +00:00
brianwilkerson@google.com cd58e290c4 Reformat
R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 22:43:12 +00:00
brianwilkerson@google.com 3750ba067f Return version with connected notification
R=jwren@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//943723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43892 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 20:45:01 +00:00
scheglov@google.com 6a78250c64 Issue 22476. Outline for enums.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22476

Review URL: https://codereview.chromium.org//934353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43853 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 21:37:27 +00:00
jwren@google.com 89219a623f Fix build, address comments from Brian in previous email.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//931833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43820 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 20:26:09 +00:00
jwren@google.com a46fc6016d Addition of the --no-index flag to the analysis server spec.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//932883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43816 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:55:00 +00:00
brianwilkerson@google.com f473ae15a3 Spec changes for issue 22254
Review URL: https://codereview.chromium.org//882643004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43565 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:35:40 +00:00
brianwilkerson@google.com 4468038300 Rework requests in execution domain
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//904733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43556 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 15:49:44 +00:00
brianwilkerson@google.com fcd7fdb93a Fix ambiguous description
R=paulberry@google.com

Review URL: https://codereview.chromium.org//901063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43493 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 01:31:09 +00:00
brianwilkerson@google.com 6ddc37a5cc Disable analysis in hidden directories (fix for issue 22170)
R=paulberry@google.com

Review URL: https://codereview.chromium.org//880313006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43485 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 21:27:43 +00:00
pquitslund@google.com ba6742f9fe Formatter service API tweaks.
Some way to indicate no selection is required in the case where there is none.  I opted for the -1 convention not becuase I particularly like it but because, well, it's convention! :)

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//894863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43369 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:14:22 +00:00
brianwilkerson@google.com 81c90c6492 Specify mapUri for directories
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//896513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43364 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 22:45:50 +00:00
jwren@google.com 3c66f9be64 Change server API version to 1.0.0 for clients
R=paulberry@google.com

Review URL: https://codereview.chromium.org//881873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43212 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 22:06:16 +00:00
scheglov@google.com c93b24904d Issue 22157. Cancel a pending refactoring request on receiving a new one.
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22157

Review URL: https://codereview.chromium.org//884453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43201 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 19:24:19 +00:00
pquitslund@google.com b9f355d2a4 Library dependencies server API updates (to pass package maps).
R=brianwilkerson@google.com, jwren@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//874373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
brianwilkerson@google.com 09b93c2416 Support code generation for other languages
R=paulberry@google.com

Review URL: https://codereview.chromium.org//863883004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43144 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:35:48 +00:00
scheglov@google.com 768aeeac4b Use 'print' to send responses/notifications to the client.
Ensure that Java client reads lines in a separate thread,
so that server's stdout never overflows.

R=brianwilkerson@google.com, danrubel@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//872633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43123 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 21:33:40 +00:00
jwren@google.com 36f5f8e768 Move AnalysisServer to package ...generated to indicated that the file shouldnt be changed manually.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//868183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43119 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 20:10:03 +00:00
danrubel@google.com f94326c241 add optional request field to record time at which client made request
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//865383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43113 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 17:41:29 +00:00
danrubel@google.com 4f59e94ce1 update analysis server spec and regen files
this is needed to support new UpdateContentConsumer

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//868893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43088 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 23:14:09 +00:00
pquitslund@google.com 03aa9c33e5 Library Dependencies Analysis service API.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//861893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43077 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 21:26:28 +00:00
jwren@google.com 54727b8eca Add addStatusListener to the AnalysisServer generator.
R=keertip@google.com

Review URL: https://codereview.chromium.org//864063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43049 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 18:25:18 +00:00
jwren@google.com 252c19c920 Addition of the new flag "file-read-mode" into the analysis server to fix the offset bug with IntelliJs integration.
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//857283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43028 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:48:00 +00:00
brianwilkerson@google.com 0b975704b5 Alternate status page
R=paulberry@google.com

Review URL: https://codereview.chromium.org//840953008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43020 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 18:46:44 +00:00
jwren@google.com bcad595a17 Revert "Addition of the optional FileReadMode into the server spec."
R=paulberry@google.com

Review URL: https://codereview.chromium.org//838243004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42965 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 17:39:32 +00:00
jwren@google.com 4d1507935d Addition of the optional FileReadMode into the server spec.
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//825393005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42921 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:01:46 +00:00
pquitslund@google.com 6fb12789e7 Analysis server format service wiring (and protocol doc update).
R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//833903005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42835 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 20:34:10 +00:00
paulberry@google.com adcffd8bf5 Fix checking of generated directory contents.
R=jwren@google.com

Review URL: https://codereview.chromium.org//811973010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42789 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 22:19:58 +00:00