ba6742f9fe
Formatter service API tweaks.
...
Some way to indicate no selection is required in the case where there is none. I opted for the -1 convention not becuase I particularly like it but because, well, it's convention! :)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//894863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43369 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:14:22 +00:00
81c90c6492
Specify mapUri for directories
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//896513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43364 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 22:45:50 +00:00
3c66f9be64
Change server API version to 1.0.0 for clients
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//881873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43212 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 22:06:16 +00:00
c93b24904d
Issue 22157. Cancel a pending refactoring request on receiving a new one.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22157
Review URL: https://codereview.chromium.org//884453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43201 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 19:24:19 +00:00
b9f355d2a4
Library dependencies server API updates (to pass package maps).
...
R=brianwilkerson@google.com , jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//874373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
768aeeac4b
Use 'print' to send responses/notifications to the client.
...
Ensure that Java client reads lines in a separate thread,
so that server's stdout never overflows.
R=brianwilkerson@google.com , danrubel@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//872633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43123 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 21:33:40 +00:00
f94326c241
add optional request field to record time at which client made request
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//865383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43113 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 17:41:29 +00:00
4f59e94ce1
update analysis server spec and regen files
...
this is needed to support new UpdateContentConsumer
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//868893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43088 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 23:14:09 +00:00
03aa9c33e5
Library Dependencies Analysis service API.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//861893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43077 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 21:26:28 +00:00
252c19c920
Addition of the new flag "file-read-mode" into the analysis server to fix the offset bug with IntelliJs integration.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//857283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43028 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:48:00 +00:00
bcad595a17
Revert "Addition of the optional FileReadMode into the server spec."
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//838243004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42965 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 17:39:32 +00:00
4d1507935d
Addition of the optional FileReadMode into the server spec.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//825393005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42921 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:01:46 +00:00
6fb12789e7
Analysis server format service wiring (and protocol doc update).
...
R=brianwilkerson@google.com , danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//833903005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42835 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 20:34:10 +00:00
14a97cafed
suggest fields rather than synthetic getters
...
and return dynamic returnType rather than null
BUG=dartbug.com/21679
R=paulberry@google.com
Review URL: https://codereview.chromium.org//791553007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42786 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 19:02:47 +00:00
f781ec6675
Add generateLints analysis option to the Server protocol API.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//806943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42745 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:38:43 +00:00
2005b07aea
Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int
...
This allows the sever to return a more graduated relevance
and facilitates moving client side prioritization over to the server.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//845553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42735 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 15:30:59 +00:00
3f6fc86c14
Remove remaining references to Angular and Polymer from the analysis server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//842753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42713 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:37:19 +00:00
e259b02b92
Adds LINTs to the server's generated protocol.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//838283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42711 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:05:48 +00:00
dd306dc9eb
Enable enum and deferred import support
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//829133007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42704 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:51:49 +00:00
94993d5cc1
Include required parameter names when completing a method call.
...
When a method such as "void m(int i, int j)" is completed, instead of
simply inserting "m()", we insert "m(i, j)", we highlight "i", and we
set up linked position groups for "i" and "j" so that the user can
press tab to move from one parameter to the next.
Optional parameters (both named and positional) are not handled by
this logic--the user must still enter them manually.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//837793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42667 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 16:57:39 +00:00
ee26309ffb
Add format API
...
R=pquitslund@google.com , rnystrom@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//809213003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42648 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 22:45:41 +00:00
77b819cd76
Report pub status
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//800913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42328 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 17:40:04 +00:00
e73e5faaad
Getters should not have parameters.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//787603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42183 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:04:44 +00:00
1d4ba5fba7
Add paging support
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//769963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42084 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 15:54:20 +00:00
20d82e5135
Compressed/optimized navigation notification.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//766323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42049 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-01 22:21:28 +00:00
d3646956e8
first cut argument list completion suggestions
...
- first cut simplistic insertion of params
- required params only for now
- move cursor after ) if no params
- don't insert () if identifier suggestion
- does not cover all method/function invocations yet
- updated comments in Server API
- extracted new declaration visitor
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//711533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41586 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 21:42:31 +00:00
67071bd861
Refactor CompletionSuggestionKind
...
- Remove many CompletionSuggestionKinds that duplicate ElementKind
- Add two new CompletionSuggestionKinds: INVOCATION and IDENTIFIER
- regenerate Analysis Server Dart and Java API and docs
- rework Dart and Java tests
- remove/rename unused Dart and Java classes and methods
- remove unnecessary reference to SDK
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//684183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41396 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 16:09:56 +00:00
a151361e2d
Add ENUM and ENUM_CONSTANT to the specification.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//677333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41307 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-26 22:01:29 +00:00
51fb6c5a9e
Issue 21377. Specify that navigation regions are sorted and implement it.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21377
Review URL: https://codereview.chromium.org//649853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41261 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 17:18:13 +00:00
751e087262
Add package root setting to analysis server API.
...
The command does not have any effect yet.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//672003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41253 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 00:11:36 +00:00
6742866101
Add "checked mode compile time error" type to analysis server API.
...
This avoids a crash if the analyzer detects a checked mode compile
time error.
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//636313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41000 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 20:52:29 +00:00
2d00d5e2c0
Specify when 'sortMembers' will return an error.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//604333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40719 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-26 17:12:15 +00:00
3bacc7ae1e
Use a separate request for 'Sort members' feature, not a refactoring.
...
As requested in https://codereview.chromium.org/609653002/
R=brianwilkerson@google.com , lukechurch@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//607813003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40713 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-26 15:53:47 +00:00
1f4682b962
Rework launch data
...
R=jwren@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//596893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40610 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-23 22:02:03 +00:00
855f8364d2
Issue 20910. Add SORT_MEMBERS refactoring to the server specification.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20910
Review URL: https://codereview.chromium.org//583843004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40573 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 21:54:03 +00:00
604a9e760d
Integration of MOVE_FILE into the server and a couple of fixes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//583193005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40510 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-19 18:10:56 +00:00
eeb6c26d21
API proposal for the MOVE_FILE refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//587553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40499 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-19 16:20:29 +00:00
3e884db043
Index and search of import prefixes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//582453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40397 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:19:39 +00:00
6cc9d7d887
add element to completion suggestion API
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//572373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40360 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 23:17:24 +00:00
457050dd88
Add SourceFileEdit.time field.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//574573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40329 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 17:19:37 +00:00
2208ce5587
Split refactoring problems into init, options and final.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//576473003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40318 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 15:14:51 +00:00
9773f61186
Add LABEL ElementKind, completion and highlighting kinds.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//567273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40247 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:04:52 +00:00
e7bdefffba
update error handling to send response with stack trace
...
BUG=dartbug.com/20893
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//569743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40237 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 12:30:07 +00:00
a9a2c98d53
gracefully handle internal exceptions during request
...
- new SERVER_ERROR response code
- return SERVER_ERROR response if exception when processing request before request can be sent
- send server.error notification if exception occurs anytime while processing request or future work triggered by request
BUG=dartbug.com/20893
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//570453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40198 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 05:01:46 +00:00
f289a1abac
Fix exception in error processing; implement mapUri
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//560103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40109 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 19:54:49 +00:00
209ebe2a7f
Integrate the EXTRACT_METHOD refactoring into Editor.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//554143003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40034 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 14:57:41 +00:00
d7f0532f29
Add feedback for INLINE_METHOD refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//551963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39992 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 19:26:52 +00:00
4187ed6349
Add feedback for 'Inline Local' refactoring.
...
Also fix for the Java client tests.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//542333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39977 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 16:29:23 +00:00
44c2892f6f
Initial support for execution domain
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//544273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39974 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 16:21:16 +00:00
29341b4e5e
Rename debug domain to execution
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//547753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39942 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-06 02:43:12 +00:00
pquitslund@google.com