ae6f534188
Add fixes for SDK violation hint
...
Change-Id: Icbb41c2e305b45c6abb9ade343d677c2e28895ce
Reviewed-on: https://dart-review.googlesource.com/c/84691
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-11-21 02:19:21 +00:00
257a6c8d2b
Don't send error responses to $/ notifications/requests
...
The LSP spec says requests/notifications starting $/ can be ignored if they are not understood.
Change-Id: I6c0d011057b2f958c38fa2c4e92a1787944cb8d0
Reviewed-on: https://dart-review.googlesource.com/c/84902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-11-20 15:31:16 +00:00
a8c30d89d3
Add basic LSP definition handling
...
Change-Id: Ife576c648db9a92b119da2dfd71366ca9b9549de
Reviewed-on: https://dart-review.googlesource.com/c/84607
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-20 08:30:39 +00:00
01e0df71a8
Stop unnecessarily extending Object
...
Change-Id: Ib557755916b09be4e1ad1b1c2e4bed052a280513
Reviewed-on: https://dart-review.googlesource.com/c/84640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-11-16 16:43:24 +00:00
b12c125825
Export Future from dart:core in the mock sdk
...
Change-Id: I9b234e5834a6a6559b65b86140d60ea781ff8883
Reviewed-on: https://dart-review.googlesource.com/c/84501
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-11-15 19:32:30 +00:00
14688305d4
Basic LSP signature help implementation
...
Change-Id: Iab985328a3df588faf641435f4ab3a15c9ed3719
Reviewed-on: https://dart-review.googlesource.com/c/84532
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-11-15 17:16:43 +00:00
f264a67d7f
Basic completion support
...
Change-Id: I59b6b247d5c47cebee6e7b1189838d3db914ae4b
Reviewed-on: https://dart-review.googlesource.com/c/84528
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-11-15 15:12:16 +00:00
da191665aa
Issue 34709. Support generic type alias (AKA generic function type alias for now) in outline and completion.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/34709
Change-Id: Ic18d98e07ba0cbd231ded27c4c32533ee013632b
Reviewed-on: https://dart-review.googlesource.com/c/84320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-11-13 21:20:08 +00:00
fa800e270c
Run "sort members" on LSP files
...
Change-Id: I166ad41b3f9dd84f664daf82e1eb38524be3ffdd
Reviewed-on: https://dart-review.googlesource.com/c/84200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-11-13 18:08:46 +00:00
8166908a03
Improve hovers to include the elementDescription
...
Also remove munging of [types] because it messes with code blocks.
Change-Id: Ieb7cd242db6662c1ee5f983b0d87544cc5e75367
Reviewed-on: https://dart-review.googlesource.com/c/84034
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-13 08:20:47 +00:00
937e950fd2
Parse inline interfaces into types
...
Change-Id: I33c6d12d760b0e44505a34ad1b4cb77ffa0db0f3
Reviewed-on: https://dart-review.googlesource.com/c/84039
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-11-13 08:08:52 +00:00
d53f8c8789
Issue 34735. Fix completion in ConstructorFieldInitializer expression.
...
R=brianwilkerson@google.com , danrubel@google.com
Bug: https://github.com/dart-lang/sdk/issues/34735
Change-Id: I420822cce50b17807d1235de5d071942ce2e6076
Reviewed-on: https://dart-review.googlesource.com/c/84048
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-11-12 18:11:14 +00:00
51f34ea580
Split up the tests for fixes related to lints
...
Change-Id: Icb299b43a745f02ecbc11c0421866f112033ca6a
Reviewed-on: https://dart-review.googlesource.com/c/84054
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-11-12 17:29:56 +00:00
5147c0c6f1
Fix handling of UTF8 characters in LSP packets
...
`.length` on a string was not the correct thing to know how many bytes when encoded as UTF8.
Change-Id: I526eb4efd9a70e9daae92d1c16843136fd6ec1d1
Reviewed-on: https://dart-review.googlesource.com/c/84032
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-12 17:02:15 +00:00
3ae0dcaa18
Merge commit '5ef1465c55be601f601e1f565c9b9d2f94d76aff' into analyzer
...
Conflicts:
pkg/analysis_server/lib/src/analysis_server.dart
pkg/analysis_server/lib/src/server/driver.dart
2018-11-12 06:39:27 -08:00
d502ba6014
Add new analysis_server_client handlers
...
* Make the NotificationHandler a mixin
and move it to /lib/handlers
* Add new notification handler mixins
- AnalysisCompleteHandler
- ServerConnectedHandler
* Add Server.stop method
.. and address comments in
https://dart-review.googlesource.com/c/sdk/+/83180
Change-Id: I94ba657f20520ae4bb0e479a014c11509eeb9d2c
Reviewed-on: https://dart-review.googlesource.com/c/83520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-08 21:10:06 +00:00
3583065b27
Implement basic document formatting & update capabilities
...
Change-Id: Iabc29423fe71f99e8dcbc1bde7e3d3a9055f18da
Reviewed-on: https://dart-review.googlesource.com/c/83761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-11-08 19:49:08 +00:00
6678d3f47e
Add support for hovers
...
Change-Id: I3403f5979e9d6bc66479fb8736ec4705d7c1b96e
Reviewed-on: https://dart-review.googlesource.com/c/83760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-11-08 18:26:55 +00:00
90d2c4f406
Split tests out into separate classes
...
Change-Id: I279b2426d0a6ecc1d9e04677bbb8d93ceb9b2d64
Reviewed-on: https://dart-review.googlesource.com/c/83743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-11-08 17:11:15 +00:00
d5e853e0ce
Improve parsing of LSP spec
...
Change-Id: Ica48b57c890105df346c5a133fe0389bd92dbb6e
Reviewed-on: https://dart-review.googlesource.com/c/83388
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-08 15:31:26 +00:00
04777b58cc
Add analysis (publishDiagnostics) and handling of opening/editing/closing files
...
Change-Id: I6dadf125b1a71c4f321f4ab9a01ff2bbfcbd1d4a
Reviewed-on: https://dart-review.googlesource.com/c/82500
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-08 08:52:48 +00:00
09435f21fc
Update member sorter to support mixins and generic type aliases.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ia417b003321d4b92f92b125a4607634fa6d21206
Reviewed-on: https://dart-review.googlesource.com/c/83464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-11-07 19:36:06 +00:00
1215f239c8
Remove references to ContentCache from analysis_server
...
Change-Id: Ie1e107467f639e9a005c7b16055541d235ac38d8
Reviewed-on: https://dart-review.googlesource.com/c/82921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-11-05 18:17:57 +00:00
40dee8da38
Merge commit '11707cab410906df65b72e94fd59b2f51690c9e7' into analyzer
2018-11-05 10:00:59 -08:00
11707cab41
Add edit.dartfix test for moveTypeArgument
...
... and address comments in
https://dart-review.googlesource.com/c/sdk/+/82741
Change-Id: Icbe7e2e2157bc31579204e9d0202c2e37cdb4be0
Reviewed-on: https://dart-review.googlesource.com/c/82881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-11-05 16:31:10 +00:00
b1cbfab274
Merge commit '9a1a7763f150e92e39a05519be47e581584c5de9' into analyzer
2018-11-05 04:01:07 -08:00
dff53c12d0
Remove more uses of package:analyzer/analyzer.dart
...
Change-Id: I4b8abf72994d7a60b09529a740bd16b591813807
Reviewed-on: https://dart-review.googlesource.com/c/82800
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-11-04 19:36:36 +00:00
25e0c7b3f9
Split apart the assist tests
...
Change-Id: I249064b4c9215bdb2ed8bc7a68d9cca4e47d6bcd
Reviewed-on: https://dart-review.googlesource.com/c/82791
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-11-03 19:10:40 +00:00
68e2cdc3e6
Add edit.dartfix test
...
Change-Id: I71b886e0b15914585ef6a65e30145fee38b4b077
Reviewed-on: https://dart-review.googlesource.com/c/82741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-11-03 00:17:43 +00:00
b71948faee
Consolidate MockSdk(s) into one, living in analyzer/lib/src/test_utilities.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I70946b8e6f790608ad52c8f27cd6f506673f7b0d
Reviewed-on: https://dart-review.googlesource.com/c/82710
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-11-02 21:52:44 +00:00
2784473939
Fixes and tests for quick fixes in mixins.
...
I hit an exception in Analysis Server, so looked at it and related places.
R=brianwilkerson@google.com
Change-Id: Ife9bac50f8ea16aa0a092de0fdbc74c0c1534b23
Reviewed-on: https://dart-review.googlesource.com/c/82700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-11-02 18:56:49 +00:00
e3c8774543
Add AnalysisSession.analysisContext, stop using AnalysisDriver's AnalysisResult outside the driver.
...
Change-Id: I63138e002d9e777f51d2d843f7ef2b1f32fed3e0
Reviewed-on: https://dart-review.googlesource.com/c/82529
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-11-02 14:16:31 +00:00
1fb58ad61b
Fix CONVERT_DOCUMENTATION_INTO_LINE when there is an empty line.
...
R=brianwilkerson@google.com
Change-Id: Ib5c103426bf5ebb84945816c01e9f5bbcef941ba
Reviewed-on: https://dart-review.googlesource.com/c/82472
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-11-01 20:25:29 +00:00
0299b98197
Renames for addPackageFile() / addPackageMeta().
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I9d710d76186f5e54592457ac8708551ac096a43a
Reviewed-on: https://dart-review.googlesource.com/c/82465
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-11-01 17:24:26 +00:00
d802c7d33d
Improve LSP server tests
...
Change-Id: Ib9c7cd2966c6cf4d0c02e56ec405761f899e6668
Reviewed-on: https://dart-review.googlesource.com/c/82441
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-01 17:08:16 +00:00
5711a1d539
Move implementations of analysis results into src/results.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I7527dfb597ff54802517093b4aa526b14e7b705c
Reviewed-on: https://dart-review.googlesource.com/c/82461
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-01 16:11:23 +00:00
d6d312cca6
Add 'Wrap with StreamBuilder' quick assist.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I109bfe41344943b6d1b456cb178f1db4d5e92858
Reviewed-on: https://dart-review.googlesource.com/c/82341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-11-01 15:33:04 +00:00
8852d36315
Add --lsp flag to analysis server and add basic Initialize handler
...
Change-Id: Iaf6c2a7cd56dea27233c4be1df2da900653e1822
Reviewed-on: https://dart-review.googlesource.com/c/81275
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-10-31 20:00:51 +00:00
c843a4fdbd
Replace resourceProvider.convertPath() with just convertPath() where possible.
...
R=brianwilkerson@google.com
Change-Id: I80c349b0ed9092e455ca2d811f5828765361ffc7
Reviewed-on: https://dart-review.googlesource.com/c/82163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-30 23:55:26 +00:00
87ee9c2c7d
Don't generate library directive in CREATE_FILE.
...
R=brianwilkerson@google.com
Change-Id: Ia2853119ac119cfeff4c72f2528ebe6bc51745e4
Reviewed-on: https://dart-review.googlesource.com/c/82161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-30 22:01:44 +00:00
298d22f4ab
remove async parse method
...
Change-Id: I7a2e633b43283221790fb88a12065fed3dcdabb7
Reviewed-on: https://dart-review.googlesource.com/c/82120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-30 19:26:00 +00:00
dfb4427c03
Fix an error in analysis_server MockSdk.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ie80843de5d01ef16b1e92cccde84c542d051d273
Reviewed-on: https://dart-review.googlesource.com/c/82082
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-30 18:39:04 +00:00
ff25f47862
Remove processRequiredPlugins() and configurePreviewDart2().
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ic93ba6b148e7bb6e7fc001dc2aceb4feaf8fa29f
Reviewed-on: https://dart-review.googlesource.com/c/82081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-30 17:40:29 +00:00
1c6774ba34
Create AnalysisDriver in AbstractContextTest using the new API.
...
Change-Id: Ia3b8e0fa297026f8d002cf4b29f179e686876d8c
Reviewed-on: https://dart-review.googlesource.com/c/81980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-30 15:57:59 +00:00
03df087c60
Merge commit '1215d9163af58229132e4776a89ea87d5302c9e3' into analyzer
...
Conflicts:
pkg/analysis_server/lib/src/edit/edit_dartfix.dart
pkg/analysis_server/lib/src/services/correction/assist_internal.dart
2018-10-29 08:48:27 -07:00
57c185c89d
Remove remaining uses of Element.context from server
...
Change-Id: Ibc383064951e181fa8e951714904526c2ea42f5f
Reviewed-on: https://dart-review.googlesource.com/c/81749
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-10-29 14:56:24 +00:00
0fe448a996
Revise the analysis server edit.dartfix protocol
...
This updates the edit.dartfix protocol to separate location from the text
describing the changes so that the dartfix client can choose
what location information to display and how it should be displayed.
Change-Id: Ic56a4cb187538571d60136d6de9265d879fccb53
Reviewed-on: https://dart-review.googlesource.com/c/81780
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-10-29 01:50:27 +00:00
faa8bcd78c
Finish spliting out the non-lint fix tests
...
Change-Id: I793a9663ad3a9adfec4248844a5881f857fb4c4c
Reviewed-on: https://dart-review.googlesource.com/c/81748
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-10-28 18:11:37 +00:00
e223bd3628
Replace most of direct uses of MemoryResourceProvider with ResourceProviderMixin.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I87114418b63ef68665b9c3e487980a72db00ec6a
Reviewed-on: https://dart-review.googlesource.com/c/81744
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-10-27 17:50:10 +00:00
5b1641432d
Create CorrectionUtils only for ResolveResult.
...
So, it is always self-consistent, never ask AnalysisContext for the
unit file content.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I93e71f7f8fa577b8e123c91252f3038a50cdccef
Reviewed-on: https://dart-review.googlesource.com/c/81580
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-26 14:04:12 +00:00
Brian Wilkerson