Commit Graph

2889 Commits

Author SHA1 Message Date
brianwilkerson@google.com 9dad99f92c Disable a test until I can fix it
Review URL: https://codereview.chromium.org//655353005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41428 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 21:47:58 +00:00
danrubel@google.com d22c027e0a add suggestions in format parameter list
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//693573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41420 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 15:13:57 +00:00
danrubel@google.com b7aeaab3f7 make deprecated elements have low suggestion relevance
BUG=dartbug.com/19615
R=scheglov@google.com

Review URL: https://codereview.chromium.org//690793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41414 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 01:08:32 +00:00
scheglov@google.com 97bc20ffc5 Suggest names for PropertyAccess.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//646103006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41409 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 22:07:27 +00:00
scheglov@google.com bdd50e1230 Issue 21458. Support for 'Add type' Quick Assist in for-each loops.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21458

Review URL: https://codereview.chromium.org//680133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41403 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 20:59:29 +00:00
danrubel@google.com 67071bd861 Refactor CompletionSuggestionKind
- Remove many CompletionSuggestionKinds that duplicate ElementKind
- Add two new CompletionSuggestionKinds: INVOCATION and IDENTIFIER
- regenerate Analysis Server Dart and Java API and docs
- rework Dart and Java tests
- remove/rename unused Dart and Java classes and methods
- remove unnecessary reference to SDK

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//684183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41396 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 16:09:56 +00:00
danrubel@google.com e4b90d4cee add class type alias suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//689433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41388 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 02:48:31 +00:00
danrubel@google.com 98d9096892 add functional type alias suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//682953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41376 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 22:03:16 +00:00
scheglov@google.com e446dd5227 Issue 21333. Constant names are not special anymore in the style guide (Dart version).
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21333

Review URL: https://codereview.chromium.org//684863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41373 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:42:46 +00:00
paulberry@google.com 02dada3dec Avoid analysis server crash when reanalyze invoked during analysis.
BUG=dartbug.com/21448
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//678413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41372 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:15:59 +00:00
paulberry@google.com 7014ca0b76 Rename package_root.dart test to package_root_test.dart
So that the test will be run on the buildbots.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//685843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41370 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:10:17 +00:00
danrubel@google.com 2e5f738ad9 add type static constants suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//686843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41369 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:03:36 +00:00
danrubel@google.com 1a68218c36 suggest imported functions in argument list
BUG=dartbug.com/21446
R=scheglov@google.com

Review URL: https://codereview.chromium.org//683133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41368 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 19:03:37 +00:00
paulberry@google.com ba8b83eac8 Fix analysis server asynchrony test.
The test had two bugs: it neglected to account for the
"server.connected" notification, and it failed to allow the test to
run to completion before reporting success.  The second bug sometimes
covered up the first, making it look like the test succeeded.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//683573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41345 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 23:19:17 +00:00
danrubel@google.com b41bc7b57e add property accessor suggestions
BUG=dartbug.com/21380
R=paulberry@google.com

Review URL: https://codereview.chromium.org//666863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41344 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 22:56:26 +00:00
scheglov@google.com a625b09fa8 Index EnumDeclaration definitions as top-level elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//685493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41341 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 21:56:55 +00:00
scheglov@google.com 0463d78cfb Semantic highlight async/await/sync/yield.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//668943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41335 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 20:18:11 +00:00
scheglov@google.com 2ca4bbbd60 Support for enums semantic highlighting.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//679103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41330 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 18:39:40 +00:00
scheglov@google.com a151361e2d Add ENUM and ENUM_CONSTANT to the specification.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//677333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41307 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-26 22:01:29 +00:00
scheglov@google.com 8ae0268b39 Issue 21419. Don't create navigation region for elements without location.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21419

Review URL: https://codereview.chromium.org//661193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41302 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-25 21:12:12 +00:00
paulberry@google.com 0251bcdcf6 Add package root support to analysis server.
Not yet hooked up in Dart editor.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//679763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41292 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 20:29:24 +00:00
scheglov@google.com 2d38012c14 'Create Local Varaible' quick fix.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//677583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41280 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 14:55:38 +00:00
paulberry@google.com dc7d2249eb Fix merge resolution in r41267.
Due to an incorrectly resolved merge, r41267 inadvertently
re-introduced the notificationProcessor parameter to Server.start(),
which was removed in r41246.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//637283008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41272 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 20:43:16 +00:00
paulberry@google.com 61c3ef6bd6 By default, don't use observatory during integration tests.
TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//676623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41268 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 19:31:48 +00:00
brianwilkerson@google.com 5d9ff4c570 Add support for attaching observatory to the server.
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//651243005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41267 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 19:18:08 +00:00
scheglov@google.com 51fb6c5a9e Issue 21377. Specify that navigation regions are sorted and implement it.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21377

Review URL: https://codereview.chromium.org//649853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41261 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 17:18:13 +00:00
scheglov@google.com 227c5524d8 Issue 21375. Fix for FunctionTypeAliasElement-based FunctionType source.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21375

Review URL: https://codereview.chromium.org//672013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41254 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 04:24:59 +00:00
paulberry@google.com 751e087262 Add package root setting to analysis server API.
The command does not have any effect yet.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//672003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41253 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 00:11:36 +00:00
paulberry@google.com 7611c5415a Add an integration test to verify that server I/O is asynchronous.
Currently disabled, since server I/O is currently synchronous.

BUG=dartbug.com/21252
R=danrubel@google.com

Review URL: https://codereview.chromium.org//668953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41246 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-22 15:48:06 +00:00
scheglov@google.com 8f337c37d1 Issue 21373. Fix for removing line info in case of exception (causes NPE in outline computer).
I will update analysis_server/pubspec.yaml before commit.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21373

Review URL: https://codereview.chromium.org//652903006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41235 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 20:34:31 +00:00
scheglov@google.com 3074fefa82 Issue 21372. "Convert into block body" and "Convert into expression body" for factory constructors.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21372

Review URL: https://codereview.chromium.org//664403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41230 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 15:32:55 +00:00
scheglov@google.com 89978808cd Issue 21238. Fix for NPE in occurrences computer when FieldFormalParameterElement references unresolved field.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21238

Review URL: https://codereview.chromium.org//668763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41215 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 21:26:09 +00:00
danrubel@google.com 4f2faa385c fix failing test
BUG=

Review URL: https://codereview.chromium.org//669483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41183 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-18 16:48:28 +00:00
danrubel@google.com 946d40e8ac improve element parameter string returned by local suggestion computer
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//664523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41178 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:37:37 +00:00
danrubel@google.com 8da06376d3 update keyword suggestion priorities
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//666473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41177 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:35:41 +00:00
danrubel@google.com efd813f9b3 update protocol server getter test
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//662013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41176 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:34:27 +00:00
danrubel@google.com 582b276b6f filter invalid method invocation suggestions
and filter _ from local suggestions

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//651443006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41159 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 21:25:46 +00:00
danrubel@google.com 8d47e699d9 filter void methods when suggesting expression
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//658053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41153 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 16:46:45 +00:00
danrubel@google.com 7c9dc9695b add imported inherited member suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//643153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41137 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 01:55:30 +00:00
danrubel@google.com 8465275f69 include locally inherited members in suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//657593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41114 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-15 03:25:20 +00:00
danrubel@google.com be3cc6897b exclude operators from "." suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//655733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41100 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-14 15:35:46 +00:00
danrubel@google.com 1766795d5f improve method invocation and string interpolation suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//651953006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41091 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-14 06:07:58 +00:00
scheglov@google.com 11f7d4027e Fix for missing LineInfo to SDK entries.
I will update analyzer reference in pubspec before commit.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//647553006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41064 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-12 21:27:08 +00:00
danrubel@google.com db9357f408 (TBR) fix the build
BUG=

Review URL: https://codereview.chromium.org//643923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41040 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 13:12:52 +00:00
danrubel@google.com eb0e7f5c0c suppress suggestions in string literals
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//643803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41039 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 12:52:20 +00:00
danrubel@google.com dd6b2426df add if statement condition suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//642973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41034 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 02:52:30 +00:00
scheglov@google.com 8f4ce65d53 Ignore case when sort members.
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//646753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41033 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 23:48:19 +00:00
danrubel@google.com b45a2aa7ff include imported elements in interpolation suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//646773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41032 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 22:49:23 +00:00
danrubel@google.com e0b32d20f2 improve suggestions in for statement
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//645733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41031 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 22:17:53 +00:00
paulberry@google.com 31310ceea4 Test that analysis server and analysis engine enums properly match.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//647563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41029 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 21:53:05 +00:00