dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

2889 Commits

Author SHA1 Message Date
danrubel e196c15ca1 performance measurement mods: 
* apply source path translation in the order in which they are defined
* print elapse times in milliseconds
* log overlay content if server exception occurs
* simplify diagnostic port initialization
* add option to start server using new task model

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1249793007 .
 2015-07-22 12:17:04 -04:00
pq f013d3868c Actual URI support for package URI resolution. 
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1245263002 .
 2015-07-21 15:53:56 -07:00
Paul Berry e30ebf79e2 Remove redundant context lookups from option-processing code. 
This required exposing the ContextInfo class for testing, but I don't think that's a problem because ContextInfo objects can't be reached through the public API of ContextManager.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1251663002 .
 2015-07-21 15:06:11 -07:00
Brian Wilkerson 3d28c45311 Fix watch manager tests 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1248723002 .
 2015-07-21 10:45:15 -07:00
Paul Berry 128dec84b5 Separate the API's used by ContextManager. 
Previously, ContextManager had two API's: one used by analysis server
to tell the ContextManager what to do, and one used by the
ContextManager to make callbacks to analysis server in response to its
requests.  The first API was implemented in the class
AbstractContextManager, which derived from ContextManager, and the
second API was implemented in ServerContextManager, which derived from
AbstractContextManager.

In addition to causing confusion, this made it impossible to provide
an alternate implementation of ContextManager as a plug-in, since the
plug in would have had to re-implement the second API, and that would
have required accessing private implementation details of the
ContextManager.

This CL separates the API's: the first API is specified in
ContextManager and implemented in ContextManagerImpl, and the second
API is specified in ContextManagerCallbacks and implemented in
ServerContextManagerCallbacks.

In the long run I hope to eliminate the ContextManagerCallbacks class
entirely, by having the ContextManager tell its client what to do
using return values rather than callbacks.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1243893002 .
 2015-07-21 10:40:57 -07:00
Konstantin Shcheglov d5d0017e21 Tweak for navigation for URIs. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1246833002 .
 2015-07-20 15:07:00 -07:00
Konstantin Shcheglov 55cb93b422 Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1241193002 .
 2015-07-20 10:37:46 -07:00
Brian Wilkerson bc265ebe28 Implement support for watching directories containing implicitly analyzed files 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1244613004 .
 2015-07-20 09:04:37 -07:00
pq 05d4206929 Server .packages support. 
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1242023008 .
 2015-07-18 22:18:30 -07:00
John McCutchan 0300e2e9fd Make analysis_server use ignore patterns from .analysis_options file 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1234293003 .
 2015-07-17 14:10:37 -07:00
John McCutchan cb5335dc4a Add a PathFilter to each context in analysis_server 
BUG=
R=brianwilkerson@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org//1238173003 .
 2015-07-17 12:42:57 -07:00
Brian Wilkerson 23f96f1916 Renames to move closer to the new API 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1240433008 .
 2015-07-17 12:20:02 -07:00
Paul Berry 2f6ebaa774 Only send "analysis.analyzedFiles" notification when the set of files changes. 
R=jwren@google.com

Review URL: https://codereview.chromium.org//1233003002 .
 2015-07-13 15:52:28 -07:00
Brian Wilkerson 2ffa8de794 Add notification of analyzed files 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1232393005 .
 2015-07-13 15:07:33 -07:00
Brian Wilkerson 41f74711e0 (TBR) Fix a broken test 
Review URL: https://codereview.chromium.org//1232913002 .
 2015-07-13 12:45:56 -07:00
Brian Wilkerson 0c6872acef Hook for overriding the ContextManager and some code clean-up (with more to follow) 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1223413003 .
 2015-07-13 10:20:13 -07:00
Brian Wilkerson 10b7db100f Revert "Update Analysis Server highlight API and implementation." 
This reverts commit 739847402b.

Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1236433003 .
 2015-07-13 09:49:55 -07:00
Konstantin Shcheglov 3f99fc1744 Add test for 'getNavigation'. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1229833004 .
 2015-07-13 07:46:07 -07:00
Konstantin Shcheglov d7c2f4550b Issue 23640. Implement 'analysis.getNavigation' request. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640

Review URL: https://codereview.chromium.org//1232683003 .
 2015-07-10 15:31:25 -07:00
Konstantin Shcheglov 739847402b Update Analysis Server highlight API and implementation. 
I think this is a good enough compromise between the existing and IDEA granilarity.

Eclipse plugin CL will follow.

(IN)VALID_STRING_ESCAPE are not implemented yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1227143003 .
 2015-07-09 11:19:44 -07:00
John McCutchan 6ecf960c5e Move SdkExtUriResolver from analysis_server to analyzer so it can be used in analyzer_cli 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1214823003 .
 2015-07-08 10:28:19 -07:00
Brian Wilkerson 27f600058e Improve propagation in binary expressions 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1226823003 .
 2015-07-08 08:02:05 -07:00
John McCutchan 598336788d Add support for .sdkext file to analysis server 
- Add SdkExtUriResolver which is populated with any dependency provided sdk extensions.
- Adjust AnalysisServer._createSourceFactory to setup a SdkExtUriResolver whenever the roots are set.
- Add unit tests for SdkExtUriResolver.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1213613017 .
 2015-07-08 07:51:41 -07:00
Konstantin Shcheglov b62e8fbca9 New Quick Assist - 'Convert to field formal parameter'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1216463004 .
 2015-07-07 14:57:43 -07:00
Konstantin Shcheglov aa4efb8c6e One more fix for making removing overlays incremental changes. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1214853028 .
 2015-07-07 14:51:44 -07:00
Brian Wilkerson bdfc16a146 Hook for overriding the creation of a package resolver 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1214243005.
 2015-07-06 13:06:33 -07:00
Konstantin Shcheglov 7e194d8fb5 Change navigation regions generation for constructors. 
In IDEA we use navigation regions for resolution.
And so far all navigation regions are for separate identifiers.
This CL splits single regions like "new A.named()" into separate "A" and "named" regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1218183007.
 2015-07-06 11:27:19 -07:00
Konstantin Shcheglov 0bb5179b84 Quick Assist for converting field formal parameters into normal parameters and initializers. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1217593006.
 2015-07-06 11:19:30 -07:00
danrubel 1647483615 move performance measurement to benchmark/integration 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1219023006.
 2015-07-01 12:09:43 -04:00
danrubel d2bd01852f performance measurement improvements 
* report mean, 90th, 99th, and std-dev
* increase analysis wait time to 60 seconds
* add option for analysis server localhost diagnostics
* report running old vs new task model
* do not check if src dir exists so that scripts are more portable
* set clientRequestTime for each request
* ensure dir paths have trailing separators

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1221893003.
 2015-06-30 18:08:10 -04:00
Paul Berry db6c95502a Work around naming conflict in analyzer's Resource class. 
Commit f8ce36df55 introduced an SDK
class called "Resource", causing warnings to appear in any files that
reference the analyzer class with the same name.  (Fortunately there
was no regression in functionality since the spec requires the name
conflict to be resolved in favor of the definition that is outside the
SDK).

As a short term workaround to avoid the warnings, we are explicitly
importing 'dart:core' and hiding the new Resource class.  In a future
CL, we plan to rework analyzer's Resource class in order to make some
changes necessary for ".packages" file support; when that happens we
will probably rename the class to avoid the name conflict.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1215753003.
 2015-06-26 13:00:44 -07:00
Dan Rubel a87e9386eb performance measurement: generate report 
* track/correlate responses
* separate req/resp from notifications
* track/report completion notifications
* add min/max/unexpected to report

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1202843010.
 2015-06-25 10:03:24 -04:00
Paul Berry 921a5229fa Make use of test_flushAstStructures in analysis server. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1203783004.
 2015-06-24 14:04:26 -07:00
pq bee94603a0 Warning fix. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1209633002.
 2015-06-24 09:35:30 -07:00
Dan Rubel aa91c7c436 performance measurement: mapFrom/To --> map 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1202803002.
 2015-06-23 19:35:15 -04:00
Dan Rubel 1ce49788ea performance measurement: add explicit temp source directory argument 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1201263002.
 2015-06-23 15:53:01 -04:00
Konstantin Shcheglov 19a87506bc Fix for the server test. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1196213005.
 2015-06-22 10:03:06 -07:00
danrubel d907a4265e (TBR) improve integration test failure message 
BUG=

Review URL: https://codereview.chromium.org//1194393002.
 2015-06-22 07:04:28 -04:00
danrubel f3a1297576 fix tests 
BUG=

Review URL: https://codereview.chromium.org//1191363003.
 2015-06-20 18:20:46 -04:00
Dan Rubel eb95064511 recompute package map when input file changes 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1180843011.
 2015-06-20 17:18:54 -04:00
Dan Rubel 8b9578ef26 add for() keyword suggestion 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1179283007.
 2015-06-20 15:01:20 -04:00
danrubel 108f6c114b analysis server performance measurement - work in progress 
still need to debug some failing requests,
verify responses match expected responses,
track notifications to determine what was analyzed,
add docs, and ...

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1182933005.
 2015-06-17 11:35:47 -04:00
Dan Rubel e7321ee4a0 (TBR) fix server tests 
BUG=

Review URL: https://codereview.chromium.org//1192603002
 2015-06-17 11:04:56 -04:00
danrubel ce311218e9 suggest keywords in if expression 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1147213008.
 2015-06-12 09:50:10 +02:00
danrubel 9c9108d51a no keyword suggestions in library identifier or property accessor 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1151493004.
 2015-06-12 09:39:40 +02:00
Konstantin Shcheglov b8067b5fb9 Compute RESOLVED_UNIT for all units in all of the libraries of the closure before verifying. 
This fixes many co19 tests, so I guess it might solve the problems with constants you mentioned.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1183533002.
 2015-06-11 10:47:26 -07:00
Brian Wilkerson add5a6910d Remove many explicit references to AnalysisContextImpl and enable testing of the new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1150863007
 2015-06-06 08:30:38 -07:00
Konstantin Shcheglov 811877df42 Invalidate resolution of analysisOptions/sourceFactory changes. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1167483004
 2015-06-05 14:09:12 -07:00
Dan Rubel 4224b9c049 fix ENUM_CONSTANT suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1157283004
 2015-06-04 18:01:06 -04:00
Dan Rubel ab5371e9b7 analysis server performance measurement driver first cut 
* reads instrumentation file (log file support later)
* tracks initial analysis elapse time
* skeleton structure for adding more operations and tracking

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1163713005
 2015-06-04 10:11:59 -04:00