dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

2889 Commits

Author SHA1 Message Date
Konstantin Shcheglov 5f71b2e7cd Check that AnalysisContext is not null. 
I guess this happens when a "resolved" CompilationUnit is not actially resolved.
I don't know why we get such units, but I saw this situation twice in IDEA.
So, probably we need to fix at least throwing NPE here.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1418513002 .
 2015-10-19 13:27:50 -07:00
Konstantin Shcheglov 5e9ea82aa4 Issue 24612. Skip excluded folder during contexts creation. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24612

Review URL: https://codereview.chromium.org/1411393003 .
 2015-10-19 13:17:11 -07:00
Konstantin Shcheglov ea947094ae Fix for suggesting methods as a *name* of a local variable declaration. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1417603002 .
 2015-10-19 12:29:22 -07:00
Konstantin Shcheglov efc1d4b224 Ignore contexts in folders named 'packages' or starting with dot. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24614

Review URL: https://codereview.chromium.org/1415713002 .
 2015-10-19 11:59:11 -07:00
danrubel 948b21a8cf (TBR) update test to run with new task model 
Review URL: https://codereview.chromium.org/1413963002 .
 2015-10-19 12:04:51 -04:00
Konstantin Shcheglov 3b198ed6ae Disable completion of formal parameter names as *types*. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1414653002 .
 2015-10-18 13:28:12 -07:00
Konstantin Shcheglov af4fbdd952 Index library/part file references from import/export/part containing files. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1407863004 .
 2015-10-18 10:24:53 -07:00
Konstantin Shcheglov c0d68a5437 DAS specification changes - spelling and ElementKind.FILE addition. 
ElementKind.FILE will be used in search.findElementReferences

1. In the 'element' field of responce when a URI is at the given offset.

2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1409333002 .
 2015-10-17 10:03:03 -07:00
Brian Wilkerson adb8ebd0e6 Remove obsolete flag to enable package support 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1411833002 .
 2015-10-16 13:43:00 -07:00
Konstantin Shcheglov ce6614f2dc Disable completion in comment text. 
It drives me nuts when I try to type some text and IDEA replaces my words with some random identifies.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1410893002 .
 2015-10-16 10:38:47 -07:00
Konstantin Shcheglov 18a29ba8a8 Tweak for make test passing with useTaskModel = true. 
A real fix after final actual switching.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1410493005 .
 2015-10-16 08:29:35 -07:00
pq 91e5facc0f Registry memory leak fixes. 
Fixes #24549.

A few notes:
  * does away with registry in favor of context-associated configurations
  * pulls in linter rev that does the context association
  * bumps analyzer version before publishing (needed to update analyzer_cli)

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1406043002 .
 2015-10-15 14:24:20 -07:00
Konstantin Shcheglov a30bcd7b97 Issue 24599. Fix for requesting navigation for directives. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24599

Review URL: https://codereview.chromium.org/1405033002 .
 2015-10-15 10:54:06 -07:00
pq 0cd0c886a1 Use new task model in completion tests. 
Review URL: https://codereview.chromium.org/1401403006 .
 2015-10-14 22:29:53 -07:00
pq 9989687a25 Revert server test extension manager "fix". 
BUG=

Review URL: https://codereview.chromium.org/1398043006 .
 2015-10-14 22:10:47 -07:00
pq 3188a74994 More extension manager unification. 
Addresses bot test failures: http://build.chromium.org/p/client.dart/builders/pkg-mac-be/builds/1531/steps/pkg%20%20tests%20failures/logs/stdio.

(See https://codereview.chromium.org/1398033004/ for background.)

Marking TBR in quest for build greenness.

Review URL: https://codereview.chromium.org/1401403005 .
 2015-10-14 21:22:26 -07:00
pq cae05d6bd4 Context invalidation on option changes (Implements #24574). 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1399893004 .
 2015-10-14 20:42:50 -07:00
pq 6bce9b2373 One extension manager (to bind them all). 
TL;DR Moves all plugin registration to AE's extension manager.

The rub is that plugin registration wasn't happening right which cropped up in integration testing.  Included is a test that verifies that options are getting properly threaded through to the linter.  (This test failed when we had two Extension Managers.)

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398033004 .
 2015-10-13 16:37:42 -07:00
pq e5f3bb163b AS strong-mode .analysis_options awareness. 
R=brianwilkerson@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/1403983002 .
 2015-10-13 13:22:49 -07:00
Konstantin Shcheglov 9913f33522 Stop looking for overrides once the pivot element reached. 
See also https://github.com/dart-lang/sdk/issues/21804 for the original motivation.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1396053003 .
 2015-10-13 08:24:16 -07:00
Konstantin Shcheglov 586a1f359a Fix for renaming (an invalid) ClassElement invocation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1385403007 .
 2015-10-12 12:21:12 -07:00
Konstantin Shcheglov 2bbb40d0e2 Warn about conflict before renamed class member and enclosing class name. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1398213004 .
 2015-10-12 12:10:12 -07:00
Konstantin Shcheglov 307438d582 Return 'null' rename refactoring in case of a null element. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1397403002 .
 2015-10-12 10:44:31 -07:00
Konstantin Shcheglov 78da03cd97 Extract protocol_dart.dart APIs. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1398333002 .
 2015-10-12 06:58:34 -07:00
Paul Berry 9767634564 Fix manual editing of integration_test_methods.dart. 
In commit 9ad256cf18,
integration_test_methods.dart (an auto-generated file) was edited
manually.  The only necessary changes were to imports--the other changes
were the result of sorting declarations and running the formatter.

This CL replicates the necessary changes in the code generator and
re-runs it, un-doing the other changes.  This should fix the test
"pkg/analysis_server/tool/spec/check_all_test".

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1397353002 .
 2015-10-12 06:49:02 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
pq 695256d586 Linter hookup into AS. 
Note the TODO to fix the extension manager interaction hijinx.  Really we should ensure that we are only using the one in engine.  At the moment, it's easy to get this wrong (as the initialization heroics herein testify).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1392683003 .
 2015-10-09 13:40:07 -07:00
Brian Wilkerson a296d57a5c Comment out debugging code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1398503004 .
 2015-10-09 08:09:53 -07:00
Brian Wilkerson 190cc1ae82 Remove an unused test 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1396983004 .
 2015-10-09 08:09:04 -07:00
Brian Wilkerson 8f4c63c92b Restructure the public API for server 
R=danrubel@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1392253002 .
 2015-10-09 07:57:00 -07:00
Konstantin Shcheglov abfa9bf46a Move getCamelWords() to the strings.dart file. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1394933003 .
 2015-10-08 21:31:27 -07:00
pq d6d2e6f3c6 Options plugin initialization fix. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1400473004 .
 2015-10-08 14:52:42 -07:00
Konstantin Shcheglov 63d8b70fce Add 'Add != null' quick fix. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24518

Review URL: https://codereview.chromium.org/1393953002 .
 2015-10-07 10:18:23 -07:00
Paul Berry b76da2d61e Turn on the new task model by default in analysis server. 
The previous option for enabling the task
model ("--enable-new-task-model") is replaced with an option for
disabling it ("--disable-new-task-model").

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1390843002 .
 2015-10-06 13:49:52 -07:00
Dan Rubel d329551747 (TBR) fix completion test - see #24511 
Review URL: https://codereview.chromium.org/1384823005 .
 2015-10-06 14:40:27 -04:00
danrubel d14a963546 only send final completion notification 
This shaves 1 ms off the average completion notification response time

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1389473002 .
 2015-10-06 14:21:29 -04:00
pq 90e975b656 Suppress scanner errors for non-existent URIs. 
Fixes #23754.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1378503003 .
 2015-10-06 10:25:50 -07:00
Konstantin Shcheglov b107dec41a Spec change: include covering expressions into Extract Local protocol. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1388783003 .
 2015-10-05 14:44:32 -07:00
Brian Wilkerson 7bbd8c66a5 Move completion APIs to private location 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383313002 .
 2015-10-05 11:57:35 -07:00
pq 8697392367 AnalysisError hasFix attr (Implements #23874). 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1385523002 .
 2015-10-05 09:46:17 -07:00
Konstantin Shcheglov 147581cf34 Remove the 'name' and 'length' getters from IndexableObject. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1378843003 .
 2015-10-05 07:27:50 -07:00
Konstantin Shcheglov 0e7f4b5717 Fix hover documentation for parameters. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1384583007 .
 2015-10-05 07:04:20 -07:00
Konstantin Shcheglov e6053aa135 Rollback https://codereview.chromium.org/1380223003 
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1390463002 .
 2015-10-04 17:07:10 -07:00
Konstantin Shcheglov 1af7b154af Issue 23694. Include 'docSummary' and 'docComplete' into CompletionSuggestion. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23694

Review URL: https://codereview.chromium.org/1380223003 .
 2015-10-04 16:16:45 -07:00
Konstantin Shcheglov 0b01edac17 More tests for 'Organize Directives'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1380893003 .
 2015-10-02 13:11:34 -07:00
Konstantin Shcheglov c06ad0db30 Issue 24420. Don't allow renaming in pub packages. 
There are no ideal solution for this.
But all our users want it somehow.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24420

Review URL: https://codereview.chromium.org/1380253003 .
 2015-10-02 13:09:55 -07:00
Brian Wilkerson 66a122a9db Stop defensively copying AST structures before resolution 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383043002 .
 2015-10-02 12:38:18 -07:00
danrubel 04e21a2a7c Completions with exact prefix should be prioritized - fixes #23099 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1369033002 .
 2015-10-02 15:12:23 -04:00
danrubel 6e441f62e8 only suggest rethrow inside catch block - fixes #24214 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1360123003 .
 2015-10-02 15:10:14 -04:00
Konstantin Shcheglov 62fd9ac787 Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24487

Review URL: https://codereview.chromium.org/1378713004 .
 2015-10-02 10:44:58 -07:00