dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

2889 Commits

Author SHA1 Message Date
pq d1bfe8bccb Calculate default args for local reference completions. 
First step towards wiring up default args for completions.

See: https://github.com/flutter/flutter-intellij/issues/553

Next up: similar enhancements for type_members, imported_refs, etc.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2722253002 .
 2017-03-01 11:45:01 -08:00
Steve Messick b3ed30b822 Add assists to move Flutter widgets up and down one level. 
Fixes:
https://github.com/flutter/flutter-intellij/issues/461

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2724473002 .
 2017-02-27 15:03:51 -10:00
pq 8e6817f1da New Completion defaultArgumentListString protocol. 
BUG=
R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/553.
Review-Url: https://codereview.chromium.org/2719083003 .
 2017-02-27 11:36:30 -08:00
Brian Wilkerson c416aabed1 Deprecate the analysis.updateOptions request 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2719853004 .
 2017-02-27 10:37:02 -08:00
Devon Carew 25dfd0fa80 Deprecate execution.setSubscriptions. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2713513007 .
 2017-02-24 11:01:00 -08:00
Devon Carew 0f7fc43df5 Remove the --no-error-notification flag. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2713053002 .
 2017-02-23 16:55:46 -08:00
Devon Carew fbb613a3fe Update the statuses of various analysis server integration tests. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2717523003 .
 2017-02-23 14:23:55 -08:00
Brian Wilkerson 37c585e842 Make it safe to initialize the notificationManager in server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2708353008 .
 2017-02-23 12:31:15 -08:00
Devon Carew 9dd2a6d452 Revert "Tweaks to the analyzer_cli." 
This reverts commit a7ac08d0e7.

BUG=

Review-Url: https://codereview.chromium.org/2709163005 .
 2017-02-23 09:39:25 -08:00
Devon Carew a7ac08d0e7 Tweaks to the analyzer_cli. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2709013005 .
 2017-02-23 09:02:49 -08:00
pq 174a50bb89 Missing @required arg quick fix improvements. 
* fixes missing `HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS` case
* improve quick fix message (add name)
* update codegen

BUG=
R=scheglov@google.com

Fixes: #28830
Review-Url: https://codereview.chromium.org/2707223003 .
 2017-02-22 06:43:43 -08:00
Devon Carew 7f83d9d173 Add a diagnostic.getServerPort analysis server request. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2703033002 .
 2017-02-19 15:19:40 -08:00
Steve Messick 2da528aeac Add assist to reparent a list of Flutter widgets 
Apparently I forgot to sort the test file, so there's a bit of code rearrangement there.

I added the optimization to the filter from the previous CL here, too.

R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2701023002 .
 2017-02-17 13:11:30 -08:00
Devon Carew 9793406f08 Switch to using expectAsync0() to address some deprecation warnings. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2701473009 .
 2017-02-17 09:39:23 -08:00
Konstantin Shcheglov 6d79ee2602 Issue 27214. Get any AnalysisDriver for getNavigation(). 
This means that we will able to analyze any file, even outside all
analysis roots.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27214

Review-Url: https://codereview.chromium.org/2689213016 .
 2017-02-17 09:13:59 -08:00
Steve Messick 7945b65449 Add assist to reparent Flutter widget 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2701563003 .
 2017-02-17 08:35:47 -08:00
Devon Carew af49bf9ff9 Fix the execution.setSubscriptions test. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2705633002 .
 2017-02-17 08:23:23 -08:00
Devon Carew 7c7c895345 Add an integration test for execution.setSubscriptions. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2703723002 .
 2017-02-17 07:41:03 -08:00
Devon Carew 5e0710617d Tests for analysis.navigation. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2696323004 .
 2017-02-16 14:35:20 -08:00
Devon Carew 3a345935bf Add tests for edit.sortMembers and edit.organizeDirectives. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2700563003 .
 2017-02-15 16:15:10 -08:00
pq e2808dff23 Add fix for missing @required params. 
Groundwork for: https://github.com/flutter/flutter-intellij/issues/553

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2692983003 .
 2017-02-15 09:02:44 -08:00
Brian Wilkerson 2e64ccbf84 Add the notification manager 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2692373002 .
 2017-02-15 08:04:31 -08:00
Devon Carew b1bc83b6d2 Add an integration test for edit.format. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2695253002 .
 2017-02-15 07:23:21 -08:00
Devon Carew 90bd4652aa Add an integration test for diagnostics.getDiagnostics. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2697833005 .
 2017-02-14 14:36:38 -08:00
Brian Wilkerson a56cee72e5 Extract object creation methods for use by a future test class 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2696853002 .
 2017-02-14 12:37:09 -08:00
Brian Wilkerson 2a2b342a70 Fix a test that was incorrectly fixed 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2690133002 .
 2017-02-13 08:40:35 -08:00
Dmitry Olshansky 13bbbd0d79 Remove duplicate key in kindMap 
Got error on a buildbot because of that.
Strangely it was passing for some time
and then failed.

R=erikcorry@google.com

Review-Url: https://codereview.chromium.org/2697553002 .
 2017-02-13 13:26:26 +01:00
Konstantin Shcheglov 65559748eb AnalysisDriver.getUnitElement() should return a structure with a key. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2691433008 .
 2017-02-12 14:57:57 -08:00
Devon Carew 4667e59e85 Add integration tests for the execution domain. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2691763002 .
 2017-02-12 11:23:33 -08:00
Brian Wilkerson 92550811ac Add conversion routines from the plugin API to the server API 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2689903002 .
 2017-02-12 08:19:13 -08:00
Devon Carew 0fee414672 Suppress a few analysis warnings in the analyzer codebase. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2688253002 .
 2017-02-10 13:16:28 -08:00
Konstantin Shcheglov 663b7f665e Analysis.getHover should return the field's documentation for field formal parameters. 
Also return the parameter's element with completion suggestion.

R=brianwilkerson@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/385

Review-Url: https://codereview.chromium.org/2681233005 .
 2017-02-10 08:49:40 -08:00
Konstantin Shcheglov 46eff8e389 Implement also 'execution.mapUri' for file to URI. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2681393004 .
 2017-02-10 08:48:02 -08:00
Devon Carew bc9cadac04 Add tests to vaildate the analysis server's integration test coverage. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2685883005 .
 2017-02-09 14:26:26 -08:00
Konstantin Shcheglov 0a09ff53c3 Include the field documentation for named field formal parameter completion suggestions. 
R=brianwilkerson@google.com, devoncarew@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/385

Review-Url: https://codereview.chromium.org/2683233002 .
 2017-02-09 13:24:25 -08:00
Konstantin Shcheglov af539081cd When addSource() in tests, call both addFile() and changeFile(). 
This fixes the two failing tests.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2681733007 .
 2017-02-09 08:50:57 -08:00
Brian Wilkerson a191011c03 Update ChangeBuilder to the new driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2688513003 .
 2017-02-09 07:51:42 -08:00
Brian Wilkerson 5d0fa7dc21 Finish file rename operation (TBR) 
Review-Url: https://codereview.chromium.org/2685783005 .
 2017-02-08 13:56:56 -08:00
Konstantin Shcheglov 2f741af001 Fix for 'execution.mapUri' with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2682983002 .
 2017-02-08 08:40:59 -08:00
Brian Wilkerson a69189972c Add failing test 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2683793003 .
 2017-02-08 08:13:37 -08:00
Brian Wilkerson 407985cbce Support merging with priority information 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2683673003 .
 2017-02-07 10:05:20 -08:00
Brian Wilkerson ccdf574d49 Add support for merging results from plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2678673002 .
 2017-02-07 08:06:59 -08:00
Brian Wilkerson 06b3f47434 [Gardening] Remove an invalid (and flaky) test 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2681493002 .
 2017-02-06 10:09:03 -08:00
danrubel 1680c434f2 suggest method references in named expressions 
Fix https://github.com/dart-lang/sdk/issues/25386

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2679503002 .
 2017-02-06 12:59:05 -05:00
danrubel 02adcc9614 suggest catch and finally keywords 
After a try block that does not have a "catch" block,
suggest the "catch" keyword and nothing else.
After a "catch" block, suggest the "finally" keyword.

Fix https://github.com/dart-lang/sdk/issues/27560

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662973007 .
 2017-02-06 12:57:57 -05:00
Brian Wilkerson 9c9de9e48c Add code to locate a plugin within a package 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2671773007 .
 2017-02-05 11:58:05 -08:00
Brian Wilkerson 2f81decdd7 Add a test that server does not send errors when errors have been disabled 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2674863004 .
 2017-02-04 09:46:55 -08:00
Brian Wilkerson a8f65e61a9 Initial support for managing partial results from plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2676593006 .
 2017-02-04 09:46:08 -08:00
Konstantin Shcheglov 7d2447d795 Replace computeNode() with AstProvider in search. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2672973002 .
 2017-02-03 10:40:44 -08:00
Konstantin Shcheglov f600f5f9de Stop using Element.computeNode() in refactorings and fixes. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2669353002 .
 2017-02-02 17:24:31 -08:00