dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

79 Commits

Author SHA1 Message Date
Konstantin Shcheglov 8c891ec25e Include type parameters into suggested code completions. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/120659839
Change-Id: I51ec6142b97b079c4db55ef1f2081354ee16dda5
Reviewed-on: https://dart-review.googlesource.com/c/91858
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-04 05:37:37 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server 
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-11 15:38:56 +00:00
Konstantin Shcheglov b71948faee Consolidate MockSdk(s) into one, living in analyzer/lib/src/test_utilities. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I70946b8e6f790608ad52c8f27cd6f506673f7b0d
Reviewed-on: https://dart-review.googlesource.com/c/82710
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-02 21:52:44 +00:00
Konstantin Shcheglov 1f52372bfa Remove CFE integration from analyzer, analysis_server, and analyzer_cli. 
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.

Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-29 13:46:45 +00:00
Janice Collins f40ff153a9 Enable --use-fasta-parser with the analyzer by default. 
Based on Devon's change at:

https://dart-review.googlesource.com/c/sdk/+/67090

Change-Id: I80b7943826e248bf37d9bbbb769330d24b0dd6ae
Reviewed-on: https://dart-review.googlesource.com/70160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2018-08-28 19:29:17 +00:00
Brian Wilkerson 83aa463fac Enable a few more server tests under CFE 
Change-Id: I5f0bd750d3da7658f836e45f02da5ef157e752ff
Reviewed-on: https://dart-review.googlesource.com/68960
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-08-08 17:13:28 +00:00
Brian Wilkerson 92ae73b6d8 Fork the remaining subclasses of AbstractAnalysisClass 
Change-Id: Ie3e561a6b6f4d29510f543d616998c795fd85191
Reviewed-on: https://dart-review.googlesource.com/68120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-02 17:43:58 +00:00
Konstantin Shcheglov 757ef3979c Revert "Revert "Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled.""" 
This reverts commit 4089111540.

R=brianwilkerson@google.com

Change-Id: I66297466f8baafe6e070acbcb1776b41f3d9fedc
Reviewed-on: https://dart-review.googlesource.com/55506
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-16 19:43:22 +00:00
Konstantin Shcheglov 8515d74332 Add ImportElement.namespace and use it in completion. 
R=brianwilkerson@google.com

Change-Id: I58cadf0e3239ad4ae8584d79485f4d9ebda10eba
Reviewed-on: https://dart-review.googlesource.com/54064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-07 21:23:48 +00:00
Konstantin Shcheglov 4089111540 Revert "Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled."" 
This reverts commit e5ed23fdb5.

R=brianwilkerson@google.com

Change-Id: Ida33856e965f06f773025f3c625d6ab3bace80a8
Reviewed-on: https://dart-review.googlesource.com/49280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-03 22:29:09 +00:00
Konstantin Shcheglov e5ed23fdb5 Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled." 
This reverts commit a1e4d8e0bf.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Don't do implicit new/const code generation with --preview-dart-2 enabled.
> 
> R=​brianwilkerson@google.com, devoncarew@google.com
> 
> Change-Id: I8a96a5ccceae57c3ed5c1f2e0fd4897a7e99df03
> Reviewed-on: https://dart-review.googlesource.com/48883
> Reviewed-by: Devon Carew <devoncarew@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=devoncarew@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: Ie3acf0794ed7b8264682e29aaa4bc1516fce6981
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/48900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-30 19:24:46 +00:00
Konstantin Shcheglov a1e4d8e0bf Don't do implicit new/const code generation with --preview-dart-2 enabled. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I8a96a5ccceae57c3ed5c1f2e0fd4897a7e99df03
Reviewed-on: https://dart-review.googlesource.com/48883
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-30 18:07:25 +00:00
Brian Wilkerson ea94e65b43 Make preview-dart-2 imply strong-mode 
Change-Id: Ifa230f9e64a538e222557ea471dc728ad3dd01d7
Reviewed-on: https://dart-review.googlesource.com/46300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-03-13 17:15:39 +00:00
Konstantin Shcheglov 0ce1a92d98 Suggest constructors for implicit creation in previewDart2. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I43270f47fb43402d1a9e0f7d9814494ffd83bb5e
Reviewed-on: https://dart-review.googlesource.com/43080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-22 18:03:12 +00:00
Dan Rubel a459bc8b7c Add fasta parser constructor reference recovery 
This CL fixes/improves 2 keyword contributor situations
when analyzer is using the fasta parser:

* Recover gracefully given a constructor reference
  followed by a dot without an identifier

* Include a colon whenever suggesting the 'default' keyword

Change-Id: I393ef16130c7d1288ac4c18e6fdc17dbbe1421ea
Reviewed-on: https://dart-review.googlesource.com/32145
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-01-03 20:42:24 +00:00
Devon Carew f383c17bc2 Redo our benchmarks; add a benchmark/benchmarks.dart tool. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2986293002 .
 2017-08-02 08:07:38 -07:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt. 
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
 2017-07-13 16:28:18 -07:00
Brian Wilkerson 7d26ff6d4f Remove some more library directives 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884233004 .
 2017-05-17 08:02:08 -07:00
danrubel 02adcc9614 suggest catch and finally keywords 
After a try block that does not have a "catch" block,
suggest the "catch" keyword and nothing else.
After a "catch" block, suggest the "finally" keyword.

Fix https://github.com/dart-lang/sdk/issues/27560

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662973007 .
 2017-02-06 12:57:57 -05:00
Konstantin Shcheglov 75fff1fdb6 Implement completion in WithDirective. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2665053004 .
 2017-01-31 15:06:54 -08:00
Konstantin Shcheglov 0160332713 Issue 28027. Move Null to the bottom in the Analyzer. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/28027

Review-Url: https://codereview.chromium.org/2638183002 .
 2017-01-18 11:15:11 -08:00
Brian Wilkerson e7577172d1 Add preliminary parser support for generic function types 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2628973003 .
 2017-01-12 07:00:24 -08:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'. 
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
 2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'. 
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
 2016-10-06 08:47:15 -07:00
Dan Rubel 023295912a improve import URI completions at EOF 
fixes https://github.com/dart-lang/sdk/issues/27020

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2342473002 .
 2016-09-14 11:22:25 -04:00
Konstantin Shcheglov 09b851c97f Don't perform final fields and top-level variables type propagation. 
A similar feature is now implemented in strong mode, and users who
need it, should switch to strong mode.

When we are ready to drop propagated types altogethoer, we could
deprecate or remove UnlinkedVariable.propagatedTypeSlot in IDL.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26794

Review URL: https://codereview.chromium.org/2288223003 .
 2016-08-29 15:18:12 -07:00
Brian Wilkerson 6ccbef94fc Convert analysis server over to use ContextBuilder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2286923002 .
 2016-08-29 08:11:53 -07:00
Jaime Wren 8a9403e15c Code completion improvement in the DAS- only suggest completions on the RHS of an as-expression that are proper subtypes of the type of the LHS of the as-expression. 
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1872073002 .
 2016-04-11 09:59:30 -07:00
Jaime Wren 04a14d0020 Code completion build fix following https://codereview.chromium.org/1860213002, fix test_all.dart to include completion_test.dart 
R=danrubel@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org/1866753004 .
 2016-04-06 14:26:18 -07:00
Brian Wilkerson 8c22a5f807 Format code in analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1838933003 .
 2016-03-29 08:27:14 -07:00
Dan Rubel 824a012d8f do not suggest static methods from superclass - fixes #24258 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1509723004 .
 2015-12-09 14:37:03 -05:00
danrubel 372cb6be58 fix combinator contributor 
gracefully degrade given partially element information
better reporting of exceptions during testing

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1506623002 .
 2015-12-06 15:34:19 -05:00
danrubel 53f777162e (TBR) get completion tests passing 
Review URL: https://codereview.chromium.org/1505443002 .
 2015-12-04 20:55:09 -05:00
danrubel 85334bed8a (TBR) update completion test to expect pass now that this is fixed #23001 
Review URL: https://codereview.chromium.org/1465143003 .
 2015-11-23 11:15:22 -05:00
Dan Rubel d329551747 (TBR) fix completion test - see #24511 
Review URL: https://codereview.chromium.org/1384823005 .
 2015-10-06 14:40:27 -04:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
 2015-09-09 08:19:18 -07:00
Dan Rubel bd95b13b90 improve keyword suggestions - fixes #24016 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1303233008 .
 2015-08-26 17:34:57 -04:00
danrubel 3bbf03ba7b suggest "in" in for statement 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1285573003 .
 2015-08-10 10:43:27 -04:00
danrubel f79d02ddd0 remove complex keyword suggestions - fixes #23978 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1280313002 .
 2015-08-10 10:09:18 -04:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
danrubel f3a1297576 fix tests 
BUG=

Review URL: https://codereview.chromium.org//1191363003.
 2015-06-20 18:20:46 -04:00
danrubel 0e39092fd0 add enum suggestions 
and update LocalDeclarationVisitor to visit enum declarations

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1157113004
 2015-06-01 12:10:46 -04:00
danrubel@google.com b05fb8ba98 suggest only superclass elements for "super." 
BUG=dartbug.com/23208
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1127643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45535 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-05 19:09:51 +00:00
danrubel@google.com 6368514b6d improve import suggestion 
BUG=dartbug.com/19941
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1113063005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45497 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 18:02:23 +00:00
danrubel@google.com 85e1841e35 suggest keywords for switch statement and expressions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1118113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45463 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-01 01:35:35 +00:00
danrubel@google.com 6237c8909f add dart: and package: import uri suggestions 
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1100393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45398 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 12:51:52 +00:00
danrubel@google.com 25c6bbaa14 suggest types in var declaration when partial type name supplied 
BUG=dartbug.com/23225
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1097973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45287 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-20 15:29:28 +00:00
danrubel@google.com 9f492ecbe6 fix keyword completion in class body 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1057403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44894 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 22:12:56 +00:00
danrubel@google.com 4e903a637e do not suggest completions for empty dot target 
BUG=dartbug.com/23095
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1056163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44887 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 20:38:50 +00:00
danrubel@google.com 8bf9e95e6e replace request.node with request.target 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1054363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44886 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 20:34:20 +00:00