ca5ac975fe
Fix for crash in _DartNavigationComputerVisitor._addUriDirectiveRegion when part has invalid URI.
...
R=brianwilkerson@google.com
Change-Id: Ia6c62c344cd195449168e5971165a3d37ffc7f67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-03-19 14:53:17 +00:00
47e988b781
Clean up the remaining copyright notices in analysis_server
...
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-11 15:38:56 +00:00
1f52372bfa
Remove CFE integration from analyzer, analysis_server, and analyzer_cli.
...
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.
Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-29 13:46:45 +00:00
cb4f5b3a3a
Resynthesize nameOffset for properties/parameters.
...
R=brianwilkerson@google.com
Change-Id: Ib3213529836df20f580a5d8805006ba13b82bf20
Reviewed-on: https://dart-review.googlesource.com/68761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-07 21:54:55 +00:00
c30af508a4
Store import prefix offset into metadata and resynthesize.
...
Change-Id: I7ef72c562323f132865c7cb6b3b068623c831043
Reviewed-on: https://dart-review.googlesource.com/68741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-07 18:17:46 +00:00
b83072cf7d
Clean up use of callFailingTest
...
Change-Id: I00ed46b48c03038825d62e1d9bac355bbe2354a7
Reviewed-on: https://dart-review.googlesource.com/68380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-08-03 17:29:37 +00:00
f169ebf418
Fork several server tests to run under CFE
...
Change-Id: I9ca4184dc5458304f3f1597681fc1c936972d8bd
Reviewed-on: https://dart-review.googlesource.com/67880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-08-01 20:18:40 +00:00
40e3f9addc
Convert paths for mock SDK libraries to fix tests on Windows
...
The other lines on this method are calling `provider.convertPath` around their paths but these ones do not, which is causing almost all analysis server tests to fail on Windows (for me - I can't explain them not
failing builds). This causes the hard-coded paths like `/lib/core/core.dart` to be fixed up to `C:\lib\core\core.dart` which is what the server is looking for (because at the other end the paths *have* been fixed up).
See #32226 .
Closes #32230
https://github.com/dart-lang/sdk/pull/32230
GitOrigin-RevId: 1adeee23f8ac8efc8acf61caf5f769e4ec44c030
Change-Id: Id9bf195967db0912c6f4b67bd79d504e627b8aab
Reviewed-on: https://dart-review.googlesource.com/42300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-20 18:55:38 +00:00
1d8a5d77c1
Convert more tests to use ResourceProviderMixin
...
Change-Id: Ia4cce51e33c79c82a989bfda9b8303dfaa72e103
Reviewed-on: https://dart-review.googlesource.com/31880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-01-02 00:47:34 +00:00
00d5012906
Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.
...
...instead of mixing formatting with actual changes in many CLs.
R=ahe@google.com , paulberry@google.com , sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2975253002 .
2017-07-13 16:28:18 -07:00
9ddb832e10
Generate constants in server as we do in plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2960073002 .
2017-06-28 08:21:33 -07:00
67ff4d4c47
Convert more tests to the new driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2933943002 .
2017-06-12 14:10:14 -07:00
fb982f5476
Make server use the common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
27f9e5e4ce
Reverse the sense of the flag to make it easier to find test that need to be converted
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884593003 .
2017-05-15 08:40:40 -07:00
e55812a3f2
Unify the server and plugin versions of the generators
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
61d5c85b48
Allow navigation from var when there is an inferred type (issue 29091)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2769813005 .
2017-03-23 10:34:09 -07:00
05a86a7495
Remove 'initializeTestEnvironment' from 'analysis_server'.
...
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/
R=paulberry@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2402483002 .
2016-10-06 10:26:17 -07:00
de4d8b3a78
Switch analysis_server to use 'package:test'.
...
I'm changing DEPS in the corresponding analyzer CL.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2394683006 .
2016-10-06 08:47:15 -07:00
2f0f398c73
Fix lints: unnecessary_brace_in_string_interp
...
Also fixes two cases of empty_constructor_bodies.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1521883002 .
2015-12-13 13:05:00 -08:00
2be2c5e55c
Fix for navigation reginos for instance creations with import prefixes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1498163003 .
2015-12-04 14:24:09 -08:00
c302b65584
Use async/await in all analysis domain tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1478513002 .
2015-11-24 14:18:37 -08:00
670db50707
Generate separate navigation regions for 'super' and optional 'name'.
...
Also support for navigation regions for RedirectingConstructorInvocation.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1465303003 .
2015-11-23 14:27:03 -08:00
289bd0a056
[Atom] Issue 424. Fix for 'getNavigation' and index expressions.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/424
Review URL: https://codereview.chromium.org/1402353009 .
2015-10-25 11:29:54 -07:00
a30bcd7b97
Issue 24599. Fix for requesting navigation for directives.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24599
Review URL: https://codereview.chromium.org/1405033002 .
2015-10-15 10:54:06 -07:00
9ad256cf18
Move the wire protocol support into the public API
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
62fd9ac787
Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24487
Review URL: https://codereview.chromium.org/1378713004 .
2015-10-02 10:44:58 -07:00
83f94a2114
Add navigation region for 'library' directives.
...
Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1373593002 .
2015-09-25 12:35:51 -07:00
5fd8b38737
Tweak navigation for 'part of' directives.
...
This makes it consistent with import/export/part directives, where only URIs are navigation sources.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1365663002 .
2015-09-23 10:14:49 -07:00
908708d655
More fixes for failures on the Windows bot
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1266923004 .
2015-08-05 08:13:28 -07:00
f909ed8adf
Add test for references in comments
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1256333008 .
2015-07-30 11:20:00 -07:00
d5d0017e21
Tweak for navigation for URIs.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1246833002 .
2015-07-20 15:07:00 -07:00
d7c2f4550b
Issue 23640. Implement 'analysis.getNavigation' request.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640
Review URL: https://codereview.chromium.org//1232683003 .
2015-07-10 15:31:25 -07:00
7e194d8fb5
Change navigation regions generation for constructors.
...
In IDEA we use navigation regions for resolution.
And so far all navigation regions are for separate identifiers.
This CL splits single regions like "new A.named()" into separate "A" and "named" regions.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1218183007 .
2015-07-06 11:27:19 -07:00
9efb25fa50
Use package:test_reflective_loader instead of reflective_tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1101003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:54:29 +00:00
cd58e290c4
Reformat
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//969113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 22:43:12 +00:00
865b217511
Issue 22381. Fix for navigating to constructor from redirecting factory constructor.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22381
Review URL: https://codereview.chromium.org//921833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43731 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 17:58:29 +00:00
b280b861f9
Issue 22143. Navigation from super initializers.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22143
Review URL: https://codereview.chromium.org//882823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43209 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 21:50:00 +00:00
a38a503d86
Replace @ReflectiveTestCase() with @reflectiveTest.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//849863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
20d82e5135
Compressed/optimized navigation notification.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//766323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42049 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-01 22:21:28 +00:00
affc91a881
Issue 21552. Fixes for navigation, hover and rename in instance creation expressions.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21552
Review URL: https://codereview.chromium.org//717513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41651 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 03:01:21 +00:00
1c6ddd0751
Issue 21498. Fix for navigation from instance creation with type arguments.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21498
Review URL: https://codereview.chromium.org//694383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41468 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-03 20:45:34 +00:00
8ae0268b39
Issue 21419. Don't create navigation region for elements without location.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21419
Review URL: https://codereview.chromium.org//661193004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41302 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-25 21:12:12 +00:00
51fb6c5a9e
Issue 21377. Specify that navigation regions are sorted and implement it.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21377
Review URL: https://codereview.chromium.org//649853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41261 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 17:18:13 +00:00
11f7d4027e
Fix for missing LineInfo to SDK entries.
...
I will update analyzer reference in pubspec before commit.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//647553006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41064 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-12 21:27:08 +00:00
5e9ba07a3e
Fix for NPE when FieldFormalParameterElement references an unresolved field.
...
I found it (in a hard way - server died) during dogfooding.
R=paulberry@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//616953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40820 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-30 17:59:16 +00:00
c7a131a7d5
Churn only: move analysis notification tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//563373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40396 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:16:29 +00:00
Konstantin Shcheglov