Commit Graph

124 Commits

Author SHA1 Message Date
Paul Berry 51046368c5 Move NNBD migration tool to a fresh package.
This gives us more flexibility for how we want to publish and deploy
the tool.  We now have the option, for example, of making a command
line app that invokes the tool and does not depend on analysis_server.

Note that some testing infrastructure had to be duplicated.  I plan to
consolidate this infrastructure in follow-up CLs.

Change-Id: I046506bc2bb5c3e467e15885f198ee0632351ee9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105463
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-06-09 17:45:35 +00:00
Konstantin Shcheglov d6f9d2da6f Add pkg/analysis_server/pubspec.yaml so that it is identified as a pub package.
We use this file to get regular and dev dependencies, and suggest
available declarations in correct parts of packages, e.g. lib/ can
only access declarations from regular dependencies, but test/ can
access both regular and dev dependencies.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Id92cae07485b21af750318a58056a11262cf1799
Reviewed-on: https://dart-review.googlesource.com/c/91762
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-01-31 22:26:59 +00:00
Paul Berry b5e294595a Remove analysis_server's pubspec.
The analysis server package isn't published on pub, so it doesn't need
a pubspec.  Removing it should help avoid the package getting
published by accident.

Change-Id: I8cf56a16fe0ad99836f192125cdfe84d757e93fb
Reviewed-on: https://dart-review.googlesource.com/c/86400
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-06 18:28:18 +00:00
Kevin Moore 4d5c5ecdbf Update synced version of pkg:test
Also updated the package references in a number of pubspecs to
more closely align with the package versions that are in the SDK

Change-Id: I061951587befa4211ac7455cf1179911eb07efc0
Reviewed-on: https://dart-review.googlesource.com/c/79920
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2018-10-16 16:12:38 +00:00
Devon Carew 89cfa2edd7 Update package:test_reflective_loader.
Change-Id: If23bb61ef03efe62282ba2e163d3a830d6e0bfad
Reviewed-on: https://dart-review.googlesource.com/67700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-01 00:20:45 +00:00
Kevin Moore 902b6db749 Mark analyzer_cli, analysis_server pubspecs as not-to-publish
Closes https://github.com/dart-lang/sdk/pull/33828

Change-Id: I3693f4b0315c4cb8f8d757dc53a9b49c0a38b0e0
Reviewed-on: https://dart-review.googlesource.com/64721
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2018-07-12 17:04:43 +00:00
Devon Carew 3a5fcf5a87 Upgrade the dep on package:isolate.
Change-Id: Ie9c52c6dd24672e2469787220505bd85a50ed5ff
Reviewed-on: https://dart-review.googlesource.com/51241
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-04-16 17:08:48 +00:00
Paul Berry b4e176b570 Adjust timeout for reanalyze_concurrent_test.dart.
Change-Id: Ic1cb4aa69cfeec14109b9503db140f85fcfab06b
Reviewed-on: https://dart-review.googlesource.com/48445
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-03-26 20:20:52 +00:00
Brian Wilkerson db6e377e6d Make analysis_server_client Dart 2 safe
Change-Id: Iab06cb5b779599a1a107fa6fdf832345950fa84c
Reviewed-on: https://dart-review.googlesource.com/48322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-25 15:20:36 +00:00
Zachary Anderson 74fc14dad7 Update args deps in analysis_server pubspec
Change-Id: I10090757fa7b6d776b9ab6948cdaee60ef4129c4
Reviewed-on: https://dart-review.googlesource.com/35802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-01-18 22:16:44 +00:00
P.Y. Laligand 56feddec9e Bump the version of intl used by analysis-server.
This aligns it with the version in third_party.

Change-Id: I0246f321e6540b6061e0b9f6c804c669f3a9596f
Bug:
Reviewed-on: https://dart-review.googlesource.com/14020
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2017-10-16 20:09:57 +00:00
Konstantin Shcheglov b1589bf879 Replace typed_mock with mockito in analysis_server.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2991773002 .
2017-07-26 08:14:25 -07:00
Devon Carew d4abd49df7 Add analytics to analyzer-cli and analysis server.
BUG=
R=brianwilkerson@google.com, scheglov@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2963323002 .
2017-07-05 23:29:46 -07:00
Devon Carew 02f7f5fee7 Updates to the diagnostics page.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2918533002 .
2017-05-31 07:15:20 -07:00
Mike Fairhurst e9edd2e568 Fix pubspecs for new analyzer plugin arch dependencies
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2877863002 .
2017-05-11 14:37:46 -07:00
Lasse R.H. Nielsen 83298690b0 Fix static typing problem in analysis_server tests.
After changing argument of `Future` constructor to be `()->FutureOr<T>`,
the `()->Future<dynamic>` argument didn't work.
Problem compounded by return type of `Stream<T>.firstWhere` being `dynamic`.

R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2794503002 .
2017-03-31 14:12:32 +02:00
Devon Carew 9793406f08 Switch to using expectAsync0() to address some deprecation warnings.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2701473009 .
2017-02-17 09:39:23 -08:00
Kevin Moore c1a0b12159 use latest pkg/isolate
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662723002 .
2017-01-28 13:53:17 -08:00
Konstantin Shcheglov 2e2b92932a Move analysis_server dependency on analyzer back to 0.28.0
The dart_style change to widen version was landed, but now pub says
that there is the same problem with 'linter'. I don't know why
analysis_server is tested as a package at all.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2391263007 .
2016-10-06 20:38:35 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'.
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
2016-10-06 08:47:15 -07:00
Konstantin Shcheglov ac81124b8c Revert "Use dependency_overrides / analyzer in analysis_server."
This reverts commit 72f5463631.

Yes, we do have bot failures :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2298423002 .
2016-08-31 15:01:10 -07:00
Konstantin Shcheglov 72f5463631 Use dependency_overrides / analyzer in analysis_server.
RFC

We always do this locally, but until analysis_server is published,
we could just keep this change in repo.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2298973002 .
2016-08-31 14:44:09 -07:00
Konstantin Shcheglov cc6beaf56d Pull in test_reflective_loader 0.0.4 and switch analyzer to it.
There are following changes:

1. DEPS to pull in test_reflective_loader 0.0.4
2. Rename runReflectiveTests() to defineReflectiveTests().
3. Remove analyzer's pkg/analyzer/test/reflective_tests.dart
4. Replace reflective_tests.dart imports with package:test_reflective_loader/test_reflective_loader.dart imports.
5. Sort/format and organize imports in the files with imports changes.
6. Fix for a couple of bugs in analysis_server exposed by the new loader.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2298913003 .
2016-08-31 13:46:39 -07:00
Kevin Moore 17a2ddfd42 Update dependency on pkg/package_compiler
For analysis_server, analyzer, analyzer_cli, compiler packages

Progress on https://github.com/dart-lang/sdk/issues/26711

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2172683002 .
2016-07-27 08:42:05 -07:00
Konstantin Shcheglov ed887c09d1 Validate cache consistency asynchronously. Compute modification times of physical files in a separate isolate.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2132073003 .
2016-07-08 15:01:05 -07:00
pq 40b03d2261 Server and CLI pubspec updates [TBR].
Should address version constraint issues introduced by dep on new plugin API.

BUG=

Review URL: https://codereview.chromium.org/1972193002 .
2016-05-12 06:21:46 -07:00
Brian Wilkerson d87f9c09de Update to use the latest version of the plugin package
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1965083002 .
2016-05-11 09:54:29 -07:00
pq 2529c09fe5 Update analyzer dep lower-bound.
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1520823004 .
2015-12-11 14:56:08 -08:00
pq 63f24be16c Update server/cli linter pubspec deps.
* bumps lower-bound to grab a `0.27.0`-compatible linter.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1520973002 .
2015-12-11 10:51:50 -08:00
pq 3b296c3d1c Analyzer version bump.
Version bump pre publishing of `_embedder.yaml` support.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1466663003 .
2015-11-20 16:40:36 -08:00
Konstantin Shcheglov dee2660831 Publish new analyzer version and use in analysis_server.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1408943008 .
2015-11-04 10:33:38 -08:00
Paul Berry ac5578d03d Refactor analysis server code generation to re-use logic from analyzer.
The code generation infrastructure logic is now shared.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1431683002 .
2015-11-02 16:18:03 -08:00
pq af7017e585 Option support for enableSuperMixins (and more).
* Adds language configuration support to `.analysis_options`:

  analyzer:
    language:
      enableSuperMixins: true

  (with validation).

* Extracts context configuration out of `server` context_manager and into `analyzer` where it can be re-used by `analyzer_cli`.
* Some general cleanup of option validation (with more to come!)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1423333002 .
2015-10-29 14:11:26 -07:00
pq b32e2ce0db Analyzer dep bump.
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1415693004 .
2015-10-26 10:02:57 -07:00
pq bb431bbec4 Publish optionValidator extentsion API.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1420903003 .
2015-10-25 20:49:49 -07:00
Konstantin Shcheglov d5830fb6a3 Publish analyzer and use it to fix completion in 'for (Type item in^)'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1417613002 .
2015-10-19 12:36:16 -07:00
Konstantin Shcheglov 381d3ac549 Require SDK >= 1.12 to start using '?.' syntax.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1412773002 .
2015-10-16 12:45:03 -07:00
pq 6bce9b2373 One extension manager (to bind them all).
TL;DR Moves all plugin registration to AE's extension manager.

The rub is that plugin registration wasn't happening right which cropped up in integration testing.  Included is a test that verifies that options are getting properly threaded through to the linter.  (This test failed when we had two Extension Managers.)

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398033004 .
2015-10-13 16:37:42 -07:00
pq 695256d586 Linter hookup into AS.
Note the TODO to fix the extension manager interaction hijinx.  Really we should ensure that we are only using the one in engine.  At the moment, it's easy to get this wrong (as the initialization heroics herein testify).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1392683003 .
2015-10-09 13:40:07 -07:00
Konstantin Shcheglov 6ae14b5774 Update required 'analyzer' version.
The library 'dart:profile' was removed.
Without this new version I cannot start DAS from sources in IDEA.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1403493003 .
2015-10-09 08:25:31 -07:00
Konstantin Shcheglov 184fe4ae58 Publish new version of analyzer and use it in AS.
R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//1377233002 .
2015-09-30 11:15:23 -07:00
danrubel 773c3cf9d1 improve import uri completions - fixes #24000
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1325583002 .
2015-08-31 15:21:34 -04:00
danrubel 65652fd5af (TBR) update analyzer version - related to #23947 (part 2)
Review URL: https://codereview.chromium.org//1288653003 .
2015-08-15 14:57:09 -04:00
Paul Berry e21c112313 Upgrade analysis_server's dependency on analyzer to 0.26.1-alpha.0.
This is necessary in order to take advantage of the new signature for
the PathFilter constructor introduced in
d977370e3f.

Also the dependency on dart_style had to be widened since older
versions of dart_style force analyzer version <0.26.0.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1278853002 .
2015-08-06 11:33:13 -07:00
pq f013d3868c Actual URI support for package URI resolution.
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1245263002 .
2015-07-21 15:53:56 -07:00
John McCutchan cb5335dc4a Add a PathFilter to each context in analysis_server
BUG=
R=brianwilkerson@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org//1238173003 .
2015-07-17 12:42:57 -07:00
Paul Berry 921a5229fa Make use of test_flushAstStructures in analysis server.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1203783004.
2015-06-24 14:04:26 -07:00
Dan Rubel 61460a0a10 pull in new watcher package
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1194653002.
2015-06-20 14:12:12 -04:00
Konstantin Shcheglov f1d4ef9164 Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'.
This fixes the corresponding 'Extract Method' issue.

R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23409

Review URL: https://codereview.chromium.org//1161343002
2015-06-01 12:40:30 -07:00
Paul Berry 2362001bdb Bump analysis server's reference to analyzer to 0.25.1-alpha.0.
This should fix errors being experienced by DartPad.

R=brianwilkerson@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org//1149203004
2015-05-27 06:37:50 -07:00