dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

3080 Commits

Author SHA1 Message Date
Konstantin Shcheglov 739847402b Update Analysis Server highlight API and implementation. 
I think this is a good enough compromise between the existing and IDEA granilarity.

Eclipse plugin CL will follow.

(IN)VALID_STRING_ESCAPE are not implemented yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1227143003 .
 2015-07-09 11:19:44 -07:00
John McCutchan 6ecf960c5e Move SdkExtUriResolver from analysis_server to analyzer so it can be used in analyzer_cli 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1214823003 .
 2015-07-08 10:28:19 -07:00
John McCutchan 8e4a96d016 Fix SdkExtUriResolver.restoreAbsolute 
BUG=

Review URL: https://codereview.chromium.org//1228643003 .
 2015-07-08 10:00:18 -07:00
John McCutchan 598336788d Add support for .sdkext file to analysis server 
- Add SdkExtUriResolver which is populated with any dependency provided sdk extensions.
- Adjust AnalysisServer._createSourceFactory to setup a SdkExtUriResolver whenever the roots are set.
- Add unit tests for SdkExtUriResolver.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1213613017 .
 2015-07-08 07:51:41 -07:00
Konstantin Shcheglov b62e8fbca9 New Quick Assist - 'Convert to field formal parameter'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1216463004 .
 2015-07-07 14:57:43 -07:00
Brian Wilkerson bdfc16a146 Hook for overriding the creation of a package resolver 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1214243005.
 2015-07-06 13:06:33 -07:00
Konstantin Shcheglov 7e194d8fb5 Change navigation regions generation for constructors. 
In IDEA we use navigation regions for resolution.
And so far all navigation regions are for separate identifiers.
This CL splits single regions like "new A.named()" into separate "A" and "named" regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1218183007.
 2015-07-06 11:27:19 -07:00
Konstantin Shcheglov 0bb5179b84 Quick Assist for converting field formal parameters into normal parameters and initializers. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1217593006.
 2015-07-06 11:19:30 -07:00
Brian Wilkerson dd9fa13157 More GetHandler clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1221703003.
 2015-06-30 07:49:32 -07:00
Brian Wilkerson 0513859704 Re-implement the status page for the new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1211243003.
 2015-06-29 12:20:19 -07:00
danrubel 13b601ffc5 watch for file system changes after context created 
Closes #23671

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1188663006.
 2015-06-29 12:24:29 -04:00
Paul Berry db6c95502a Work around naming conflict in analyzer's Resource class. 
Commit f8ce36df55 introduced an SDK
class called "Resource", causing warnings to appear in any files that
reference the analyzer class with the same name.  (Fortunately there
was no regression in functionality since the spec requires the name
conflict to be resolved in favor of the definition that is outside the
SDK).

As a short term workaround to avoid the warnings, we are explicitly
importing 'dart:core' and hiding the new Resource class.  In a future
CL, we plan to rework analyzer's Resource class in order to make some
changes necessary for ".packages" file support; when that happens we
will probably rename the class to avoid the name conflict.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1215753003.
 2015-06-26 13:00:44 -07:00
Paul Berry 921a5229fa Make use of test_flushAstStructures in analysis server. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1203783004.
 2015-06-24 14:04:26 -07:00
danrubel e43c98a13c rework packageMapInfo dependency watching to avoid race condition 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1199083002.
 2015-06-22 19:19:09 -04:00
danrubel 679de372f4 gracefully degrade if package map input file cannot be watched 
BUG=

Review URL: https://codereview.chromium.org//1198423002.
 2015-06-22 17:07:12 -04:00
Konstantin Shcheglov e9c3b2d7b1 Move cache consistency validation into Analysis Server. 
This speeds up the add/analyze/remove/analyze cycle from 1600 ms to
1300 ms, i.e. on about 20%.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1195183002.
 2015-06-22 08:19:44 -07:00
Dan Rubel eb95064511 recompute package map when input file changes 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1180843011.
 2015-06-20 17:18:54 -04:00
Dan Rubel 8b9578ef26 add for() keyword suggestion 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1179283007.
 2015-06-20 15:01:20 -04:00
danrubel db11964b83 refactor Reqest.fromJson for use by performance measurement tests 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1181363004.
 2015-06-15 12:27:41 -04:00
danrubel ce311218e9 suggest keywords in if expression 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1147213008.
 2015-06-12 09:50:10 +02:00
danrubel 9c9108d51a no keyword suggestions in library identifier or property accessor 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1151493004.
 2015-06-12 09:39:40 +02:00
Konstantin Shcheglov f3c28ef449 Don't create navigation regions for not existing sources. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1180883003.
 2015-06-11 13:21:12 -07:00
Konstantin Shcheglov 1c1497ff98 Another tweak for displaying performance. 
1. It is still interesting to see performance tags, even with the next task model.

2. Factor out "WorkOrder.moveNext" as a separate performance tag, something like "intertask" for new tasks.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1161183004
 2015-06-05 09:19:28 -07:00
Dan Rubel 4224b9c049 fix ENUM_CONSTANT suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1157283004
 2015-06-04 18:01:06 -04:00
Konstantin Shcheglov 3cbd3e2e96 Tweak ADD_PART_OF quick fix to support both new/old task models. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1165943003
 2015-06-04 14:28:35 -07:00
Konstantin Shcheglov c1e2448928 Tweak for the new task statistics formatting. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1147043006
 2015-06-04 11:49:37 -07:00
Dan Rubel 4b082cb871 cleanup local reference contributor 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1163973004
 2015-06-04 14:18:03 -04:00
Brian Wilkerson aec339a767 Expose timing data for the new task model in the status pages 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1169573003
 2015-06-04 10:47:04 -07:00
Konstantin Shcheglov a567814119 Replace 'Element.node' with 'Element.computeNode()'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1164823003
 2015-06-02 13:25:04 -07:00
Konstantin Shcheglov 8e439849b3 Issue 23573. Catch exception during indexing. 
R=paulberry@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23573

Review URL: https://codereview.chromium.org//1168473003
 2015-06-02 09:40:20 -07:00
Brian Wilkerson 40e925078f Bug fixes for the new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1144393006
 2015-06-01 16:42:36 -07:00
Konstantin Shcheglov aad76fdcbf Issue 23568. Fix for NPE in index when unresolved field formal parameter. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23568

Review URL: https://codereview.chromium.org//1162853004
 2015-06-01 15:08:33 -07:00
Konstantin Shcheglov b9cdbace93 Issue 23545. Replace unaccessible type parameters with 'dynamic'. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23545

Review URL: https://codereview.chromium.org//1147213005
 2015-06-01 14:50:39 -07:00
Konstantin Shcheglov a3a40c9ef6 Issue 11200. Quick Fix for adding required/positional parameters. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=11200

Review URL: https://codereview.chromium.org//1159273004
 2015-06-01 14:48:50 -07:00
Konstantin Shcheglov be9cd1c165 Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Quick Fix. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23551

Review URL: https://codereview.chromium.org//1151183003
 2015-06-01 14:19:33 -07:00
Paul Berry 717da6731b Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef. 
Modifier.TYPEDEF was redundant with Modifier.MIXIN_APPLICATION and
ClassElement.isTypedef was redundant with
ClassElement.isMixinApplication.

Since Modifier.TYPEDEF was private to analyzer, it has been
eliminated.  Since ClassElement.isTypedef is part of the public API to
analyzer, it is retained, but with a "@deprecated" annotation.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1158193008
 2015-06-01 14:17:40 -07:00
Konstantin Shcheglov c1c0354014 Issue 23239. Fix for 'Create Class' Quick Fix i case of prefixed names. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23239

Review URL: https://codereview.chromium.org//1161333002
 2015-06-01 12:26:39 -07:00
Konstantin Shcheglov f118546d06 Issue 23332. Don't compute overrides for static members. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23332

Review URL: https://codereview.chromium.org//1151573011
 2015-06-01 10:42:22 -07:00
Konstantin Shcheglov 5b44136f2a Issue 23389. Report error in the renamed element be invisible after rename. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23389

Review URL: https://codereview.chromium.org//1153253004
 2015-06-01 10:40:59 -07:00
Brian Wilkerson 213f0322f9 Fix missed version number 
R=jwren@google.com

Review URL: https://codereview.chromium.org//1165763002
 2015-06-01 09:50:57 -07:00
Brian Wilkerson 07dd6b7649 Add lineLength parameter to edit.format request (issue 23519) 
R=jwren@google.com

Review URL: https://codereview.chromium.org//1154303005
 2015-06-01 09:39:02 -07:00
danrubel 0e39092fd0 add enum suggestions 
and update LocalDeclarationVisitor to visit enum declarations

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1157113004
 2015-06-01 12:10:46 -04:00
Brian Wilkerson 089038b085 Move index closer to the plugin API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1156493004
 2015-06-01 08:25:40 -07:00
danrubel ecf44e960d remove keyword suggestions in constructor names and prefixed expressions 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1158413003
 2015-05-29 13:28:34 -04:00
Paul Berry 535394c265 Remove debugging print statements. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1149063005
 2015-05-27 20:24:06 -07:00
Konstantin Shcheglov 45862f401e Send 'execution.launchData' only after full resolution. 
We don't need to send them after each and every notice.
This information becomes ready somewhere in between parsing and full resolution.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1157823002
 2015-05-24 10:39:21 -07:00
Brian Wilkerson ad52c9eab9 Add support for specifying files needing analysis 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1152013002
 2015-05-21 14:34:04 -07:00
pq 0ce6fb29a6 Propogate and handle lint analysis option. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1131373004
 2015-05-19 15:13:26 -07:00
Konstantin Shcheglov d5774c5402 Issue 23481. Fix for creating a new class referenced from an inner local function. 
R=paulberry@google.com, brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23481

Review URL: https://codereview.chromium.org//1144893002
 2015-05-19 12:10:50 -07:00
Konstantin Shcheglov 8851388c43 Check for null in 'Create Class' Quick Fix. 
I don't know how to reproduce it.

How is it possible to have a type name outside a CompilationUnitMember?

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1149473002
 2015-05-19 09:35:40 -07:00