4e5938f373
Completion exceptions are never fatal.
...
Actually only some methods of the 'edit' domain are potentially fatal.
Alternative solutions:
1. Don't make anything fatal.
2. Add areExceptionsFatal to RequestHandler.
3. Let every domain to decide whether exceptions in some method or none of them are fatal.
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1404353007 .
2015-10-21 20:26:46 -07:00
f18a0209fb
Fix for 'Assign to Local Variable' in closures.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1415253002 .
2015-10-21 13:20:22 -07:00
6c85fe785a
Analysis Options error notifications.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1411013003 .
2015-10-21 09:59:19 -07:00
c7907e7800
Support for searching files by import/export/part URIs and library identifiers.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1417483006 .
2015-10-20 08:52:02 -07:00
5f71b2e7cd
Check that AnalysisContext is not null.
...
I guess this happens when a "resolved" CompilationUnit is not actially resolved.
I don't know why we get such units, but I saw this situation twice in IDEA.
So, probably we need to fix at least throwing NPE here.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1418513002 .
2015-10-19 13:27:50 -07:00
5e9ea82aa4
Issue 24612. Skip excluded folder during contexts creation.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24612
Review URL: https://codereview.chromium.org/1411393003 .
2015-10-19 13:17:11 -07:00
ea947094ae
Fix for suggesting methods as a *name* of a local variable declaration.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1417603002 .
2015-10-19 12:29:22 -07:00
efc1d4b224
Ignore contexts in folders named 'packages' or starting with dot.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24614
Review URL: https://codereview.chromium.org/1415713002 .
2015-10-19 11:59:11 -07:00
e0636b183c
Make IndexableObjectKind parameterized.
...
LMK if this is a bad change.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1413563004 .
2015-10-19 10:13:43 -07:00
f80bd4203d
Index Dart CompilationUnit(s) with the correct context.
...
We should use the context that they belong to, not the context that we got them through.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1410983003 .
2015-10-19 09:59:58 -07:00
140a4f5891
Register .analysis_options files for analysis.
...
Some oportunistic constant cleanup as well (follow-up from: https://codereview.chromium.org/1399893004/ ).
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1412213003 .
2015-10-19 09:46:54 -07:00
27eb09033f
Clean up wording of client usage expectations
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org/1409353002 .
2015-10-19 07:46:49 -07:00
8eb408914d
Fix library name
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1411523007 .
2015-10-19 07:46:32 -07:00
3b198ed6ae
Disable completion of formal parameter names as *types*.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1414653002 .
2015-10-18 13:28:12 -07:00
af4fbdd952
Index library/part file references from import/export/part containing files.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1407863004 .
2015-10-18 10:24:53 -07:00
c0d68a5437
DAS specification changes - spelling and ElementKind.FILE addition.
...
ElementKind.FILE will be used in search.findElementReferences
1. In the 'element' field of responce when a URI is at the given offset.
2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1409333002 .
2015-10-17 10:03:03 -07:00
67576340b0
Declare IndexableObject.file instead of Source.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1409203002 .
2015-10-16 14:43:49 -07:00
adb8ebd0e6
Remove obsolete flag to enable package support
...
R=pquitslund@google.com
Review URL: https://codereview.chromium.org/1411833002 .
2015-10-16 13:43:00 -07:00
3825cf0cd4
Add an experimental domain
...
R=paulberry@google.com , pquitslund@google.com
Review URL: https://codereview.chromium.org/1412683002 .
2015-10-16 12:56:13 -07:00
ce6614f2dc
Disable completion in comment text.
...
It drives me nuts when I try to type some text and IDEA replaces my words with some random identifies.
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1410893002 .
2015-10-16 10:38:47 -07:00
a30bcd7b97
Issue 24599. Fix for requesting navigation for directives.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24599
Review URL: https://codereview.chromium.org/1405033002 .
2015-10-15 10:54:06 -07:00
cae05d6bd4
Context invalidation on option changes (Implements #24574 ).
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1399893004 .
2015-10-14 20:42:50 -07:00
6bce9b2373
One extension manager (to bind them all).
...
TL;DR Moves all plugin registration to AE's extension manager.
The rub is that plugin registration wasn't happening right which cropped up in integration testing. Included is a test that verifies that options are getting properly threaded through to the linter. (This test failed when we had two Extension Managers.)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398033004 .
2015-10-13 16:37:42 -07:00
e5f3bb163b
AS strong-mode .analysis_options awareness.
...
R=brianwilkerson@google.com , leafp@google.com
Review URL: https://codereview.chromium.org/1403983002 .
2015-10-13 13:22:49 -07:00
4ca8a3f19b
Strong mode checker integration. This integrates jmesserly's CL, and adds a task for computing strong mode errors and an annotated unit.
...
BUG=
R=brianwilkerson@google.com , jmesserly@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1396273004 .
2015-10-13 10:16:35 -07:00
9913f33522
Stop looking for overrides once the pivot element reached.
...
See also https://github.com/dart-lang/sdk/issues/21804 for the original motivation.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1396053003 .
2015-10-13 08:24:16 -07:00
586a1f359a
Fix for renaming (an invalid) ClassElement invocation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1385403007 .
2015-10-12 12:21:12 -07:00
2bbb40d0e2
Warn about conflict before renamed class member and enclosing class name.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1398213004 .
2015-10-12 12:10:12 -07:00
307438d582
Return 'null' rename refactoring in case of a null element.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1397403002 .
2015-10-12 10:44:31 -07:00
78da03cd97
Extract protocol_dart.dart APIs.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1398333002 .
2015-10-12 06:58:34 -07:00
9ad256cf18
Move the wire protocol support into the public API
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
695256d586
Linter hookup into AS.
...
Note the TODO to fix the extension manager interaction hijinx. Really we should ensure that we are only using the one in engine. At the moment, it's easy to get this wrong (as the initialization heroics herein testify).
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1392683003 .
2015-10-09 13:40:07 -07:00
8f4c63c92b
Restructure the public API for server
...
R=danrubel@google.com , paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1392253002 .
2015-10-09 07:57:00 -07:00
abfa9bf46a
Move getCamelWords() to the strings.dart file.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1394933003 .
2015-10-08 21:31:27 -07:00
d6d2e6f3c6
Options plugin initialization fix.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1400473004 .
2015-10-08 14:52:42 -07:00
e292918cff
Back out options plugin notifications.
...
Pending investigation of AbstractContextManagerTest failures.
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1393383002 .
2015-10-08 12:53:43 -07:00
b4091099be
Fix DAS, use all the Analyzer plugins.
...
R=pquitslund@google.com
BUG=
Review URL: https://codereview.chromium.org/1398803002 .
2015-10-08 12:35:21 -07:00
e19f10fbec
Add context to OptionsProcessor callback API.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1392143002 .
2015-10-08 10:47:06 -07:00
307612582b
Show UsedLocalElements and parts ASTs on the status pages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1392173002 .
2015-10-07 21:41:17 -07:00
870d9196ee
Add dependency information to the status pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1392863003 .
2015-10-07 16:58:19 -07:00
651221bb82
Resolve ordering issues.
...
This CL changes the way that the task model does strong mode inference to use the strongly connected components in the import/export graph. Library cycles are computed and inference is staged by forcing each stage of inference to happen across an entire library cycle at once, and to force all external dependencies of a library cycle to have completed inference before inference for the library cycle can begin.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1386023002 .
2015-10-07 16:14:35 -07:00
63d8b70fce
Add 'Add != null' quick fix.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24518
Review URL: https://codereview.chromium.org/1393953002 .
2015-10-07 10:18:23 -07:00
fe76c6f3c4
Lint support for the new task model.
...
Related bug: https://github.com/dart-lang/analyzer_cli/issues/64
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1385293002 .
2015-10-06 16:45:45 -07:00
b76da2d61e
Turn on the new task model by default in analysis server.
...
The previous option for enabling the task
model ("--enable-new-task-model") is replaced with an option for
disabling it ("--disable-new-task-model").
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1390843002 .
2015-10-06 13:49:52 -07:00
d14a963546
only send final completion notification
...
This shaves 1 ms off the average completion notification response time
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1389473002 .
2015-10-06 14:21:29 -04:00
a96541b369
fix call to get current source - fixes #24509
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1385213002 .
2015-10-06 13:36:28 -04:00
b107dec41a
Spec change: include covering expressions into Extract Local protocol.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1388783003 .
2015-10-05 14:44:32 -07:00
8e523195e6
Move refactoring APIs into provisional
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1387703003 .
2015-10-05 12:51:57 -07:00
7bbd8c66a5
Move completion APIs to private location
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1383313002 .
2015-10-05 11:57:35 -07:00
ba318117d8
More documentation clean-up for server APIs
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1389713002 .
2015-10-05 11:04:09 -07:00
Konstantin Shcheglov