dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

2966 Commits

Author SHA1 Message Date
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 22:23:53 +00:00
danrubel@google.com fabddbd918 add ContextsChangedEvent 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//732093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41786 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 17:14:48 +00:00
danrubel@google.com f60be24eb8 add code completion cache 
- generic mechanism for use in a subsequent CL
- minor get_handler import cleanup

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//729193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41778 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 15:13:38 +00:00
danrubel@google.com dc7f0c20dc cleanup warnings 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//729283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41776 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 15:06:07 +00:00
scheglov@google.com 30e11469c3 Use a better way to compute InterfaceTypes least upper bound. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//730803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41761 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 16:52:58 +00:00
danrubel@google.com 84c6c0d7ba only wait for analysis if necessary when computing invocation suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//728143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41760 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 15:16:53 +00:00
scheglov@google.com 0f0a275fc7 Issue 21612. Support for multiple returns in the 'Extract Method' refactoring. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21612

Review URL: https://codereview.chromium.org//725393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41758 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 01:40:46 +00:00
scheglov@google.com 6a03e08cca Issue 21617. Replace explicit 'this' references and clean ups. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21617

Review URL: https://codereview.chromium.org//733663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41753 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-14 23:16:13 +00:00
scheglov@google.com 19bd923634 Remove unused fields from analysis_server. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//725153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41743 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-14 15:47:53 +00:00
scheglov@google.com 2bcc7feba2 Remove unused methods in analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//721223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41718 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-13 16:27:07 +00:00
scheglov@google.com affc91a881 Issue 21552. Fixes for navigation, hover and rename in instance creation expressions. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21552

Review URL: https://codereview.chromium.org//717513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41651 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-11 03:01:21 +00:00
brianwilkerson@google.com d23df4f448 Clean up references in comments 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//708263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41623 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-08 15:45:19 +00:00
scheglov@google.com 7e71785a58 Issue 20827. Add imports as needed the 'Add type annotation' Quick Assist. 
I left some TODOs, the CL is big enough already.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827

Review URL: https://codereview.chromium.org//706263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41620 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-07 23:21:35 +00:00
danrubel@google.com 7e7f3ce68c display completion performance in new server status page 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//691853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41612 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-07 18:10:51 +00:00
danrubel@google.com d3646956e8 first cut argument list completion suggestions 
- first cut simplistic insertion of params
- required params only for now
- move cursor after ) if no params
- don't insert () if identifier suggestion
- does not cover all method/function invocations yet
- updated comments in Server API
- extracted new declaration visitor

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//711533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41586 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 21:42:31 +00:00
scheglov@google.com 772a0c6b22 Fix 'Unused local variable' hints in analyzer and analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//709493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41576 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 18:32:54 +00:00
scheglov@google.com df6233ae4a Use Element's source paths instead of URIs as a key in the index. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//703963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41530 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-05 21:02:37 +00:00
danrubel@google.com f92b942be2 move combinator suggestion ast traversal into computeFast 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//694203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41521 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-05 14:13:46 +00:00
scheglov@google.com 7f4d5bb1fb Issue 21506. Fix for adding back previously excluded resources in sub-folders. 
The server's part of the issue.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21506

Review URL: https://codereview.chromium.org//692073004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41500 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-04 18:47:14 +00:00
paulberry@google.com 24fac6c7e5 Flush analysis server output stream when closed. 
This ensures that if the analysis server terminated with an exception,
the stacktrace will actually be written to stdout before the server
exits.

BUG=dartbug.com/21494
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//694413004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41495 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-04 16:11:55 +00:00
scheglov@google.com 1c6ddd0751 Issue 21498. Fix for navigation from instance creation with type arguments. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21498

Review URL: https://codereview.chromium.org//694383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41468 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 20:45:34 +00:00
scheglov@google.com 1d69da9c39 Issue 21496. Fix for inlining negate/decrement into negate. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21496

Review URL: https://codereview.chromium.org//695383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41466 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 20:29:57 +00:00
scheglov@google.com 15743f701e Support for inlining methods when some arguments are missing. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//694373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41464 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 18:35:58 +00:00
scheglov@google.com da1b1e947a Remove unnecessary cast in Quick Assist. 
Sorry, missed it in the previous CL.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//696003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41451 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 20:44:44 +00:00
scheglov@google.com 90b785c88c Fix for an error in the error handler. 
We pass exception as String message.

We would have caught it if we had run the server in the checked mode.
Instead it failed at the JSON serialization stage.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//698563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41450 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 20:43:28 +00:00
scheglov@google.com 8bd5c75f0c Fix for 'Replace if-else with conditional expression' in case of mixed expression/return branches. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//690353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41446 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 19:22:22 +00:00
scheglov@google.com b7c685bbe2 Support for 'Add Type Annotation' when selection if right after ';'. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//693193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41445 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 19:09:03 +00:00
brianwilkerson@google.com e9696e5f67 Clean up logging uses 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//685993004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41443 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 19:05:19 +00:00
danrubel@google.com 58b915ffea move import combinator suggestions into a separate computer 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//695773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41442 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 18:31:18 +00:00
brianwilkerson@google.com 20c13d4715 Fix logging API. This should fix the exception I'm seeing. I'll clean up uses of the deprecated API in a separate CL. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//694833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41439 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 16:22:50 +00:00
brianwilkerson@google.com 3d13808d7d Status page improvements: sort context names, right align numbers, add missing data descriptors. 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//685123006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41427 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 21:11:40 +00:00
danrubel@google.com d22c027e0a add suggestions in format parameter list 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//693573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41420 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 15:13:57 +00:00
danrubel@google.com b7aeaab3f7 make deprecated elements have low suggestion relevance 
BUG=dartbug.com/19615
R=scheglov@google.com

Review URL: https://codereview.chromium.org//690793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41414 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 01:08:32 +00:00
scheglov@google.com 97bc20ffc5 Suggest names for PropertyAccess. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//646103006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41409 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-29 22:07:27 +00:00
scheglov@google.com e96b29143c Rename ForEachStatement.iterator -> iterable. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//689793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41405 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-29 21:33:04 +00:00
scheglov@google.com bdd50e1230 Issue 21458. Support for 'Add type' Quick Assist in for-each loops. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21458

Review URL: https://codereview.chromium.org//680133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41403 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-29 20:59:29 +00:00
paulberry@google.com 03b3d16691 Make table entries on analysis server's '/status' page clickable. 
Clicking on a table entry now takes you to a list of files in the
given state.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//685863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41400 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-29 20:05:16 +00:00
danrubel@google.com 67071bd861 Refactor CompletionSuggestionKind 
- Remove many CompletionSuggestionKinds that duplicate ElementKind
- Add two new CompletionSuggestionKinds: INVOCATION and IDENTIFIER
- regenerate Analysis Server Dart and Java API and docs
- rework Dart and Java tests
- remove/rename unused Dart and Java classes and methods
- remove unnecessary reference to SDK

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//684183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41396 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-29 16:09:56 +00:00
danrubel@google.com e4b90d4cee add class type alias suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//689433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41388 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-29 02:48:31 +00:00
paulberry@google.com 3e361ba46b Allow print() to be used for debugging analysis server. 
We now run analysis server inside a zone so that all print() calls it
executes can be captured to a buffer (rather than being sent to
standard output, where they will confuse the client).  When the server
is run in HTTP server mode, the print buffer is displayed on the
status page.

R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org//686763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41380 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 23:29:27 +00:00
danrubel@google.com 98d9096892 add functional type alias suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//682953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41376 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 22:03:16 +00:00
scheglov@google.com e446dd5227 Issue 21333. Constant names are not special anymore in the style guide (Dart version). 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21333

Review URL: https://codereview.chromium.org//684863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41373 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 21:42:46 +00:00
paulberry@google.com 02dada3dec Avoid analysis server crash when reanalyze invoked during analysis. 
BUG=dartbug.com/21448
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//678413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41372 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 21:15:59 +00:00
danrubel@google.com 2e5f738ad9 add type static constants suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//686843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41369 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 21:03:36 +00:00
danrubel@google.com 1a68218c36 suggest imported functions in argument list 
BUG=dartbug.com/21446
R=scheglov@google.com

Review URL: https://codereview.chromium.org//683133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41368 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 19:03:37 +00:00
paulberry@google.com 4745b7f24a Add a debug option to analysis server to specify HTTP port. 
When a port is specified, user may navigate to localhost:$port/status
to see the status of analysis.

Intended for internal debugging of analysis server only.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//679113006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41349 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 00:34:24 +00:00
brianwilkerson@google.com 2f937685fc Code clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//667463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41348 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 00:25:22 +00:00
danrubel@google.com b41bc7b57e add property accessor suggestions 
BUG=dartbug.com/21380
R=paulberry@google.com

Review URL: https://codereview.chromium.org//666863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41344 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-27 22:56:26 +00:00
scheglov@google.com a625b09fa8 Index EnumDeclaration definitions as top-level elements. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//685493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41341 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-27 21:56:55 +00:00
scheglov@google.com 0463d78cfb Semantic highlight async/await/sync/yield. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//668943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41335 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-27 20:18:11 +00:00