6a90488fc8
cache pub list results
...
BUG=
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//941883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44062 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 17:24:08 +00:00
98c9558a23
Issue 20827. Import required type in 'Extract Method' refactoring.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827
Review URL: https://codereview.chromium.org//956393002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44059 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 17:08:13 +00:00
ec8ab11a9d
Issue 20827. Extract library importing helper and use it fox Quick Fixes.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827
Review URL: https://codereview.chromium.org//961583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44052 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 15:57:10 +00:00
08cff379ca
Don't propose 'Assign to local variable' when in arguments list.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//943053005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44036 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 01:34:25 +00:00
7c257183de
Issue 21804. Type hierarchy should show overrides in mixins.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21804
Review URL: https://codereview.chromium.org//956023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44033 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 22:53:19 +00:00
d7672348a1
Issue 21978. Put function 'main' first when sorting members.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21978
Review URL: https://codereview.chromium.org//961443004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44032 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 22:40:26 +00:00
49a2b92b29
Measure time spent running pub
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//959543005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44031 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 21:37:15 +00:00
6c16e7a255
Small improvements for indexing NameElements.
...
It improves analysis by about 2%.
For analyzer + analysis_server indexing takes about 12% now.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//951463005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44027 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 18:51:30 +00:00
209fcdf1d7
Merge notifications computing into the 'notices' tag.
...
Also cover incremental analysis with its own tag.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//956623006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44013 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 01:42:26 +00:00
ba818ae5e1
Add more user tags to help trackdown analysis server perf bottlenecks.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//928073003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44008 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 22:59:34 +00:00
9581e77f58
Replace try/finally with PerformanceTag.makeCurrentWhile().
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//954013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44004 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 22:33:55 +00:00
12ccb77c10
Add more performance tags.
...
This reduces amount of "unknown" time to less than 1%.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//951423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44000 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 21:47:09 +00:00
a2fa6b10ec
Improve displaying overlays.
...
1. Use path as argument instead of id.
2. Show every file in the global ContentCache just once.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//949283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43994 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 19:55:01 +00:00
d2c177955f
Optimize IntArrayToIntMap and ElementCodec.encodeHash().
...
This make analysis about 6% faster.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//953913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43993 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 18:25:17 +00:00
e267b86440
Improve performance tags display - percent and sorting.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//953933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43992 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 17:53:08 +00:00
e0f3cceb17
Add the 'executionDomain' performance tag.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//955743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43991 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 17:39:51 +00:00
fcb524088e
Add support for writing instrumentation to a log file
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//950983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43976 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 20:41:45 +00:00
2cc371c123
Drop return type in _IndexContributor.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//949993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43975 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 19:49:51 +00:00
b36efe9640
Field references in field format parameter declarations and initializers mean writing.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//949623005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43971 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 18:45:30 +00:00
2e466105b2
Create package: URIs everywhere
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//946803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43965 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 17:34:12 +00:00
acec842aee
Add 'Convert Method to Getter' proposal only if it is an available refactoring.
...
So, that we don't show it for method with parameter or returning null.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//945113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43936 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 23:18:21 +00:00
946d56198e
Fix for searching constructor references.
...
Currently we record constructor declarations and SearchEngine returns them as "references".
But it is not quite a reference, and it is used only as a way to get name range.
With this change to ConstructorElement we don't need to have these artificial references.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//946023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43932 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:10:30 +00:00
0348d0decd
Issue 22288. Rename named parameters in hierarchy.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22288
Review URL: https://codereview.chromium.org//945693004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43931 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:08:18 +00:00
bbc11c6640
Add ignore-unrecognized-flags as an option to the command line options of analysis server
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//940093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43920 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 17:19:53 +00:00
45acfc4524
fix code completion invocation on getter
...
BUG=dartbug.com/22376
R=scheglov@google.com
Review URL: https://codereview.chromium.org//929323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43896 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:14:52 +00:00
3750ba067f
Return version with connected notification
...
R=jwren@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//943723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43892 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 20:45:01 +00:00
7256562fcd
Return RequestErrorCode.NO_INDEX_GENERATED if no index.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//939823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43866 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 05:07:06 +00:00
1e120443b5
Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body.
...
R=danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21879
Review URL: https://codereview.chromium.org//935123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43857 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 23:17:10 +00:00
6a78250c64
Issue 22476. Outline for enums.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22476
Review URL: https://codereview.chromium.org//934353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43853 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 21:37:27 +00:00
4e34c0d247
Generate artificial hashCode for often used classes.
...
By avoiding calling Object.hashCode we analyze about 1% faster.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//934113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43832 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 01:12:43 +00:00
0e73ada9c2
Use package: URIs for files in lib
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//914373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43827 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 22:47:34 +00:00
55a3255070
Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests.
...
Also remove passing a SearchEngine instance into Quick assists/fixes - they don't use it.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//923103004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43819 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 20:01:45 +00:00
a46fc6016d
Addition of the --no-index flag to the analysis server spec.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//932883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43816 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:55:00 +00:00
298747c23e
Add properties to the element tree
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//934603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43801 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-16 21:41:50 +00:00
a56ac2f521
update code completion suggestion relevance based on common usage
...
BUG=
R=lukechurch@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//925723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43792 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-15 21:17:48 +00:00
9e883eb661
Use a slightly faster way to write index data.
...
It makes initial analysis about 3% faster.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//924943003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43786 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-14 04:30:27 +00:00
ef1e368409
Improve code generation for 'bottom' and 'dynamic' arguments.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//924783005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43780 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 21:02:34 +00:00
056909e4a7
Rework analysis server performance measurement code.
...
This change has the following advantages:
- We now keep track of the amount of time spent doing unknown
activities using its own timer.
- Several pieces of analysis server functionality are now tracked
(previously we only tracked time spent inside the "analyzer"
package).
- The set of all performance timers is tracked in PerformanceTag.all
so that new timers can be added without having to update the code
that prints out timing measurements.
- Performance measurement code has been integrated with Observatory
"user tags", so that the same categories measured by the analysis
server also show up in the VM profiler view.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//918383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43745 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 23:54:49 +00:00
865b217511
Issue 22381. Fix for navigating to constructor from redirecting factory constructor.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22381
Review URL: https://codereview.chromium.org//921833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43731 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 17:58:29 +00:00
06b1a16819
Include source info in status AST dump
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//922453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43708 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 00:41:38 +00:00
3f5da18831
Add packageUriResolver before ResourceUriResolver.
...
Otherwise execution.mapUri always restores file:// URI.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//922433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43705 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 23:06:48 +00:00
0efb52aa0f
More complete state transition data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//916973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43700 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 22:04:51 +00:00
c762e94a1c
check for null completion node
...
BUG=dartbug.com/22371
R=scheglov@google.com
Review URL: https://codereview.chromium.org//915023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43690 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 15:44:21 +00:00
0b922f3d22
Quick Fix for an undefined class in is/as expressions.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//913923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43675 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 01:31:53 +00:00
7b59c01e8a
Use async/await in refactorings.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//913903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43674 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 01:21:43 +00:00
52af26ea3d
Minimal initial performance reporting
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//913853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43672 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 23:09:40 +00:00
937c4be45d
Add index search support to AST and element model pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//910293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43665 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 20:11:27 +00:00
ff4e2bfce1
Issue 22188. Verify that none or all execution flows return.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22188
Review URL: https://codereview.chromium.org//871013012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43663 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:14:01 +00:00
92e3e1b94a
Fix notifications for nested packages
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//907183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43620 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 22:57:44 +00:00
94dd9d28f8
Fix a null pointer exception
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//908873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43617 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:55:48 +00:00
danrubel@google.com