dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

2966 Commits

Author SHA1 Message Date
Konstantin Shcheglov a4fd5d814f Extract PerformanceLogger from AnalysisDriver. 
I also added the runAsync().

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2883633002 .
 2017-05-12 14:27:50 -07:00
danrubel 98825b4918 improve code completion abort request tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2876793006 .
 2017-05-12 13:28:39 -07:00
Brian Wilkerson bef53e72e4 Remove unintentional dependency on analysis_server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2875323002 .
 2017-05-12 10:07:37 -07:00
pq dc64c43480 Unused import cleanup. 
BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2876913002 .
 2017-05-11 14:08:47 -07:00
danrubel 66bb2d618e Remove unused analysisContext from completion request and contributors 
Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.

R=brianwilkerson@google.com, pquitslund@google.com

Review-Url: https://codereview.chromium.org/2877653002 .
 2017-05-11 09:38:50 -07:00
danrubel 6798cdfcd1 cleanup dart code completion contributors 
Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.

DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2873943003 .
 2017-05-11 09:12:36 -07:00
Brian Wilkerson 3b2c3ae5b2 Add support for built-in plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874803003 .
 2017-05-10 13:31:20 -07:00
Steve Messick 55097a44b3 Recover from merge problem 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2868383002 .
 2017-05-10 13:12:14 -07:00
Brian Wilkerson a3ac4253b1 Remove an obsolete error from the spec and an obsolete command-line flag 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2865403005 .
 2017-05-10 09:33:43 -07:00
Brian Wilkerson fbc3f3708d Remove unused reference to SearchEngine 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2872803003 .
 2017-05-09 14:32:12 -07:00
Brian Wilkerson 98e8f17b96 Convert server to use RangeFactory 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2869083002 .
 2017-05-09 10:08:14 -07:00
Konstantin Shcheglov bd1ee32543 Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/. 
We are going to reuse ByteStore in front_end, also for incremental
compilation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2869803004 .
 2017-05-09 09:12:15 -07:00
pq 11558c8a90 Add trailing commas after Flutter instance creation params fixes (flutter-intellij/#f978). 
R=brianwilkerson@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/978
Review-Url: https://codereview.chromium.org/2864373003 .
 2017-05-09 07:00:15 -07:00
danrubel bc310f5f1f cleanup KeywordContributor 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2871443003 .
 2017-05-08 10:03:39 -07:00
danrubel 959b7c14b8 improve completion for formal param initializers 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2864233002 .
 2017-05-08 06:50:46 -07:00
danrubel eb15a4c7c9 add constructor initializer completions 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2869653002 .
 2017-05-08 05:52:12 -07:00
Brian Wilkerson d2bbfb4f77 Make an AstProvider available to AssistProcessors 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2862143003 .
 2017-05-05 09:24:30 -07:00
Brian Wilkerson 6c2023bd07 Move ChangeBuilder to analyzer_plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2860383002 .
 2017-05-05 07:52:27 -07:00
Brian Wilkerson 0d2bfea054 Remove the use of CorrectionUtilities 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2866603002 .
 2017-05-05 06:06:57 -07:00
pq 1a394e975f Specify types in generated closure args. 
Follow-up from: https://github.com/flutter/flutter-intellij/issues/975

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2863683002 .
 2017-05-04 12:54:23 -07:00
Devon Carew f6f845c879 Fix a completion exception during import suggestions. 
BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2862793002 .
 2017-05-04 09:24:18 -07:00
Brian Wilkerson 4a9092d9c9 Change the ChangeBuilder API to use SourceRange 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2856233003 .
 2017-05-04 08:49:01 -07:00
pq 374871da75 Add default implementation when fixing missing required closures (flutter-intellij#975) 
Fixes: https://github.com/flutter/flutter-intellij/issues/975

Also improves code generation for required lists to include empty list literals.

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2862623002 .
 2017-05-03 13:22:52 -07:00
pq a51af38461 Widget details for Flutter children: param completions. 
R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2855883003 .
 2017-05-02 13:50:34 -07:00
Brian Wilkerson 9eee213363 Fix bugs found while working on tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2849253002 .
 2017-05-02 06:15:25 -07:00
Steve Messick 28b7710190 Complete declarations; detect invalid blocks 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2852073002 .
 2017-05-01 08:45:41 -07:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
 2017-05-01 08:28:10 +02:00
jpaulsen 6ff38127d6 New Lint quick-fix: await_only_futures (#29490) 2017-04-28 14:00:52 -07:00
jpaulsen ddd9bb1be2 New Lint quick-fix: avoid_annotating_with_dynamic (#29489) 
New Lint quick-fix: avoid_types_on_closure_parameters
 2017-04-28 13:40:51 -07:00
pq 37dbc98df8 Fix null default value access (#29512). 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Fixes: #29512
Review-Url: https://codereview.chromium.org/2844323004 .
 2017-04-28 11:33:34 -07:00
pq fa318bf1c7 Fix VERBOSE_FLUTTER_COMPLETIONS flag. 
(Mis-defined as an option when it should be an arg flag.)

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2854453002 .
 2017-04-28 11:20:05 -07:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
 2017-04-28 07:46:29 -07:00
pq daa399499d Fix following comma detection in code completion (#29503). 
BUG=
R=brianwilkerson@google.com

Fixes: https://github.com/dart-lang/sdk/issues/29503
Review-Url: https://codereview.chromium.org/2849703002 .
 2017-04-27 16:52:33 -07:00
pq efb5c5ddc5 Trailing commas for named args in Flutter cons invocations (flutter-intellij#551). 
* adds trailing commas to named params in Flutter instance creations
* adds trailing commas to default value boilerplate

See https://github.com/flutter/flutter-intellij/issues/551 for action shots. :)

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2850693002 .
 2017-04-27 14:58:02 -07:00
jpaulsen f929ab15e7 New Lint quick-fix: empty_statements (#29491) 2017-04-27 14:10:17 -07:00
Brian Wilkerson 51dd0538ea Guard against files that are not being analyzed (issue 29493) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2844413002 .
 2017-04-27 14:10:06 -07:00
Brian Wilkerson d98d672c16 Add completion support for plugins. 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842243003 .
 2017-04-27 10:26:46 -07:00
pq bfc071e515 Named arg completion fixes. 
Related to: https://github.com/flutter/flutter-intellij/issues/551

* fixes named arg selection offset to precede comma
* fixes inconsistent trailing commas between completions w/ and w/o prefixes

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2839273002 .
 2017-04-27 10:12:47 -07:00
Max Kim a211c5e4e7 Add stopgap for angular autocompletion. 
Autocompletion for angular

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2835053005 .
 2017-04-26 15:48:17 -07:00
jpaulsen 404f9a806c New Lint quick-fix: prefer_conditional_assignment (#29473) 2017-04-26 12:56:36 -07:00
jpaulsen ff46777c61 New Lint quick-fix: unnecessary_override (#29472) 2017-04-26 12:56:26 -07:00
Dan Rubel 3b790e5311 new TokenType and Keyword API 
This adds two new methods and adapts most of the old references
to use these new API. Once all call sites have been updated,
the old API can be removed.

This is part one of https://codereview.chromium.org/2842643004/

* replace type == TokenType.KEYWORD with type.isKeyword
* change Keyword.syntax --> Keyword.lexeme

R=paulberry@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2842213003 .
 2017-04-26 15:53:58 -04:00
Brian Wilkerson 207fffe067 Send re-analyze requests to plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2843093002 .
 2017-04-26 12:36:26 -07:00
Brian Wilkerson 65f492a043 Add support for watch events and error notifications 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842013003 .
 2017-04-26 09:36:26 -07:00
jpaulsen 7979eadef0 New Lint quick-fix: unnecessary_this (#29469) 2017-04-25 16:40:01 -07:00
jpaulsen b90aad2b2e New Lint quick-fix: unnecessary_lambdas (#29459) 2017-04-25 16:14:58 -07:00
Steve Messick 17360ffa6d Add colon to switch cases and default 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2837063003 .
 2017-04-25 11:13:54 -07:00
Steve Messick 8c2aae7dee Fix detection of bad catch-clauses and try-statements 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842523002 .
 2017-04-24 12:00:14 -07:00
jpaulsen dcba4b42cd New Lint quick-fix: prefer_collection_literals (#29378) (#29427) 2017-04-24 10:49:25 -07:00
Brian Wilkerson a81dac8288 Minor clean-up and bug fix 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2836953002 .
 2017-04-24 08:49:01 -07:00