dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

2966 Commits

Author SHA1 Message Date
Brian Wilkerson e9504d2857 Add outline support for the new mixin syntax 
Change-Id: I75d020f613daf37812ccf805d75e35091a28c198
Reviewed-on: https://dart-review.googlesource.com/72524
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-08-31 21:53:15 +00:00
Konstantin Shcheglov 0fae13e6bf Support for mixins in search.getElementDeclarations. 
R=brianwilkerson@google.com

Change-Id: I88e90159ae28a2585fdbaacca2c4caab15891b83
Reviewed-on: https://dart-review.googlesource.com/72523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-31 20:19:18 +00:00
Brian Wilkerson 4461b7cbcc Add folding support for the new mixin syntax 
Change-Id: I8f37a391cc47a2203730c81acd5f1776cb386e2e
Reviewed-on: https://dart-review.googlesource.com/72521
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-31 17:33:36 +00:00
Brian Wilkerson c22f0c6167 Add completion support for the new mixin syntax 
Change-Id: I3a8744e03f32092c15f1e340e0ee6bef5245a859
Reviewed-on: https://dart-review.googlesource.com/72520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-31 16:59:18 +00:00
Konstantin Shcheglov dbb1b2f4a6 Add 'Wrap with Container' quick assist. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I860a3a92024b349153266fd9e70b56beea426ee2
Bug: https://github.com/flutter/flutter-intellij/issues/2566
Reviewed-on: https://dart-review.googlesource.com/72260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-30 21:47:32 +00:00
Konstantin Shcheglov e81c1c57de Remove the workaround for a stale issue. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/25884
Change-Id: I87741664f00200170990e9a13d2f639c41671bda
Reviewed-on: https://dart-review.googlesource.com/71924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-29 15:33:17 +00:00
Konstantin Shcheglov 1f52372bfa Remove CFE integration from analyzer, analysis_server, and analyzer_cli. 
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.

Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-29 13:46:45 +00:00
Janice Collins f40ff153a9 Enable --use-fasta-parser with the analyzer by default. 
Based on Devon's change at:

https://dart-review.googlesource.com/c/sdk/+/67090

Change-Id: I80b7943826e248bf37d9bbbb769330d24b0dd6ae
Reviewed-on: https://dart-review.googlesource.com/70160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2018-08-28 19:29:17 +00:00
Danny Tuppeny 19f6c826a4 Ensure we don't walk over closures when looking for argument lists 
Bug: https://github.com/dart-lang/sdk/issues/34241
Change-Id: I21e9e8e1389e989aa3ad5ee98f63c497548ffd6b
Reviewed-on: https://dart-review.googlesource.com/71481
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-28 11:40:33 +00:00
Konstantin Shcheglov 83324a8db9 Fix for NPE when prefix completion after an expression without type. 
R=brianwilkerson@google.com

Change-Id: I3ef1c1e1f981e3a5c9ed6da066a1d204c6b3816d
Reviewed-on: https://dart-review.googlesource.com/71620
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-27 22:14:01 +00:00
Brian Wilkerson aded927ff4 Fix cast exception in ArgListContributor (issue 34227) 
Change-Id: Ib6db1fcab1b03059261fc35432794efd92524298
Reviewed-on: https://dart-review.googlesource.com/71188
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-22 19:04:35 +00:00
Devon Carew b63b73d46d Cosmetic tweaks to how we train the analysis server. 
Change-Id: I78785450820c3773cb17ce69561806c82d68ddf4
Reviewed-on: https://dart-review.googlesource.com/71182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-22 16:57:37 +00:00
Jens Johansen fd00c0a4f7 Train analysis server with cfe too 
Prior to this change the analysis server was trained in non-cfe mode
only, meaning that the playing field wasn't even.
This CL updates the training so both modes are trained, reducing the
cold server benchmark in cfe mode from ~76 to ~71 seconds on my machine.
This is still *way* more than the non-cfe version, but still.

Before:
```
$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run analysis-server-cold
Running analysis-server-cold 3 times...
  {analysis-server-cold-analysis: {micros: 15779864}, analysis-server-cold-memory: {bytes: 254571344}}
  {analysis-server-cold-analysis: {micros: 15181035}, analysis-server-cold-memory: {bytes: 272837552}}
  {analysis-server-cold-analysis: {micros: 15029866}, analysis-server-cold-memory: {bytes: 312474240}}
Finished in 49 seconds.

{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":15029866},"analysis-server-cold-memory":{"bytes":254571344}}}


$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run --use-cfe analysis-server-cold
Running analysis-server-cold 3 times...
  {analysis-server-cold-analysis: {micros: 76810701}, analysis-server-cold-memory: {bytes: 1634409696}}
  {analysis-server-cold-analysis: {micros: 74706698}, analysis-server-cold-memory: {bytes: 1565364624}}
  {analysis-server-cold-analysis: {micros: 75798888}, analysis-server-cold-memory: {bytes: 1759452128}}
Finished in 228 seconds.

{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":74706698},"analysis-server-cold-memory":{"bytes":1565364624}}}
```


Now:

```
$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run analysis-server-cold
Running analysis-server-cold 3 times...
  {analysis-server-cold-analysis: {micros: 15064119}, analysis-server-cold-memory: {bytes: 302396944}}
  {analysis-server-cold-analysis: {micros: 14909304}, analysis-server-cold-memory: {bytes: 273778864}}
  {analysis-server-cold-analysis: {micros: 14934034}, analysis-server-cold-memory: {bytes: 353252928}}
Finished in 45 seconds.

{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":14909304},"analysis-server-cold-memory":{"bytes":273778864}}}



$ out/ReleaseX64/dart pkg/analysis_server/benchmark/benchmarks.dart run --use-cfe analysis-server-cold
Running analysis-server-cold 3 times...
  {analysis-server-cold-analysis: {micros: 70252048}, analysis-server-cold-memory: {bytes: 1650741520}}
  {analysis-server-cold-analysis: {micros: 70853869}, analysis-server-cold-memory: {bytes: 1579162320}}
  {analysis-server-cold-analysis: {micros: 71155850}, analysis-server-cold-memory: {bytes: 1579512288}}
Finished in 213 seconds.

{"benchmark":"analysis-server-cold","result":{"analysis-server-cold-analysis":{"micros":70252048},"analysis-server-cold-memory":{"bytes":1579162320}}}
```

Change-Id: I8fb75624c86605e7028a2b8483df85ebbd958b0d
Reviewed-on: https://dart-review.googlesource.com/70260
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-08-20 07:15:47 +00:00
Devon Carew 97fddfc414 Don't have the analysis server ignore unrecognized flags. 
Change-Id: Iced499446cfbc3908e0d7f3f31abd97a7435bfe6
Reviewed-on: https://dart-review.googlesource.com/70421
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-16 22:39:18 +00:00
Brian Wilkerson 0bcf767d4d Clean up more preview-dart-2 related code 
Change-Id: Id1f81a635727f0f2fafb5dea4178f303c6ca4659
Reviewed-on: https://dart-review.googlesource.com/70143
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-15 14:43:12 +00:00
Brian Wilkerson 964a2fb9bb Produce fix when super constructor does not exist 
Change-Id: I8186b42a938a3ad814e624ba5b378c130422209f
Reviewed-on: https://dart-review.googlesource.com/70080
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-15 13:24:32 +00:00
Brian Wilkerson 49437e3bae Split TooManyArguments to support quick fixes 
Change-Id: I31511f619cafbce01f68d6e182328567a2bc3523
Reviewed-on: https://dart-review.googlesource.com/70021
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-15 13:24:22 +00:00
Devon Carew a517d19788 Change how we calculate memory usage for the analysis server benchmarks. 
Change-Id: I22ce228bd6bbd9fface6ebc19b4bb80d601b9893
Reviewed-on: https://dart-review.googlesource.com/70100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-08-15 02:04:42 +00:00
Brian Wilkerson 817e2cacb5 Base fixes on UNDEFINED_GETTER rather than UNDEFINED_IDENTIFIER 
Change-Id: Icf951cbb8b046985df4f6cae6e7e7e1cfab7766a
Reviewed-on: https://dart-review.googlesource.com/69980
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-14 17:50:48 +00:00
Brian Wilkerson ecad8d67b3 Add fix for getters on parameters 
Change-Id: I42b34534d9a83dd6802e5a79ea1d69bd4bbef887
Reviewed-on: https://dart-review.googlesource.com/69981
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-14 17:50:14 +00:00
Devon Carew 6a4f1b76ac Remove the --preview-dart-2 option from dartanalyzer and the analysis server. 
Change-Id: I268b9d5f79b30d0e4a0f8e6bb81a7738c98e5eea
Reviewed-on: https://dart-review.googlesource.com/69802
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-14 04:24:47 +00:00
Brian Wilkerson 8f768e7305 Fix an NPE when creating a fix to add a method for an undefined identifier that is not in a class context 
Change-Id: Id7989b1dc0dc80b820aaf57a746247ac7525ed56
Reviewed-on: https://dart-review.googlesource.com/69660
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-13 17:32:59 +00:00
Brian Wilkerson d72334e6a2 Prevent NPEs in the fix processor 
Change-Id: I2a5c12bf6f3aec4c8a504590f39b666c9934e4e4
Reviewed-on: https://dart-review.googlesource.com/68435
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-08-13 17:30:10 +00:00
Brian Wilkerson 978f12c17f Use void in place of Null in analysis_server 
Change-Id: Ifef805cb3c0111e237a6147f71a968958d5651e5
Reviewed-on: https://dart-review.googlesource.com/69560
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-13 13:16:53 +00:00
Mike Fairhurst 010828ada4 Fix issue with pub upgrade not running on existing plugins. 
Code trying to run "pub upgrade" was blocked behind "runPub" being
false. Instead, expect the pub command to run. If the folder exists, run
"pub upgrade," and if it doesn't, run 'pub get'.

Change-Id: Ia37bf11d08e921e31d2ed4410210d03b8dbe1b00
Reviewed-on: https://dart-review.googlesource.com/69440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-08-10 23:24:43 +00:00
Devon Carew 4c659e9f83 Have --use-cfe contribute to the driver signature. 
Change-Id: Ica21f166bde60e41e19c3e6ab49e05a29540b0b0
Reviewed-on: https://dart-review.googlesource.com/69320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-08-10 18:11:41 +00:00
Konstantin Shcheglov 0aa8f2d5cb Fix for some Quick Fix tests by adding CFE generated error codes. 
R=brianwilkerson@google.com

Change-Id: I2b06dc388a00aa0c8e5ab3db045b3fe8ec02ed5e
Reviewed-on: https://dart-review.googlesource.com/69283
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-10 18:00:46 +00:00
Konstantin Shcheglov ac973e5ba7 Return SourceSpan with actual length from _CompilationMessage. 
Change-Id: I883a4ce1b6fc63643db259a0d22e0719b460c109
Reviewed-on: https://dart-review.googlesource.com/69005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-10 16:03:42 +00:00
Konstantin Shcheglov d69a354026 Put fileEndOffset into ArgumentsJudgment and use to report argument errors. 
Change-Id: Id79bd71e7147be379e93024591134c12aa598a38
Reviewed-on: https://dart-review.googlesource.com/69221
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-10 15:40:37 +00:00
Konstantin Shcheglov c619413fef Fix for unawaited future in assists. 
R=brianwilkerson@google.com

Change-Id: Ie297476866d380d7938896e18cb5ffd5fff9fb1f
Reviewed-on: https://dart-review.googlesource.com/68762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-07 19:49:10 +00:00
Brian Wilkerson 87f753dbd3 Replace some declarations of element with declaredElement 
Change-Id: Idd62472b16cccaa98749a510197ec8d0f5053cb1
Reviewed-on: https://dart-review.googlesource.com/67820
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-08-02 16:00:36 +00:00
Brian Wilkerson 6a6e7abfc6 Clean up some warnings in the server code base 
Change-Id: I762fcc704fe0fa0547bbbc347eb248853d358121
Reviewed-on: https://dart-review.googlesource.com/67842
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-01 21:09:45 +00:00
Danny Tuppeny 3dc201e168 Update ChangeBuilder to not include empty edits (Take 2) 
Combination of Brian's change:
https://dart-review.googlesource.com/c/sdk/+/63901

and Devon's change:
https://dart-review.googlesource.com/c/sdk/+/66405

Change-Id: I57e5d1f7d3a653f225aba2d690190fe1ff18a5b1
Reviewed-on: https://dart-review.googlesource.com/67344
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-07-31 13:44:06 +00:00
Devon Carew 6e322f794c No longer run pub list-package-dirs from the analysis server. 
Change-Id: Id02bdfc25cb8827873ff607f7c4d4a3401c9a199
Reviewed-on: https://dart-review.googlesource.com/67205
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-27 23:05:41 +00:00
Brian Wilkerson b0636e1b09 Improve an error message 
Change-Id: I95cbc725c019dc1efce8d56940d1db167c343138
Reviewed-on: https://dart-review.googlesource.com/67202
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-07-27 21:01:47 +00:00
Danny Tuppeny b2d0f8ea63 Remove tests relating to selected parameter index + bump version number 
Change-Id: I2417b202b6b11b4c714f4c1d92edb13fd8d0ccc3
Reviewed-on: https://dart-review.googlesource.com/66572
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-07-26 13:51:19 +00:00
Danny Tuppeny 4c32dbb613 Add missing 'new' keywords to fix --no-preview-dart-2 failures 
Change-Id: I1a8dab5d703e130ccc7fb25842db52fa642fc775
Reviewed-on: https://dart-review.googlesource.com/66570
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-07-26 07:33:40 +00:00
Danny Tuppeny d792809d6f Add signature param defaultValue and remove (unused) selectedParameterIndex 
Bug: https://github.com/dart-lang/sdk/issues/27034
Change-Id: I3409ab544b79a7f64d6d41e5d091ca20418f248a
Reviewed-on: https://dart-review.googlesource.com/66562
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-25 15:42:44 +00:00
Danny Tuppeny e5a58158e3 Add constructor impl/tests + additional function tests for getSignature 
Bug: https://github.com/dart-lang/sdk/issues/27034
Change-Id: Ie47f76d4197dbcdec0fcfdada7914fdf986731ec
Reviewed-on: https://dart-review.googlesource.com/66540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-07-25 14:57:15 +00:00
Devon Carew ab0d27b694 Ignore an exception when deleting the temporary driver cache directory. 
Change-Id: I019adc6211af2db861900aaa80a126a48419be77
Reviewed-on: https://dart-review.googlesource.com/66620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-25 14:35:08 +00:00
Brian Wilkerson be7717dab4 Deprecate more propagated info members 
Change-Id: I65555bad9f1087602b7bdb5ae41a3920c23d143d
Reviewed-on: https://dart-review.googlesource.com/66500
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-25 13:17:23 +00:00
Danny Tuppeny ebb033cb72 Add signature information to spec and add basic implementation for functions 
Bug: https://github.com/dart-lang/sdk/issues/27034
Change-Id: I8d3f1a9c9a824b4b80f9cfa0370a439fa897b226
Reviewed-on: https://dart-review.googlesource.com/64689
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-25 07:16:52 +00:00
Devon Carew 80f851a711 Normalize the analysis server snapshot. 
Bug: https://github.com/dart-lang/sdk/issues/33944
Change-Id: I2eaefb81e1a06e9ed9cc7bd263d8a3ee667df75f
Reviewed-on: https://dart-review.googlesource.com/66403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-25 06:35:42 +00:00
Devon Carew c1552c3728 Ensure we terminate training if we get an exception from the analysis server. 
Change-Id: Iddd9ca5af50594e2dcc23833ae5d6a75a2cf09f8
Reviewed-on: https://dart-review.googlesource.com/66411
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-25 05:06:25 +00:00
Brian Wilkerson 54e241d71f Deprecate more AST API and replace uses of it 
Change-Id: I6ecf17853915e4b61ee39f25d99451b78d2ba4ac
Reviewed-on: https://dart-review.googlesource.com/66401
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-24 15:51:18 +00:00
Brian Wilkerson e98334a58c Remove remaining references to propagated types and mark the members as deprecated 
Change-Id: I2508bc7d6afb36a42e33f0e421f3a39f6d8b4d02
Reviewed-on: https://dart-review.googlesource.com/66142
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-22 23:47:01 +00:00
Brian Wilkerson 81c2b9d486 Remove some of the uses of propagated information 
Change-Id: Ie82b72302d96c14fd6104945e0fb25cd721ecfda
Reviewed-on: https://dart-review.googlesource.com/65940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-07-20 16:32:41 +00:00
Devon Carew 7ddc4ce8ba Train the analysis server snapshot on pkg/analyzer_cli. 
Change-Id: I07dcaec344d681a4abf8f09558d83a68efdd70e8
Reviewed-on: https://dart-review.googlesource.com/65575
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-18 21:32:09 +00:00
Devon Carew 006a2f481b Fix a type issue at runtime. 
Change-Id: I6e61813883c15b872dc5ee5aa9e9f4c617484958
Reviewed-on: https://dart-review.googlesource.com/65560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-18 16:08:20 +00:00
danrubel a133e78ead Mark last 2 statement completion tests as failing for now 
... so that the many other tests will be correctly asserted as passing by the bots.

Change-Id: I382f49b6578574ea2e1ea1adf52aa67241b9ae09
Reviewed-on: https://dart-review.googlesource.com/65460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-07-18 14:10:10 +00:00