Commit Graph

46 Commits

Author SHA1 Message Date
Konstantin Shcheglov 4324d46080 Use an available socket port for memory benchmark.
R=devoncarew@google.com

Change-Id: I96472010b6bfa01e0ae2254f105d8e71bb7e86d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105683
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-06-12 16:18:14 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-01-11 15:38:56 +00:00
Brian Wilkerson 73ea4b1a82 Remove dead code from the analysis_server tests
Change-Id: I91f943baa191e27b7e647d78e5424fcb3a5cc990
Reviewed-on: https://dart-review.googlesource.com/c/88165
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-01-02 14:23:09 +00:00
Konstantin Shcheglov 1f52372bfa Remove CFE integration from analyzer, analysis_server, and analyzer_cli.
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.

Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-08-29 13:46:45 +00:00
Devon Carew a517d19788 Change how we calculate memory usage for the analysis server benchmarks.
Change-Id: I22ce228bd6bbd9fface6ebc19b4bb80d601b9893
Reviewed-on: https://dart-review.googlesource.com/70100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-15 02:04:42 +00:00
Devon Carew fe3bba8b03 Switch integration tests to use a snapshot for the analysis server.
Bug: https://github.com/dart-lang/sdk/issues/33189
Change-Id: I27ac08545c36c1cc1c7718b945f298b6286731b9
Reviewed-on: https://dart-review.googlesource.com/57300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-05-30 17:29:55 +00:00
Vyacheslav Egorov f2b137343c Do not run analyzer benchmarks in checked mode.
Change-Id: Ib591a981d29ae671c6c6ea3b4f1e64e098607a5a
Reviewed-on: https://dart-review.googlesource.com/54230
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
2018-05-08 19:44:37 +00:00
Devon Carew 703a26a723 Pass the --dart-sdk flag into the flutter analyze benchmark.
Change-Id: I232e108eb29dd3cab75c4586f777555d84385731
Reviewed-on: https://dart-review.googlesource.com/52082
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-04-20 17:33:09 +00:00
Devon Carew 1ab4cee181 Add a benchmark for running flutter analyze --flutter-repo against flutter head.
Change-Id: I0e4cb66808126b37b43edede43ec7fdd2bbec45a
Reviewed-on: https://dart-review.googlesource.com/51042
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-04-12 21:01:36 +00:00
Konstantin Shcheglov 1d184ace7b Fixes for packages:args deprecated uses.
Mostly addOption() -> addMultiOption().

Change-Id: Iab40059aab45a371e0def89fbdfcd08bd1487d47
Reviewed-on: https://dart-review.googlesource.com/47121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-19 20:15:37 +00:00
Brian Wilkerson 602a8c2a7b Clean up usage of deprecated constants
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-03-09 01:02:49 +00:00
Danny Tuppeny f91ab5b64e Fix test failures on Windows
Windows doesn't have curl, but PowerShell does have Invoke-WebRequest (aliased to curl).
Also Fix set_general_subscriptions_test path issue.

Bug: https://github.com/dart-lang/sdk/issues/32355
Change-Id: I7567e2e01fc2158443b86569894ab0b17b3c5096
Reviewed-on: https://dart-review.googlesource.com/44240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
2018-03-01 07:46:36 +00:00
Jaime Wren cd878bc433 Create the new flag --use-cfe in the analyzer, analysis server and analyzer_cli and migrate the old behavior of --preview-dart-2 to --use-cfe. The --preview-dart-2 flag is now a no-op, with functionality coming soon.
See https://github.com/dart-lang/sdk/issues/31640

Change-Id: I2db2e7ef6a324cbd5d369b807e331495fed167df
Reviewed-on: https://dart-review.googlesource.com/33121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
2018-01-08 22:37:05 +00:00
Devon Carew c3abeef304 Add a --verbose option to the analysis server benchmarks.
Bug:
Change-Id: I5cadfacc8f2fcb5b7f0c1c140b2b08b60e65fb6c
Reviewed-on: https://dart-review.googlesource.com/25221
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-01 16:20:31 +00:00
Devon Carew ee1404e91a Allow analysis server benchmarks to run with --preview-dart-2.
Bug:
Change-Id: Ifb9a5c596d3ad63012177cfb4e0bd7b107e78aff
Reviewed-on: https://dart-review.googlesource.com/20941
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2017-11-15 07:37:51 +00:00
Devon Carew a714187898 Tweaks to the analysis server benchmarks.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2998813002 .
2017-08-10 12:35:06 -07:00
Devon Carew f383c17bc2 Redo our benchmarks; add a benchmark/benchmarks.dart tool.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2986293002 .
2017-08-02 08:07:38 -07:00
Brian Wilkerson 7d26ff6d4f Remove some more library directives
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884233004 .
2017-05-17 08:02:08 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
Devon Carew 9a852506c6 Tweaks to the analysis server --help output.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2810553002 .
2017-04-10 07:06:19 -07:00
Brian Wilkerson 203cf1d057 Remove unused import
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2549993002 .
2016-12-04 16:03:47 -08:00
Michael R Fairhurst 7e04b119aa Add a performance benchmark for the angular analyzer plugin (#27932) 2016-12-02 12:06:10 -08:00
Konstantin Shcheglov 33ecec5d4f Replace expect() with outOfTestExpect() in Analysis Server performance benchmark.
In package:test function expect() does not want to be used outside of
test() methods. So, we need a partial copy for using it in integration
tesitng code, and performance benchmarks.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2413573003 .
2016-10-12 12:57:03 -07:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'.
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'.
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
2016-10-06 08:47:15 -07:00
Brian Wilkerson ab9ba20c04 Fix recently introduced strong-mode errors
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2344933002 .
2016-09-15 14:37:37 -07:00
Konstantin Shcheglov 34ae48a6b0 Don't run Analysis Server performance tests in checked mode.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2153163002 .
2016-07-15 09:05:09 -07:00
Konstantin Shcheglov ce55b927fc Print min/max element in memory benchmarks.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2150033002 .
2016-07-14 12:20:41 -07:00
Konstantin Shcheglov e279c1de27 Rework local benchmarks into benchmarks on the Flutter codebase.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2150793003 .
2016-07-14 08:45:54 -07:00
Brian Wilkerson d8dfab5217 Fix comments in benchmark
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2124053002 .
2016-07-06 11:06:03 -07:00
Brian Wilkerson f3dc748db5 Add two memory usage benchmarks
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2111743002 .
2016-06-30 07:44:41 -07:00
Brian Wilkerson 221e92f172 Add a flutter benchmark; refactor
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2110443002 .
2016-06-28 10:27:22 -07:00
Konstantin Shcheglov 929cdf8e02 New scenario and local benchmark - refactoring after change.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2087763002 .
2016-06-21 08:38:33 -07:00
Konstantin Shcheglov 716f3fe041 Analysis and completion benchmarks with a set of local uses.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2081483002 .
2016-06-20 09:02:30 -07:00
Brian Wilkerson 97c613aad4 More strong mode changes in analysis_server
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1852113002 .
2016-04-03 17:56:30 -07:00
Brian Wilkerson 338c95be8c Sort the files in analysis_server
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1834423002 .
2016-03-28 18:25:29 -07:00
Konstantin Shcheglov 2f0f398c73 Fix lints: unnecessary_brace_in_string_interp
Also fixes two cases of empty_constructor_bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1521883002 .
2015-12-13 13:05:00 -08:00
keertip 2a88bdac4a refactor timing tests to not use the test framework
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1419503002 .
2015-10-19 16:34:56 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
Keerti Parthasarathy 6352acfaa8 add completion tests
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1393693003 .
2015-10-09 11:08:07 -07:00
pq 37d4be8f61 Improved AS benchmarking metrics.
Notably:
  * adds support for multiple metrics via the `--metric` flag  (e.g., `--metric outline,navigation,highlighting`).
  * captures timings in a list in case there are multiple results (e.g., outline before and after resolution).

R=keertip@google.com

Review URL: https://codereview.chromium.org/1395573002 .
2015-10-07 13:09:15 -07:00
pq df52deea9f More pluggable AS benchmarks.
R=keertip@google.com

Review URL: https://codereview.chromium.org/1387823005 .
2015-10-06 13:02:46 -07:00
pq d21c6ef67e Benchmarking for navigation results.
R=keertip@google.com

Review URL: https://codereview.chromium.org/1386003002 .
2015-10-05 15:46:28 -07:00
keertip 56e39e99eb rename _test => _tests
BUG=

Review URL: https://codereview.chromium.org//1358243005 .
2015-09-25 09:07:15 -07:00
Keerti Parthasarathy 6f775acc7b add performance tests
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1366923003 .
2015-09-25 08:35:42 -07:00