Commit Graph

10 Commits

Author SHA1 Message Date
Brian Wilkerson b936ffb329 Move several libraries out of the public API
Change-Id: I8259de00134310f25b1c6168940aea5190488999
Reviewed-on: https://dart-review.googlesource.com/51443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-04-17 17:35:27 +00:00
Konstantin Shcheglov feceb2c59e Restore ErrorCode default constructor, rename the one with named parameters to 'temporary'.
R=brianwilkerson@google.com

Change-Id: If0577d0e3da0abdef83f0f46f979014b69f76202
Reviewed-on: https://dart-review.googlesource.com/49020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-04-02 17:38:45 +00:00
Konstantin Shcheglov 14806df576 Make correction parameter optional named in ErrorCode and subclasses.
This is a preparatory step before adding a flag that signals
that the error code represents an unresolved identifier situation.

R=brianwilkerson@google.com

Change-Id: Ic3b30e2efae7ee0c12a40d1cc2bd48c14185d926
Reviewed-on: https://dart-review.googlesource.com/48763
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-03-29 19:59:13 +00:00
Devon Carew 5883eb9904 Add a hint for strong-mode: false in the analysis options file.
Related to https://github.com/dart-lang/sdk/issues/30789

Bug:
Change-Id: I77c85e49001934ce49708cddc431a6c1a082d386
Reviewed-on: https://dart-review.googlesource.com/9789
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2017-09-29 23:03:16 +00:00
Devon Carew 69afd51bbe Add a hint to rename .analysis_options files.
BUG=
R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2993323002 .
2017-08-09 11:48:37 -07:00
Brian Wilkerson defb2990d2 Add a test to ensure that error codes are not being missed and add missed error codes
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2992243002 .
2017-08-04 07:45:46 -07:00
Dan Rubel 236497901e Revert "add warning for deprecated .analysis_options file name"
This reverts commit b431498760.

Review-Url: https://codereview.chromium.org/2654223002 .
2017-01-25 23:03:03 -05:00
Dan Rubel b431498760 add warning for deprecated .analysis_options file name
This warns users about using the deprecated analysis options file name
and recommend that they rename it.
See https://github.com/dart-lang/sdk/issues/28385

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2654043003 .
2017-01-25 22:00:36 -05:00
Dan Rubel 0d15f1d892 report errors in included options files
Example error messages include:
/analysis_options.yaml(10..27): The include file other_options.yaml in /analysis_options.yaml cannot be found.
/analysis_options.yaml(10..27): Bad options file format (expected String scope key, got YamlScalar) in /other_options.yaml(0..0)
/analysis_options.yaml(10..27): Warning in the included options file /other_options.yaml(47..49): The option 'ftw' isn't supported by 'errors'.

Since the included options file may not be part of the project,
the error is reported on the initial include statement
and includes the needed location information for the user to track down the problem.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2502233004 .
2016-11-17 14:43:05 -05:00
Brian Wilkerson 9f0e4e1162 Split out error codes into separate files
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2442463002 .
2016-10-20 08:40:36 -07:00