dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
68,020 Commits 2 Branches 0 Tags
b334ea832018822dfd0aa5e9debdd9a8be0f2c4e
Commit Graph

308 Commits

Author SHA1 Message Date
Paul Berry b3ed442f70 Fix some unnecessary imports of front_end in analyzer 
Change-Id: I9d45dffffafca7799055b3db165200c2a8454537
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123841
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-01 13:54:22 +00:00
Johnni Winther 00c2962db8 [cfe+analyzer] Move messages, scanner and parser to package:_fe_analyzer_shared 
Change-Id: I4fa87aee65f30a9868a6cf8f0342591869ece7ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123663
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-11-01 09:37:57 +00:00
Paul Berry 5b4612bc68 Move front_end/lib/src/base/errors.dart into _fe_analyzer_shared package. 
Change-Id: I9369e8dbf7b5d6fff9ad2a74346871b3e274e8ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123640
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-31 13:05:53 +00:00
Brian Wilkerson df8876582c Include all variations of a message in diagnostic docs 
We now have multiple messages for the same name (id) and all of the
messages should be included in the docs so that users aren't confused
when the message they see doesn't match what's documented.

Change-Id: I0f668ececae1e9852eff9db25f29a48b7414c4d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-28 15:55:31 +00:00
pq 1a611e1d72 validate nonVirtual overrides 
Change-Id: I1077ffa17d5620b5af77872a5862012ce8274324
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122820
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-25 21:16:28 +00:00
Brian Wilkerson 8db1005d64 Clean up after changes to ffi diagnostic changes 
Remove markdown from diagnostic messages,
Format messages to fit in 80 lines,
Sort unsorted file,
Move diagnostic tests to the correct test classes,
Remove diagnostic that is no longer being generated.

Change-Id: I1dbd6a141a4ef31eb89d9ea5edfd17512cbb261a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122821
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-24 20:27:27 +00:00
pq 0f2787c9f3 validation of @nonVirtual use 
see: https://github.com/dart-lang/sdk/issues/34378

Change-Id: I0fe67c56bf7c08f211b6bf89d84c5495e32601a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122742
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-24 13:16:44 +00:00
Konstantin Shcheglov 7d474c95bb Remove fixed GENERIC_FUNCTION_TYPED_PARAM_UNSUPPORTED. 
Change-Id: Id5119149cf24fe748a3100b3a2b774915928ddf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122303
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-22 05:14:03 +00:00
Martin Kustermann 65813f5856 [analyzer/ffi] Extends dart:ffi specific analyzer checks 
This makes all tests in the ffi test suite pass:

   % tools/test.py -cdart2analyzer -mrelease -ax64 ffi

Issue https://github.com/dart-lang/sdk/issues/35777

Change-Id: I93338ee530041e5e8cb1eb5958b12fbf1517496e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121711
Auto-Submit: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-15 21:33:27 +00:00
Daco Harkes d82ca1a9c7 [vm/ffi] Remove Struct type argument 
This has coupled changes in package:ffi and package:tflite_native which are pinned in DEPS.

This CL includes the required analyzer changes from https://dart-review.googlesource.com/c/sdk/+/121647.

Issue: https://github.com/dart-lang/sdk/issues/38611

Change-Id: I712a886fd28ce0a2954fc42c90e1dfa495057732
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-reload-mac-release-simdbc64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-precomp-mac-release-simarm_x64-try,dart-sdk-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121422
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-10-15 18:35:57 +00:00
Brian Wilkerson af671211ab Add more ffi related checks 
There are still two checks that I'm aware of that are not being performed
(there are TODOs for them) and two diagnostics that need to be removed
because `Struct` will soon not take a type argument.

Change-Id: I17424a32225eeff7e3b2c0e0f36cfc6ccd45e0a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121640
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-14 18:36:25 +00:00
Brian Wilkerson a2e00066ff Add an error if a field in a struct class does not have a type annotation 
Change-Id: Ie38354045f0b5d1d8a335c6bb2d14689c2b49d6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121460
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-11 18:11:58 +00:00
Brian Wilkerson 3f80de6dc5 Generate errors rather than hints for ffi conformance checks 
Change-Id: Icb3a3b393200ae7b2cd0d0b603472e90174c970b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121403
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-11 17:18:09 +00:00
Brian Wilkerson 5facc76ad9 Initial set of hints for ffi 
This should cover the checks under "Subtyping restrictions" and
"Struct rules". The remaining checks will be in a follow-on CL.

Change-Id: Iaa328dad545e4f9cddd413c6039f7c15744db5b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121146
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-10 22:27:24 +00:00
Jens Johansen 8f477fd84a [parser] Disallow covariant on extension method parameters 
Fixes #38560.

Change-Id: I4c941fb6713983cc01efbe143c7924d0643efe73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119332
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-08 13:01:40 +00:00
Sam Rawlins ebc0a88154 Error for assert initializer in redirecting constructor; fixes #37867 
Bug: https://github.com/dart-lang/sdk/issues/37867
Change-Id: I74a809f2202e7ea1beeb45a8ce5d62613f102045
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120100
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-07 05:33:35 +00:00
Brian Wilkerson 04910d62f5 Include the deprecation message in diagnostics (issue 38667) 
Change-Id: Ib1fa24fa4b112b9675d1f1900cbdda15319080a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119780
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-04 16:27:07 +00:00
Kallen Tu c3bbd6a247 Added parser recovery for multiple variance modifiers. 
New error message for multiple variances and will handle recovery from
more than one variance modifier before a parameter.

Change-Id: I63ed8a7f04dd664e20d72b632b40f723aa43020f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118621
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-25 17:12:06 +00:00
Brian Wilkerson 4895185b1e Fix NPE when extension override is invoked without a call method (issue 38505) 
Change-Id: Ia2ad1168441cf07e379184ad82f592701f5ef2bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118481
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-23 22:42:10 +00:00
Konstantin Shcheglov 381d808686 Add UNDEFINED_EXTENSION_OPERATOR. 
R=brianwilkerson@google.com

Change-Id: I5370c9cab5968e520266085e6060f29f42cbedef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118469
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-23 22:25:50 +00:00
Brian Wilkerson f342d07b0d Report an error if an extension override is used in a cascade (issue 38417) 
Change-Id: I578d0b9663f4bc85a9b3d9726457682953809a72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117461
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-17 19:13:31 +00:00
Sam Rawlins 90b44e77d8 Report strict-inference issues with function return types 
Change-Id: I249a3a7b2b6698c784b1fea67679b0b810414161
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117201
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-16 20:43:41 +00:00
danrubel 3b1d3de988 update parser to report out of order "?.." operator 
Change-Id: I2d90e458d5721d16142752e8ac6a522cc41c2051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-09-12 14:38:31 +00:00
Brian Wilkerson be93b04a7c Introduce a better diagnostic message for unqualified references to static members within extensions 
Change-Id: Ie505bf86e510161bf5dece489292388039902f83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116748
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 19:02:56 +00:00
Sam Rawlins 80040e5cfe Remove errors for raw types in is or as expressions. 
This brings the errors in line with the exceptions described in the spec:

https://github.com/dart-lang/language/blob/master/resources/type-system/strict-raw-types.md#conditions-for-a-raw-type-hint

Change-Id: I045237d937579d4390d3e676dc5e12346b90b480
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-11 18:13:46 +00:00
danrubel fb73cb19e6 update parser to report MixinDeclaresConstructor error 
Change-Id: I4750ff522046cbcc6bab561d189f578a8e8fd8d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 05:26:16 +00:00
Konstantin Shcheglov ffd50c0dc5 Report EXTENSION_AS_EXPRESSION, set type fo dynamic. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38203
Change-Id: Iee270b7b3fecbeaba202c304f21ef703a8567674
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116055
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-06 22:14:34 +00:00
danrubel 4e4047a52f fix extension abstract method error 
This changes EXTENSION_DECLARES_ABSTRACT_MEMBER to be a parse error
and moves it into the parser so that it is generated for all of CFE.

Fix https://github.com/dart-lang/sdk/issues/37945

Change-Id: Iba2876eb2db83e96ec49adc49a7b6a0e7aff200b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116002
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 19:50:17 +00:00
Brian Wilkerson 233b4a71ca Deprecate some unnecessarily duplicated error codes 
Originally the spec made a distinction between when some of these
conditions were errors and when they were warnings. That distinction has
been removed, so this just cleans up our code to reflect that fact.

Change-Id: I3a6fdae2896eb93c6b9cacfea790cd9b553feec5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115261
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-03 16:01:25 +00:00
pq a78e0c4af0 generate errors for extensions named w/ built-in ids 
Fixes: https://github.com/dart-lang/sdk/issues/38095

Change-Id: I7e328668898e46ad2e37e0e57046b2ec1cc8ccc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114755
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-29 20:11:15 +00:00
Dan Rubel e9a44ba6a8 fix extension instance field error 
This changes EXTENSION_DECLARES_INSTANCE_FIELD to be a parser error
and moves it into the parser so that it is generated for all of CFE.

See https://github.com/dart-lang/sdk/issues/37945

Change-Id: Ib49d49a20d670e0dd7d9a4cd870237d2cf87dd00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114882
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-28 21:26:31 +00:00
danrubel 52e732b786 fix constructor in extension error 
This changes EXTENSION_DECLARES_CONSTRUCTOR to be a parser error
and moves it into the parser so that it is generated for all of CFE.

See https://github.com/dart-lang/sdk/issues/37945

Change-Id: Iecaf277c63d7791a4b7ac9e6583b5018821d2c18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114626
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-28 00:57:42 +00:00
Parker Lougheed d61daa79d3 Add more specific warnings to analyzer for @required on parameters 
Deprecates the old HintCode and adds three new ones which clarify to
the user the problem with using @required on different types
of parameters.

Bug: https://github.com/dart-lang/sdk/issues/36966
Change-Id: I2245663537e88aeb15bcf14eb5913e54be98829d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102900
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-27 14:54:45 +00:00
Brian Wilkerson 9b46abc4ad Restore removed error codes to unbreak angular 
Change-Id: I18403d3dcf9cf2a9966458836561574367c82602
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114542
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-08-26 18:49:30 +00:00
Brian Wilkerson 5935b916e3 Rename several error codes and improve some messages 
Change-Id: I6e629719dee14c2af7c1358145fb25b21f5d5157
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114160
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-22 20:08:53 +00:00
Sam Rawlins 72923471c4 strict-inference failures for untyped parameters: 
* Untyped function parameters are a strict-inference failure.
* Add tests for strict-inference failures on fields.

This finalizes the "untyped / uninferred variables" cases.

strict-inference spec: https://github.com/dart-lang/language/blob/master/resources/type-system/strict-inference.md

Bug: https://github.com/dart-lang/sdk/issues/33749
Change-Id: I1d01ad15418be1891c95588132a44d478c5905a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112142
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:06:48 +00:00
Dan Rubel e2777454cc Fix dartfmt bug 
... by changing ANNOTATION_WITH_TYPE_ARGUMENTS to be a syntax error

Fix https://github.com/dart-lang/dart_style/issues/836

Change-Id: I2ac1b1105b817b6728ecc3d73875581a9cf65861
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:04:19 +00:00
Dan Rubel bb076a20c5 Fix unsupported initializer exception 
... and add a new ParserErrorCode.INVALID_INITIALIZER error code

Fix https://github.com/dart-lang/sdk/issues/37693

Change-Id: I0a30ad97f90aab35cd3af76d1546e1e78f1de2db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 19:55:12 +00:00
Brian Wilkerson ed69e2dc35 Add a hint if extension methods are used with an sdk version constraint that does not support them 
Also clean up some tests that were not correctly awaiting futures.

Change-Id: I646e24ec81edc3f2129ae8bacee5e0a0d0873981
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113272
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 17:44:52 +00:00
Brian Wilkerson e86ce41bcf Rename a hint code to be consistent with similar codes 
Change-Id: I916c97c2e3ef34f2cf8d613b2b192dcde96c87e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112740
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-12 16:29:05 +00:00
Brian Wilkerson c9126333ab Rename misleading error codes 
In all three cases, the if the element in question were not a const we'd
produce a different code, so "non-constant" is misleading.

Change-Id: If04fb4a91815612b47dd1357806bdfc2b047841b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-12 12:46:05 +00:00
Brian Wilkerson 1dbcf2445a Remove an unnecessary error code 
Change-Id: Idb57f172535cd1233c0ffa4b4ac254c990ba75e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112606
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-10 14:04:05 +00:00
Konstantin Shcheglov 9713ce16b9 Report EXTENSION_CONFLICTING_STATIC_AND_INSTANCE and DUPLICATE_DEFINITION for extensions. 
R=brianwilkerson@google.com

Change-Id: I237ee3edc6a2196693638c12c59d1530a1f15152
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112605
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-09 23:09:25 +00:00
Brian Wilkerson 77a957da1d Report the use of an extension override without an instance member access 
Change-Id: Ibd960aedd1739e4b446371349f0f4d4d6d5f6c61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-05 18:11:28 +00:00
Brian Wilkerson 57b9ce7fb7 Report when super is used in instance members of extensions 
Change-Id: I58370268e018d97c78667c900678e419af07e7ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111863
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-02 21:31:49 +00:00
Sam Rawlins 0451f598cc Warn about UI-as-Code features in const context with low SDK constraint 
Fixes #37675

Bug: https://github.com/dart-lang/sdk/issues/37675
Change-Id: I54bea3325cf2cf6b54fce20fe5e884f5416d96ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111362
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-07-31 15:19:04 +00:00
Konstantin Shcheglov dddd58b3d3 Report an error when extension declares a member with the same name as declared in Object. 
R=brianwilkerson@google.com

Change-Id: Ic344d3c3dfe291e7f10494897160a2ed4f6c108e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111140
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-30 16:59:30 +00:00
Konstantin Shcheglov 60725e7030 Report an error when 'covariant' is used in extension. 
R=brianwilkerson@google.com

Change-Id: I69e2d35bdc485448266706239e199911411f720f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-29 19:11:23 +00:00
Mike Fairhurst c27db7ce6f Preliminary work for INVALID_USE_OF_NEVER 
Change-Id: Ifa37cbc7a9c36c5713591d63e241ba388214d7d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109899
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-07-26 21:53:51 +00:00
Brian Wilkerson d2f1dde3c7 Merge two codes, improve some messages, and general code cleanup 
In retrospect I probably should have made this three separate CLs, and
I'm happy to go back and do so if you'd prefer.

Change-Id: I816bbbc16794c86129c9b6501db4a5dce2a8e199
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110480
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-26 18:25:21 +00:00