7db3b15a48
Update changelog for analysis_server_client 1.1.2
...
Change-Id: Ic38c7bf0bd4176f569dce201fe3e3ea9c0869438
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123885
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-11-01 16:59:32 +00:00
c0163f15a5
Add an optional port to the dartfix request to allow changes to be previewed
...
Change-Id: I6f7a8f880883195fd6558f5533f82da416c777bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-10-29 17:16:34 +00:00
a3ca5c3c54
[analysis_server] remove session id from connected params
...
Change-Id: I313d3f0b0c5df2148a3cbceddd4db54fecdc74a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122082
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-10-25 23:14:53 +00:00
dd83ded1e9
Add output directory field to dartfix API
...
Change-Id: Ia2dc3e4d3a458f43e9f2b0c1a25418f10931920c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117442
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2019-09-16 22:51:21 +00:00
a2e9af92d2
Protocol for 'server.log' notification.
...
R=brianwilkerson@google.com
Change-Id: Ifed9a0f04ee961b217643b7236fce7a0067664cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114607
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-29 22:33:33 +00:00
e5b0ff494b
Adding an offset field to TokenDetails to return token offset as part of listTokenDetails
...
Closes #38013
https://github.com/dart-lang/sdk/pull/38013
GitOrigin-RevId: f384b20a96950238a50a95420b264100de5bbbe4
Change-Id: Iabca2d4ac89f07424439ab5bba2156860aab2c81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114587
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Alex Bykov <abykov@google.com >
2019-08-27 17:52:38 +00:00
2b31e41564
Remove 'docComplete' and 'docSummary' from AvailableSuggestion.
...
They contribute to much size of available suggestions, and not
used in IntelliJ.
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/37816
Change-Id: I9c28020dc528980ee9efef3820c2acf679405ca2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-22 20:16:46 +00:00
f53388b50d
[analyzer] enable implicit-casts: false for several projects
...
Change-Id: Idd7ed77756d93a94f637dcc4abd7e0403a2f6d81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112703
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-13 16:26:41 +00:00
1c5911982e
add includePedanticFixes flag to dartfix protocol
...
Change-Id: I43c40eacf038beed6245ec873e746dcbb1ed80df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-05 20:18:05 +00:00
cdf6103b38
Support for free-form 'expression' in FlutterWidgetPropertyValue.
...
Also add ENUM_LIKE property editor, that is like ENUM, but allows
such free-form expressions.
R=brianwilkerson@google.com
Change-Id: I3910b6bea98110c192b6cc9fb716b73270e1d97c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111985
Reviewed-by: Jacob Richman <jacobr@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-05 18:43:29 +00:00
202379aaee
Implement getWidgetDescription and setPropertyValue in Flutter domain.
...
R=brianwilkerson@google.com
Change-Id: I45fdb0121bdd067856e5c9e72466d9a5c1a00e55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109313
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-16 21:32:37 +00:00
65f8cd4365
Start implementing widget properties.
...
Only self properties for now.
No compound properties.
No virtual Container properties.
R=brianwilkerson@google.com
Change-Id: Icd61f45ecc95c45037c3998a927eb267fd13c4cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-15 21:06:56 +00:00
f0b119c1b4
Add nameLocation/valueLocation to FlutterOutlineAttribute.
...
R=brianwilkerson@google.com
Change-Id: Ib73c5a01013516232f78f1ffa89bff005976e632
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109060
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-15 14:50:59 +00:00
a917043332
APIs for editing Flutter widget properties.
...
Change-Id: I602ea1a873f17a9bf47f1a77fb3af5b206464d6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108663
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jacob Richman <jacobr@google.com >
2019-07-11 20:38:24 +00:00
ad6b1ebbd6
Support for 'double' fields in protocol.
...
R=brianwilkerson@google.com
Change-Id: If8dacd4578e01380f4d9e4ce1f809b9485bffc7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-09 18:09:47 +00:00
8a1dcdae68
Graduate 'flutter' domain from experimental, remove unused methods and fields.
...
We could also remove FlutterCorrections, because right now we don't
use it, but we will restore it soon as we get new Flutter domain
methods.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I084fe5acbe5d854673c7247d734aeca1f8d721af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108364
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-08 22:03:24 +00:00
c41e9ae0e8
Fix wording in spec
...
Change-Id: I468d0afa21102fc6fe6f30aa1c7bd0d1c46d8f94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105464
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-10 17:24:35 +00:00
065c42705c
Added an errors field to allow permissive mode to display the exceptions that are being ignored
...
Change-Id: Id8fd27a7882c6dd20854d055477af25d17de3582
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105440
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-06-07 19:32:35 +00:00
37b714401d
Add AvailableSuggestion.declaringLibraryUri
...
We need this to support existingImports filtering, because filtering
is done on suggestion basis, not on the whole suggestion set basic,
because of re-exports.
R=brianwilkerson@google.com
Change-Id: Id97cb122fa6e3c5c62e367098e1917eba997a76f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104808
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-05 01:20:51 +00:00
519ddc1ac4
Document that AVAILABLE_SUGGESTION_SETS also turns on existingImports.
...
R=brianwilkerson@google.com
Change-Id: I053c68eb541358f0bbd891ca16f1c5628e701096
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-01 17:27:03 +00:00
03e415a4e8
Update the hover 'containingLibraryName' to not include the 'file:///' prefix.
...
This is a follow up on a comment in the previous change https://dart-review.googlesource.com/c/sdk/+/103481/ .
Change-Id: I0f377d6c7d68d55464a4e111a6a65715a82e0591
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103546
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2019-05-24 21:54:56 +00:00
4979a51a9c
Add information about existing imports to completion response.
...
This adds quite a lot of information though, because we send many
strings.
Before: 20686 characters.
After: 55345 characters.
Theoretically we could do better, and send information about existing
imports only once as well, so when the user continues typing in a
single file, without touching imports, we don't send any new data
about imports (maybe just a confirmation that it is still the same).
But I'm not sure if this is a worthwhile optimization.
Actually, even included suggestion sets have similar property - they
don't change for a given file, unless there are changes to other
libraries which we might want to include.
R=brianwilkerson@google.com
Change-Id: I2f55e2dc85508849146aa39eb279beabaec937c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103561
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-24 21:35:06 +00:00
cd2188f2f5
DAS change in hover behavior- the containingLibraryName now returns the URI of the containing library instead of the (possibly non-existent) library name
...
Change-Id: Ief2a7615b92ca635c696d48f907677bae538577b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103481
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-23 19:06:19 +00:00
8de23bbbff
Update the Dart Analaysis Server protocol to 1.26.1 to mark that the MOVE_FILE refactoring is now enabled. The functionality landed May 3rd, 2019 with https://dart-review.googlesource.com/c/sdk/+/101320
...
Change-Id: I7f33b73304a72db1375a6a21132dc8207cc784c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101630
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
2019-05-07 22:15:56 +00:00
7e28fc2cd6
Increment Analysis Server version to 1.26.0
...
R=brianwilkerson@google.com
Change-Id: I3121d8262bab8748fdd64a58178b7020607a2252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-04 21:02:33 +00:00
7e5810ab30
Add an offset to the protocol used for import-on-paste
...
Change-Id: I87c50b2fee7643733b38a368b2c231e5fb7cddda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-04 16:18:43 +00:00
da15746f4c
Update the production of training data
...
Change-Id: Ib9634c5e5bdd8c0097f55a9cf71054e2a2b6a5fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98287
Reviewed-by: Ari Aye <ariaye@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-03 22:36:01 +00:00
3a3731665f
Initial implementation of server support for training data
...
Change-Id: I4943b8c30575e78c1028d9d0be174f535db99303
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97841
Reviewed-by: Ari Aye <ariaye@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-03-26 20:32:20 +00:00
4b609422e9
Make AVAILABLE_SUGGESTION_SETS and related APIs non-experimental.
...
R=brianwilkerson@google.com
Change-Id: I1facae905319f050636126b021f56f353f81d6f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95661
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-03-07 21:29:36 +00:00
1c27b817fc
New protocol to inspect analysis server state at code completion time
...
This change adds a new, experimental completion domain request
`completion.listTokenDetails`. Its purpose is to allow
other programs to observe and make smarter decisions contingent
upon analyzer's internal knowledge of a Dart program.
Bug: 36083
Change-Id: I5ab477221efeac076eccc873a29cf6feae91052e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95100
Commit-Queue: Ari Aye <ariaye@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-03-04 20:33:44 +00:00
266ce73e28
Remove CompletionSuggestion.elementUri, replaced with AvailableSuggestionSet.
...
R=brianwilkerson@google.com
Context: https://github.com/JetBrains/intellij-plugins/pull/633#issuecomment-465725310
Change-Id: I03a1b7e7ec7cc0a5b0797dc960b72ca314a32132
Reviewed-on: https://dart-review.googlesource.com/c/93745
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-20 21:34:18 +00:00
4c1025493a
Enhance available suggestions protocol.
...
1. Rename includedSuggestionKinds -> includedElementKinds.
2. Add defaultArgumentListString and defaultArgumentListTextRanges.
R=brianwilkerson@google.com
Change-Id: I65c67252f6bad66c0c60a20315fd87affbeb653a
Reviewed-on: https://dart-review.googlesource.com/c/93560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-19 19:51:11 +00:00
0ef30fb86e
Protocol for IncludedSuggestionSet.displayUri.
...
R=brianwilkerson@google.com
Context: https://github.com/JetBrains/intellij-plugins/pull/633#issuecomment-464746341
Change-Id: I27339f4c9327adb761f2bb0ba326c318ce010383
Reviewed-on: https://dart-review.googlesource.com/c/93487
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-19 16:42:30 +00:00
b9bcfb4529
Change IncludedSuggestionRelevanceTag to using 'relevanceBoost'.
...
Sometimes there is no difference between 'relevance' and 'relevanceBoost',
for example for enum constants. But for primitive constants, there might
be multiple `double` constants, in different libraries with their own
different relevances. And it would be nice to keep relative relevances
of these libraries in primitive type constants.
R=brianwilkerson@google.com
Change-Id: I3641a4709e09f5c5dd979f5ca8df7b0235c708d2
Reviewed-on: https://dart-review.googlesource.com/c/92623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-11 20:10:29 +00:00
67c5923cce
Enhance protocol to allow changing relevance of individual suggesions.
...
R=brianwilkerson@google.com
Change-Id: I3f3d256fcdc4d41c527bbc03fb71800583a264f7
Reviewed-on: https://dart-review.googlesource.com/c/92382
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Ari Aye <ariaye@google.com >
2019-02-08 19:25:05 +00:00
6c680a0ebd
Update dartfix readme and update version numbers
...
* Update the readme to discuss required vs suggested fixes
* Remove the out-of-date options section from the readme
* Update dartfix and analysis_server_client versions and changelog
Change-Id: Ida4b30f9f89eb84a2fe856f61562ff73bf6725da
Reviewed-on: https://dart-review.googlesource.com/c/92153
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2019-02-07 01:16:56 +00:00
d236dca9d9
Add 'offset' to 'getSuggestionDetails'.
...
We need it to know if names in the syntactic scope will shadow
the requested name if unprefixed import is used.
R=brianwilkerson@google.com
Change-Id: I1fd28add9241b27795160c4705a80e0f8aa6c647
Reviewed-on: https://dart-review.googlesource.com/c/92022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-05 16:49:55 +00:00
d4b8e0696d
Add the capability in analysis server protocol for clients to express
...
interest in receiving not yet imported code completions from specific
packages and libraries.
The design of this interaction aims to avoid forcing analysis server
to send every public symbol from dependent packages at every completion.
Instead, clients express interest in certain packages and/or libraries
and analysis server will notify with the entire set of symbols for
each of them only once. Then it is the client's responsibility to save
these pre-computed completions in memory, and analysis server can
instruct the client on how to union them with the base set of completion
suggestions at code completion time.
Bug: https://github.com/dart-lang/sdk/issues/35680
Change-Id: I42c6fddc5d8daa2b546daa81456c0992e3ef547d
Reviewed-on: https://dart-review.googlesource.com/c/90125
Commit-Queue: Ari Aye <ariaye@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 19:56:18 +00:00
db44a727e5
Extend the edit.dartfix protocol
...
This CL extends the dartfix protocol to allow specifying which
fixes should be applied. In summary:
* includedFixes - list of fix names to be applied
* includeRequiredFixes - bool indicating required fixes should be applied
* excludedFixes - list of fix names that should not be applied
Given that the client can specify the fixes to be included/excluded,
then the dartfix cmdline help text should include the list of known fixes.
Rather than hard code this in the dartfix client, a new edit.getDartfix
request has been added to return the list of known fixes.
Change-Id: I319f6f405a5d29757bf28b70b778a449f901bbef
Reviewed-on: https://dart-review.googlesource.com/c/91700
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 01:53:32 +00:00
b767744cfc
Add optional elementUri field to CompletionSuggestion types in analysis server protocol
...
This will enable clients such as IntelliJ to display the package which code
completions are being offered from in addition to the keyword or identifier
that they're already getting from analysis server.
R=brianwilkerson@google.com
Change-Id: I30311451ad56b4eddbe73da20641ee0d14849293
Reviewed-on: https://dart-review.googlesource.com/c/88744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Ari Aye <ariaye@google.com >
2019-01-09 00:13:39 +00:00
a84863253c
Re-apply "Add AnalysisDriver.resetUriResolution() and use it for analysis.reanalyze request."
...
Original change's description:
> Add AnalysisDriver.resetUriResolution() and use it for analysis.reanalyze request.
>
> This CL changes "analysis.reanalyze" API. We decided to repurpose it. It was not
> used for some time now in IntelliJ, and AFAIK has never been used in VS Code.
>
> R=brianwilkerson@google.com , paulberry@google.com
>
> Change-Id: I7510b0189197c9f3f848b0fc59a7b2bd22889ac7
> Reviewed-on: https://dart-review.googlesource.com/c/85523
> Reviewed-by: Paul Berry <paulberry@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Change-Id: I828c9a77f1e28d44c00bfcf39527514e39cccc42
Reviewed-on: https://dart-review.googlesource.com/c/86221
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-12-06 23:14:28 +00:00
784ad29470
Update dartfix to check analysis server protocol version
...
This updates dartfix to more narrowly verify the analysis server
protocol version and print instructions for the user if the protocol
version expected by dartfix is incompatible with the current Dart SDK.
This is necessary because the edit.dartfix protocol is experimental
and will continue to evolve.
Change-Id: Ib31eb594a8a94416cb4fc676e7da9150f8c99b6a
Reviewed-on: https://dart-review.googlesource.com/c/84780
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-19 21:14:28 +00:00
e39fa29bd6
analysis_server_client API tweaks before publish
...
* Rename ClientListener to ServerListener
* Change ServerConnectionHandler on --> implements NotificationHandler
Change-Id: I459e4c566971d49790e12b8f1386ae80db33b38b
Reviewed-on: https://dart-review.googlesource.com/c/84560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-11-15 21:44:03 +00:00
23980a34a6
Fix a typo.
...
Change-Id: I3784a67987a5f4d56301c7ced9f9bcc31ff3fd03
Reviewed-on: https://dart-review.googlesource.com/c/84540
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-11-15 18:45:09 +00:00
bec2daba02
Cleanup analysis_server_client API
...
This reduces the client functionality and renames some
of the classes and methods in the API.
Specifically:
- rename Server to Client
- rename ServerConnectionHandler to ConnectionHandler
- rename Client.start to Client.startServer
- rename Client.stop to Client.stopServer
- rename Client.kill to Client.killServer
- extract behavior from Client into Listeners
- move some of the listeners into dartfix
- make several Client fields private
Change-Id: Ie71b0ac55b489099a848764251e8369c27f6ea2d
Reviewed-on: https://dart-review.googlesource.com/c/84460
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-15 15:06:55 +00:00
552b25084e
Generate NotificationHandler dartdoc and add server tests
...
Change-Id: Iec977015ae89e2a703e9013fb7b6969043554afc
Reviewed-on: https://dart-review.googlesource.com/c/84080
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-10 01:16:14 +00:00
aa8cc30e5c
Update ServerConnectionHandler to check the protocol version
...
... as well as reworking the example to use notification handlers and
addressing comments in https://dart-review.googlesource.com/c/sdk/+/83520
Change-Id: I27959cba79953d95d1afd851ab6a5f137dff47db
Reviewed-on: https://dart-review.googlesource.com/c/83580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-08 21:10:06 +00:00
d502ba6014
Add new analysis_server_client handlers
...
* Make the NotificationHandler a mixin
and move it to /lib/handlers
* Add new notification handler mixins
- AnalysisCompleteHandler
- ServerConnectedHandler
* Add Server.stop method
.. and address comments in
https://dart-review.googlesource.com/c/sdk/+/83180
Change-Id: I94ba657f20520ae4bb0e479a014c11509eeb9d2c
Reviewed-on: https://dart-review.googlesource.com/c/83520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-08 21:10:06 +00:00
7e6a39fd91
Generate analysis server notification handler
...
... and generate the analysis server protocol version
Change-Id: I585e50cc854d5ae1aa7440a14f856c983bbfc93a
Reviewed-on: https://dart-review.googlesource.com/c/83180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-11-06 23:04:53 +00:00
a074bcf93c
Update dartfix package for publication
...
Updates to dartfix for publication including:
* add changelog, readme, and license
* update pubspec version and executables
along with a collection of smaller changes including:
* test cleanup
* remove duplicate time value from verbose output
* read dartfix pubspec version and pass that to analysis server
Change-Id: Ifa94df45e6cbcf9a98f7bf393c22e06eaab48c38
Reviewed-on: https://dart-review.googlesource.com/c/82240
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-10-31 17:36:51 +00:00
Sam Rawlins