dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
68,020 Commits 2 Branches 0 Tags
b334ea832018822dfd0aa5e9debdd9a8be0f2c4e
Commit Graph

4418 Commits

Author SHA1 Message Date
Mike Fairhurst e68ca9b652 [analyzer] move crash reporting to server because telemetry isn't pulished 
Change-Id: I8fb293632267e7991c578076a43bfbd277fc1ee1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-07 22:19:07 +00:00
Konstantin Shcheglov cb0e5c5a3e Set operator== parameter type to dynamic if directly from Object. 
See https://github.com/dart-lang/language/issues/569

See https://github.com/dart-lang/sdk/issues/38339

Change-Id: I8d42135985aa4d55ffcc65cdf849572736cb9198
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124284
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-07 20:07:29 +00:00
Mike Fairhurst 5134490b78 [analysis_server] add crash reporting 
Change-Id: I8005e87f75eecb0e8320d6db124256c8c7c509d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123549
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-05 21:07:33 +00:00
Mike Fairhurst 1d774abeea [analysis_server] Remove old crash reporting 
Change-Id: Ib725b678dc0c9aa1ec0afec68d586690942c872b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-11-05 20:55:33 +00:00
Mike Fairhurst 7ba5584c2e [analysis_server] Fix outdated desin Service->Server, use Service->Logger. 
Also multiplex the service rather than the logger, so that we can
multiplex a crash reporting instrumentation service with a file logging
instrumentation service.

Change-Id: I7720c55e26225c27d2d9447a0156b2ca83da6598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122100
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-04 21:31:26 +00:00
Ari Aye 5bae0f23cf Increase completion model token lookback to 100 
In moving to a pointer mixture network from a traditional language
model I had initially decreased model lookback to 50 tokens to
facilitate faster model training iteration. Now that we've landed
on a configuration that works well, increasing lookback to 100 tokens
improves accuracy further.

I also went ahead and followed a recommendation from Jacob to
oversample Flutter sources since they're greatly underrrepresented
in our training corpus compared to our users' code at prediction time.

Change-Id: I885ddb606270394198f3aca2554e381f4465bdae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-11-04 18:00:16 +00:00
Brian Wilkerson f1fd342f71 Initial sketch of a preview site 
Change-Id: I83d8ced7ece839c06deb85968446ff15bc031af7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124020
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2019-11-04 16:59:26 +00:00
Sam Rawlins 9fd4d468b2 NNBD i13n: Temporary fix in order to migrate path package 
Change-Id: I72c003742b17cf75a553a89cf8772272de9aa9d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123881
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-01 15:34:52 +00:00
Johnni Winther 00c2962db8 [cfe+analyzer] Move messages, scanner and parser to package:_fe_analyzer_shared 
Change-Id: I4fa87aee65f30a9868a6cf8f0342591869ece7ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123663
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-11-01 09:37:57 +00:00
Mike Fairhurst 924ec34e01 Remove analysis logger, replace with calls to InstrumentationService 
Change-Id: Ifddd58b731aa0af8f76a91261757997dc52a9fc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123328
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-31 21:26:44 +00:00
Konstantin Shcheglov 84a8a2db33 Issue 39192. Fix codeLength / codeOffset, store it into the cached data. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39192
Change-Id: I17fe30839dd8a51c047103e028eea145ced1ec87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123689
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-31 20:03:58 +00:00
Brian Wilkerson f78e5463c9 Clean up server code to remove a lint 
Change-Id: Id7ccca9e2f11580c1a9263ad59c1f9279d89bada
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123740
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Ari Aye <ariaye@google.com>
 2019-10-31 16:42:33 +00:00
pq fde7cbf293 support type params in stateful widget conversion 
Open question:

Should we generate:

`class _MyWidgetState<T> extends State<MyWidget<T>>` ?

Fixes:  https://github.com/flutter/flutter-intellij/issues/4033


Change-Id: Ieffbb56d84a645f84661b2160eda14957c1539f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123507
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-30 23:13:55 +00:00
Konstantin Shcheglov fb362b54a7 Stop using FunctionTypeAliasElement.parameters/returnType in analyzer. 
The goal is to stop implementing FunctionTypedElement in
FunctionTypeAliasElement, and keep only TypeParameterizedElement.

For some time we will have to keep implementing TypeDefiningElement, it
is used currently as a marker for top-level declarations.

Change-Id: I0062aaa66861a4d7dd5337eb9a44338ad49f5901
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-30 21:36:33 +00:00
Brian Wilkerson f49713a1ee Improve display of non-migrated code 
Change-Id: I3eb0ff1099c453facfa911f81068852fbd13f535
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123485
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-29 22:48:31 +00:00
Brian Wilkerson 85f87f8589 Fix a cast exception in the FixProcessor 
Change-Id: Iad9b566c9a9acfe38dc7248630982abb249d8a82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123480
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-29 17:16:54 +00:00
Brian Wilkerson c0163f15a5 Add an optional port to the dartfix request to allow changes to be previewed 
Change-Id: I6f7a8f880883195fd6558f5533f82da416c777bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-29 17:16:34 +00:00
Konstantin Shcheglov b085f71a35 No need to create ConstructorMember for superType constructors. 
Change-Id: I945eb05d56957dae657a6d86b07642ff00196253
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123334
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-29 16:23:29 +00:00
Ari Aye 805989b7cd Use includedElementNames to choose between server and client suggestions 
In the case where model doesn't find a CompletionSuggestion or
IncludedSuggestionRelevanceTag we previously created both in case
the client was holding a matching token in its cache. Now we instead
apply a contains check to includedElementNames and will create
an IncludedSuggestionRelevanceTag if a token exists client-side.
Otherwise we will create a CompletionSuggestion.

Bug: https://github.com/dart-lang/sdk/issues/37797
Change-Id: I558734b65d38d8833c414a4c2cc584d0a6d15b28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-28 19:03:35 +00:00
Konstantin Shcheglov 32a9a5f181 Add '--enable-experiment' to DAS. 
Bug: https://github.com/dart-lang/sdk/issues/39103
Change-Id: I37e1897efd044143fd9c2c96611cfa38efc056c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-28 16:17:03 +00:00
Mike Fairhurst a3ca5c3c54 [analysis_server] remove session id from connected params 
Change-Id: I313d3f0b0c5df2148a3cbceddd4db54fecdc74a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122082
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-10-25 23:14:53 +00:00
Konstantin Shcheglov 567df45660 Issue 37797. Provide CompletionRanking with includedElementNames. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/37797
Change-Id: I9626147e360195de2cd71d73ebe68c157547298e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122962
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-25 19:07:37 +00:00
Konstantin Shcheglov 80b0aaf9b8 Deprecate FunctionTypeAliasElement.instantiate2(), replace with instantiate(). 
Change-Id: Iead94143fb3d02536309e464039493981cf853d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122965
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-25 14:38:50 +00:00
Ari Aye 5edeee8907 Transform hexadecimal numbers coming into model to <num> like we do for decimal numbers 
Not hugely important since hexadecimal usage is very low in Dart in general, but
this is consistent with the transformation we apply at training time.

Change-Id: I45875fd46cd172374acba14251a8d86264339c47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-24 21:45:07 +00:00
Ari Aye f2e2b3257b Fix code completion performance regression introduced by pointer mixture network 
Latency had grown to over 100ms and after this change we're consistently
under 100ms https://i.imgur.com/CCo0iQa.png. In addition, I was able to reduce
the number of isolates to two from four, lowering the memory footprint of model.

The biggest change is that we're moving from taking a map of size |V| = 100k
like {"foo" => 0.2, "bar" => 0.3} and sorting it to find the top n completions
to simply filtering / selecting lexemes with probability greater than a min
threshold (set for now to be a percent of a percent, 0.0001).

Change-Id: I721e6de343add6b8ebcf3ef4fad20f136302808e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122842
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-24 20:31:52 +00:00
Sam Rawlins bc5fb05def NNBD i13n: Highlight non-nullable types with upstream triggered edges 
Change-Id: I10fc2f731381ab60f0f724b2d463533895348500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122405
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-22 20:06:06 +00:00
Paul Berry 5d4cd6d589 Breaking changes for analyzer version 0.39. 
Change-Id: Ifa9ca24487f93f3eb0ec95eeb64f5bbb5aa32714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113216
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-21 18:23:10 +00:00
Konstantin Shcheglov cb9eefca4f Issue 142793249. Never remove directive with unresolved URIs. 
Bug: https://buganizer.corp.google.com/issues/142793249
Change-Id: I5ced1bcf4cb5d634f8e11555bb464f10c4bac68c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121926
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-18 17:06:50 +00:00
Devon Carew 21972daf7d [analyzer] refactor the flutter assists menu 
Change-Id: I6ecfa612b55aa755a5d56b2eac7d4f665954e5ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122025
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-18 00:15:46 +00:00
Sam Rawlins 8a92058226 Support omitted name args; fix as-expressions, refactor tests 
Fixes #38919

Change-Id: Ia302e7d56aa20ebd1d9b7afa8ceda249ba31015b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122021
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-17 20:19:46 +00:00
Konstantin Shcheglov 1c2dc77f64 Issue 38947. Support for then/else widgets in ConditionalExpression. 
Bug: https://github.com/dart-lang/sdk/issues/38947
Change-Id: Iec498eb9368d1090e8ba9e2221d00205df1ac746
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121925
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-17 17:49:16 +00:00
Sam Rawlins 680a880c10 Move string utils from services/correction to utilities; more generally used 
Change-Id: Idb81b54fe380e6af00af5ddee3977705ff58c741
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121912
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-17 15:04:00 +00:00
Sam Rawlins 8e7fa2a35b NNBD i13n: Proper messages for nullable values in collection literals 
Change-Id: I5eccfeb7d88f3f4adb57f3734f170dce82c1fd2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121906
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-17 03:41:11 +00:00
Devon Carew 68d398b392 [analyzer] add more diagnostics for ML completion 
Change-Id: I63263ff3b51a4986c55567456bdfebeb9f355a5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121882
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-16 22:56:51 +00:00
Sam Rawlins 3e992eb8fe NNBD i13n: Add line numbers to a few messages 
fixes #38920

Change-Id: I6656a2e47901cbe66ccbd040d3d2fe6913f7031a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121867
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-16 22:52:01 +00:00
Ari Aye 630100fb16 Don't allow ML to suggest punctuation by reference 
This change filters out any predictions for names that
are neither alphanumeric nor strings.

Change-Id: I515ca1263a05f234b263ab6d01cd41f80704ea3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121805
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2019-10-16 21:05:36 +00:00
Sam Rawlins 2cee751fb9 dartfix: Don't sort edits when using --outputDir; fixes #38924 
Change-Id: Id60264f6543fc9abff2180169dc363315d8e42a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121862
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-16 18:31:16 +00:00
Devon Carew e47ab49f0c [analyzer] add a diagnostics page for ml completion 
Change-Id: Iaddef290048be2246372ada03828c6f282e94efb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120900
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-16 15:46:43 +00:00
Sam Rawlins f1657ab934 NNBD i13n: Handle returned values in deeper expressions 
Change-Id: I109ce111f0e0eb9c2b172c9f86aa4e3cbda482c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121769
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-16 00:41:22 +00:00
Jaime Wren cf9c6134b8 Move consumerName(Request) from the analysis server generator to codegen_java.dart 
Change-Id: I864a02dbba609809420479d392071af43e7931c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121807
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
 2019-10-16 00:06:42 +00:00
Sam Rawlins 2e6695f6f9 NNBD i13n: Add line numbers 
Change-Id: Ifd81b3e99a3e8c0a1b1a0b6dbe29ad545f6e50f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121779
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-15 23:48:32 +00:00
Devon Carew 81679a2ab4 [analyzer] reduce the default number of times we repeat a benchmark 
Change-Id: Ie9a9b0d58464c6b78e3a707975fda773e043d403
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121804
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-15 22:52:56 +00:00
Sam Rawlins cfe25c7e95 NNBD i13n: Sort navigation links 
Change-Id: I32d21b26f3c813907308e9768a01a4cb9d45d1fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121768
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-15 22:37:08 +00:00
Ari Aye e642af52a5 Fix behavior of ML query construction 
This is one of the rare cases where the comment was correct
and the code was wrong. If we've typed class FooB^ then the
query should be ['class'] whereas typing void main(^ should
result in the query ['void', 'main', '('].

Change-Id: I5f53fa70c1ddfd1803e5697cdaaaf7d3b73f5ae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121778
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-15 22:33:25 +00:00
Ari Aye 95bd6a2888 Fix --completion-model flag 
Either setting --completion-model=/path/to/model/folder explicitly or
setting --enable-completion-model should turn on ML code completion.
This preserves the behavior that --no-enable-completion-model will
override --completion-model but fixes the bug where an omitted
--enable-completion-model flag will also override --completion-model.

Change-Id: I49a40a29c3444192e551fdcc4a51690f26969685
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121803
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-15 22:24:13 +00:00
Konstantin Shcheglov c5498891fc Don't suggest class member completions for ExtensionOverride targets. 
Change-Id: Ic3e2ef31cc42ccf4d16688050b894a50e5a8f51e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121765
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-15 20:58:29 +00:00
pq 5300ce4a2d ADD_DIAGNOSTIC_PROPERTY_REFERENCE assist 
Change-Id: I0acd3254eb309e95cce211612d6c1a11db5789bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121800
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-15 19:54:59 +00:00
pq 3e497dd00a diagnostic function field support 
See: https://github.com/dart-lang/sdk/issues/38633

Follow-up from: https://github.com/flutter/flutter/pull/42447#discussion_r335025065


Change-Id: Idd3cbc4b3419e792d6b81e02bd556b35faaef8c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121770
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-15 19:06:19 +00:00
Sam Rawlins 19e2f03421 NNBD i13n: Fix non-target reasons and add failing test for method return inheritance 
Change-Id: I3cee0c8972f1657abac89b1d9251ccc5e05d070f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121767
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-15 17:56:08 +00:00
Konstantin Shcheglov abecefd1ac Forward compatible portion of CL that does not set types for identifiers that are not expressions. 
The full CL:
https://dart-review.googlesource.com/c/sdk/+/119761

Change-Id: I9c909a4e1eec5d05f5718849ea45da79f01c5291
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121643
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-15 17:29:07 +00:00