dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
46,251 Commits 2 Branches 0 Tags
b00a85231e3926a983113801d6c19005cb0bfdca
Commit Graph

696 Commits

Author SHA1 Message Date
Stephen Adams 14c7c3c556 Redo "Refined types for most HtmlElement factory constructors" 
Fix: ShadowElement is not always present.

Original:
Committed: https://github.com/dart-lang/sdk/commit/b7b12b564a3e1811ccfca3e28fe30dde685f6633
Reverted:  https://github.com/dart-lang/sdk/commit/963df1e3e1a3bac0013d191d2b02898bbebefa9d

BUG=

Review-Url: https://codereview.chromium.org/2718713003 .
 2017-02-24 14:28:58 -08:00
Stephen Adams 963df1e3e1 Revert "Refined types for most HtmlElement factory constructors" 
Need to fix ShadowElement

TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2710323004 .
 2017-02-24 14:15:37 -08:00
Stephen Adams b7b12b564a Refined types for most HtmlElement factory constructors 
The body of new DivElement() is marked as returning a DivElement, instead of inferred to return Element.
The more precise receiver type allows svg polyfills to be excluded, allowsing the HtmlElement methods to be identified as the single target and inlined.

This tends to improve the code generated for idioms like

    new DivElement()..classes.add('foo')

    var e1 = new DivElement();
    e1.children.add(e2);

BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2705213003 .
 2017-02-24 11:23:06 -08:00
Alan Knight de05077537 Revert "Add Selection.toString() calling the native method" 
This reverts commit 01e6e00499.

BUG=

Review URL: https://codereview.chromium.org/2678593002 .
 2017-02-03 17:02:06 -08:00
Alan Knight 01e6e00499 Add Selection.toString() calling the native method 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2669103003 .
 2017-02-03 10:24:18 -08:00
Kulshekhar Kabra b42dbe524c Add documentation for a method (#28209) 
* Add documentation for a method

Adds docs for the `getPropertyValue` method of the `CssStyleDeclaration` class in the `html` package

* Remove unneeded extra line
 2017-01-16 09:18:27 +01:00
Terry Lucas 4b497fb319 Fixed checked mode error for resolvePackageUri. 
TBR=asiva@google.com

Review-Url: https://codereview.chromium.org/2626643003 .
 2017-01-10 09:00:16 -08:00
Terry Lucas 559ae993d1 Added VMLibraryHooks setup for Dartium to support resolvePackageUri. 
BUG=25594
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2611353002 .
 2017-01-10 07:25:10 -08:00
Harry Terkelsen 1d749a2fec record that Gamepad.buttons creates GamepadButtons 
This also extends the html generator to be able to generate List implementations with nullable element types

Fixes https://github.com/dart-lang/sdk/issues/27073

R=sra@google.com, terry@google.com

Review URL: https://codereview.chromium.org/2242203002 .
 2016-08-16 13:56:32 -07:00
Harry Terkelsen faaff39aa9 Record that MediaStream creates MediaStreamTracks 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2168473002 .
 2016-07-19 17:00:04 -07:00
William Hesse bde8d3efc6 Revert "Don't call _ensureRequestAnimationFrame in Dartium." 
This reverts commit bf8eeef6a0.

Revert "Fix animationFrameRequest for dartium."

This reverts commit 3daaf3849f.

BUG=https://github.com/dart-lang/sdk/issues/26906

Review URL: https://codereview.chromium.org/2159183003 .
 2016-07-19 13:56:36 +02:00
Alan Knight 30b489578d Revert "Reapply zone tasks." 
This reverts commit 6a7c037aa6.

BUG=

Review URL: https://codereview.chromium.org/2162643002 .
 2016-07-18 13:12:36 -07:00
Terry Lucas 2b1816c869 Added switch to disable generating cached_patches.dart file (Dartium only). 
The switch --no-cached-patches to be used by Dart enlistment (non-Dartium) and need to
re-gen the sdk/lib files using:

    ./go.sh --no-cached-patches

R=alanknight@google.com

Review URL: https://codereview.chromium.org/2154863002 .
 2016-07-18 05:45:33 -07:00
Alan Knight e610d803b1 Update test status for webgl extension tests, fix one typo in extension name 
BUG=

Review URL: https://codereview.chromium.org/2152393002 .
 2016-07-15 15:00:15 -07:00
Alan Knight b9316f9882 Recognize WEBGL extensions on Firefox (copy with regenerated files) 
Both of the following objects need to map to Dart type 'AngleInstancedArrays'

    [object ANGLEInstancedArrays]
    [object ANGLE_instanced_arrays]

Fixes https://github.com/dart-lang/sdk/issues/26850

BUG=

patch from issue 2147093002 at patchset 1 (http://crrev.com/2147093002#ps1)

R=sra@google.com

Review URL: https://codereview.chromium.org/2150003002 .
 2016-07-15 12:48:22 -07:00
Florian Loitsch 3daaf3849f Fix animationFrameRequest for dartium. 
Review URL: https://codereview.chromium.org/2124863002 .
 2016-07-05 19:22:27 +02:00
Florian Loitsch 6a7c037aa6 Reapply zone tasks. 
This reverts commit 34d3c37233.

Committed: https://github.com/dart-lang/sdk/commit/f746f8f77e93fd93cb4ff3b4ed644c96a432947a

R=lrn@google.com

Review URL: https://codereview.chromium.org/2119243002 .

Reverted: https://github.com/dart-lang/sdk/commit/dae392291595fa394d601d2d0baa77b66d85533f
 2016-07-05 17:33:09 +02:00
Florian Loitsch dae3922915 Revert "Reapply zone tasks." 
This reverts commit f746f8f77e.

Review URL: https://codereview.chromium.org/2123593002 .
 2016-07-04 21:58:15 +02:00
Florian Loitsch f746f8f77e Reapply zone tasks. 
This reverts commit 34d3c37233.

Review URL: https://codereview.chromium.org/2119243002 .
 2016-07-04 19:55:58 +02:00
Florian Loitsch 34d3c37233 Revert zone tasks. 
Revert "Add tasks to zones."

This reverts commit 85cccde717.

Revert "Make Dom events run through zone tasks."

This reverts commit 6d1f6b2af6.

Revert "Add zone task support for request-anim."

This reverts commit 726b9f8dc7.

Revert "Add zone task support to http-requests."

This reverts commit b40cfcb57f.

Revert "Update status file for jsshell."

This reverts commit 5e05ee9b5f.

Review URL: https://codereview.chromium.org/2120063002 .
 2016-07-01 22:36:52 -07:00
Florian Loitsch b40cfcb57f Add zone task support to http-requests. 
R=alanknight@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2042033002 .
 2016-07-01 19:44:19 -07:00
Jacob Richman fd58be1816 Add back in pure_interfaces list that turned out to still be needed. The checked in generated code matches this cl. 
BUG=

Review URL: https://codereview.chromium.org/2005143004 .
 2016-05-24 10:25:31 -07:00
Jacob Richman f26e522f84 Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1987073002 .
 2016-05-18 12:49:09 -07:00
Harry Terkelsen 1745ba77f5 fix all instances of "the the" 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1980573003 .
 2016-05-13 12:38:25 -07:00
Alan Knight 5542568adc Fix MouseEvent.movement to not use old webkit prefix 
BUG=

Review URL: https://codereview.chromium.org/1921823002 .
 2016-04-25 12:35:03 -07:00
Terry Lucas 8f7b8a9d87 Update to new Webkit additions for custom elements 
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1914643002 .
 2016-04-22 12:53:36 -07:00
Jacob Richman 819ed4bb60 Fix strong mode errors in SVG 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903893003 .
 2016-04-21 12:45:08 -07:00
Jacob Richman b546d05362 TBR. Add back fix to the misleading types for onError. Otherwise, html/worker_test/functional fails due to the browser itself throwing an event of type Error that is not an ErrorEvent. 
BUG=

Review URL: https://codereview.chromium.org/1908603002 .
 2016-04-20 10:41:56 -07:00
Jacob Richman 068252e721 Revert changes to event signatures as they broke one co19 test and this change isn't required due to relaxation in types in EventStreamProvider.dart 
BUG=

Review URL: https://codereview.chromium.org/1903033002 .
 2016-04-19 16:42:16 -07:00
Jacob Richman 864b64fd5e Strong html 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1894713002 .
 2016-04-19 15:08:45 -07:00
Alan Knight 810faa31b9 Don't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D) 
BUG=

Review URL: https://codereview.chromium.org/1885943002 .
 2016-04-16 16:26:14 -07:00
Terry Lucas 74ddf84ffd Remove MutationEvent bad entries in both removed list and renamed list 
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1890983002 .
 2016-04-14 13:49:42 -07:00
Alan Knight a718c8dac9 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 15:13:31 -07:00
Alan Knight 3fd7e32b65 Revert "Fix a few strong mode errors in dart:html" 
This reverts commit 65fe0a5383.

BUG=

Review URL: https://codereview.chromium.org/1879253004 .
 2016-04-13 14:56:42 -07:00
Alan Knight 65fe0a5383 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 14:41:10 -07:00
Jacob Richman 08c171d3e5 Revert "Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects."" 
Fix missing case that was breaking co19 tests.
This reverts commit 688eeb555c.

BUG=

Review URL: https://codereview.chromium.org/1883513004 .
 2016-04-12 17:16:06 -07:00
Jacob Richman 688eeb555c Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects." 
This reverts commit f382890e1a.
Reverting while tests are fixed.

BUG=

Review URL: https://codereview.chromium.org/1879093002 .
 2016-04-12 11:28:05 -07:00
Jacob Richman f382890e1a Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1873933002 .
 2016-04-12 10:23:32 -07:00
Terry Lucas c95b9875ef Fix registerElement for HTMLElement prototype should not change it's m_type 
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1857343002 .
 2016-04-05 11:59:28 -07:00
Jacob Richman 3cb280c5e1 Fast path Location.hash as some apps call it 10000+ times a frame. 
BUG=

Review URL: https://codereview.chromium.org/1847543003 .
 2016-03-31 09:04:10 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X. 
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
 2016-03-29 18:32:52 -07:00
Terry Lucas 10e70db01c Speed up interop patch file creation. 
Made a number of optimizations to reduce load time from 8 secs to 1 sec.  The changes involved:

- No longer dynamically generate patch files on startup for dart:* libraries (created from WebKits IDL e.g., html, svg, web_audio, web_gl, indexed_db, web_sql).  Instead create a cache of patch files.

- Comparison of @JS refelctedType not by library and symbol name comparison.

- In addition, a VM mirror change see CL https://codereview.chromium.org/1834673003/ gives us the remaining speedup.

This cache of interop patch files, for Dartium only, requires a manual re-gen after go.sh run is:

> cd tools/dom/scripts
> run go.sh

The steps after (for Dartium) are:

1.  build Dartium
2.  cd tools/dartium
3.  run generate_patches.sh
4.  build Dartium

R=jacobr@google.com, alanknight@google.com

Review URL: https://codereview.chromium.org/1833373002 .
 2016-03-28 08:20:13 -07:00
Alan Knight ab55f22334 Fix WebGL tex[Sub]Image2D/buffer[Sub]Data, restored Typed/Untyped aliases 
BUG=

Review URL: https://codereview.chromium.org/1831033002 .
 2016-03-24 10:20:11 -07:00
Alan Knight 4fe809c211 Add @creates annotation to VttCue members 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1811213002 .
 2016-03-18 07:35:35 -07:00
Alan Knight 051451d7e6 Trying to fix SQLResultSetRowList's subscript operator to do type conversion 
BUG=

Review URL: https://codereview.chromium.org/1779023002 .
 2016-03-09 14:02:30 -08:00
Terry Lucas af562187bc Chrome moved clipboardData from Event to ClipboardEvent for security clipboard can only be accessed during a onCut/onCopy/onPaste event. 
The polyfill class KeyEvent can no longer access clipboardData without listening for the cut, copy or paste event.

TBR=alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1775923002 .
 2016-03-08 05:24:02 -08:00
Terry Lucas 5c3728b067 Fix for KeyEvent,KeyboardEvent and UIEvent changes in roll 45 
TBR=jacobr@google.com,alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1754523006 .
 2016-03-07 07:51:50 -08:00
Terry Lucas a552c24089 Match version of idl_parser and WebCore so go.sh can be run from a Dart only enlistment. 
Needed to pull in the tools/idl_parser code for a Dart enlistment populated during a gclient sync.

Added .gitingore to not ignore tools/idl_parse

TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1768853002 .
 2016-03-06 15:10:36 -08:00
Terry Lucas c510dc9831 Fixed typedef used globally in IDLs 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1763063003 .
 2016-03-05 07:34:51 -08:00
Alan Knight 83e2e2dbb2 Change scripts to avoid generating things that bloat the compiled code 
BUG=

Review URL: https://codereview.chromium.org/1763213002 .
 2016-03-04 15:08:48 -08:00