Commit Graph

4414 Commits

Author SHA1 Message Date
Zachary Anderson b6bb2978e1 [Fuchsia] Build only the parts of the SDK that are needed
In particular, dart2js, dartdoc, and ddc aren't used.

R=johnmccutchan@google.com, pylaligand@google.com

Review-Url: https://codereview.chromium.org/2826793002 .
2017-04-19 09:00:14 -07:00
Martin Kustermann a7e6da3a93 Add support for core dump archiving on macos
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2815553003 .
2017-04-19 10:36:23 +02:00
Kevin Moore 040c4bfdcf Also updated dartium deps
follow-up from https://codereview.chromium.org/2824783002/
https://github.com/dart-lang/sdk/commit/fab7b0028ff19e94d75fd8af7e5feae08ad213dd

R=het@google.com

Review-Url: https://codereview.chromium.org/2821993002 .
2017-04-17 10:47:43 -07:00
Martin Kustermann 0de8c02b6c Try work around issues executing powershell scripts on windows on the bots
R=ricow@google.com

Review-Url: https://codereview.chromium.org/2817553005 .
2017-04-12 12:28:20 +02:00
Martin Kustermann a3e9cd8ff6 Attempt at capturing screenshot on IE if tests time out
The hypothesis is that a modal dialog from Internet Explorer causes
the currently running test to hang until test.dart kills the browser.

Capturing a screenshot might give an insight into there is a dialog showing up.

BUG=https://github.com/dart-lang/sdk/issues/28955
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2811093003 .
2017-04-12 10:57:58 +02:00
Ryan Macnak 442d59d30e Roll Dartium blink to "Stop passing removed flag 'background_finalization'."
Review-Url: https://codereview.chromium.org/2813973002 .
2017-04-11 13:22:06 -07:00
Erik Corry 782fbee690 Improve test script help output for --compiler
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2811973002 .
2017-04-11 14:54:51 +02:00
Johnni Winther 12615de38f Support dartk on Windows.
This adds tools/dartk_wrappers/dartk.bat. The --package argument is
deliberately relative because of issue 29284.

R=asgerf@google.com

Review-Url: https://codereview.chromium.org/2803973002 .
2017-04-07 09:31:10 +02:00
Zachary Anderson f1c7a22c43 [infra] Fixes for cross-toolchains
toolchain_prefix was not correctly propagated everywhere it needed to
go. This CL also adds an error to build.py if someone tries to use
--toolchain as it is not supported there.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2797303005 .
2017-04-06 15:03:26 -07:00
William Hesse ac23816bb7 Fix an error where html_test (which is usually null) is used without checking for null, when reporting status back to the test controller.
BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2804543004 .
2017-04-06 17:16:38 +02:00
William Hesse 87f38760e6 Add retry to test scripts' attempt to delete temporary Chrome config dirs.
BUG=https://github.com/dart-lang/sdk/issues/29282
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2803613005 .
2017-04-06 16:05:59 +02:00
Johnni Winther f4050f8739 Add find_timeouts and caching to tools/gardening
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2797253006 .
2017-04-06 12:07:40 +02:00
Erik Ernst 9af9943cf0 Refreshed tools/gardening/lib/src/shard_data.dart
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2801603006 .
2017-04-06 09:50:07 +02:00
William Hesse c3d4674a8c Remove unused call to discoverPackagesInRepository from test scripts.
Rewrite StandardTestSuite.forEachTest using async/await.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2793333002 .
2017-04-04 17:31:42 +02:00
William Hesse 801bf3a829 Update checked-in SDKs to 1.23.0-dev.11.3
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2791233002 .
2017-04-03 15:49:06 +02:00
Ryan Macnak 21e9a4fc65 Use -no_compact_unwind when creating dylibs on Mac.
Instructs the linker not to attempt generating _eh_frame from the DWARF info, avoiding warnings like

R=vegorov@google.com

ld: warning: could not create compact unwind for _kDartVmSnapshotInstructions: register saved more than once (might be shrink wrap)
Review-Url: https://codereview.chromium.org/2784253003 .
2017-03-31 13:37:09 -07:00
William Hesse 1d2b30b147 Start working on version 1.24 of the Dart SDK
BUG=
R=kasperl@google.com

Review-Url: https://codereview.chromium.org/2784183003 .
2017-03-30 12:36:07 +02:00
Vijay Menon 7a809bcc02 Add requirejs to repo for DDC
Fixes #29140

R=jakemac@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2782213002 .
2017-03-29 08:05:40 -07:00
Terry Lucas 074cae7681 Updated to latest WebKit change
TBR=whesse@google.com

Review-Url: https://codereview.chromium.org/2781633002 .
2017-03-27 11:14:26 -07:00
Dmitry Stefantsov 506667f068 Add the data on the rest of the buildbots to the gardening tool
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2764053002 .
2017-03-27 10:36:05 +02:00
William Hesse c8f5753845 Update checked-in SDKs to version 1.22.1
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2769693003 .
2017-03-22 16:41:58 +01:00
Martin Kustermann b40a9e8608 Add link to cit bug in the exception for coredumps
Review-Url: https://codereview.chromium.org/2769683002 .
2017-03-22 14:36:20 +01:00
Jacob Richman 88eb557b65 Fix warnings_checker.dart handling of multitests
Update all tests

Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com
BUG=

Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
2017-03-21 17:29:56 -07:00
Jacob Richman bf2b545150 Revert "Update all tests"
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
2017-03-21 16:33:18 -07:00
Jacob Richman 3c7353d987 Update all tests
Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2765693002 .
2017-03-21 12:39:28 -07:00
Ryan Macnak 25282fbf64 test.py: Push dart_precompiled_runtime and process_test once per device instead of once per test.
R=kustermann@google.com, vegorov@google.com

Review-Url: https://codereview.chromium.org/2750403006 .
2017-03-21 09:45:35 -07:00
William Hesse 2095fc382e Update name of content-shell flag --run-layout-test in test scripts
BUG=
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2768493002 .
2017-03-21 13:05:05 +01:00
Ryan Macnak 9c69417a41 Add support to test.py for running Android AOT with dylibs.
R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2754263003 .
2017-03-17 15:08:32 -07:00
Terry Lucas 9af5996380 Updated to match change in WebCore
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2761463003 .
2017-03-17 12:42:30 -07:00
Erik Ernst eb01590af4 Fixed bug: last entry was missing from shard_data.dart
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2759533003 .
2017-03-17 17:43:45 +01:00
Erik Ernst 4181dbee1e Script finding the build bot group for a given shard.
Helping to solve a silly little problem that I've experienced many
times: If you learn that there is a problem with a buildbot shard like
'dart2js-linux-drt-2-2-be' it may not be obvious that it should be
found on the buildbot status page (go/darto) in the group 'chrome'.
I didn't really know any other way than hovering the mouse over a few
dozen areas on that web page, hoping that one of them showed that
shard name as a tool tip.

This CL adds a small script, 'bin/shard2group.dart' to the 'gardening'
package, which will find the group from any given (partial) shard
name. For instance:

  > dart bin/shard2group.dart noopt                                                                                                                                                                                                                                                [16:00]
  vm-precomp(1): vm-noopt-simarm64-mac-be
  vm-precomp-dev(1): vm-noopt-simarm64-mac-dev
  vm-precomp-stable(1): vm-noopt-simarm64-mac-stable

The number indicates the placement of this shard in the group.

The script 'bin/create_shard_groups.dart' transforms the source code
for the buildbot web page to the source code for a Dart part file
which provides 'bin/shard2group.dart' with the concrete data on the
build bots and their shards.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2756193002 .
2017-03-17 16:19:12 +01:00
Florian Loitsch 7d8f3946a1 Add logdog support to gardening tools.
R=regis@google.com

Review-Url: https://codereview.chromium.org/2754123002 .
2017-03-16 19:52:18 +01:00
Kevin Moore 621b5f0796 structure gardening tool
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2751543006 .
2017-03-16 08:54:25 -07:00
pq 0eeb63b2ca Add kernel sources to the SDK (flutter#8812).
R=kmillikin@google.com, whesse@google.com

See: https://github.com/flutter/flutter/issues/8812
Review-Url: https://codereview.chromium.org/2756593002 .
2017-03-16 06:00:04 -07:00
Peter von der Ahé a228e0b2d7 Move deps file generation to fasta.
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2742333006 .
2017-03-15 15:42:22 +01:00
Johnni Winther fa8a35f439 Add status_summary and current_summary to tools/gardening
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2753513005 .
2017-03-15 15:32:56 +01:00
Johnni Winther a3b193db80 Add compare_failures gardening utility.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2711733005 .
2017-03-14 09:34:16 +01:00
Peter von der Ahé d1bdc9596d Improve detection of compile-time errors.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2739213004 .
2017-03-10 14:14:49 +01:00
John McCutchan 51f60482f9 Print a helpful error message when observatory_tool.py encounters an error
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2741803003 .
2017-03-09 15:43:43 -08:00
Kevin Moore 4b0384c899 Homebrew cleanup (#28899)
* basic cleanup to home-brew script
* avoid global variables
* Up a more typical package layout
* add generate binary – make it easy to test the output without dealing with git
* Update output to pass brew audit `brew audit --strict --online dart.rb`
2017-03-09 12:35:36 -08:00
Florian Schneider b7359ace36 test.dart: Cope with errors when locating the VS toolchain on Windows.
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2723263002 .
2017-03-09 12:35:08 -08:00
Peter von der Ahé 8608d1b436 Use correct types on cloned constructors in mixin applications.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2736103004 .
2017-03-09 12:52:00 +01:00
John McCutchan bffe527cfe Sanity check that 'localhost' can be resolved before building Observatory
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2738983002 .
2017-03-08 15:45:57 -08:00
Peter von der Ahé 2934dfaf16 Avoid crashing on function syntax.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2730093002 .
2017-03-07 16:54:09 +01:00
William Hesse b226f6c3c2 Remove mojo download from dartium DEPS
This step is causing failures on the buildbots, so if it isn't needed,
we can remove it.  The scripts try and use gsutil in an incorrect location,
and we can no longer manually copy it because the buildbots have started
automatically removing it.

BUG=https://github.com/dart-lang/sdk/issues/28248
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2724303004 .
2017-03-06 09:32:43 +01:00
Vyacheslav Egorov 021f933f69 VM: Make use_osr an Isolate flag, similar to how we made use_field_guards.
In Debug mode we have assertions checking that we don't attempt OSR when
FLAG_use_osr is disabled - however app-jit snapshots are compiled with OSR
enabled and still contain countining and OSR attempting code, which causes
assertions to fail.

Refactor how getters for isolate flags are defined, consolidate all flags into
a single list.

Update test expectations and switch -c dartk configuration to use app-jit snapshot.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2728163002 .
2017-03-03 19:02:23 +01:00
Vyacheslav Egorov 4f06bae505 patch_sdk.dart: Fix Windows build.
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2730913002 .
2017-03-03 15:19:28 +01:00
Vyacheslav Egorov c0c87b0afd GN: change the way we specify dependencies for the patched_sdk target.
Instead of listing all files as inputs in GN script using Python helper we make
patch_sdk.dart generate a depfile that Ninja can use:

            https://ninja-build.org/manual.html#_depfile

This prevents breakages when some dependencies are deleted and GN is not rerun.

R=ahe@google.com, kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2729503006 .
2017-03-03 14:52:51 +01:00
Martin Kustermann c00f2f0d00 Correct help message for --write-test-outcome-log
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2729153002 .
2017-03-03 11:28:16 +01:00
Peter von der Ahé 88a92f805a Move all main methods to tool/.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2722223006 .
2017-03-02 14:41:06 +01:00