Commit Graph

1883 Commits

Author SHA1 Message Date
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
William Hesse 011a5a6a66 Remove ie10 and opera sections from status files
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2783653002 .
2017-03-28 16:38:59 +02:00
Jacob Richman 14531fa62d Re-land "Format all multitests"
Only delta from the original is a bad merge of tests/corelib/list_test.dart

This reverts commit 44d8be0ed3.

BUG=

Review-Url: https://codereview.chromium.org/2774783002 .
2017-03-23 12:40:21 -07:00
Jacob Richman 44d8be0ed3 Revert "Format all multitests"
This reverts commit 312b66dd5f.

BUG=

Review-Url: https://codereview.chromium.org/2770063002 .
2017-03-23 10:49:40 -07:00
Jacob Richman 312b66dd5f Format all multitests
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2768073002 .
2017-03-23 10:26:44 -07:00
Jacob Richman 88eb557b65 Fix warnings_checker.dart handling of multitests
Update all tests

Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com
BUG=

Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
2017-03-21 17:29:56 -07:00
Jacob Richman bf2b545150 Revert "Update all tests"
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
2017-03-21 16:33:18 -07:00
Jacob Richman 3c7353d987 Update all tests
Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2765693002 .
2017-03-21 12:39:28 -07:00
Jacob Richman 6a7d6c385e Add comments
Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/2763823002 .
2017-03-20 21:03:12 -07:00
William Hesse 96ffa224bf Update status for co19 tests on Chrome 57.
BUG=https://github.com/dart-lang/sdk/issues/29055
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2743273003 .
2017-03-13 14:21:33 +01:00
Alan Knight 8d5015556e Update test status for Firefox 52/Issue 28983
BUG=

Review URL: https://codereview.chromium.org/2732963006 .
2017-03-07 16:52:28 -08:00
Asger Feldthaus 3a7529a363 Remove status file sections for the CPS IR.
BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d6c90a6b3d6d1be5095e12a0a633305e1d5db2a
Review-Url: https://codereview.chromium.org/2720513006 .
2017-02-28 17:11:19 +01:00
Asger Feldthaus e7b9672b3e Revert "Remove status file sections for the CPS IR."
This reverts commit 2d6c90a6b3.

BUG=

Review-Url: https://codereview.chromium.org/2720283002 .
2017-02-28 17:08:04 +01:00
Asger Feldthaus 2d6c90a6b3 Remove status file sections for the CPS IR.
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2720513006 .
2017-02-28 14:40:06 +01:00
Jens Johansen 849934f9bc Marking document_register_template_test as 'Pass, Slow'
I previously marked it as just "Slow" which apparently is not ok.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2704643003 .
2017-02-17 10:44:56 +01:00
Jens Johansen 6df4aed85c Trying to mark document_register_template_test as slow
BUG=
R=asgerf@google.com

Review-Url: https://codereview.chromium.org/2699813003 .
2017-02-17 08:16:35 +01:00
Brian Wilkerson 2ee2fe9b5c [Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2679553003 .
2017-02-06 13:26:39 -08:00
Jennifer Messerly 816592a941 fixes #28236, generic methods should not cause warnings in Dart 1
Instantiate universal functions in subtype tests & tear-offs. Also updates the status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2621433003 .
2017-01-09 12:46:20 -08:00
Asger Feldthaus 6d6df75271 Mark html/fileapi_test/entry as flaky on chrome.
Likely related issue: https://github.com/dart-lang/sdk/issues/20488

BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2615153003 .
2017-01-06 16:51:46 +01:00
Kevin Millikin e2ee86b3f7 Fix dart:typed_data runtimeType getters.
The proper way to override runtimeType in the VM is not to provide an
overriding getter in Dart code but to rely on Class::UserVisibleName.
This works both with optimizations and also with external typed data.

Closes https://github.com/dart-lang/sdk/issues/28183

BUG=
R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2610513004 .
2017-01-05 11:28:22 +01:00
Lasse R.H. Nielsen 44594277e1 Make core libraries use generic method syntax.
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/68818315b5cc6c63fea0e10e90f515f6083ec095
Committed: https://github.com/dart-lang/sdk/commit/3f74b8d82edca8c342c43306714e68ddf84548e1
Review-Url: https://codereview.chromium.org/2529393002 .
2017-01-03 12:05:40 +01:00
Kevin Millikin 96227c8bc3 Mark a Dartium test as failing
An HTML test has started failing due to a change in the VM's
implementation of typed data.

This is issue https://github.com/dart-lang/sdk/issues/28183.

R=kasperl@google.com
BUG=

Review-Url: https://codereview.chromium.org/2600483002 .
2016-12-22 12:30:01 +01:00
Jacob Richman 3659aaf181 Fix bug in Blob creation from workers.
Fixes https://github.com/dart-lang/sdk/issues/28155

BUG=

Review-Url: https://codereview.chromium.org/2592813003 .
2016-12-21 08:45:48 -08:00
William Hesse b5ec4b813c Update status for html/worker_api_test
BUG=https://github.com/dart-lang/sdk/issues/28155
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2588283003 .
2016-12-20 15:08:57 +01:00
Jacob Richman 7f26211c26 Correct handling of cross-frame functions in ddc.
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2587203002 .
2016-12-19 15:00:55 -08:00
Sigmund Cherem 0cb170488c Update failing chrome tests after chrome 55 roll (issue #27991), also update a
status comment.

Review URL: https://codereview.chromium.org/2557533002 .
2016-12-05 14:38:01 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'.
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
2016-12-01 16:47:33 -08:00
Sigmund Cherem 008da86c03 Support extending TemplateElement in IE11 + webcomponents-lite.js
Addresses issue reported in the polymer repo: https://github.com/dart-lang/polymer-dart/issues/682

R=jakemac@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2493703004 .
2016-11-14 07:32:09 -08:00
Stephen Adams f734606d0e Add native_testing library to mock @Native classes
Convert 114 tests to use native_testing.dart library.

Includes reviewed code from
https://codereview.chromium.org/2332953002/

Committed: https://github.com/dart-lang/sdk/commit/ddfc70f1640e5918216d1bd2b125d8d84d24c469

Review URL: https://codereview.chromium.org/2379173002 .

Reverted:  https://github.com/dart-lang/sdk/commit/74deaad759bfbacbdf55bd47e4f175a4c15ac571
2016-11-10 14:16:08 -08:00
Sigmund Cherem 3cdcaeda96 Fix browser test status.
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .

Committed: https://github.com/dart-lang/sdk/commit/940e498e1788c342f6a1bafbbda6b5983c7e070f
2016-10-18 12:50:58 -07:00
Sigmund Cherem 2200ee77f7 Revert "Fix browser test status."
This reverts commit 940e498e17.
2016-10-18 12:48:15 -07:00
Sigmund Cherem 940e498e17 Fix browser test status.
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .
2016-10-18 12:38:45 -07:00
Sigmund Cherem 997581ccec Fix custom elements in startup emitter
R=sra@google.com

Review URL: https://codereview.chromium.org/2424553002 .
2016-10-14 16:58:47 -07:00
Sigmund Cherem ee42a0a0aa Add js-interop support to the fast-startup emitter
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2420173002 .
2016-10-14 14:22:11 -07:00
Nicholas Shahan 2a51e46153 Copy new JS Interop test from dev_compiler test suite.
The test was added in the issue #2394103002.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2402163002 .
2016-10-12 10:15:34 -07:00
William Hesse 2512e5b340 Update status for windows ie11 and firefox tests
BUG=https://github.com/dart-lang/sdk/issues/27533
BUG=https://github.com/dart-lang/sdk/issues/27535
R=lrn@google.com

Review URL: https://codereview.chromium.org/2401803003 .
2016-10-07 15:15:52 +02:00
Stephen Adams 74deaad759 Revert "Add native_testing library to mock @Native classes"
Investigating failures.

BUG=

Review URL: https://codereview.chromium.org/2383273002 .
2016-09-30 13:27:09 -07:00
Stephen Adams ddfc70f164 Add native_testing library to mock @Native classes
Convert 114 tests to use native_testing.dart library.

Review URL: https://codereview.chromium.org/2379173002 .
2016-09-30 12:13:52 -07:00
Stephen Adams 8aba13e471 Add test for initialization of the native interceptor dispatch property.
R=het@google.com

Review URL: https://codereview.chromium.org/2360093002 .
2016-09-21 15:14:07 -07:00
Terry Lucas 79f406443d Update status for expected failures in Dartium.
TBR=whesse@google.com

Review URL: https://codereview.chromium.org/2341653005 .
2016-09-15 09:38:55 -07:00
Johnni Winther 7f4c3675aa Skip interop tests.
Review URL: https://codereview.chromium.org/2322913002 .
2016-09-08 09:22:25 +02:00
Johnni Winther 18d6c38ac6 Fix tests to avoid analyzer warnings.
Review URL: https://codereview.chromium.org/2320593002 .
2016-09-07 13:46:00 +02:00
Johnni Winther b358d062c2 Fix type masks for js-interop types.
Type-masks for js-interop types are replaced by `subtype/subclass of JavaScriptObject`.

Closes #24822

R=jacobr@google.com

Review URL: https://codereview.chromium.org/2307883002 .
2016-09-07 10:42:45 +02:00
Sigmund Cherem 342eb3f296 Additional status file fixes
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2283273002 .
2016-08-26 18:29:19 -07:00
Sigmund Cherem b84fff3e2e fix more more more
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2285893002 .
2016-08-26 14:34:09 -07:00
Sigmund Cherem 0594c91a8d Fix more errors due to custom element support
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2280203002 .
2016-08-26 14:18:50 -07:00
Sigmund Cherem 13a090a879 More status fixes
TBR=sra@google.com,het@google.com

Review URL: https://codereview.chromium.org/2280193002 .
2016-08-26 13:46:14 -07:00
Sigmund Cherem fbd56da2f0 Fix status files: js-interop in fast-startup, co19 test that appears to be fixed
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2280883003 .
2016-08-26 10:30:03 -07:00
Sigmund Cherem fc0bf7a85b First set of test triage for fast-startup
Review URL: https://codereview.chromium.org/2285823002 .
2016-08-26 10:04:41 -07:00
Lasse R.H. Nielsen a3a28f9e95 Remove deprecated Resource class from dart:core.
BUG=
R=floitsch@google.com, mit@google.com

Review URL: https://codereview.chromium.org/2272373002 .

Committed: https://github.com/dart-lang/sdk/commit/f61143153a9aee2738bf3bf83d447e016f41e653
Committed: https://github.com/dart-lang/sdk/commit/35437dda1f8b120d4b241a0a4925071a16f42442
Committed: https://github.com/dart-lang/sdk/commit/99ec987a0932920fd82c0fcf493d968e2996b8e7
2016-08-26 13:48:23 +02:00