2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
7399d4bdec
DBC follow up CL
...
- [x] Hoist handle out of loop.
- [x] Avoid allocating a handle.
BUG=
Review-Url: https://codereview.chromium.org/2819523003 .
2017-04-13 07:38:15 -07:00
588857cae3
Restore status line for non-dart2js compilers.
...
Review-Url: https://codereview.chromium.org/2802003002 .
2017-04-06 14:46:17 +02:00
4e65f5d759
Update status file with dart2js crash.
...
Review-Url: https://codereview.chromium.org/2798313002 .
2017-04-06 13:44:53 +02:00
d515791312
Handle bad packages files and #void without crashing.
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2804843003 .
2017-04-06 12:05:54 +02:00
c53e020e6c
Adjust status files to account for running the Dart test cases through flutter engine on linux.
...
Accounted for language, co19, lib, corelib, isolate and standalone tests.
Filed issues to track all failing tests
https://github.com/flutter/flutter/issues/9109
https://github.com/flutter/flutter/issues/9110
https://github.com/flutter/flutter/issues/9111
https://github.com/flutter/flutter/issues/9113
https://github.com/flutter/flutter/issues/9114
https://github.com/flutter/flutter/issues/9115
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2784293003 .
2017-04-03 16:35:09 -07:00
d8e291cb89
[kernel] vm: Fix a few issues in the kernel flow graph builder, update status file for checked-mode
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2792033002 .
2017-04-03 19:47:01 +02:00
4525b2451c
VM: Re-enable regexp/global_test
...
The corresponding performance issue has been fixed.
Fixes #21708 .
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2781283003 .
2017-03-30 16:02:58 -07:00
c6ef4c8dd9
Fix edge cases where a FormatException source argument starts with a newline.
...
Fixes #29195
BUG= http://dartbug.com/29195
R=eernst@google.com
Review-Url: https://codereview.chromium.org/2789523002 .
2017-03-30 15:17:38 +02:00
536c610fd2
Update status files for all test suites for -c dartk / -c dartkp configuration.
...
We are going to switch to testing all testsuites instead of just limiting ourselves to
co19 language kernel service
BUG=
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2780943004 .
2017-03-29 13:18:57 +02:00
011a5a6a66
Remove ie10 and opera sections from status files
...
BUG=
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2783653002 .
2017-03-28 16:38:59 +02:00
14531fa62d
Re-land "Format all multitests"
...
Only delta from the original is a bad merge of tests/corelib/list_test.dart
This reverts commit 44d8be0ed3https://codereview.chromium.org/2774783002 .
2017-03-23 12:40:21 -07:00
44d8be0ed3
Revert "Format all multitests"
...
This reverts commit 312b66dd5fhttps://codereview.chromium.org/2770063002 .
2017-03-23 10:49:40 -07:00
312b66dd5f
Format all multitests
...
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2768073002 .
2017-03-23 10:26:44 -07:00
88eb557b65
Fix warnings_checker.dart handling of multitests
...
Update all tests
Support //# multitests for better dartfmt compatibility and fewer multitest false positives
All files under tests were manually updated with
find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'
For now both old and new styles are allowed to accommodate CO19 tests.
R=efortuna@google.com
BUG=
Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
2017-03-21 17:29:56 -07:00
bf2b545150
Revert "Update all tests"
...
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
2017-03-21 16:33:18 -07:00
3c7353d987
Update all tests
...
Support //# multitests for better dartfmt compatibility and fewer multitest false positives
All files under tests were manually updated with
find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'
For now both old and new styles are allowed to accommodate CO19 tests.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2765693002 .
2017-03-21 12:39:28 -07:00
6a7d6c385e
Add comments
...
Add spaces to make sure dartfmt doesn't destroy bespoke indentation
BUG=
R=sra@google.com
Review-Url: https://codereview.chromium.org/2763823002 .
2017-03-20 21:03:12 -07:00
1cb1b70d5d
Update firefox status for Unicode 6.3 test
...
BUG=https://github.com/dart-lang/sdk/issues/28983
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2745303003 .
2017-03-14 14:39:37 +01:00
8cadbf4f72
Redo "Remove U+180E from whitespace in js_runtime and tests"
...
TBR=alanknight@google.com
BUG=
Review-Url: https://codereview.chromium.org/2747983003 .
2017-03-13 21:43:05 -07:00
66539fb493
Revert "Remove U+180E from whitespace in js_runtime and tests"
...
Several VM and browser status updates needed.
TBR=alanknight@google.com
BUG=
Review-Url: https://codereview.chromium.org/2748003002 .
2017-03-13 21:11:10 -07:00
c6a01283c1
Remove U+180E from whitespace in js_runtime and tests
...
BUG= https://github.com/dart-lang/sdk/issues/28983
R=alanknight@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2733353002 .
2017-03-13 20:18:19 -07:00
129f9dbb4c
Update status for ff + jsshell list_test
...
TBR=nweiz@google.com
BUG=
Review-Url: https://codereview.chromium.org/2744743002 .
2017-03-09 16:28:39 -08:00
8d5015556e
Update test status for Firefox 52/Issue 28983
...
BUG=
Review URL: https://codereview.chromium.org/2732963006 .
2017-03-07 16:52:28 -08:00
3a7529a363
Remove status file sections for the CPS IR.
...
BUG=
R=kmillikin@google.com
Committed: https://github.com/dart-lang/sdk/commit/2d6c90a6b3d6d1be5095e12a0a633305e1d5db2a
Review-Url: https://codereview.chromium.org/2720513006 .
2017-02-28 17:11:19 +01:00
e7b9672b3e
Revert "Remove status file sections for the CPS IR."
...
This reverts commit 2d6c90a6b3https://codereview.chromium.org/2720283002 .
2017-02-28 17:08:04 +01:00
2d6c90a6b3
Remove status file sections for the CPS IR.
...
BUG=
R=kmillikin@google.com
Review-Url: https://codereview.chromium.org/2720513006 .
2017-02-28 14:40:06 +01:00
dccdd1b981
Normalize UriData.parse result.
...
Validates base64 encoding, normalizes padding.
Normalizes non-base64 data using URI percent-escapes for all invalid characters.
Fixes issue #28728 , #28700
BUG= http://dartbug.com/28728 http://dartbug.com/28700
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2694373003 .
2017-02-17 11:02:38 +01:00
91796be231
Add mode to test.dart to run dart2js with kernel, and include initial set of
...
failures in status files
BUG=
R=efortuna@google.com , whesse@google.com
Review-Url: https://codereview.chromium.org/2688413004 .
2017-02-14 14:37:23 -08:00
cfe5e5f075
Include metadata in AOT to expand inline frames in stack traces and provide line numbers.
...
Also fix stack trace collection to always include invisible frames. It can happen that a visible function is inlined into an invisible function, and we don't expand inlined frames until we print a stack trace.
dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2687143005 .
2017-02-13 10:27:36 -08:00
8de3c35cc2
[Gardening] Mark a test as flaky on Dart2js. ( #28713 )
...
corelib/list_unmodifiable_test fails flakily on dart2js.
See #28712
2017-02-10 15:05:40 -08:00
d4a1e06892
Update URI related documentation and examples.
...
Adds a test for all the examples.
Fixes issues: #28659 , #28660 , #28661
BUG= http://dartbug.com/28659 , http://dartbug.com/28660 , http://dartbug.com/28661
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2679933002 .
2017-02-07 11:54:28 +01:00
2ee2fe9b5c
[Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean
...
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2679553003 .
2017-02-06 13:26:39 -08:00
dd561d513b
Add Uri.isScheme test function.
...
Allows checking the scheme of a URI against a known value.
Example: `uri.isScheme("http")`.
Has two advantages over `uri.scheme == "http"`:
* It's case insensitive, so you can do `uri.isScheme("HTTP")` as well, and
* for simple URIs, it doesn't need to allocate a new string.
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2664453003 .
2017-01-30 13:26:39 +01:00
dab2d0efb8
Fix invalid URIs generated using Uri constructor with clever paths.
...
Fixes issue #28359
BUG= http://dartbug.com/28359
R=floitsch@google.com
Committed: https://github.com/dart-lang/sdk/commit/d3a839fb84c744fb77bfff67d0d39df99cfa6404
Review-Url: https://codereview.chromium.org/2626013004 .
2017-01-16 09:16:06 +01:00
d3a839fb84
Fix invalid URIs generated using Uri constructor with clever paths.
...
Fixes issue #28359
BUG= http://dartbug.com/28359
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2626013004 .
2017-01-13 09:38:07 +01:00
bef4967ea1
Remove dart_noopt and related parts from the VM.
...
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.
Fixes #24569
Fixes #25726
Fixes #25845
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2624393002 .
2017-01-11 16:55:55 -08:00
dfde15a8be
Gardening: mark regexp pcre_test slow/timeout in precompiled code
...
This test seems to be slow in any configuration. There are old bugs,
e.g. 21593 and 22008 that mention the slowness and flakiness, but there
are no takers to either fix the regexp code or make the test smaller.
Note: in precompiled mode, the regular expression code is interpreted, and thus actually slower than in the JIT version of the test.
BUG=
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2624733005 .
2017-01-10 13:03:49 -08:00
dc0605012f
Move Null type to the Bottom in the VM ( fixes #28025 ).
...
Fix wrong comments.
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2608373002 .
2017-01-05 10:05:31 -08:00
59ffd06f15
Update status file.
...
Review-Url: https://codereview.chromium.org/2598183002 .
2016-12-23 11:51:28 +01:00
dd1a470dda
No luck at status-bingo
...
Review-Url: https://codereview.chromium.org/2600503002 .
2016-12-22 15:27:52 +01:00
f6b5361adb
Support for Null as bottom in dart2js
...
Closes #28026
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2595363002 .
2016-12-22 15:01:33 +01:00
0efa6cfda0
Revert "Update status"
...
This reverts commit 5fdc195aa1R=johnniwinter@google.com
BUG=
Review-Url: https://codereview.chromium.org/2592373002 .
2016-12-22 09:53:14 +01:00
5fdc195aa1
Update status
...
Review-Url: https://codereview.chromium.org/2594013002 .
2016-12-21 16:36:35 +01:00
c78814326c
Update jsshell to 50.0
...
R=sra@google.com
Review URL: https://codereview.chromium.org/2552123003 .
2016-12-06 16:58:15 -08:00
1ebeb79942
Remove runtime 'dart_app' as it became identical to 'vm'.
...
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.
Update status files to reflect these changes.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2541533004 .
2016-12-01 16:47:33 -08:00
e2a48dbf38
Update status for failing tests
...
BUG=https://github.com/dart-lang/sdk/issues/27925
R=eernst@google.com
Review URL: https://codereview.chromium.org/2536183002 .
2016-11-29 14:26:27 +01:00
6f7005ee71
Update status for co19 tests on browsers.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org/2538443002 .
2016-11-28 16:32:41 +01:00
7957a1c256
Make EfficientLength extend Iterable.
...
This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.
It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.
R=floitsch@google.com
Review URL: https://codereview.chromium.org/2467113003 .
Committed: https://github.com/dart-lang/sdk/commit/b08fb1373f88121bb4056adce9b71849a5bede2a
2016-11-28 08:04:04 +01:00
4bfe727db6
Update status for Firefox 50
...
BUG=https://github.com/dart-lang/sdk/issues/27873
BUG=https://github.com/dart-lang/sdk/issues/27872
BUG=https://github.com/dart-lang/sdk/issues/27871
BUG=https://github.com/dart-lang/sdk/issues/27867
R=sortie@google.com
Review URL: https://codereview.chromium.org/2526493004 .
2016-11-23 09:49:01 +01:00
Jacob Richman