dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
46,251 Commits 2 Branches 0 Tags
b00a85231e3926a983113801d6c19005cb0bfdca
Commit Graph

14566 Commits

Author SHA1 Message Date
Peter von der Ahé 8420947265 Update status file for debug mode. 
Review-Url: https://codereview.chromium.org/2828273002 .
 2017-04-20 13:15:12 +02:00
Peter von der Ahé 9356e3cd61 Check const constructors. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2799973003 .
 2017-04-20 10:55:58 +02:00
Peter von der Ahé e2eee219ac Complain about incorrect this/super constructor initializers. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2800083002 .
 2017-04-20 10:04:12 +02:00
Peter von der Ahé cf6b2736ec Wrap VariableDeclarations in Blocks as specified by Kernel. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2801283002 .
 2017-04-20 09:31:36 +02:00
Stephen Adams 6c75646b3e Revert "Remove JavaScriptBackend from ClosedWorldBase" 
TBR=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2828873002 .
 2017-04-19 12:55:14 -07:00
Sigmund Cherem 60964ab735 Fix 29264: remove access to the network on source-map unit test 
BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2824083002 .
 2017-04-19 08:47:36 -07:00
Florian Loitsch 74686b9f66 Update status file for dartk (for function_type tests) 
Review-Url: https://codereview.chromium.org/2827023002 .
 2017-04-19 16:19:41 +02:00
Florian Loitsch 1c355af468 Add generated function_type tests. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2707033004 .
 2017-04-19 15:56:47 +02:00
Peter von der Ahé 6bd0085ec1 Throw isn't a constant expression. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2801873008 .
 2017-04-19 15:55:05 +02:00
Peter von der Ahé e534a45cec Handle bad rethrows. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2802203002 .
 2017-04-19 15:17:10 +02:00
Peter von der Ahé ba0e07846f Produce a compile-time error if there's no main method. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2801853006 .
 2017-04-19 14:28:10 +02:00
Johnni Winther 7c58301eaf Hardwire kernel/visitor_test 
- to the set of tests moved from pkg/kernel/testcases to
pkg/fasta/testcases in https://codereview.chromium.org/2825063002

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2830583003 .
 2017-04-19 11:43:44 +02:00
Johnni Winther ee4b776108 Remove JavaScriptBackend from ClosedWorldBase 
Also extract more extract more methods from ClosedWorldImpl into
ClosedWorldBase.

This is a step towards creating a closed world object from kernel based
elements. This CL adds the first mock of that object.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2826673002 .
 2017-04-19 11:14:02 +02:00
Régis Crelier 4dd686e9df More work on finalization of recursive types (fixes #29357). 
Add regression test.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2822323002 .
 2017-04-18 17:18:39 -07:00
Jacob Richman b7995140f8 Revert "Fix #28740 demangle constructors in stack traces (A.A becomes new A)." 
This reverts commit a84b6b7f7b.

BUG=

Review-Url: https://codereview.chromium.org/2824323002 .
 2017-04-18 16:48:33 -07:00
Mike Fairhurst a84b6b7f7b Fix #28740 demangle constructors in stack traces (A.A becomes new A). 
Regular constructors and unnamed factory constructors:
- Were A.A, now are new A
Named constructors (including factory constructors):
- Were A.A.name, now are new A.name

BUG=
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2818933003 .
 2017-04-18 15:18:29 -07:00
Ryan Macnak b15cf1c490 Fix VM crash when encountering an assignment expression in a case expression. 
Fixes #29370
Issue #29379

R=regis@google.com

Review-Url: https://codereview.chromium.org/2825843003 .
 2017-04-18 13:48:06 -07:00
Siva Annamalai 96bbe512eb Fix for issue 29350 - VM Crashes when covariant is used incorrectly. 
BUG=#29350
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2827453003 .
 2017-04-18 11:10:28 -07:00
Vyacheslav Egorov 8f563f2c32 VM: Prohibit reload when throwing or processing language errors. 
This fixes flaky crashes on negative tests in stress reload mode: when
we attempt to reload an isolate while throwing/formatting compile time error.

Fixes https://github.com/dart-lang/sdk/issues/27835

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2825043002 .
 2017-04-18 18:51:49 +02:00
Johnni Winther e484e652e2 Remove Compiler/JavaScriptBackend from metadata_collector 
- and Compiler from type_test_registry.

The CodeEmitterTask was removed from the TypeRepresentationGenerator to
break a dependency cycle between the two. An Emitter is now provided as
an argument to TypeRepresentationGenerator methods instead.

This is a step towards passing data object to the codegen/emitter
instead of pulling data directly from Compiler/JavaScriptBackend. This
is needed to support an element model switch between codegen and
resolution.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2809203003 .
 2017-04-18 09:58:27 +02:00
Johnni Winther 9cff58233f Extract ClosedWorldRefiner implementation from ClosedWorldImpl to ClosedWorldBase 
- to make it reusable for kernel based elements.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2814973003 .
 2017-04-18 09:45:00 +02:00
Johnni Winther 5ccf530f62 Extract OrderedTypeSetBuilderBase from OrderedTypeSetBuilder 
- to make it reusable for kernel based elements.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2808763005 .
 2017-04-18 09:29:39 +02:00
Jacob Richman be6d22e015 Roll back files where the formatter made non-whitespace changes. 
This is due to a bug in how the formatter handled generic functions.
BUG=

Review-Url: https://codereview.chromium.org/2822103002 .
 2017-04-17 22:12:57 -07:00
Jacob Richman b280a7803d Dev compiler debugger related tweaks. 
Optimize dynamic call tracking using random sampling.
Apply source maps to improve dynamic call tracking accuracy.
Dynamic calls within the sdk are now attributed correctly.

Fix bug formatting modules where we were incorrectly flagging them as JS.

BUG=
R=jmesserly@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2811343002 .
 2017-04-17 14:57:31 -07:00
Jacob Richman 2dcd56ef43 Format all tests. 
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
 2017-04-17 14:53:02 -07:00
Konstantin Shcheglov 62320cc838 Issue 25558. Report an error, but don't crash when AST it too deep. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25558

Review-Url: https://codereview.chromium.org/2823993002 .
 2017-04-17 14:46:55 -07:00
Zachary Anderson 9ce608e89d [dart:io] Adds ProcessInfo.{max,current}Rss. Adds OS::MaxRSS on Fuchsia. 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2822943002 .
 2017-04-17 14:41:40 -07:00
Emily Fortuna 93a908fde0 Remove BackendClasses and JavaScriptBackendClasses. 
BUG=
R=johnniwinther@google.com, sra@google.com

Review-Url: https://codereview.chromium.org/2813093002 .
 2017-04-13 17:22:54 -07:00
Stephen Adams d15da7d900 dart2js: Capture typedef arguments once 
The type Map<T, Foo<Set<T>>> contains one type variable referenced twice,
so there are two inputs into the HTypeInfoExpression instruction.

If Foo is a typedef, T can be reused, e.g.

    typedef E Foo<E>(E a, E b);

As the typedef is expanded (to Function(Set<T>, Set<T>) => Set<T>) it
should not consume additional types from the to-level input.  We
prevent this by capturing the types and using the captured type
expressions inside the typedef expansion.

TODO: We should make the type subexpression Foo<...> be a second
HTypeInfoExpression, with Set<T> as its input (a third
HTypeInfoExpression). This would share all the Set<T> subexpressions
instead of duplicating them. This would require HTypeInfoExpression
inputs to correspond to type variables AND typedefs.

BUG= https://github.com/dart-lang/sdk/issues/28749
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2812393003 .
 2017-04-13 12:45:32 -07:00
Ben Konyi d7c55fb926 Updated status file to allow for RuntimeErrors in raw_synchronous_socket_tests temporarily while the cause of flakiness is found. 
BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2822523002 .
 2017-04-13 11:29:35 -07:00
John McCutchan 7399d4bdec DBC follow up CL 
- [x] Hoist handle out of loop.
- [x] Avoid allocating a handle.

BUG=

Review-Url: https://codereview.chromium.org/2819523003 .
 2017-04-13 07:38:15 -07:00
Ben Konyi cf6165c767 Fixed status file to not expect a raw_synchronous_socket_test crash on the analyzer bots. 
TBR=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2811363003 .
 2017-04-12 16:16:35 -07:00
John McCutchan 024ccd3095 Mark language/vm/optimized_stacktrace_test slow on reload bots 
BUG=

Review-Url: https://codereview.chromium.org/2814743008 .
 2017-04-12 15:15:11 -07:00
Ben Konyi 7549bc6b48 Added missing sync_socket_unsupported.cc and fixed issues in test which were causing analysis errors 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2814283002 .
 2017-04-12 15:13:10 -07:00
Ben Konyi 6fbdd19ddb Various fixes for sync socket implementation. 
Revert "Revert "Added sync_socket.h include in sync_socket_win.cc""

This reverts commit 2bd6168e1ebf35f6dbd9b2724339362c493377fc.

Revert "Revert "Added synchronous socket implementation to dart:io.""

This reverts commit a47bce03f5502dac7fb12e777e87b5aa1cfc830b.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2814773004 .
 2017-04-12 14:20:48 -07:00
Konstantin Shcheglov 54f845cfd2 Support for generic function as type arguments in DeclarationResolver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2814223002 .
 2017-04-12 13:47:23 -07:00
Regis Crelier 25dbc9b28a Fix look-ahead parsing code in the VM (fixes #29243). 
Add regression test.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2812323002 .
 2017-04-12 11:04:21 -07:00
Karl Klose 7b5010d440 [Gardening] Mark regress_29025_test as crashing in precompiled-debug 
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2817683002 .
 2017-04-12 16:12:13 +02:00
Johnni Winther 5c0566c476 Use entity WorldImpl where possible 
This is a step towards making WorldImpl reusable for kernel based elements.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2813853002 .
 2017-04-12 09:29:35 +02:00
Johnni Winther f900cf69b7 Use ClassEntity in ClassHierarchyNode 
This makes ClassSet/ClassHierachyNode reusable for kernel based elements.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2814663002 .
 2017-04-12 09:23:49 +02:00
Emily Fortuna 81dfc04a81 Don't duplicate switch case code if we fall through to the default case. 
BUG=https://github.com/dart-lang/sdk/issues/26900
R=sra@google.com

Review-Url: https://codereview.chromium.org/2810093002 .
 2017-04-11 16:28:51 -07:00
Ben Konyi b439bd9a54 Revert "Added synchronous socket implementation to dart:io." 
This reverts commit a1f87ebdb8.

Revert "Added sync_socket.h include in sync_socket_win.cc"

This reverts commit bdec13e865.

BUG=

Review-Url: https://codereview.chromium.org/2812153002 .
 2017-04-11 15:18:46 -07:00
Ben Konyi bdec13e865 Added sync_socket.h include in sync_socket_win.cc 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2809153003 .
 2017-04-11 15:14:35 -07:00
Stephen Adams 208c007650 Work-around for issue 29309 
BUG= https://github.com/dart-lang/sdk/issues/29309
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2815543003 .
 2017-04-11 15:08:44 -07:00
Ben Konyi a1f87ebdb8 Added synchronous socket implementation to dart:io. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2803543006 .
 2017-04-11 14:41:09 -07:00
Emily Fortuna 7697137485 Merge CommonElements and BackendHelpers! 
BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2814453005 .
 2017-04-11 14:32:54 -07:00
Regis Crelier 659511d518 Fix type parameter invocation in the VM (fixes #19725). 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2814833003 .
 2017-04-11 13:31:30 -07:00
Johnni Winther 4adfd9498b Mark preserve_uris_test as slow 
R=eernst@google.com

Review-Url: https://codereview.chromium.org/2809143002 .
 2017-04-11 12:22:06 +02:00
Johnni Winther ad52db16e0 Add kernel/closed_world2_test 
This is a step towared computing the closed world purely from kernel based elements.

The added test runs the resolution enqueuer on a kernel based world.
Some methods and classes are mocked and no closed world object is computed, yet.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2810633003 .
 2017-04-11 10:33:46 +02:00
Regis Crelier 54784f1cdc Fix bad status file modification. Tests are still failing in kernel debug mode. 
Review-Url: https://codereview.chromium.org/2806353004 .
 2017-04-10 14:50:00 -07:00