1975c8431a
Migrate async tests to strong
...
No modifications to the actual tests
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2802973005 .
2017-04-07 12:46:12 -07:00
4827ac4f38
Remove references to renamed test.
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2790893002 .
2017-04-04 09:51:29 +02:00
509bcd58e1
Fix type checks and display for JS interop types.
...
Re-enable formatter test that had been disabled when someone changed type
name display for Foo<dynamic> types.
Fix bug in how type names were displayed for JS interop types.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2789663005 .
2017-04-03 08:34:20 -07:00
46d6c56c96
Fix ddc async test code
...
Fortunately, not too many false passes.
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2792703002 .
2017-03-31 15:57:08 -07:00
466d4ffb9c
Add runtime tests for ignored checks
...
Tests for https://codereview.chromium.org/2788933002/
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2789933002 .
2017-03-31 13:31:59 -07:00
1c504f8945
Fix #28120 , strong mode allows field overrides
...
Fix #28119 , DDC supports field overrides without @virtual
Fix #28801 , devirtualize private fields in DDC where possible
Fix #28589 , stop supporting @virtual in strong mode
R=leafp@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2781443003 .
2017-03-28 10:26:36 -07:00
50ceaa4c04
Fix for #29003
...
This is an alternative to the other CL. It just uses the result of
dart.mixin instead of declaring a new class. That preserves the assumption (at least at runtime) that the mixin class directly inherits from Object.
We were also not declaring interfaces for ClassTypeAliases.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2783443002 .
2017-03-27 16:06:13 -07:00
ac68d598cf
Add patch code for List.filled growable param
...
Looks like a missing param doesn't break patch_sdk. I think this was a recent add.
Fixes #28508
R=jakemac@google.com , jmesserly@google.com
Review-Url: https://codereview.chromium.org/2771953004 .
2017-03-24 14:27:47 -07:00
27d14402fa
Skip test on chrome canary
...
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2770033004 .
2017-03-24 08:07:51 -07:00
dba842bcc8
Handle casts from Number to FutureOr<double>.
...
Fixes https://github.com/dart-lang/sdk/issues/29128 .
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2772573003 .
2017-03-23 13:33:33 -07:00
4d983162d5
Fix status for canary
...
This particular test seems to have frequent canary only errors. Not
sure there is a better way - e.g., alway ignore on Canary?
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2769873004 .
2017-03-23 10:21:32 -07:00
f021a7019b
fixes #27586 , prefer downwards context type in generic inference
...
fixes #27625 , Object constraints were not tracked in inference
fixes #27933 , pin return type from downwards inference
We now prefer to pick the bound (lower or upper) that had some information on, and it also improves inference error messages somewhat (still a ways to go).
The way this works is we now have a type representing an unknown type: ?. We use ? when performing downward inference steps, instead of `dynamic`. This allows more accurate tracking of type constraints.
For example: given:
var x = await Future.wait([a, b]);
Future.wait<T>'s argument type is Iterable<Future<T>>. Since we didn't know T, we previously pushed down Iterable<Future<dynamic>>. The dynamic caused loss of information. Now we push down Iterable<Future<?>>, allowing us to infer the right type there.
R=leafp@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2456803004 .
2017-03-17 16:59:56 -07:00
6cf2ac1f62
Fix FF test status and re-enable
...
With sra's num parse fixes and couple more, FF should be green again (as well as Chrome Canary).
R=alanknight@google.com
Review-Url: https://codereview.chromium.org/2750503009 .
2017-03-14 09:28:10 -07:00
f9cb23d2eb
Fix DDC status, take 2
...
They *do* pass on Chrome 59.
TBR=sra@google.com
Review-Url: https://codereview.chromium.org/2749853002 .
2017-03-14 07:35:29 -07:00
9c1a75bf34
Fix DDC status
...
These tests appear to pass on FF, but fail on Chrome.
TBR=sra@google.com
Review-Url: https://codereview.chromium.org/2748133002 .
2017-03-14 07:28:58 -07:00
406a82723f
Fix expectations
...
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2744853002 .
2017-03-10 08:53:08 -08:00
b4163fa8bb
Fix test expectation
...
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2739103003 .
2017-03-09 14:55:21 -08:00
402e025c63
Add option to suppress type-check whitelisting
...
Run most tests without the whitelisting.
See #27223
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2739863003 .
2017-03-08 17:51:32 -08:00
f6e964fca9
Fix dangling ddc references in libraries.dart
...
Our internal tooling is complaining about this when building / checking the ddc sdk. It appears to use the analyzer's summary builder tool which seems less forgiving about dangling references / missing files.
R=srawlins@google.com
Review-Url: https://codereview.chromium.org/2740573003 .
2017-03-07 15:27:46 -08:00
d5372c79ae
Bump timeout
...
This test seems to timeout often on travis lately.
TBR=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2731243003 .
2017-03-06 16:45:59 -08:00
2acb2eb669
Update for latest tests and sdk
...
TBR=leafp@google.com
Review-Url: https://codereview.chromium.org/2731333002 .
2017-03-06 09:36:14 -08:00
a6a206062d
Custom formatter cleanup Fix case where displaying a class constructor generated unreadable huge output. Fix case where exceptions were throw. Correct display of statics, fix indentation bugs. Add improved custom formatter test to main repro. As a drive by fix, switch hashCode to use a symbol instead of the name $identityHash as $identityHash was making custom formatter test output unstable.
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2703263002 .
2017-02-28 17:47:53 -08:00
fe294f3753
unfork DDC's copy of most SDK libraries
...
There's some changes in strong mode errors we may want to follow up on.
Unforks the following: async, collection, convert, core, developer, internal, io, isolate, math, mirrors.
Does not unfork: html, indexed_db, js, js_util, svg, typed_data, web_audio, web_gl, web_sql.
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2698353003 .
2017-02-28 17:10:52 -08:00
53971cb67e
Fix Function.apply
...
Fixes #27257 .
R=alanknight@google.com , jmesserly@google.com
Review-Url: https://codereview.chromium.org/2716583006 .
2017-02-24 19:24:48 -08:00
72b58ee3b6
Fix corelib_strong/sort_test on dev_compiler
...
BUG=
R=jacobr@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2683583009 .
2017-02-08 23:06:52 +01:00
5817ba47e2
fix #28642 , handling of top and bottom types in DDC
...
in particular: void, Null, and combinations with FutureOr<T>
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2671113002 .
2017-02-06 14:56:10 -08:00
c88a17ff55
Some test cleanup
...
These tests occasionally time out on travis. uri_test as well, but
there are two tests with that name, so I added code to disambiguate in
the logs.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2666593002 .
2017-01-31 10:23:26 -08:00
50ccf6d9b5
Fix DOM constructors in inline JS
...
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2659063002 .
2017-01-27 09:47:13 -08:00
fd94337b42
Fix for Animation and other polyfills
...
The polyfill code needs to run before dart_sdk is loaded. Otherwise, the registerExtension step on these types does not work.
Also fixes #27605
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2649613003 .
2017-01-25 16:18:49 -08:00
a91cc9cc9e
Use microtasks in dart.async
...
Not quite sure about this, but it makes ordering match for the example in #28509
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2653253002 .
2017-01-25 16:14:01 -08:00
d90ed8c295
Fix noSuchMethod handling of methods that are also extension methods. Fix noSuchMethod handling of methods with names that are rewritten in DDC e.g. "_get" instead of "[]" Fix some mirror system handling of symbols with names that are rewritten in DDC
...
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2623053004 .
2017-01-24 11:16:21 -08:00
a27adee736
Update tests for FF 51
...
A handful of tests started working in FF 51.
TBR=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2655673003 .
2017-01-24 08:32:17 -08:00
590a188066
Use "Object" as the reified type of covariant override parameters.
...
This ensures the runtime type is of the tear-off expression's static
type, even when accessed through a superclass.
I also moved the two tests into a subdirectory so they are easier to
find. (It is inscrutable to me why we would have a single directory
with 1,868 test files in it.) That involved enabling recursive
directory listing in codegen_test, which exposed a couple of things.
Fix #27484 .
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2641543003 .
2017-01-18 14:48:42 -08:00
5b34e47f40
Fix subtyping check on number
...
language_strong/null_is_test started failing on Konstantin's recent change. Another test started passing.
Does this fix make sense to you guys?
TBR=leafp@google.com ,scheglov@google.com
Review-Url: https://codereview.chromium.org/2638393004 .
2017-01-18 13:27:27 -08:00
21e1ebc3aa
Fixes to status
...
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2643793002 .
2017-01-18 06:16:56 -08:00
c83dac537f
Throw TypeError on arg mismatch
...
Improvement on #28286 - this is still not quite right as we'll throw a
TypeError instead of a NSM in certain cases depending on the order.
The spec will only throw a TypeError if NSM doesn't apply.
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2636313002 .
2017-01-17 16:26:22 -08:00
83f8ca4652
Fix status
...
See #27259
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2634303002 .
2017-01-17 06:01:04 -08:00
14cf17d898
Fix FF tests
...
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2638493002 .
2017-01-13 15:17:39 -08:00
1f5562e29c
More test refactoring to catch failures
...
Skip fewer tests. Many are now passing. Mark the rest as fail and test that they're still failing.
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2634433002 .
2017-01-13 09:02:45 -08:00
580186a655
Defend against false positives
...
If a seemingly non-async test returns a Future, wait on it. I noticed this on an earlier CL today related to the await_in_cascade_test - the test was broken, but we were falsely passing.
This still doesn't handle false negatives (e.g., tests that are expected to fail). That's why many of these are marked skip_fail. If the exception happens after main returns, we currently don't see it.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2629023002 .
2017-01-11 14:34:07 -08:00
be95523221
Cleanup references to the old DDC repo
...
Reachable issues migrated over.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2621543004 .
2017-01-10 12:56:29 -08:00
33c8f425b6
Disable auto "debugger" call for tests
...
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2621823002 .
2017-01-09 15:42:42 -08:00
93fb5d8119
Fix cross-window JS interop on FireFox.
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2610813003 .
2017-01-04 14:15:20 -08:00
77cd33722b
Mark test failing on FF
...
Jacob: looks like you changed the test just before the holidays?
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2610843002 .
2017-01-04 05:53:57 -08:00
dca3e74882
blob_constructor_test is passing now.
...
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2598853002 .
2016-12-21 17:11:22 -08:00
7f26211c26
Correct handling of cross-frame functions in ddc.
...
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197 )
BUG=
R=alanknight@google.com , leafp@google.com , rnystrom@google.com
Review-Url: https://codereview.chromium.org/2587203002 .
2016-12-19 15:00:55 -08:00
77f53f609f
fixes #27385 , implement virtual fields in DDC
...
If a field is marked @virtual in Analyzer, DDC will allow it to be overridden as well
also fixes #28114 , abstract getters/setters broke generation of forwarding getters/setters
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2571363002 .
2016-12-15 11:39:25 -08:00
392c242df9
Add dart:io stubs to ddc sdk, define dart.library.html
...
Fixes #27302
R=brianwilkerson@google.com , jmesserly@google.com , rnystrom@google.com
Review-Url: https://codereview.chromium.org/2578573003 .
2016-12-14 12:34:33 -08:00
94e4a98671
Migrate tests for initializing formals
...
BUG=#27894
R=eernst@google.com
Review URL: https://codereview.chromium.org/2534293002 .
2016-12-07 10:58:02 -08:00
69f0218802
Mark test pass on Chrome 55
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/2554523002 .
2016-12-05 05:55:44 -08:00
Vijay Menon