dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
46,251 Commits 2 Branches 0 Tags
b00a85231e3926a983113801d6c19005cb0bfdca
Commit Graph

2445 Commits

Author SHA1 Message Date
Brian Wilkerson ba3ed4ba37 Initial support for getting fixes from plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830863002 .
 2017-04-19 15:00:00 -07:00
Steve Messick 0829174516 Complete for-each and switch statements 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2826283002 .
 2017-04-19 14:44:41 -07:00
Konstantin Shcheglov 91d6dcf9fb We cannot use relative URIs to reference files outside of a package. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2830733002 .
 2017-04-19 10:09:14 -07:00
Erik Corry 23c0caf4dc Revert "New Lint quick-fix: prefer_collection_literals (#29378)" 
This reverts commit 6a56c86c81.
This a gardener revert to fix buildbot redness.

R=karlklose@google.com, loitsch@google.com
TBR=casanueva@google.com
BUG=

Review-Url: https://codereview.chromium.org/2827863003 .
 2017-04-19 12:49:07 +02:00
jpaulsen 6a56c86c81 New Lint quick-fix: prefer_collection_literals (#29378) 2017-04-18 18:55:08 -07:00
Steve Messick 6a19d96ee2 Complete for-statement 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2824233002 .
 2017-04-18 15:20:31 -07:00
jpaulsen c386e41f25 New Lint quick-fix: avoid_init_to_null (#29367) 2017-04-18 14:13:53 -07:00
Konstantin Shcheglov 62320cc838 Issue 25558. Report an error, but don't crash when AST it too deep. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25558

Review-Url: https://codereview.chromium.org/2823993002 .
 2017-04-17 14:46:55 -07:00
Devon Carew d02519aec4 Make the analysis server integration tests driver only. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2820893002 .
 2017-04-17 11:23:38 -07:00
Steve Messick b9f9ad24f1 Add completion for do-stmt, refactor for reuse 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2816943005 .
 2017-04-17 10:56:26 -07:00
Konstantin Shcheglov 124f874b4a Make copy of the drivers list in SearchEngineImpl2 to avoid ConcurrentModificationError. 
I think this happens when a driver is disposed why search is in
progress. So, we need to make defensive copies.

This also makes me realize that we don't handle situations when
a driver instance is disposed, but it has pending requests, such as
getResult(), getIndex(), etc - actually any getXXX(), and search. As
it is now, I think we just leave these Future(s) and they never
complete.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2818163003 .
 2017-04-17 09:41:52 -07:00
Devon Carew eb1839b8fd Minor changes to the generated spec, and display deprecated methods better. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2800283002 .
 2017-04-15 13:43:36 -07:00
Mike Fairhurst d55dc29727 Temp fix to allow plugins to serve the getErrors APIs. 
Had to allow a means of supplementing existing errors/line info, but
then also for where dart has no response whatsoever (like html), need a
way to provide analysis options and line info in addition to errors.

Happy to clean it up, but also not very motivated to make it perfect
since it should be temporary.

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2815643004 .
 2017-04-13 10:37:39 -07:00
Brian Wilkerson 3dcf0e31c5 Split error code to ease future improvements 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2813553006 .
 2017-04-11 13:35:38 -07:00
Konstantin Shcheglov 6fe8e2278b Simplify PackageMapUriResolver - one folder, return any file, or null. 
If the package is know, we return the corresponding file, whether it
exists or not.

If the package is not know, there is no valid Source to resolve to,
so we return null.

We don't need all the features that existed.

Internally we switched to BazelPackageUriResolver, which has its own
logica for searching files in workspaces across multiple folders.

All the places where we create PackageMapUriResolver in analyzer
or analysis_server, we create it with exactly one folder.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2812093002 .
 2017-04-11 13:03:56 -07:00
Brian Wilkerson 4cf6da3a9f More enhancements to ChangeBuilder 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2809943002 .
 2017-04-11 12:15:30 -07:00
Steve Messick 3406c4c1be Fix renaming that got dropped 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2812733002 .
 2017-04-11 09:52:51 -07:00
Konstantin Shcheglov 3e9d358131 Add missing checks for null imported/exportedLibraries. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2812673002 .
 2017-04-10 11:29:38 -07:00
Konstantin Shcheglov 3be10faaee Issue 29303. Prefer import updates and SDK imports over other imports. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29303

Review-Url: https://codereview.chromium.org/2808803003 .
 2017-04-10 09:52:43 -07:00
Devon Carew fb4828d2e1 Add integration tests for edit.getAssists and edit.getFixes. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2812483002 .
 2017-04-10 07:50:12 -07:00
Devon Carew 9a852506c6 Tweaks to the analysis server --help output. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2810553002 .
 2017-04-10 07:06:19 -07:00
Devon Carew e572bf93ec Add 4 integration tests for the analysis domain. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2808623002 .
 2017-04-08 20:56:00 -07:00
Steve Messick eadc6af226 Statement completion framework with a few examples 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2803313002 .
 2017-04-07 13:55:50 -07:00
Dan Rubel 46b0c1da56 merge fasta.Keyword into analyzer.Keyword 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2797133008 .
 2017-04-06 16:52:01 -04:00
Dan Rubel 99aefce48c do not allow built-in keywords to specified when refactoring 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2802433002 .
 2017-04-04 17:13:42 -04:00
Brian Wilkerson 3c234a72c2 Update failing tests (TBR) 
Review-Url: https://codereview.chromium.org/2793123002 .
 2017-04-03 11:26:45 -07:00
Brian Wilkerson 0ea61b64ab Bug fixes and added support for creating source edits 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2790173003 .
 2017-04-03 10:56:41 -07:00
Brian Wilkerson dd49e79f74 Add context information to driver and add hooks for plugin management 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2795743002 .
 2017-04-03 10:13:45 -07:00
Lasse Reichstein Holst Nielsen d4c1531b5b Use the *correct* type for the fix to analysis_server/test/mocks.dart. 
It's a stream, not an iterable, so the return type is a Future.

Review-Url: https://codereview.chromium.org/2784363003 .
 2017-03-31 16:36:24 +02:00
Lasse R.H. Nielsen 83298690b0 Fix static typing problem in analysis_server tests. 
After changing argument of `Future` constructor to be `()->FutureOr<T>`,
the `()->Future<dynamic>` argument didn't work.
Problem compounded by return type of `Stream<T>.firstWhere` being `dynamic`.

R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2794503002 .
 2017-03-31 14:12:32 +02:00
Steve Messick 543d0dc20e Update coverage testing 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2780393004 .
 2017-03-30 11:15:55 -07:00
Steve Messick 4a2cca3a52 Add getStatementCompletion to the API spec 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2784673003 .
 2017-03-30 10:13:21 -07:00
Steve Messick 56afa1abb0 Add experimental attribute to requests (recreated due to git failure) 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2787013002 .
 2017-03-30 10:10:43 -07:00
Devon Carew 394a106074 Remove unused imports. 
BUG=
R=danrubel@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2786553002 .
 2017-03-29 07:10:44 -07:00
Konstantin Shcheglov 483066a697 Fix for Quick Fix to import SDK classes. 
It's not 100% replacement, we handle SDK libraries just as any other
library, if it has not been imported yet somewhere, we don't know
about it. But probably this covers the most often case of using a
library in a new file of the project that already uses this SDK
library.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2781963002 .
 2017-03-28 14:15:52 -07:00
Brian Wilkerson 84f2f4a677 Enhance the change builders 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2776233002 .
 2017-03-28 08:29:30 -07:00
pq 5a237935f0 Fix tests to verify defaultArgListString specified as null are null. 
* introduces a sentinel default value to ensure that we know when asserting if `null` was specified or the result of an excluded optional arg

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2769223004 .
 2017-03-24 11:53:00 -07:00
pq 4a9cabf493 Arglist children: default value gen fixes. 
* fixed arglist codegen (include params)
* fixed defaultTextRange generation (and added tests)
* cleanup (followup from https://codereview.chromium.org/2768273003/

R=brianwilkerson@google.com, danrubel@google.com

See: https://github.com/flutter/flutter-intellij/issues/832
Review-Url: https://codereview.chromium.org/2771123002 .
 2017-03-24 09:36:24 -07:00
pq 6f846bcd53 <Widget> boilerplate for Flutter children: suggestions. 
Cleanup (tracked in TODOs) and consolidation to follow.

R=brianwilkerson@google.com, danrubel@google.com

See: https://github.com/flutter/flutter-intellij/issues/832
Review-Url: https://codereview.chromium.org/2768273003 .
 2017-03-23 15:20:42 -07:00
Brian Wilkerson d3c926b089 Fix errors in analyzer 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2772473004 .
 2017-03-23 11:26:49 -07:00
Brian Wilkerson 61d5c85b48 Allow navigation from var when there is an inferred type (issue 29091) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2769813005 .
 2017-03-23 10:34:09 -07:00
pq 03398561a1 IdeOptions awareness for Driver (for access via IDEA registry). 
R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2768003003 .
 2017-03-23 09:33:37 -07:00
pq df06af12eb Completion boilerplate for Flutter cons children (flutter-intellij#463) 
* plumbs IDE options into completion requests
* simple POC test

More tests and a bit of cleanup to come.

R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2771653002 .
 2017-03-22 15:14:28 -07:00
Florian Loitsch cd826a144c Fix typing in analyzer. 
Review-Url: https://codereview.chromium.org/2764413002 .
 2017-03-22 19:01:54 +01:00
Devon Carew a231501692 Format generated files. 
BUG=
R=brianwilkerson@google.com, jacobr@google.com

Review-Url: https://codereview.chromium.org/2765953002 .
 2017-03-21 15:54:16 -07:00
pq d95508183d Introducing IdeOptions. 
* add simple `IdeOptions` class
* remove unused `ServerOptions`

R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2765063002 .
 2017-03-21 14:48:27 -07:00
Brian Wilkerson 9a66373ee9 Fix errors and warnings 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2760993002 .
 2017-03-20 11:30:32 -07:00
Brian Wilkerson c56210c294 Create a new element for generic function types 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2758123002 .
 2017-03-19 10:45:50 -07:00
Steve Messick 221125d1ac Add quick-fix to convert child: to children: 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2753123003 .
 2017-03-17 14:49:42 -07:00
Mike Fairhurst 319b726f8b Guard analysis server's getAnalysisResult, must be dart 
Otherwise spews errors inside html files when users do things like
autocomplete in the middle of them.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2755023002 .
 2017-03-17 10:42:00 -07:00