Commit Graph

144 Commits

Author SHA1 Message Date
scheglov@google.com c74b350b50 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//489173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39416 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-20 18:18:43 +00:00
brianwilkerson@google.com 90a5272601 Add flags for proposed features
R=scheglov@google.com

Review URL: https://codereview.chromium.org//481273003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39372 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-19 16:02:46 +00:00
scheglov@google.com a12312f39f Improve formatting of variable declarations/assignments.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//477373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39320 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-17 20:24:07 +00:00
scheglov@google.com c8e533be3a Tweak for formatting constructor initializers.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//474363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39313 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 21:12:36 +00:00
scheglov@google.com f127b725e9 Test for JavaFile.toURI().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//479593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39300 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 16:28:03 +00:00
scheglov@google.com 7af986dcd1 Issue 20520. JavaFile.toURI() should use absolute path.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20520

Review URL: https://codereview.chromium.org//471053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39260 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 18:22:28 +00:00
scheglov@google.com de7d21f38c New analyzer snapshot, add format/formatList.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//475543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39222 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 21:51:47 +00:00
scheglov@google.com 9e3aa826dc New analyzer snapshot.
Basically it includes all the code that was not translated before.

Includes new library: element_handle, but it should not be used because of WeakReference absence in Dart.
Includes new test: engine_test, but it has too much code requirering manual tweaks, after we will stop translating.
All other tests are in all_the_rest.dart, again to be moved into corresponding libraries and cleaned up later.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//459703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39091 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 15:41:37 +00:00
scheglov@google.com 0f041852a6 Fix for opening SDK sources.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//449583003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38955 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 22:13:28 +00:00
scheglov@google.com c5263aae9f Breaking changes in 'analyzer' package.
1. Source.uri added.

2. DartSdk.fromEncoding() replaced with fromFileUri().

  This CL cannot be committed as is until pkg/code_transformers is fixed.

R=brianwilkerson@google.com, sigmund@google.com
BUG=

Review URL: https://codereview.chromium.org//428303004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38949 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 20:41:42 +00:00
scheglov@google.com 57f076f17f New analyzer snapshot.
Not to be published.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//435483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38764 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 00:40:17 +00:00
scheglov@google.com a4dee8bf4c Resolve names in combinators for PropertyInducingElements instead of PropertyAccessorElements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//384093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38199 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-14 17:11:34 +00:00
scheglov@google.com 7a27ca20dd New analyzer snapshot.
Also includes the tweak for property accessor identifiers.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//382953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38129 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-10 20:33:33 +00:00
scheglov@google.com 0a09f96271 Improve wrapping during formatting.
It will wrap on spaces with the lowest priority first, and if required - on the next priority, etc.

R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//381663004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38109 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 22:26:30 +00:00
scheglov@google.com 0597e61ba3 Move index/search to services.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//375693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38045 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-07 22:24:59 +00:00
scheglov@google.com 1f45100688 Move Index and IndexStore implementations into Engine.
Also move most of the related tests.

LocalIndex test is commented out, because relies on the infrastucture existing only in Server - virtual file system, mocks.
We need to move it into Engine or extract into a separate package.

This CL also removes Dart implementation of BTree.
We now use a different approach to implementing the index.

Bots are red after the previous CL, I hope that this one will fix at least some redness.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//365193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37993 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 21:30:25 +00:00
scheglov@google.com 4b5436f498 IndexStore, Index and SearchEngine APIs and partial implementatons.
IndexStore and Index implementations are not moved yet to engine package.

SearchEngine implementation is not cleaned up yet, there is only (commented) raw java2dart translation result.

Index contributions are present, but without tests yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//363373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37991 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 19:06:33 +00:00
scheglov@google.com ab2fe30d18 Rewrite 'throw thrownException' with 'throw new AnalysisException(...)'
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//355203009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37917 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 22:15:57 +00:00
scheglov@google.com b405df0d27 New analyzer snapshot.
Mostly to get GetContentTask.internalPerform() to catch all exceptions.
We throw non-Java exception from memory resource, so we cannot test not existing parts/libraries cases in server.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//360393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37907 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 21:01:50 +00:00
paulberry@google.com 35461efcb8 Analyzer snapshot based on r37767.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//353083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37788 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-27 15:31:20 +00:00
scheglov@google.com 46b9b138d6 Move Tokenfactory, AstFactory and ElementFactory from tests to the testing/ Folder.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//351283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37748 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 17:30:25 +00:00
scheglov@google.com 03819fe9e0 Analyzer snapshot to with FunctionElement.identifier fix.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//346303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37625 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 22:03:08 +00:00
scheglov@google.com 6b6467a9ca New analyzer snapshot.
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//348673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37516 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 20:58:28 +00:00
paulberry@google.com 238ea2c84e Fixes to CaughtException and AnalysisException
Two issues:

1. Some exceptions don't derive from Exception (for example
   NoSuchMethodError).  So to avoid problems in checked builds,
   CaughtException.exception needs to have type Object.

2. When an exception is caught by the unittest framework, it prints it
   using its toString() method.  So in order to see the stack trace of
   the CaughtException nested in an AnalysisException, we need
   AnalysisException's toString() to print both the exception and its
   cause (if any).

R=brianwilkerson@google.com, jwren@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//304293010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37186 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 17:16:48 +00:00
brianwilkerson@google.com 04cc76da9f Add intern support to analyzer.
In tests, this reduces the memory requirements for engine by about 15%. I have only enabled it for the command-line analyzer, though, because other uses will need to guard against memory leaks.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//325473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37112 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-07 15:57:01 +00:00
scheglov@google.com d06a1cff08 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//322603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37096 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 19:48:47 +00:00
scheglov@google.com 5c5e55205c Formatter: fix for long multiline strings.
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//322563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37088 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 17:25:56 +00:00
scheglov@google.com 591ecb6f1e Formatter: keep a right parenthesis ')' with the last argument.
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//321513006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37087 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 17:09:51 +00:00
scheglov@google.com be92cd5009 Tweaks for long formal parameters and method body '{' formatting.
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//320503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37084 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 15:33:56 +00:00
scheglov@google.com d83c344f43 Formatter: don't indent EOL comment at the beginning of a line.
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//319063004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37083 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 15:32:22 +00:00
scheglov@google.com 979d9be919 Formatter: do not use a space when using < and > for a map literal.
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//322483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37082 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 15:29:54 +00:00
brianwilkerson@google.com 640bc9d2e9 Communicate defined variables to the context. With this change we ought to be able to get defined variables from the command-line to the context and should be unblocked for using the values in constant evaluation.
R=paulberry@google.com

Review URL: https://codereview.chromium.org//300043012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36695 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 16:45:51 +00:00
scheglov@google.com 555bc4ef2d New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//294903015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36511 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 16:58:29 +00:00
scheglov@google.com af851cdcdc New analyzer snapshot (with CaughtException).
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//285423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36256 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-16 01:43:54 +00:00
scheglov@google.com 862a54b592 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//267293006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35872 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-07 22:06:01 +00:00
scheglov@google.com 593096bef2 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//263913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35704 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-02 20:06:26 +00:00
pquitslund@google.com c9bf850f58 Support for new 'deferred' import declaration modifier.
R=brianwilkerson@google.com, jwren@google.com

Review URL: https://codereview.chromium.org//264473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35553 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 23:06:25 +00:00
scheglov@google.com 496aa45ed1 New analyzer snapshot. Sorted unit members.
New Character utilities.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//259773005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35468 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-26 22:37:24 +00:00
paulberry@google.com 6c000ea2cb New analyzer snapshot, based on r35422.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//257773008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35426 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 15:18:19 +00:00
scheglov@google.com d1cc18b5e1 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//247053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35270 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 17:10:47 +00:00
scheglov@google.com 314fd76902 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//243263004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35179 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 19:55:14 +00:00
pquitslund@google.com 9f93ab5937 Annotation whitespace convention fixes (dartbug.com/17837).
R=scheglov@google.com

Review URL: https://codereview.chromium.org//225863005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34902 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 22:22:31 +00:00
pquitslund@google.com 3edb0efcf4 Fix constructor initializer space conventions (dartbug.com/17642).
R=scheglov@google.com

Review URL: https://codereview.chromium.org//231743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34893 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 20:25:36 +00:00
scheglov@google.com e5652e0e90 New analyzer snapshot with MapIterator.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//229653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34891 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 20:18:01 +00:00
brianwilkerson@google.com b4cdb0dc98 Add new performance option to get both cold and warm timings.
@Rico: Does it matter that the errors will be written between the two sets of timings?

R=scheglov@google.com

Review URL: https://codereview.chromium.org//227533005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34817 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 11:08:36 +00:00
scheglov@google.com bd532a6990 Correct or pause previous TimeCounters.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//225183020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34809 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 05:08:08 +00:00
scheglov@google.com 6da7a82a20 Fix for translation of \!= to \!identical(), but use == and \!= for Enum.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//221483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34636 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 03:09:22 +00:00
scheglov@google.com 1145c19860 Rollback pkg/analyzer that breaks code_transformers
R=blois@google.com, brianwilkerson@google.com, sigmund@google.com
BUG=

Review URL: https://codereview.chromium.org//214593008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34479 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 20:29:08 +00:00
scheglov@google.com 240b4138ce Translate Java enums to Dart constants.
1. Restore "this.field" field formal initializers.

2. Tweaks for several Java places - mostly to the constructors; but also duplicate HintCode messages (in Dart we cannot get values of constant values final fields).

3. Translate field that are not written to Dart final fields and also to field initializers, even if there are no property for them.

4. And constant enums.

5. pkg/code_transformers/test/resolver_test has to be skipped, I cannot fix it myself.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//214253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34474 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 15:37:37 +00:00
scheglov@google.com eedaae10e6 Optimizations for hashCode.
This improves Dart-based analyzer performance.

dart2js:   12500 -> 11600 ms, about 900 ms or 7%.
blueshift: 23500 -> 21500 ms, about 2000 ms or 8%.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//207853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34318 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 18:18:14 +00:00