ce8a5ffab2
Remove remaining definitions of EMPTY_LIST in server
...
Change-Id: Ia7a9286f2fc7e151f99091169635b71fde88649a
Reviewed-on: https://dart-review.googlesource.com/77421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-01 15:42:55 +00:00
f6d2c2378a
Add awaits in async methods to restore previous semantics
...
Change-Id: I7711cd878a31df0fb0c92572e2256c0a26923640
Reviewed-on: https://dart-review.googlesource.com/59480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-06-08 19:58:07 +00:00
ca7d545df8
Follow up on initial fix-all fixes PR, https://dart-review.googlesource.com/c/sdk/+/56220 , adding some assertions and a test.
...
Change-Id: I6e22f8537f616ce2d09247f90bb81fff17eb1b66
Reviewed-on: https://dart-review.googlesource.com/56601
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-05-24 22:29:45 +00:00
351d70674d
Initial new union of Dart Analysis Fixes, the initial fix is to remove all unused imports in a file.
...
Change-Id: I259e796b2603234955a1950b2c886e6f08a697bc
Reviewed-on: https://dart-review.googlesource.com/56220
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-05-24 15:23:40 +00:00
2cd992663e
Sort assists and fixes by relevance and then by name.
...
We used to get away with sorting just by relevance because the order
of assists and fixes was correct. I think it is time to switch to
sorting. I still would like to keep 'Surround with XXX' ordered in
a specific way, so I'm changing relevance for these assists.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I77f77ec732d70b31c32164759a3ac62dc790e469
Reviewed-on: https://dart-review.googlesource.com/40880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-13 18:18:59 +00:00
b941f148a7
Remove uses of the old plugin model from the analysis server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3001413002 .
2017-08-23 07:42:13 -07:00
6248e7cab2
Add support code to make fixes easier in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2962903002 .
2017-06-28 10:52:06 -07:00
0929b7736e
Convert quick assist support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2899843002 .
2017-05-22 13:45:55 -07:00
7e47a24c8a
Convert quick fix support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2894403003 .
2017-05-22 10:41:57 -07:00
a6214b3129
Remove more libraries directives from server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2894883002 .
2017-05-19 08:42:30 -07:00
fb982f5476
Make server use the common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
e55812a3f2
Unify the server and plugin versions of the generators
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
f600f5f9de
Stop using Element.computeNode() in refactorings and fixes.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2669353002 .
2017-02-02 17:24:31 -08:00
57c3002ede
Implement 'Import Library' Quick Fix for project libraries using TopLevelDeclarationInSource.
...
Only the current implementation is done.
Implementation for the new analysis driver is not linked yet.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2554113003 .
2016-12-06 14:24:22 -08:00
ecc84b26a4
Break up another large file
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2342733002 .
2016-09-15 07:49:27 -07:00
8c22a5f807
Format code in analysis_server
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1838933003 .
2016-03-29 08:27:14 -07:00
7d72c6e1f5
Deprecate the generated AST library and clean up imports
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1788223002 .
2016-03-12 08:50:48 -08:00
1c5e2fd0fb
Use getResolvedCompilationUnit2() instead of resolveCompilationUnit2() in QuickAssist and QuickFix contributors.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1582613010 .
2016-01-15 12:15:45 -08:00
86216e5154
Consistently use implements when one interface inherits from another interface
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1481273002 .
2015-11-30 07:58:10 -08:00
bb1914e175
Make FixContributor asynchronous.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1461313004 .
2015-11-20 14:57:00 -08:00
27eb09033f
Clean up wording of client usage expectations
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org/1409353002 .
2015-10-19 07:46:49 -07:00
9ad256cf18
Move the wire protocol support into the public API
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
8f4c63c92b
Restructure the public API for server
...
R=danrubel@google.com , paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1392253002 .
2015-10-09 07:57:00 -07:00
Brian Wilkerson