dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
54,275 Commits 2 Branches 0 Tags
acf86bfb22cdb47af05fdff13b90ebbc06f57cbe
Commit Graph

2986 Commits

Author SHA1 Message Date
Danny Tuppeny f91ab5b64e Fix test failures on Windows 
Windows doesn't have curl, but PowerShell does have Invoke-WebRequest (aliased to curl).
Also Fix set_general_subscriptions_test path issue.

Bug: https://github.com/dart-lang/sdk/issues/32355
Change-Id: I7567e2e01fc2158443b86569894ab0b17b3c5096
Reviewed-on: https://dart-review.googlesource.com/44240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2018-03-01 07:46:36 +00:00
Konstantin Shcheglov 3a5be046bb Update FlutterOutline API to provide widgets instrumentation. 
So, this is alternative approach - the plan is to instrument in Analysis
Server, then generate the entry point and instrumented code in Flutter
plugin, and run flutter_tester also from the plugin.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I6b2bb0fea6494df6b9f6b3e69e7548d03af7e94b
Reviewed-on: https://dart-review.googlesource.com/44382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-28 23:02:53 +00:00
Konstantin Shcheglov 215aa21172 Boost completion relevance for more cases. 
R=brianwilkerson@google.com

Change-Id: Ib5fe69d3a0d20e29f36575e692a7418b6744ca83
Reviewed-on: https://dart-review.googlesource.com/44281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-28 19:32:56 +00:00
Konstantin Shcheglov 4cf5b7df12 Boost relevance for compatible types in '==' and switch/case. 
Probably less Flutter specific, but still useful.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I979e1a0640494a4a6cbedcec90781bc165c94f31
Reviewed-on: https://dart-review.googlesource.com/44000
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-27 17:36:40 +00:00
Danny Tuppeny 7ca10a7adf Fix file completion for absolute paths on Windows + related tests 
Bug: https://github.com/dart-lang/sdk/issues/32226
Bug: https://github.com/dart-lang/sdk/issues/32277
Change-Id: Ie78423dc4a99efd25976b49ec7642362ed61a3c6
Reviewed-on: https://dart-review.googlesource.com/43961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2018-02-27 17:20:49 +00:00
Konstantin Shcheglov 75858ec680 Add optional 'parameters' field to ElementDeclaration. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I6b8e4417e7a7bc32537fdcbaa8fd04caf18da052
Reviewed-on: https://dart-review.googlesource.com/43885
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-27 01:27:37 +00:00
Konstantin Shcheglov 199206a735 Implement support for 'pattern' and 'maxResults' in getEElementDeclarations(). 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I38a53c44016d01e2012b2e20173e0ae07cc658e2
Reviewed-on: https://dart-review.googlesource.com/43883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-26 22:48:20 +00:00
Konstantin Shcheglov 586c183904 Add code range to ElementDeclaration. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I6e7afe3b8ea8191d737c717b753d55d2a7945a81
Reviewed-on: https://dart-review.googlesource.com/43840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-26 20:37:44 +00:00
Konstantin Shcheglov c3330ba080 Add 'pattern' and 'maxResults' to getElementDeclarations() request. 
R=brianwilkerson@google.com

Change-Id: I2094fa106cbdd7bc4eff9015d94b34517b3d50a5
Reviewed-on: https://dart-review.googlesource.com/42180
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 18:46:27 +00:00
Danny Tuppeny af527dd769 Fix some CompletionDomainHandlerTest tests on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: If6d0568d0de2268157c916267a0120c5b4295951
Reviewed-on: https://dart-review.googlesource.com/43666
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:53:37 +00:00
Danny Tuppeny 0c62908b40 Fix FixesTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I010b2365ffc2a3ab2a9daa6cec71067ce32a2f76
Reviewed-on: https://dart-review.googlesource.com/43663
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:37:47 +00:00
Danny Tuppeny e9527bed5e Fix plugin tests on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Iffbd616eec6afcc7613d829c47d8c278a268ab1b
Reviewed-on: https://dart-review.googlesource.com/43662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:35:42 +00:00
Danny Tuppeny 49d68924b5 Fix OrganizeDirectivesTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie033ae9fcf4088d4fb39f46c2a7a6dc7afab68b3
Reviewed-on: https://dart-review.googlesource.com/43664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:27:58 +00:00
Danny Tuppeny 40d7fe87f1 Fix GetErrorsTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I0636fb61ffdec435e5f84a6c85ae102151a5a609
Reviewed-on: https://dart-review.googlesource.com/43680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:27:37 +00:00
Danny Tuppeny b9b8b9080e Fix ExecutionDomainTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I149c32c4b2130518921c592be56c71d451010a36
Reviewed-on: https://dart-review.googlesource.com/42947
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:14:37 +00:00
Mike Fairhurst 69474f23c2 Fix the 'pub' command in plugins on Windows -- '.bat' required. 
Change-Id: Ibcf212902454dd8d9eb442e9633a193163d5bcae
Reviewed-on: https://dart-review.googlesource.com/43620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-02-25 03:33:23 +00:00
Brian Wilkerson 716daa3b0d Add assists to convert between literal string styles 
Change-Id: I691ff29d0bdc5a01cef6736f403025d1eee912d0
Reviewed-on: https://dart-review.googlesource.com/43580
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-02-24 21:45:32 +00:00
Konstantin Shcheglov 9567305bd6 Set selection position for Flutter move widget up/down assists. 
This requires also changes to Dart plugin for IntelliJ, because currently
we use exit position only when there are linked edits. I attempted to
implement it myself, it mostly works, but there are race condition
complications.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Iff1a79ebb0cb7e0eabfe59e45d8dde7559c60a0f
Reviewed-on: https://dart-review.googlesource.com/43600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-24 17:14:30 +00:00
Konstantin Shcheglov 316af55593 Suggest enum constants for imported enums. 
So, you can complete `Column(crossAxisAlignment: ^)` and get all of
the CrossAxisAlignment right away for selection. Or you can start
typing `center` and by the time when you typed first letters, you get
several completion suggestions. There are several enums with `center`,
but because we give compatible types higher relevance, the correct
one is always the first.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I6c2082668c6b25bf23e070915b5df03081ff0d5c
Reviewed-on: https://dart-review.googlesource.com/43485
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-23 19:26:36 +00:00
Brian Wilkerson a3bc0284c2 Correctly convert file paths to URIs on Windows (issue 32278) 
Change-Id: I386038f828154b35e8f7a212d351a054d28e3b1f
Reviewed-on: https://dart-review.googlesource.com/43483
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-23 17:23:54 +00:00
Konstantin Shcheglov cc3e062578 Set higher relevance for exact type and subtype completions. 
Exact type get the largest relevance boost, subtypes a smaller boost,
and the rest has default relevance for its element kind.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: Ibb38caedc314e9cf476de2116aeb61bcec8c8a08
Reviewed-on: https://dart-review.googlesource.com/43263
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-23 06:05:13 +00:00
Brian Wilkerson a81a2c120f Guard against exception in fix processor when URI is invalid (issue 32276) 
Change-Id: I5902ab5f260941f0da3a751a03783999737319f1
Reviewed-on: https://dart-review.googlesource.com/43202
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 21:41:11 +00:00
Brian Wilkerson cbacb35d51 Fix selection range from override contributor and contribute when there is a leading annotation 
Change-Id: If43dd85531d1c9cdcba0f750b299990c10991538
Reviewed-on: https://dart-review.googlesource.com/43140
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 20:22:29 +00:00
Konstantin Shcheglov 9b71ba7f17 Copy 'className' field into the API structure. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: Ie95f4b59dfa15fc085694317883b0c2fd81c1fbb
Reviewed-on: https://dart-review.googlesource.com/43160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-22 18:40:37 +00:00
Konstantin Shcheglov 0ce1a92d98 Suggest constructors for implicit creation in previewDart2. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I43270f47fb43402d1a9e0f7d9814494ffd83bb5e
Reviewed-on: https://dart-review.googlesource.com/43080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-22 18:03:12 +00:00
Danny Tuppeny c840168ef2 Fix CombinatorContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I198378b707df36852d4d7a90f98e4542b95c218c
Reviewed-on: https://dart-review.googlesource.com/42944
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:53:26 +00:00
Danny Tuppeny 5da95d7c9f Fix AssistProcessorTest on Windows 
Note: This fixes one of the tests but the other still fails. I believe
that's because of https://github.com/dart-lang/sdk/issues/32278 and
should pass once that issue is fixed.

Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I6469b75de39e6476353da303c9c72cfba2da922e
Reviewed-on: https://dart-review.googlesource.com/43006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:37:11 +00:00
Danny Tuppeny 89240070b0 Fix AnalysisNotificationAnalyzedFilesTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I9d8c333f0c5070d932645d34986dc931b0038b61
Reviewed-on: https://dart-review.googlesource.com/43022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:33:06 +00:00
Danny Tuppeny 6074dcfdae Fix LibraryPrefixContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I7073e516109570ca80b1890368351e22b9ed844f
Reviewed-on: https://dart-review.googlesource.com/43004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:10:38 +00:00
Danny Tuppeny 82a1702cc8 Fix OverrideContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I68f0691007820e5efbabca58b6436d0c68d81487
Reviewed-on: https://dart-review.googlesource.com/43005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:05:43 +00:00
Danny Tuppeny ddf36c26c9 Fix GetTypeHierarchyTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I57a1ebf7481e17d8cdd7be8d69c3ac84d0fcc185
Reviewed-on: https://dart-review.googlesource.com/43000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:02:33 +00:00
Danny Tuppeny f94a0f54e6 Fix CommonUsageSorterTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie90a0b8823816d8b64f261e561183c35fb1737c8
Reviewed-on: https://dart-review.googlesource.com/43001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:56:03 +00:00
Danny Tuppeny 812b635ea3 Fix CompletionManagerTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I6b521604141b4584c4ed17470e7ea25b060af841
Reviewed-on: https://dart-review.googlesource.com/43003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:51:53 +00:00
Danny Tuppeny 6437794e32 Fix LocalLibraryContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie57904d6eac2eabe8538400b4e56b2c414aebb35
Reviewed-on: https://dart-review.googlesource.com/42921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:39:43 +00:00
Danny Tuppeny 7d1f930949 Fix DiagnosticDomainTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I3b32087af3690ea7faa6715fdb6e5889b798b263
Reviewed-on: https://dart-review.googlesource.com/42948
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:25:03 +00:00
Danny Tuppeny e7d57c8535 Fix RenameClassMemberTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I57804f6c168cccdbfee62f8fa6b60b40f260015b
Reviewed-on: https://dart-review.googlesource.com/42946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:17:33 +00:00
Danny Tuppeny 04830ac262 Fix RenameUnitMemberTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I98f2c5025615adf52919ea87d637a47ee50fe760
Reviewed-on: https://dart-review.googlesource.com/42942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:11:53 +00:00
Danny Tuppeny 9e96a89628 Fix NamedConstructorContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I47d47bf7275f4e78d6e077d5f2c1e0ec4246c150
Reviewed-on: https://dart-review.googlesource.com/42943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:06:03 +00:00
Danny Tuppeny 0796ea4ee5 Fix RefactoringLocationTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ieead4b1d434740078a6383cafb426ddc4bbe002b
Reviewed-on: https://dart-review.googlesource.com/42941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 15:51:33 +00:00
Danny Tuppeny 1c44401f2e Fix LocalReferenceContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I75a3b5200f6ef06c3c14233d45c897ae8bdd655c
Reviewed-on: https://dart-review.googlesource.com/42923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 15:46:23 +00:00
Danny Tuppeny 427506d1f0 Fix LibraryMemberContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I53c12fc79d0d5bf9331eb42714d7a6c29a5325af
Reviewed-on: https://dart-review.googlesource.com/42940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 15:36:43 +00:00
Danny Tuppeny 6a82f29e32 Fix ArgListContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I04faca9575387faeca1cf6b505f05c15a1b0e670
Reviewed-on: https://dart-review.googlesource.com/42920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 15:29:36 +00:00
Konstantin Shcheglov 0346acf550 Don't suggest generative constructors of abstract classes. 
So, we don't suggest EdgeInsetsGeometry for 'padding: ', even though
it is the type of the parameters. But we still suggest its subclasses
EdgeInsets and EdgeInsetsDirectional.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: If2d7ba550ec76e4f66cb81e1346466b5f1a30464
Reviewed-on: https://dart-review.googlesource.com/42888
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 02:03:33 +00:00
Konstantin Shcheglov fcccab9199 Filter constructor completions by required type. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I88eb345bfa7f0a65d135e5fdcb443d5dadd695c5
Reviewed-on: https://dart-review.googlesource.com/42882
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-21 23:12:31 +00:00
Konstantin Shcheglov ebd16bd33f New Quick Fix 'Convert to named arguments'. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1100
Change-Id: I317204424c38313c8c3eb844d9e8bb574118aa66
Reviewed-on: https://dart-review.googlesource.com/42860
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 20:07:09 +00:00
Danny Tuppeny 23127d04b6 Fix test_ArgDefaults_function_with_required_named test on Windows 
The changes in addSource are so that the driver gets the convertedPath
(newFile already converts).

The change in the test is to format a path for importing on Windows - it
seems that importing a file with an absolute path is a bit wonky on
Windows (I presume since this is testing imports it's using absolute
paths for a reason).

The helper in the Mixin is for doing the conversion from a Windows path
to an importable version of it (this has many questions to answer and
maybe already exists somewhere?).

See #32095.

Change-Id: Ifed137ac354f9d0527344020c719e0c3c81ccf3e
Reviewed-on: https://dart-review.googlesource.com/42681
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 18:49:19 +00:00
Danny Tuppeny d66e6b1c6e Fix refactoring tests on Windows 
This hand-built JSON fails on Windows because the paths being inserted
only have a single slash ("C:\test.dart") but in the real results the
JSON is encoded correctly and hhas two paths.

This works around the issue by JSON-encoding the filename but really the
whole object should be serialised to JSON properly.

Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I8aa418e8e3e6377ed01fe3bbecc3242f3a012629
Reviewed-on: https://dart-review.googlesource.com/42742
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 18:49:12 +00:00
Danny Tuppeny 358a8502fd Fix UriContributorTests on Windows 
See #32226.

Change-Id: I685b0b5875001a56af5c3cf623fe9bca7261b478
Reviewed-on: https://dart-review.googlesource.com/42740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 17:56:59 +00:00
Danny Tuppeny f1cdf5f9be Fix up plugin/protocol_dart_test.dart for Windows paths 
See #32226.

Change-Id: I37362ba86188616dd1f0fd6623a62e05ee825454
Reviewed-on: https://dart-review.googlesource.com/42702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 17:39:09 +00:00
Danny Tuppeny 20578644c0 Fix all remaining broken FixProcessorTest tests on Windows 
See #32226.

Change-Id: Idc80d0ac7441e1db8c0213093b9b79d4b3e70315
Reviewed-on: https://dart-review.googlesource.com/42700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 17:19:19 +00:00