dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
88,085 Commits 2 Branches 0 Tags
ab217c355f5f2ef9f6340170c0fbd94de0fa1923
Commit Graph

300 Commits

Author SHA1 Message Date
Ben Konyi 72506b826a [ CLI ] Add support for --[no-]sound-null-safety to dart compile {jit-snapshot,kernel} 
Fixes https://github.com/dart-lang/sdk/issues/50079

Change-Id: I4a71dab1c9003f13ff74741bc64f3ee239c03195
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262620
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-04 17:03:29 +00:00
Ben Konyi c8651ac551 [ CLI ] Force isolate running dart2js to use --no-sound-null-safety 
Fixes https://github.com/dart-lang/sdk/issues/50090

TEST=N/A

Change-Id: I5e26a88a8daa107fa684009562c4eb2207f41a9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262621
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2022-10-04 16:59:57 +00:00
Devon Carew ad34feec87 [dart create] suggest using the pubspec repository field 
Change-Id: I51e83853d947bc545aced1ae2ae3d048dd7c6b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261940
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-09-29 19:13:27 +00:00
Tess Strickland be4d469e38 [pkg/dart2native] Refactor MachO parsing. 
* Move parsing functions to static methods of the classes that
  represent the data being parsed.

* Move calculations for adjusting offsets in load commands into the
  corresponding classes.

* Make function to insert a new payload segment an instance method
  of MachOFile.

* Remove unnecessary abstractions and definitions for MachO load
  commands that we don't need to parse.

These refactorings are being done to make later changes easier to
review, by first lifting the initial refactorings out into a
separate CL.

Issue: https://github.com/dart-lang/sdk/issues/49783
Change-Id: I133eb368cbb9ee0d8e4f3998ba1a0bbe8555b8aa
Cq-Include-Trybots: luci.dart.try:analyzer-mac-release-try,dart-sdk-mac-arm64-try,dart-sdk-mac-try,pkg-mac-release-arm64-try,pkg-mac-release-try,vm-kernel-precomp-mac-product-x64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256821
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2022-09-07 11:32:37 +00:00
pq 1519292b7a [dart fix] dry-run individual code run details 
Adds details to make applying individual fixes easier.

Example output:

```
3 proposed fixes in 1 file.

foo/baz/main.dart
  annotate_overrides • 1 fix
  prefer_single_quotes • 2 fixes

To fix an individual diagnostic, run one of the following commands:
  dart fix --apply --code=no_duplicate_case_values .
  dart fix --apply --code=unused_imports .

To fix all diagnostics, run:
  dart fix --apply .
```

See: https://github.com/dart-lang/sdk/issues/47219


Change-Id: Ibc89388acabe868fe3253d802e03481d853646ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256367
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-25 18:11:40 +00:00
pq c0e74c4433 [dart fix] report undefined diagnostics 
Fixes: https://github.com/dart-lang/sdk/issues/49699

Change-Id: Ia412e4dce51b0887c3cd0d9b6d91f0ace926bea3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-08-24 20:35:59 +00:00
Michael Richards 8d262e2944 [dartdev] This adds the ability for the Dart CLI to use the Resident Frontend Compiler for faster start times. 
Dartdev will use the user's home directory to store the server information and will keep a directory for cached kernel files in each dart package's .dart_tool directory and in the .dart directory for stand alone dart programs.

This functionality is accessed by providing the --resident flag to the Dart CLI, and the server can be manually shutdown with the new shutdown command.

Change-Id: I5231a00b7535266ab0704ca3ae35c039738bd38b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254341
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Michael Richards <msrichards@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2022-08-18 17:01:34 +00:00
pq f4ea96ff2c [dartdev] fix --code support 
See: https://github.com/dart-lang/sdk/issues/47219

I'll follow up with tests for error conditions once diagnostic codes are validated by the protocol (see: https://dart-review.googlesource.com/c/sdk/+/255541).

Change-Id: I3318364e952522522608e86bdfdd231839685689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255544
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-18 16:51:54 +00:00
Michael Thomsen c626cb8346 Make package arg to analyzer absolute 
Bug: https://github.com/dart-lang/sdk/issues/49646

Change-Id: Ie653b2372ba12992457c25972294c261cb8ea40e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254901
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-16 20:54:32 +00:00
Ben Konyi eff8c305d9 [ Service / Timeline ] Enable Compiler, Dart, and GC timeline streams when --observe is provided 
TEST=pkg/vm_service/test_timeline_default_streams_test.dart

Fixes https://github.com/flutter/devtools/issues/3444

Change-Id: I3f772a54a512eb836e3e7279ee8d4d3437473393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255181
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2022-08-15 21:02:36 +00:00
Danny Tuppeny 09bcc1f4ae [dartdev] [dds] Share DevTools arg parsing with serve_local script 
Change-Id: Ia8f95b205fda1201a7ec50805a84d374a6201f39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253460
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-08-04 20:32:14 +00:00
Ben Konyi 887601b726 [ CLI ] Add better logging to the DartDev isolate 
Should make debugging unhandled errors in the CLI easier.

Related issue: https://github.com/flutter/flutter/issues/106753

Change-Id: I6cfc88a52c0af756c0d7a00fc1a2edcf61b86538
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252464
Reviewed-by: Siva Annamalai <asiva@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-07-25 14:44:59 +00:00
Anis Alibegić 40e18905f2 Fixed various typos in a lot of files 
Closes https://github.com/dart-lang/sdk/pull/49478

TEST=Manual

GitOrigin-RevId: f4c9c6869dfe73639295e86574a021523b3d374d
Change-Id: I134a97caed4eec59d70e9cbca16b7e9a472cf2c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251902
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2022-07-25 12:21:59 +00:00
Ben Konyi cc92eb0a7f [ CLI ] Fix LateInitializationError in DartDev when passed an invalid flag 
`log` was previously initialized after argument parsing had already
taken place, which caused an exception when an invalid flag was passed
to DartDev as `log` was referenced in the `dart fix` command
description, which is accessed when building the usage message.

Also fixes a minor test failure related to usage line lengths not being
set correctly for `dart devtools`.

Fixes https://github.com/dart-lang/sdk/issues/49437

Fixed: 49437
Change-Id: Ib367677db5f34d7b6da31e51dbe717c954298ecf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251241
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-07-12 18:22:42 +00:00
Ben Konyi c50236ff9c [ CLI ] Ensure training arguments aren't parsed by the CLI for JIT snapshots 
TEST=test/commands/compile_test.dart

Fixes https://github.com/dart-lang/sdk/issues/49302

Change-Id: I15462eb617de2dca042ee445b85084b8b8602f6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249340
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2022-06-24 14:26:39 +00:00
Sam Rawlins 567b45fb1d Add the enable-experiment flag back to DAS 
Bug: https://github.com/dart-lang/sdk/issues/48960
Change-Id: I6576f45e63e28902986db844df49a06a71385704
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245202
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-06-16 16:26:39 +00:00
Ahmed Ashour 85700570f6 Fix typos 
Fixes #49241

TEST=ci

Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 11:08:28 +00:00
pq 8d9009d610 fix path normalization for windows 
See: https://github.com/flutter/flutter/issues/105641#issuecomment-1150497628

Change-Id: I176467d5885feab1c44892ea9140f619e30df223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247608
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2022-06-09 03:00:02 +00:00
Jaime Wren 128a7e1641 Modify dartdev language-server to call the server snapshot 
This change also modifies the Dart Analysis Server to default to use the LSP protocol

Change-Id: I73a1ceae9a05bc8e5af219e4f28df959c054d4c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247461
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-07 21:31:02 +00:00
pq 467a1b05c0 dart fix for single files 
Fixes: https://github.com/dart-lang/sdk/issues/43892

Change-Id: If1dca6bdef59e9de6dfd74e9774f61072651166d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246160
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 17:42:14 +00:00
Jaime Wren 6c210bbc57 Revert "Modify dartdev language-server to call the server snapshot" 
This reverts commit 1598182907.

Reason for revert: The snapshot for the DAS needs to have the default set before this change can land.  Will work with Analyzer folks in the morning to put together a new PR.

Original change's description:
> Modify dartdev language-server to call the server snapshot
>
> Change-Id: I6fc7b2c1e55089fa0bf88633733c51ff768e699b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246059
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Jaime Wren <jwren@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I848f4ad08405fee5aeb0d2eb166f95390e81bb3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246840
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-02 05:13:26 +00:00
Jaime Wren 1598182907 Modify dartdev language-server to call the server snapshot 
Change-Id: I6fc7b2c1e55089fa0bf88633733c51ff768e699b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246059
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2022-05-31 21:40:44 +00:00
Danny Tuppeny e00fe8a259 [dartdev] Don't filter out TODO errors from dart analyze if configured as warning/error 
Fixes https://github.com/dart-lang/sdk/issues/49061.

Change-Id: I251d6a6c918023f4f8b4597dbb79dc02064898ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245542
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-21 17:25:33 +00:00
Sam Rawlins bbd7e5a4d9 Fix bad sdk-path error message 
Fixes #48959

Change-Id: I2ebbb06583886a8e54dbda0a4222bc02d380f7fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244742
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 20:03:35 +00:00
Sam Rawlins f3c2d2ee81 Support an sdk-path option in dart analyze 
Bug: https://github.com/dart-lang/sdk/issues/48959
Change-Id: I4c386f1f7c474c1ff809d15d597d3f8f2de0418a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-05-06 03:08:28 +00:00
Danny Tuppeny 5dafbb8889 [dds] Provide better error output for DAP protocol violations 
See https://github.com/flutter/flutter/issues/99734.

Change-Id: Idf23f745d0736db41a195fd5294b5f545c2a39a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240541
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-04-27 14:12:54 +00:00
pq 5470e07025 rename local functions with _s 
These will be flagged by the next linter release which updates `non_constant_identifier_names` to flag local functions.

Change-Id: If6e6497418e7044ce906d87981e3b3afa1f26da8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242423
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-04-26 17:48:43 +00:00
Parker Lougheed 731ef4f5c9 [dartdev] Adjust dart compile packages flag description for .packages discontinuation 
Change-Id: Ie461aa6124308637585f37c26d0f0525236680b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240903
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-04-25 14:10:54 +00:00
pq dfa6c5f402 update package:lints dep to 2.0.0 
See: https://github.com/dart-lang/lints/issues/73.

Change-Id: I553ef8d9226c1c7d43c9594160a115a1abf043c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236841
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-03-18 19:55:51 +00:00
Darren Chan 019b6f110b Increase analysis server shutdown timeout. 
Fixes https://github.com/dart-lang/sdk/issues/48584.

Tested on infra CQ (see http://tqr/509011 vs http://fxr/659793).

Also logs an error if the server shutdown times out.

Change-Id: Idd126f915c2b00f7331a51f0f3d527452b540a59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237780
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Darren Chan <chandarren@google.com>
Commit-Queue: Darren Chan <chandarren@google.com>
 2022-03-18 00:35:07 +00:00
pq 47a52fc5de lint 2.0 fixes 
In anticipation of lints v 2.0.

See: https://dart-review.googlesource.com/c/sdk/+/237746

Change-Id: I42bcdfa43d4707324622b498c57dde6e2fe1f13b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-03-17 23:11:28 +00:00
Ben Konyi 8c484d12fe Reland "[ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS" 
This reverts commit d4f71515c7.

TEST=CQ

Change-Id: I180f9d045870a1ff5f7f3f82b6f4782e18c18cfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237440
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-15 18:14:42 +00:00
Emmanuel Pellereau d4f71515c7 Revert "[ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS" 
This reverts commit bd8590ba9b.

Reason for revert: breaks google3 (b/224731131)

TEST=Clean revert

Original change's description:
> [ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS
>
> Polling logic was introduced due to a bug in Fuchsia's network stack
> which could result in the VM service attempting to start the server
> before the network stack was initialized. This issue should be resolved
> now, so this logic is no longer necessary.
>
> TEST=pkg/dartdev/test/commands/run_test.dart
>
> Change-Id: I10f185dfb1be1b0363983f3e0564d65c38c99ea8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235763
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,rmacnak@google.com,asiva@google.com

Change-Id: I3016fad25220c4e5479f17294626d79a17bd316a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237360
Reviewed-by: Alexander Thomas <athom@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Emmanuel Pellereau <emmanuelp@google.com>
Commit-Queue: Emmanuel Pellereau <emmanuelp@google.com>
 2022-03-15 12:01:30 +00:00
Ben Konyi bd8590ba9b [ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS 
Polling logic was introduced due to a bug in Fuchsia's network stack
which could result in the VM service attempting to start the server
before the network stack was initialized. This issue should be resolved
now, so this logic is no longer necessary.

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: I10f185dfb1be1b0363983f3e0564d65c38c99ea8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235763
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-14 21:44:29 +00:00
Ben Konyi 53d16a6657 [ CLI ] Add --packages support for kernel/jit-snapshot commands 
Change-Id: Ifd947bd74f114bd081fd1b2c990cfc392f767278
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236661
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-10 19:36:35 +00:00
Sam Rawlins 603ed39e49 Throw on crashed analysis_server instead of hanging 
Fixes https://github.com/dart-lang/sdk/issues/48413

This fix required detecting an unexpected shut down,and then an
explicit `io.exit()`. Without the exit, the process continued to hang.

Also code in the same function according to Effective Dart.

* https://dart.dev/guides/language/effective-dart/design#dont-redundantly-type-annotate-initialized-local-variables
* https://dart.dev/guides/language/effective-dart/design#avoid-abbreviations

Change-Id: Ifb94394e0a788aa990f5a9c5cd3fb54279827775
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234660
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-03 22:42:41 +00:00
Ben Konyi 942a2f03a3 [ CLI ] Add support for --define/-D to dart compile jit-snapshot 
Fixes https://github.com/dart-lang/sdk/issues/48447

TEST=Added to compile_test.dart

Change-Id: I2435a9933ee16da0e9b25de4a53e464872b4b16e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235162
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-03 19:22:30 +00:00
Sam Rawlins ed68a37df7 Tidy code in dartdev 
Just code I was tidying while investigating a dartdev bug. Complies
better with Effective Dart.

* https://dart.dev/guides/language/effective-dart/design#dont-redundantly-type-annotate-initialized-local-variables
* https://dart.dev/guides/language/effective-dart/design#avoid-abbreviations

Also restrict a utility function to accept a non-nullable String and
return a non-nullable String.

Change-Id: I465a320cbd4fe9f7625119e873f67425b4caf8e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-28 23:35:57 +00:00
Devon Carew e6ff207cf8 [dartdoc] rev to dartdoc 5.0.0 
Change-Id: I25ce5abb97eef229fd61d308742f7a034f961ab4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234442
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-02-25 23:40:33 +00:00
Ben Konyi 1486443d6e Reland "[ CLI ] Attempt to execute samples generated by 'dart create' templates" 
Adds missing `PUB_CACHE` entry to a couple of places where a new process
is spawned.

This reverts commit 7a7c36ab2f.

Change-Id: I198deeb29ab32ca325b4d918b36ab94609a17de1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227560
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-02-25 20:05:42 +00:00
Devon Carew f99e6a824d [dartdev] minor update to the server template's description 
Change-Id: If6e03feb0c54bfb914d3d20c27c1b63b9468c456
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234441
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-02-25 19:22:24 +00:00
Ben Konyi 45bebe43bb [ CLI ] Fix tests generated by server-shelf template 
Fixes https://github.com/dart-lang/sdk/issues/48263

Change-Id: I07c818dcb8e8b8797f97d6658912f65a0eadc1f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234329
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-02-24 22:11:46 +00:00
Ilya Yanok b7b5b25a3d Don't start analysis for dart fix command 
`edit.bulkFixes` method doesn't need previous analysis results since
it starts everything itself.

Change-Id: I829bb30922afd4686727f7701def8284ef164185
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234046
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Ilya Yanok <yanok@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-24 19:04:35 +00:00
Ben Konyi ee5837aa7a Revert "[ Service ] Update VM service message to not reference Observatory" 
This reverts commit f9147d933e.

TEST=N/A

Change-Id: Idef34b70f1066ddf79d02588dfba7caeec443e7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234325
Reviewed-by: Dan Field <dnfield@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2022-02-24 18:32:14 +00:00
Michael Thomsen 2244be02e1 Simplify template names. 
Also adds support for alternate template names,
so this is a non-breaking change as the older
template names still work.

xcodebuild/DebugX64/dart-sdk/bin/dart help create
Create a new Dart project.
...
Available templates:

         console: A command-line application.
         package: A package containing shared Dart libraries.
    server-shelf: A server app using `package:shelf`
             web: A web app that uses only core Dart libraries.
Change-Id: I81e981c065de2cbc967bf2f2020760886be8b074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232800
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2022-02-23 12:10:34 +00:00
Ben Konyi f9147d933e [ Service ] Update VM service message to not reference Observatory 
See https://github.com/dart-lang/sdk/issues/46756

TEST=Existing

Change-Id: Ib71bf00d667369d7438a4547ae444951ec0979df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233504
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-02-18 20:53:52 +00:00
Devon Carew bd5da72538 [dartdev] tweak the pubspec file generation for 'dart create' 
Change-Id: I769ef258b9875aeeb23bc9aeca396bc9594197d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232980
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-02-14 21:23:59 +00:00
Devon Carew 554b001ad9 [dartdev] adjust the behavior of several 'dart doc' cli flags 
Change-Id: I9efdd71da948b87b0fcbcd2b3e242647131462b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232120
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-02-10 18:55:41 +00:00
Kenzie Schmoll deb9cd31e7 Add missing 'help' option to DevTools server arg parser. 
This option existed in the previous impl of devtools server: https://github.com/flutter/devtools/blob/v2.10.0/packages/devtools_server/lib/src/server.dart#L507-L516

Change-Id: Icdc2f1b29e9128531a51fbc471c7b52e761e8f31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232122
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2022-02-08 19:15:56 +00:00
Ben Konyi 250173e60c [ CLI ] dartdev null-safety migration cleanup 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/229948

Change-Id: If5624638eeb629ea025ec04b6a11d23144ea43ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231741
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2022-02-04 19:23:40 +00:00