dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
88,085 Commits 2 Branches 0 Tags
ab217c355f5f2ef9f6340170c0fbd94de0fa1923
Commit Graph

410 Commits

Author SHA1 Message Date
Konstantin Shcheglov c7ebfde808 Fix highlighting local variable names in ForPartsWithDeclarations. 
Change-Id: I60b9f054e46909f53e9a1c6cab58e109ae279f3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266442
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-28 19:50:39 +00:00
Danny Tuppeny 172bcc33dd [analysis_server] Fix hover on constructor name declarations 
Change-Id: I6254a8a8d82a1f2b12e8fa3589fbe114d9945af6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-10 16:43:57 +00:00
Greg Spencer 73bb76184f Fix Windows tests, return absolute paths from example navigation 
Fixes failing post-submit Windows tests,
and causes the examples/api IDE navigation results to return absolute paths.

Change-Id: If6d1ca9848644b78ff6f8e9549b84df7139b7ffc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261801
Auto-Submit: Greg Spencer <gspencer@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-29 16:58:51 +00:00
Danny Tuppeny dd12cfd073 [analysis_server] Filter "see code in" navigation regions to requested range 
This fixes one of the issues noted in https://github.com/Dart-Code/Dart-Code/issues/4181, where all example regions would be returned for a code block instead of only those that matched the requested region.

This was because the code that handles comments didn't go through helpers in `_DartNavigationCollector` that does the filtering.

Change-Id: I58931c02f0e4f538c246dc8fc0c3e57895cad5fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-28 19:33:36 +00:00
Greg Spencer ae7e3517c8 Add a test for examples/api navigation, and fix it 
This adds a test for the dartdoc "See code in examples/api..." navigation in the analysis_plugin, and changes things so that it doesn't walk the directory tree to find the examples directory more than once per compilation unit.

Change-Id: I1938396b160ca2d21b08214f79fb1c7ddbf6a388
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Greg Spencer <gspencer@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-28 16:31:26 +00:00
Konstantin Shcheglov ace52d922b Semantic highlighting for record type annotations and literals. 
Change-Id: I16fb395a721f4fdd63cbf23b931551ea0f5c8682
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-08 21:55:53 +00:00
Konstantin Shcheglov 6f0fe880c4 Breaking changes for analyzer version 5.0.0 
Reland of https://dart-review.googlesource.com/c/sdk/+/243164

Change-Id: I5167844ea1001f026cf8d9b82465a79f560d188d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257267
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-07 16:27:18 +00:00
Brian Wilkerson cf2448e5d4 Fix the windows bot 
Change-Id: If0525c4a0caaa9e229ea2c516d916e1e3a323a34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257426
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-03 04:38:23 +00:00
Brian Wilkerson a186d80b0f Add semantic highlighting support for record literals 
I don't believe that we need any semantic highlighting for record types.

Change-Id: I33d8d3b91c30e4780e6909d4d201f211cefe9814
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257425
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-02 22:32:14 +00:00
Brian Wilkerson 2f758c7389 Add tests for hovers related to record types and literals 
As far as I can tell, there's no implementation work that needs to be
done. Let me know if there's an interesting case that I missed.

Change-Id: Ib6200d07fd2c6ef21749e522705810f537f053df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257423
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-09-02 20:12:43 +00:00
Konstantin Shcheglov ff8024fc78 Revert "Breaking changes for analyzer version 5.0.0" 
This reverts commit d8df88cbe4.

Reason for revert: breaks Flutter HHH, requires updates to linter

Original change's description:
> Breaking changes for analyzer version 5.0.0
>
> Change-Id: Id9f27b6c41829249f6b2e7b93ad396643193fc78
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243164
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I6ca213427189c169ddacbd89f60d463efa2c38f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257122
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-31 21:05:19 +00:00
Konstantin Shcheglov d8df88cbe4 Breaking changes for analyzer version 5.0.0 
Change-Id: Id9f27b6c41829249f6b2e7b93ad396643193fc78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243164
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-31 05:08:50 +00:00
Danny Tuppeny 857a0d2e66 [analyzer] Resolve comment references for inherited members 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4114.

Change-Id: I47fe2909e4d09366c1e2f432c31076ba690fac7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256162
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-25 14:29:43 +00:00
Konstantin Shcheglov 05d01e79cc Highlight 'required' in SuperFormalParameter. 
Change-Id: Ia25378e88eced277bb6242c8cea6bbf09dbb521a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-08-18 15:56:17 +00:00
Konstantin Shcheglov 4eb511da43 Replace more Bazel with Blaze, some simplifications. 
Change-Id: I096860e17ce56c2f602718f11706f24989c1f65b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-15 19:50:46 +00:00
Konstantin Shcheglov 43065920cc Rename Bazel to Blaze - files, classes, methods. 
No changes to implementation yet, we still look for both Blaze and Bazel.

Bug: https://github.com/dart-lang/sdk/issues/49629
Change-Id: Iaf1b1cc2c9a8cf28d8bbfb5541819a1f5c8a3de6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254343
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-10 16:00:18 +00:00
Brian Wilkerson 0a1793eb5d Move the tests for legacy refactorings 
This reflects the recent change to the implementation classes.

Change-Id: I0867a274c830d34f46c858713f0df511b7b811c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254066
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-09 04:22:42 +00:00
Konstantin Shcheglov 01173e2aa2 Deprecate 'name' in AST, use 'name2' token instead. 
Change-Id: I867f009dca12208f835199297d2ea85c203c8556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252566
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-02 16:25:34 +00:00
Konstantin Shcheglov 2e86c1f018 Deprecate AnalysisDriver.dispose(), use dispose2() instead. 
Change-Id: Icfb46bf83f3a1f5828efd76eab1014c4dee0e088
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251587
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-15 17:15:40 +00:00
pq 3efd79b4b5 linter 1.26.0 
Change-Id: I0a20fd9f26933908f6c40cb1019fca45b9a88299
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250949
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-07-11 20:00:21 +00:00
Konstantin Shcheglov d19e1d16b9 Use LibraryFileStateKind to link. 
Change-Id: I35a88c71e9cd1c6e05d3de28ecb7c5dabf75defd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250680
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-07 18:08:31 +00:00
Danny Tuppeny a2f9ad4ba7 [analysis_server] Tweak navigation regions/targets for named constructors 
+ fix an issue with constructor declarations not returning any matches at all for LSP which provides an offset.

Fixes https://github.com/Dart-Code/Dart-Code/issues/4020.

Change-Id: Id59c83e32630c4ab947e3c3062b55989c78d1c61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248581
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-06-16 17:47:59 +00:00
Konstantin Shcheglov 33b6483ad1 Support for AugmentationFileStateKind. 
Change-Id: Ib32b7b56739d89118c9a497087dc5066bab177dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-25 16:54:38 +00:00
Danny Tuppeny 2591ed885b [analysis_server] Handle navigation for "part of"s using URIs 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3970.

Change-Id: I972f8811f0819d3018f36cb36ed796b8dafc1b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-24 16:23:47 +00:00
Brian Wilkerson b088f98e05 Add the hooks to capture analytics for requests and responses 
In the process of testing this I found (and fixed) a couple of bugs
introduced in the recent conversion of the legacy code to handler
classes. I wanted to validate that I'd added hooks in all the right
places, so I wrote an AnalysisManager to keep track of request/response
pairs. It showed that some extra responses were being generated. I'm
still debating how best to add this to the normal tests to prevent
regressions, so you'll probably see it in another CL at some point.

Change-Id: Ib203c02ef27b6efb53a41a48696a3a39e61ed800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245260
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
 2022-05-19 13:24:40 +00:00
Konstantin Shcheglov e28972166c Return PartWithoutLibraryResult when a part without its library. 
Change-Id: I5eb384d77c263b489b10e112a79115bf028e79af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245081
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-18 16:45:53 +00:00
Konstantin Shcheglov cbab0c5245 Issue 48281. Update navigation to field formal parameters. 
In constructor initializers the reference is to the parameter itself,
not the field.

Bug: https://github.com/dart-lang/sdk/issues/48281
Change-Id: Ic875e68d9b0d4ebdc08b3a8e71ecd8f0e52c3c26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-16 15:32:19 +00:00
Brian Wilkerson 45d8c7ee4b Stop using main in test code in more places, part 3 
Change-Id: Ia35343f4d79037875fe154a38a3adcf8117d9369
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243881
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-06 22:34:50 +00:00
pq 68fa0e96d0 rename local functions with _s 
These will be flagged by the next linter release which updates `non_constant_identifier_names` to flag local functions.

Change-Id: If663698d9cab270accd477a507071232905bc083
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-04-27 00:23:06 +00:00
Konstantin Shcheglov cf36021633 Migrate AnalysisHoverBazelTest to BazelWorkspaceAnalysisServerTest. 
Change-Id: Ibafbeb27d6b494c2139a298dd3e3cab74c7c1e4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241994
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-22 21:07:29 +00:00
Danny Tuppeny 84fbee066e [analysis_server] Add KEYWORD highlight/semantic token for "var" in for loop 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3932.

Change-Id: Ie37dfb884761e0f23c05c9eb2ec5ea7f98f02a82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-19 16:59:47 +00:00
Konstantin Shcheglov 994b2e2f47 Deprecate newAnalysisOptionsYamlFile2(), use newAnalysisOptionsYamlFile(). 
Change-Id: Ia86808f649459e6c4c9c7d4e488273c1e593a85b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241515
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-19 15:49:57 +00:00
Konstantin Shcheglov 20b560226e Rename newFile2() to newFile(). 
Change-Id: I1c2a4f15dee607a0a6241dfaf2d764a7d284389b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-19 02:59:57 +00:00
Konstantin Shcheglov 61c05151e7 Fixes for errors in dart:core for mock SDK. 
Change-Id: Id4d244aeee3609e58081235e6eba2b04b7aced15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-16 02:01:14 +00:00
pq 16b436151a migrate server to recommended lints 
See: https://github.com/dart-lang/sdk/issues/48785

Change-Id: I1bec40cc0b52e5df5f07c35ec993e08c56a59cbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240907
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-04-12 13:34:12 +00:00
Konstantin Shcheglov 9ab676b6d0 Migrate analysis domain tests to PubPackageAnalysisServerTest. 
Change-Id: I684d027906b118d2c0fddd8f64930ae291ed8827
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-30 17:01:00 +00:00
Konstantin Shcheglov 0640f6e1e3 Move navigation tests to PubPackageAnalysisServerTest. 
Change-Id: I7c98b5621bca9b204a253faec5e45488e1ef1bc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-29 18:09:51 +00:00
Konstantin Shcheglov 38a0305768 Inline 'testFilePathPlatform' as 'testFile.path'. 
Change-Id: I6b27af152f91a639e1dfc09a2b1a4da286692a38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239124
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-29 05:55:45 +00:00
Konstantin Shcheglov 4247bcbbdc Extract PubPackageAnalysisServerTest. 
Change-Id: Ib952f26c226f147221471af0366bf9c95c7bc5b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-28 21:48:20 +00:00
Danny Tuppeny 7e46465786 [analyzer] Make ConstructorElement.nameLength consistent with offset/end 
Fixes https://github.com/dart-lang/sdk/issues/48677.

Change-Id: I4198a58e6cf3e61e4e1bdf6e4f3f766fcc8efdeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-28 20:08:50 +00:00
Konstantin Shcheglov 7f2350f386 Move some AbstractAnalysisTest based tests to PubPackageAnalysisServerTest. 
Change-Id: I8d2fd9a2a6f01aaf0394069c9a0c3f7d72229d96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239011
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-28 15:46:30 +00:00
Danny Tuppeny 065b771844 Include const keyword tokens for constructor declarations 
Fixes https://github.com/dart-lang/sdk/issues/48676.

Change-Id: If06412500a7ec7af097b4f69d514c11621e1ed5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239027
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-28 15:42:21 +00:00
Brian Wilkerson 306dd6e4eb Convert a sync handler to an async handler 
If this seems like a reasonable approach to converting syncronous
handler implementations into async handler classes, then I can tackle a
few more to see how far I can get.

Let me know if you think this kind of change should wait to land until
after we've cut the next branch. It appears to be fine, based on tests,
and we can revert if we find an issue before that date, but still ...

Change-Id: I7a3aa248add24e9e871d6818864ab7f5d5b0a215
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238941
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-28 14:58:21 +00:00
Konstantin Shcheglov 41b3e0abcc Make 'content' required in ResourceProviderMixin.newFile() 
Change-Id: Id697b0736b95a913c31247a66425027852f1ddc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-14 17:31:48 +00:00
Konstantin Shcheglov 6de7ea7432 Don't remove overlays immediately, wait for the next watch event. 
Change-Id: Ie3352bf70010de88874aea122d83a5533a00a1ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-14 17:21:28 +00:00
Konstantin Shcheglov 5fa65048c1 Use file_paths.pubspecYaml instead of 'pubspec.yaml' literal. 
WDYT ?

Change-Id: I6677b2237e0558c74bb11073dcfb44d7b672323f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-10 19:03:55 +00:00
Konstantin Shcheglov 1531030b42 Stop using newDotPackagesFile() in analysis_server/. 
Change-Id: Iaa4e8657ee1d5f115ab62177570aa662494b9d9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-09 23:56:15 +00:00
Konstantin Shcheglov 1693908268 Apply file changes between (not during) other operations. 
This would be a breaking change, so for now it is disabled, but
the method `applyPendingFileChanges()` can be added, and the clients
will call it to be ready for the switching the flag.

Only clients that call methods like `changeFile` have to await applying
the file changes. Other clients can continue using synchronous
`currentSession`.

Change-Id: I0f8d4cc874f485776f611790f6c80fd7e07c8051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-09 18:16:45 +00:00
Danny Tuppeny da5670c677 [analysis_server] Fix end locations of navigation regions for code sample links 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3867.

Change-Id: Icdfc93c1b03fdd4c40e3ea4563045d993cb50c32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-09 16:40:25 +00:00
Konstantin Shcheglov 601b5379a8 Tests for hover and enums. 
Change-Id: I633d6aaf8e0ff425aeb4b461677d6aaff187f85f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234911
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-02 23:36:31 +00:00