dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
88,085 Commits 2 Branches 0 Tags
ab217c355f5f2ef9f6340170c0fbd94de0fa1923
Commit Graph

40891 Commits

Author SHA1 Message Date
Kallen Tu ab217c355f [analyzer/cfe] Add an experiment flag for sealed class. 
Have a separate flag from patterns, even though sealed families are to be shipped with patterns -- keep the work separate for now.

Change-Id: Ic3996b81d9a61f2a3b1e5137e7cc32ecc8bdec9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267289
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2022-11-05 00:20:50 +00:00
Mateus Felipe C. C. Pinto 82143e6c95 [analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter 
Bug: https://github.com/dart-lang/sdk/issues/49796
Change-Id: Ide144ceb57bae94a71b9d1a7ec841d03363fc121
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258200
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-04 23:38:40 +00:00
Srujan Gaddam 186e4c5c25 [dart2js] Do static interop erasure for both dill and src 
This is a reland of https://dart-review.googlesource.com/c/sdk/+/266803.
Performance regressions came from visiting core libraries. To avoid
this, this CL skips all core libraries that aren't in an allowlist.

Change-Id: I68bbf8b8df6863dfc9deeca487a66ff60947b841
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267769
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-11-04 23:11:41 +00:00
Brian Wilkerson ca7ab1e89d Add documentation on tokens 
This was written in response to a question from a contributor.

Change-Id: If689b1a22ac00a6a5a14cc09f47054a88baa4347
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268101
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-04 22:20:49 +00:00
Stephen Adams 238c74cbb8 [dart2js] Migrate ssa/nodes.dart 
Migrate the cycle containing the four files nodes.dart, invoke_dynamic_specializers.dart, logging.dart, and validate.dart

Change-Id: I64aa8308e54f980e79e3405d9b751225306e39df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267900
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-11-04 21:56:47 +00:00
Anna Gringauze cc80ccfaa0 Fix stack overflow in mixin application from separate library 
Make sure that calls to super class methods from mixin application
stubs are always generated using `super` and not `this`.

Replacing `super` by `this` should not be used as non-virtual field access optimization in forwarding stubs that intend to redirect to the super class members (using `this` redirects to itself and causes infinite recursion).

Closes: https://github.com/dart-lang/sdk/issues/50119
Change-Id: Ib9c9aebdc88555518998db64aefa1fd0905c5b11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267822
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Anna Gringauze <annagrin@google.com>
 2022-11-04 21:25:08 +00:00
Joshua Litt d4db1e8f8e [dart2wasm] Disable disallowed external check. 
Bug: 50381
Change-Id: I2344a4d5c5b91acc44efb5d0c1ee10386eedd12c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268061
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2022-11-04 21:17:55 +00:00
Konstantin Shcheglov 303d907237 Add Pattern type variable to TypeAnalyzer. 
Change-Id: I3d88b0337689efecffac228c9acf03a5a52229d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267461
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-11-04 19:23:37 +00:00
Nate Biggs 9766e53168 [dart2js] Migrate dump_info.dart to null safety. 
Change-Id: I0b6232bb29866777b7048e30bed62abab10016d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267824
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-11-04 16:39:53 +00:00
Keerti Parthasarathy 81ebaee9a2 Fix for unecessary string escape in a string interpolation 
BUG: https://github.com/dart-lang/sdk/issues/50150

Change-Id: Ia3ab2e4cca951cb8006f6b59d5e3bea2c38ef4e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267460
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-04 16:17:30 +00:00
Joshua Litt 84c695a38d Reland "[test] Fix some tests for Dart2Wasm." 
This CL cleans up the logic in two tests to better prepare for Dart2Wasm. In addition, env_test has been cleaned up now that the multitest no longer makes sense.

Change-Id: I0a7eabff1e2bfb6ea7aa1078ee85a58db9886e21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267286
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-11-04 16:10:39 +00:00
Sigmund Cherem fbcccdefc9 [dart2js] migrate main_call_stub_generator 
Change-Id: I7f8933d9a1de71418f03cf48b4afebfbadc0d0bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267767
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2022-11-04 15:27:13 +00:00
Sigmund Cherem 53c712e47b [dart2js] migrate interceptor_stub 
Change-Id: Id1e75a59b758c979ab8384d0a250ea2aa1df4380
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267766
Reviewed-by: Nate Biggs <natebiggs@google.com>
 2022-11-04 15:27:13 +00:00
Sigmund Cherem 1f8bad1a75 [dart2js] Migrate instantiation_stub 
Change-Id: Ib9cce2bb5f2e2787daac390309418d59ac27fd54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267764
Reviewed-by: Nate Biggs <natebiggs@google.com>
 2022-11-04 15:27:13 +00:00
Sigmund Cherem 3318b5d892 [dart2js] Migrate class_stub_generator 
Change-Id: I1461174b57713431b4f8c87aea04d9fc7a83cfa1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267763
Reviewed-by: Nate Biggs <natebiggs@google.com>
 2022-11-04 15:27:13 +00:00
Nate Biggs 1aecd5bcce [dart2js] Migrate serialization/strategies.dart to null safety. 
Change-Id: Iad23474f69b78231a6c77da5f5b8b379618f77be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267820
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
 2022-11-04 15:11:27 +00:00
Nate Biggs 3ed70b013b [dart2js] Remove JClosedWorld interface and use only implementer, JsClosedWorld, everywhere. 
Change-Id: I9641033aa3a93a28ee428ddc63aa7fc337e5468a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267802
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-11-04 15:11:27 +00:00
Chloe Stefantsova f01126211f [cfe] Implement the desugaring for NullCheckPattern 
Additionally, fix the revealed variable declaration issues of
VariablePattern and change more remnant mentions of Matchers and
Binders.

Part of https://github.com/dart-lang/sdk/issues/49749

Change-Id: I8f31bb1038f29768c82e0cfa4b55bfee3e0e16c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267581
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2022-11-04 12:40:26 +00:00
Chloe Stefantsova 51ad58d2fe [cfe] Allow inferred and aliased record types in opted-out libraries 
Part of https://github.com/dart-lang/sdk/issues/50317

Change-Id: Icaed6443759a337769c4abaddd09b167f622db07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267363
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2022-11-04 11:16:25 +00:00
Jens Johansen dda5ed11f9 [CFE] Fix potential null pointer crash in the incremental compiler 
Crash seen in https://github.com/flutter/flutter/issues/114672

Change-Id: I647cbc97aefee7702ca5c14f4b8999cfc444db49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267920
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-11-04 11:03:14 +00:00
Chloe Stefantsova 523257ab8a [cfe] Add license headers to the patterns testcaes 
Part of https://github.com/dart-lang/sdk/issues/49749

Change-Id: I61cd83124083f2e017101be3ea020e04583023e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267600
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2022-11-04 09:20:19 +00:00
Konstantin Shcheglov 24ffc8838d Issue 50373. Catch InconsistentAnalysisException. 
Bug: https://github.com/dart-lang/sdk/issues/50373
Change-Id: I60947122e63e683cb425df91be2e7039f443e957
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-11-04 00:41:38 +00:00
Srujan Gaddam b597b7571a Revert "[dart2js] Run static interop erasure regardless if from dill or src" 
This reverts commit 5d7029e288.

Reason for revert: Increases memory usage in dart2js benchmarks

Original change's description:
> [dart2js] Run static interop erasure regardless if from dill or src
>
> Removes modular transformation as well.
>
> Change-Id: Ib3aafcaf35b72fdb6a93db682dcf8df84842578f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266803
> Reviewed-by: Joshua Litt <joshualitt@google.com>
> Commit-Queue: Srujan Gaddam <srujzs@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I8c40f16983a3f7e2383dcf3b47c2134c9ecd6746
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267762
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
 2022-11-03 23:12:50 +00:00
Nate Biggs 902e5d030e [dart2js] Remove isConstructor from entity model in favor of type test. 
Change-Id: Id082b573478e3d916bb450b12a9d57f3a852f158
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267800
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
 2022-11-03 20:48:12 +00:00
Nate Biggs 863ae7b60e [dart2js] Remove isField from entity model in favor of type test. 
Change-Id: I94d854ea34f610f0212bc7b1abeedfa90c67968d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267741
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-11-03 20:48:12 +00:00
pq eff76309dc validate pubspec screenshot paths 
See: https://github.com/dart-lang/sdk/issues/50179

Change-Id: I589809f17d45adfc6f1e3850d2109e58ec47af13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-11-03 20:44:48 +00:00
Paul Berry 402a05de1b Add record type parsing to mini_types.dart. 
We now no longer need the `expr2` function to test expressions whose
type is RecordType.

Also added unit tests of the type parser in mini_types.dart (which was
previously tested only by virtue of its use in other tests).

Change-Id: I5d351f3ff924676b4d84e65c8949f42feca0dab9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267522
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-11-03 19:41:47 +00:00
Paul Berry 941056459a Change NamedType to not extend Type 
The NamedType class in mini_types.dart doesn't really represent a type
in the same way that the other subclasses of Type do; it's simply a
pairing of a name and a type.

Change-Id: I20709e66a44da4afbf187984c2032b315c1cc21e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267287
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-11-03 17:35:39 +00:00
Johnni Winther 2794cb9e17 [cfe] Check redirecting factory patches 
In response to https://github.com/dart-lang/sdk/issues/49898

Change-Id: Ib87fb7558f85e9d8b956f1946e1e5de062deca4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267500
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2022-11-03 16:26:44 +00:00
Nate Biggs beacf3d7bf [dart2js] Migrate inferrer/type_graph_inferrer to null safety. 
Change-Id: Ib6f82a9b7fd58d7185f4d3b9997f2c0eacfa33cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267248
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
 2022-11-03 16:18:40 +00:00
Nate Biggs 217c18f296 [dart2js] Clean up inferrer/engine migration files. 
Change-Id: I22a2b14eee779900881b54c40723e5cc59113d90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267247
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-11-03 16:18:40 +00:00
Nate Biggs 08c981a387 [dart2js] Migrate inferrer/engine.dart to null safety. 
Change-Id: I3eff0355904d5c221946c2ee3549128f771aa731
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267246
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-11-03 16:18:40 +00:00
Alexander Markov 3afb674e52 [vm] Cleanup kernel format versioning from the VM 
TEST=ci

Change-Id: I9116d0e60aa073733fee3ce523fb5cbc2fb692f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267440
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2022-11-03 15:44:25 +00:00
Danny Tuppeny e417e3c3f7 [analysis_server] Fix folding for nested blocks in line-folding-only mode 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4242.

Change-Id: Id2dd55085ed02879c2dcf581a5f4164e0df6b1c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-03 14:42:19 +00:00
Johnni Winther 05ff50e6ca [kernel] Add View and ViewType 
These are needed for the 'views' feature. No nodes are created yet.

TEST=existing

Change-Id: I0c7a34e460a4d17bd39ee23e7aa6bd8851f4275e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266620
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-11-03 08:42:06 +00:00
Alexander Aprelev 4ae1500152 [gardening] Fix instruction_sizes_test on Windows 
Bug: https://github.com/dart-lang/sdk/issues/45354
Change-Id: Idbf22076bf01e9dcbe20a6d99993b3283edc067f
TEST=ci
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267244
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2022-11-03 01:50:48 +00:00
Nate Biggs 6539e200b8 [dart2js] Migrate inferrer/type_graph_dump.dart to null safety. 
Change-Id: Idc6af28c0bb257e78f11aa4c89ba04c1a67aebed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267242
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-11-02 23:55:48 +00:00
Nate Biggs 2bfabc6392 [dart2js] Migrate inferrer/builder.dart to null safety. 
Change-Id: I0e9a51b72ee619932f324b5f636b4788faa7ad76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267241
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-11-02 23:55:48 +00:00
Brian Wilkerson dd7fcfaa43 Revert 215546 to fix a regression 
Change-Id: Idc99e68b217ba9c24c9a06d65756d1885d30a3e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267281
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-11-02 21:45:11 +00:00
Konstantin Shcheglov d27d206108 Add analyzeRecordPattern() to the shared TypeAnalyzer. 
Change-Id: I10e582a32f60db8bba8acf1f9cc8578469c51f77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267442
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-11-02 21:06:33 +00:00
Joshua Litt d61c47fb8f Revert "[test] Fix some tests for Dart2Wasm." 
This reverts commit 7f0fa313cc.

Reason for revert: Breaks a VM test

Original change's description:
> [test] Fix some tests for Dart2Wasm.
>
> * bool_from_environment_test is updated with the correct check.
> * env_test is updated to consolidate some of the test cases so that it
>   has the correct behavior on all backends.
>
> Change-Id: I1cb2d7f3ddd7042b26eda4fee2616aa47a55bd74
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267221
> Commit-Queue: Joshua Litt <joshualitt@google.com>
> Reviewed-by: Aske Simon Christensen <askesc@google.com>

TBR=askesc@google.com,joshualitt@google.com,dart-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I338a280f48d362b5b021df58c56fbb3978489932
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267284
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-11-02 20:45:57 +00:00
Joshua Litt dee7aa0a91 [dart2wasm] Implement async* via lowering. 
Change-Id: Iebd4d215b71aed8a7e8cff751902f8fa48ff5ae9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262627
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2022-11-02 19:46:48 +00:00
Derek Xu 40defeeb44 [VM/Service] Support records in the VM Service 
This makes VM Service responses involving records comply with
https://docs.google.com/document/d/1gq7ZlH9My2qIrlFY7-pceNmabOPLLeLVMt6Z44KE7_8.

service.md and package:vm_service are not yet updated by this CL. They
will be updated in a future CL that makes as much of the service comply
with the above proposal as possible without introducing breaking
changes.
e.g., the future CL will make it so that both the `decl` and `name`
properties will be populated for fields of `PlainInstance`s.

TEST=CI

Issue: https://github.com/dart-lang/sdk/issues/49724
Change-Id: Iff798e391d28f137a000352c15e180f32e3d3969
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264782
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2022-11-02 19:32:54 +00:00
Ahmed Ashour 919a0460fb [analysis_server] fix data-driven constructor matching 
Fixes #50363

Change-Id: Ib7f7e3f9320c39135d4ddbeebd751b04c142b9cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-02 19:29:27 +00:00
Joshua Litt 1dc57aca9e [dart2wasm] Handle default arguments to callbacks more consistently. 
Change-Id: I88f511ea84640b9078b788eecba0700b878485d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266869
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2022-11-02 19:12:38 +00:00
Ahmed Ashour 1928cd3f82 [analysis_server] fix packageName of DataDriven fix files 
Fixes #50358

Change-Id: Id852dc2c53cb562c33ec2728b4cf07d518d6a298
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267364
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-02 18:34:17 +00:00
Srujan Gaddam 5d7029e288 [dart2js] Run static interop erasure regardless if from dill or src 
Removes modular transformation as well.

Change-Id: Ib3aafcaf35b72fdb6a93db682dcf8df84842578f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266803
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2022-11-02 18:12:28 +00:00
Stephen Adams 35d37349cf [dart2js] Preparation for migrating ssa/nodes.dart 
- Make HInstruction visitors generic.

Change-Id: I9b3a14422a0eec50e0b2ae08d78b8c597482ad31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263221
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-11-02 17:22:15 +00:00
Stephen Adams feb6af023b [nnbd_migration] Fully migrated directories are initially collapsed 
This saves a lot of manual scrolling or collapsing for large projects
that are well along in migration.

Change-Id: I6891ea57d94f157ecf722ba4c55a27cd21d28d19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267223
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-11-02 17:17:41 +00:00
Joshua Litt 9fd8bf01db [dart2wasm] Handle implicit nullable initializer. 
This is to handle the case where a nullable local is used in a loop. In such a case, if we do not implicitly initialize the variable, it will retain its state across multiple loop iterations.

Fixes lib/convert/html_escape_test

Change-Id: I35d4ebe827e2486e847659b2e6b494a1af2be57f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267120
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-11-02 16:25:49 +00:00