20fc81470e
Fix override_on_non_overriding_method hint
...
Change-Id: I9a53115b5542abe0791324f26449dc210662d096
Reviewed-on: https://dart-review.googlesource.com/c/91763
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 18:06:35 +00:00
ca4978e363
Add pkg:analysis_tool as an SDK-only set of utils
...
Reduces the API surface of pkg:analyzer that requires pkg:html
Related to https://github.com/dart-lang/sdk/issues/35802
Change-Id: Icd08d76190d6ab77cd180561cdde6df254b22557
Reviewed-on: https://dart-review.googlesource.com/c/91701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kevin Moore <kevmoo@google.com >
2019-01-31 16:52:05 +00:00
e5164be27e
Issue 35127. Fixes for mixin implements / overrides.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/35127
Change-Id: I5869175cee13b6e22ce25c2d361b0b1aa52efe48
Reviewed-on: https://dart-review.googlesource.com/c/91690
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 16:01:55 +00:00
c31627b778
Remove the unused TypeOverrideManager
...
Change-Id: I031c2777e6b9d5cfd46bc0bc1978dfde95a316b7
Reviewed-on: https://dart-review.googlesource.com/c/91692
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 15:19:05 +00:00
485a41bb12
Include superclass constraints into mixin type suggestions.
...
R=brianwilkerson@google.com
Bug: https://buganizer.corp.google.com/issues/123231336
Change-Id: I0e1ce9a332f47211ef2614ae73009433d1839ba0
Reviewed-on: https://dart-review.googlesource.com/c/91691
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-31 15:12:15 +00:00
8f12035f36
Clean up the diagnostic tests
...
Change-Id: I0c9e962246d4c83036f91ba49b0a28dd9d1c3c4b
Reviewed-on: https://dart-review.googlesource.com/c/91688
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 14:57:05 +00:00
d6608f19c0
Check function types in subtype tests
...
Change-Id: I27b38e2a6edc67e13662aa16da2fde13dc2501e9
Reviewed-on: https://dart-review.googlesource.com/c/90922
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-31 08:58:10 +00:00
a6a9d4854b
Start checking type arguments in subtype tests
...
Change-Id: I4832eac17be7129cfe846df0f088e59b8fa9cd6c
Reviewed-on: https://dart-review.googlesource.com/c/90921
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-31 08:58:10 +00:00
dd70ecd5c0
Substitute type variables when computing class hierarchy
...
Change-Id: Ic447c2ae8aaa0bc033749de68bc6a93f6e6fcb1e
Reviewed-on: https://dart-review.googlesource.com/c/90741
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-31 08:58:10 +00:00
85c5082cf4
Support Kernel classes in ClassHierarchyBuilder
...
Change-Id: I0de3cc8c1e51aa3b429fd5aba3cdf7e0e5281154
Reviewed-on: https://dart-review.googlesource.com/c/90706
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-31 08:58:10 +00:00
18ff842341
Start testing Fasta types implementation
...
Change-Id: I93a95319cc6390beaddc36a2b35737a097096fda
Reviewed-on: https://dart-review.googlesource.com/c/90705
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-31 08:58:10 +00:00
db44a727e5
Extend the edit.dartfix protocol
...
This CL extends the dartfix protocol to allow specifying which
fixes should be applied. In summary:
* includedFixes - list of fix names to be applied
* includeRequiredFixes - bool indicating required fixes should be applied
* excludedFixes - list of fix names that should not be applied
Given that the client can specify the fixes to be included/excluded,
then the dartfix cmdline help text should include the list of known fixes.
Rather than hard code this in the dartfix client, a new edit.getDartfix
request has been added to return the list of known fixes.
Change-Id: I319f6f405a5d29757bf28b70b778a449f901bbef
Reviewed-on: https://dart-review.googlesource.com/c/91700
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 01:53:32 +00:00
6c96d8fdaf
Fix crashing analysis_server with some defensive null checks
...
Bug: https://github.com/dart-lang/sdk/issues/35814
Change-Id: I1536e77adb9fe4699201ca8e0462b0f5154ca127
Reviewed-on: https://dart-review.googlesource.com/c/91686
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-01-30 23:19:19 +00:00
3b5c1012e9
Update CodeChecker to handle the code-as-ui features
...
Change-Id: Iaea7e63b9ee6c5fe7f57da22c0215c9caa316a3e
Reviewed-on: https://dart-review.googlesource.com/c/91685
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-30 22:48:27 +00:00
b8fc017778
Replace convertAbsolutePathToUri() with toUriStr().
...
Change-Id: Ib34247ce7457ada7e4705714984034387f09a80c
Reviewed-on: https://dart-review.googlesource.com/c/91684
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-30 20:47:56 +00:00
f903ee6dc0
Don't crash on formal parameters without name, exclude private SDK lbiraries.
...
R=brianwilkerson@google.com
Change-Id: Ie5d72458c6d19fb250591550d47c4076082dff1e
Reviewed-on: https://dart-review.googlesource.com/c/91683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-30 19:48:28 +00:00
118bdcc1f6
backlink to language docs for customized analysis
...
Follow up from: https://github.com/dart-lang/linter/issues/1365 .
Change-Id: Iaeef849406b191d99a84501884c3d34b37ccb59d
Reviewed-on: https://dart-review.googlesource.com/c/91681
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-30 18:01:04 +00:00
bc2a5a6789
Generate some of the code-as-ui diagnostics; implement more resolution
...
Change-Id: I6d5ac14d5b6cb601d6d968a8140bc63435519230
Reviewed-on: https://dart-review.googlesource.com/c/91586
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-30 16:40:46 +00:00
e8a0a209e3
Include into Declaration data that we will need for pre-cached suggestions.
...
R=brianwilkerson@google.com
Change-Id: Ie4419e785c06fa7b3913359e5831e97c611f46a7
Reviewed-on: https://dart-review.googlesource.com/c/91587
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-30 16:31:34 +00:00
0bb1aee3ff
AstBuilder cleanup
...
Change-Id: I83f936d353df8828795b4236655147ea414866b9
Reviewed-on: https://dart-review.googlesource.com/c/91621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-01-30 15:12:34 +00:00
ec13e61df3
Move question getter from GenericFunctionType and NamedType to their common base class.
...
Change-Id: I5f9494a0c354f5b1fc2ec08c7e748dd795671752
Reviewed-on: https://dart-review.googlesource.com/c/91680
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-30 14:59:24 +00:00
71bee8f05e
Fix serializing procdure when realClass is Object from dart:core.
...
Bug: 34224
Change-Id: I244ed3c15a2e134f1599588a156a7ff45917d4be
Reviewed-on: https://dart-review.googlesource.com/c/91641
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-01-30 08:44:05 +00:00
2632e201b7
Support for DeclaredIdentifier(s) in new ForEachPartsWithDeclaration/ForElement(s).
...
R=brianwilkerson@google.com , danrubel@google.com
Change-Id: I589d427fca83129bf96c78070b05f61fdac74b27
Reviewed-on: https://dart-review.googlesource.com/c/91584
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-30 02:11:14 +00:00
4e0aa3ff37
Run ddb with debug port open
...
Change-Id: I5d83cd7deb789499517d1cf1d2a251655bff5924
Reviewed-on: https://dart-review.googlesource.com/c/90760
Reviewed-by: Jenny Messerly <jmesserly@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2019-01-29 23:15:04 +00:00
b196cd2acb
Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
...
Downgrade INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED and INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL to warnings.
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I4399839e04135a5d9a557c0ab06f319d9759af23
Reviewed-on: https://dart-review.googlesource.com/c/91460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 22:35:15 +00:00
25d8456c48
Small improvements for DeclarationsTracker.
...
R=brianwilkerson@google.com
Change-Id: Ic35e7cead9a50b9eb8ae590f9fbf85df0a8f7fc1
Reviewed-on: https://dart-review.googlesource.com/c/91583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-29 22:33:34 +00:00
081160036a
Fix #35306 , improper recursion detection.
...
Bug: 35306
Change-Id: I28f7a298ebf701f9709cb3f49eff07da4cf01fd4
Reviewed-on: https://dart-review.googlesource.com/c/90880
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-01-29 21:28:49 +00:00
6f5556c88a
Prepare to publish analyzer version 0.35.0.
...
Change-Id: Icd0cd786a2b7746046367ca4315748d33381c590
Reviewed-on: https://dart-review.googlesource.com/c/91580
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-01-29 20:27:37 +00:00
011a1239fc
Support for out-of-band worker in AnalysisDriverScheduler.
...
It will be used to perform work of searching for available declarations
and sending corresponding completion libraris notifications.
R=brianwilkerson@google.com
Change-Id: I21b23c4fadf1dc679c16ff00a47149d62707ae51
Reviewed-on: https://dart-review.googlesource.com/c/91581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-29 20:09:47 +00:00
09e6a689c2
parse nested control flow collection entries
...
Change-Id: Id50c0a53a51f076dd75dd5bc13a694663449bc83
Reviewed-on: https://dart-review.googlesource.com/c/91400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 17:53:58 +00:00
213cfdc85e
Update AstBuilder to generate new for statement structure
...
... if control flow or spread collection entries are enabled.
Change-Id: I8718c1f7a649b7a2a7c9e376a6bf67c1df0542cf
Reviewed-on: https://dart-review.googlesource.com/c/91320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 17:53:58 +00:00
93a56336a3
Parse simple for control flow collection entires
...
... and address comments in:
https://dart-review.googlesource.com/c/sdk/+/91144
https://dart-review.googlesource.com/c/sdk/+/90901
Change-Id: I7a9288bf28e069832193bd8a196a11f9a407b20d
Reviewed-on: https://dart-review.googlesource.com/c/91300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 17:53:58 +00:00
d73d3183a2
Fix dead_code hint
...
Change-Id: I30eb074b5346f7c53997e585eda31b374445d807
Reviewed-on: https://dart-review.googlesource.com/c/91500
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 14:58:54 +00:00
f5fd281150
Prevent unsound promoted bounds from being used as arguments
...
Fixes https://github.com/dart-lang/sdk/issues/35100
Change-Id: I65f73f40d0ea970f0631599e01b177412fc32a40
Reviewed-on: https://dart-review.googlesource.com/c/90390
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 14:46:04 +00:00
cf56801308
Garbage-collect compiled libraries
...
If - for instance - a file (say 'main.dart') tries to include a part
(say 'lib.dart') that is not part of that file (i.e. doesn't state
something like 'part of "main.dart"'), and the file ('lib.dart') is not
otherwise used, before this change, the library ('lib.dart') would be
included in the first comile, but on subsequent re-compiles wouldn't
include it because it's not referenced, nor ever cleaned up
(and would thus be re-compiled.)
This change garbage-collects the library as it's not referenced.
Change-Id: I8fa90b3ae6fc3d99af9fec780abe62855e653ddb
Reviewed-on: https://dart-review.googlesource.com/c/90385
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-01-29 14:25:44 +00:00
8fc9eaf06c
Support to run co19_2 on ddk
...
Change-Id: I93b9752655385d0e26cdf97d0f8224a88c198657
Reviewed-on: https://dart-review.googlesource.com/c/90781
Commit-Queue: Vijay Menon <vsm@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2019-01-29 13:50:02 +00:00
812a6af41a
Anonymous mixin applications are abstract
...
Change-Id: Ib36a0bd243010a5b51bf49bda750d7e432017eae
Reviewed-on: https://dart-review.googlesource.com/c/90703
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2019-01-29 13:29:32 +00:00
977e5b31e2
Support type variables on function types and intersection types
...
Change-Id: Ic4f6f26f1e779e9fc084a06f546584f826a6e720
Reviewed-on: https://dart-review.googlesource.com/c/90382
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 13:29:32 +00:00
f822d0abb8
Make CoreType test friendly
...
The classes Future and Stream are exported by dart:core.
By attempting to look up FutureOr in dart:core before dart:async,
we support simple a simple test scenario where there's only one
platform library.
Change-Id: I76627f89957b91fbdb52a7772c177a769c37cecb
Reviewed-on: https://dart-review.googlesource.com/c/90381
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 13:29:32 +00:00
d025ff5367
Copy subtype tests
...
The tests are copied from pkg/kernel/test/type_subtype_test.dart
Change-Id: I1120aa7ae1928fc20982f24fab14925b9ee851c8
Reviewed-on: https://dart-review.googlesource.com/c/90229
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 13:29:32 +00:00
219a2fcf66
Revisit existing constants in the constants transformer.
...
Unevaluated constants are re-evaluated, and evaluated constants are
re-canonicalized.
Change-Id: I241f6b5d734797101ab1168746a849713c104695
Reviewed-on: https://dart-review.googlesource.com/c/91230
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-01-29 10:36:12 +00:00
97cb74cf63
Tweak the subtype rule for Null
...
Change-Id: I3c1f1af40f5930a02355f8d986a27db606998096
Reviewed-on: https://dart-review.googlesource.com/c/90980
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 10:04:21 +00:00
5fbf15d9c4
Mixins have no static members
...
Change-Id: I93b43ad2d58ab2804ed7deafeadb6346eade9eab
Reviewed-on: https://dart-review.googlesource.com/c/91481
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2019-01-29 09:54:52 +00:00
c5a954794b
Fix PackageBuildWorkspacePackage's contains
...
This implementation did not check whether the path was actually contained
in the package:build workspace. It also made an assumption about how a
resource which is a directory would be treated, which was masked by an
unconditional-and-silenced catch.
The existing test which should have caught this had a hidden exception,
caught by the same unconditional-and-silenced catch. :(
Bug: https://github.com/dart-lang/linter/issues/1393
Change-Id: I0a6ecb584e06877463a47681830eed8f6f914030
Reviewed-on: https://dart-review.googlesource.com/c/91441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-01-29 02:01:51 +00:00
d84851daf8
[vm/bytecode] Capture receiver if creating a closure
...
When creating a closure, receiver is loaded in order to obtain
instantiator type arguments. That access was not capturing
receiver, if a closure was created inside another closure.
Change-Id: I9ec6d9f2c90643e6deb9c4efde1b070a3255a387
Reviewed-on: https://dart-review.googlesource.com/c/91442
Commit-Queue: Régis Crelier <regis@google.com >
Auto-Submit: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2019-01-28 23:41:01 +00:00
1ba59eb13d
Make ERROR the default severity for StaticWarningCode. Remove _StrongModeTypeErrorProcessor.
...
As a preparatory step for re-landing https://dart-review.googlesource.com/c/sdk/+/91170
and making these two restored problems to warnings.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I6266632ade84743b5725c54475fe402902576c00
Reviewed-on: https://dart-review.googlesource.com/c/91420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 22:08:17 +00:00
95b017a888
Implement changeFile() and recompute available libraries and declarations.
...
Some renames in tests.
R=brianwilkerson@google.com
Change-Id: Ia54752c816bbc62f99a200d62658b6f4dfb26480
Reviewed-on: https://dart-review.googlesource.com/c/91381
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-28 18:05:17 +00:00
ec5ba8a252
Revert "Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden."
...
This reverts commit 6699384dddhttps://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8923238548150736816/+/steps/analyze_flutter/0/stdout
Original change's description:
> Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
>
> R=brianwilkerson@google.com , paulberry@google.com
>
> Bug: https://github.com/dart-lang/sdk/issues/34437
> Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
> Reviewed-on: https://dart-review.googlesource.com/c/91170
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I07c96c8131c16b2748a403f38d5f15b814131c63
Reviewed-on: https://dart-review.googlesource.com/c/91360
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 17:09:24 +00:00
7daa9f65fc
Start supporting resolution of the code-as-ui constructs
...
Change-Id: I8fba9bfcac2339b113de6bc2954821585e7b8ab4
Reviewed-on: https://dart-review.googlesource.com/c/91240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 15:12:47 +00:00
69af7af70d
Additional tests for interpolation and CONVERT_TO_MULTILINE_STRING.
...
For discussion in https://dart-review.googlesource.com/c/sdk/+/91262
R=brianwilkerson@google.com
Change-Id: Ib25a5da32ade4d4bccef8856867761e153a6d5dc
Reviewed-on: https://dart-review.googlesource.com/c/91263
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 15:08:06 +00:00
Paul Berry