dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
30,924 Commits 2 Branches 0 Tags
a75b05bc31e0d6ee12d550fa528e002ded3fd528
Commit Graph

849 Commits

Author SHA1 Message Date
scheglov@google.com ec67f0c0c5 Issue 23184. Fix for exception when 'async' is used outside of a function body. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23184

Review URL: https://codereview.chromium.org//1098493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45219 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 19:39:39 +00:00
brianwilkerson@google.com e57ae7de7b Rename method for consistency 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1091003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45214 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 16:22:13 +00:00
danrubel@google.com 118f05d804 suggest "this." local fields in constructor param 
BUG=dartbug.com/22685
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1082233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45213 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 16:06:26 +00:00
paulberry@google.com cd1dd1864b Fix additional cases where analysis server might send null, violating protocol. 
In addition, modify the code generation so that these protocol
violations will be caught by assertions during unit tests.
Previously, they would only be caught at runtime by client code.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1083223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45211 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 15:41:39 +00:00
paulberry@google.com cb319b21cd Fix "edit.format" to follow protocol when there is no selection. 
BUG=dartbug.com/23230
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1092653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45210 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 14:44:55 +00:00
paulberry@google.com 7e53bd2b1f Avoid redundant calls to "pub list" when multiple dependencies change. 
BUG=dartbug.com/22574
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1089453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45170 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-15 16:02:18 +00:00
paulberry@google.com 5b1c199b22 Prevent analysis exceptions from crashing the completion engine. 
Prevent CompletionDomainHandler.priorityChanged() from crashing if the
future returned by DartCompletionManager.computeCache() completes with
an error (which can happen in the event that an exception occurred
while analyzing the file in question).

BUG=dartbug.com/23176
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1080323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45142 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-14 16:30:23 +00:00
danrubel@google.com 29d83d3cb5 improve keyword suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1084613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45113 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-13 17:44:19 +00:00
scheglov@google.com 9448ea0f06 Use working cache size when request resolved units in requests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1081903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45111 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-13 16:35:16 +00:00
brianwilkerson@google.com dbfb8bf97d Create a public API for contributing assists and make assists pluggable 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1073383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45109 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-13 16:03:50 +00:00
brianwilkerson@google.com 46064e8f2f Create a public API for contributing fixes and make fixes pluggable 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1080653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45079 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-10 21:01:10 +00:00
scheglov@google.com 2e2bb91f26 Move getElementAt() to CompilationUnitElement. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1080503003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45072 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-10 16:57:51 +00:00
danrubel@google.com 9efad0a88f add suggestions for named param 
BUG=dartbug.com/22403
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1078943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45047 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-10 01:23:23 +00:00
scheglov@google.com 3acb224c1d Add await/async when a method with 'await' in its body is extracted. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1055183004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45036 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 21:16:17 +00:00
scheglov@google.com ed26cdbf05 Remove old debug output. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1070223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45025 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 18:40:00 +00:00
scheglov@google.com 28c4a74388 Tweaks for Element encoding and decoding. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1067363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45016 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 16:09:07 +00:00
danrubel@google.com a22a7c47ff do not suggest local functions 
BUG=dartbug.com/23131
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1076773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45014 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 15:58:59 +00:00
scheglov@google.com 976eeb8df4 Use file/offset/kind triplet as elements id. 
It saves about 20 MB for each ToDo MVC sample.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1075773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45011 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 15:21:12 +00:00
danrubel@google.com 0a1f0d3fc9 refactor optype to better filter invocation/prefixed suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1072623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45001 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 12:16:28 +00:00
danrubel@google.com de06a0607e fix NSMError in completion 
BUG=dartbug.com/23114
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1069813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44979 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-08 18:42:25 +00:00
danrubel@google.com a34401414c improve parser recovery for import statements 
BUG=dartbug.com/23108
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1068263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44978 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-08 18:26:00 +00:00
danrubel@google.com 509dd4988a suggest loadLibrary is import is deferred 
BUG=dartbug.com/23108
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1065063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44953 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 22:20:04 +00:00
danrubel@google.com 2a7093fa25 suggest deferred/as keywords 
BUG=dartbug.com/23108
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1067143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44952 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 22:17:20 +00:00
danrubel@google.com ec456501b5 do not suggest elements from internal sdk libs 
BUG=dartbug.com/23104
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1064743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44939 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 16:52:43 +00:00
scheglov@google.com 4d9b8090a0 Tweaks for 'Encapsulate Field' assist. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1066913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44936 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 15:33:53 +00:00
danrubel@google.com 1e83a73221 rename completion source files to match content 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1068483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44921 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-06 17:46:39 +00:00
danrubel@google.com 259dac94cc rename completion computer to contributor 
* this will be followed by a separate CL that renames related files

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1060713005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44918 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-06 17:25:09 +00:00
scheglov@google.com a9bbd436f5 Issue 13239. Add the 'Encapsulate Field' refactoring. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=13239

Review URL: https://codereview.chromium.org//1062823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44912 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-06 15:44:33 +00:00
paulberry@google.com 4af80fc1e7 Add an analysis server option to enable null-aware-operator support. 
The option may be enabled in editor by setting the tracing option
"experimental/nullAwareOperators" (in com.google.dart.tools.core) to
true.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1063613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44909 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-06 14:53:00 +00:00
danrubel@google.com 9eede4128e suggest dynamic and void when defining new compilation unit members 
BUG=dartbug.com/23063
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1048303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44895 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 22:18:39 +00:00
danrubel@google.com 9f492ecbe6 fix keyword completion in class body 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1057403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44894 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 22:12:56 +00:00
scheglov@google.com 8a1f8b158b Issue 23091. Fix for adding import prefix before string-interpolated identifier. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23091

Review URL: https://codereview.chromium.org//1059133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44893 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 21:58:59 +00:00
scheglov@google.com cadcd05f73 Issue 22988. Improve checking for conflicts between parameters and local elements during extracting methods. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22988

Review URL: https://codereview.chromium.org//1053323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44891 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 21:04:26 +00:00
danrubel@google.com 4e903a637e do not suggest completions for empty dot target 
BUG=dartbug.com/23095
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1056163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44887 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 20:38:50 +00:00
danrubel@google.com 8bf9e95e6e replace request.node with request.target 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1054363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44886 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 20:34:20 +00:00
scheglov@google.com 17ea180d2c Issue 23081. Fix for inlining into IndexExpression index. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23081

Review URL: https://codereview.chromium.org//1052243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44863 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-02 17:19:08 +00:00
danrubel@google.com 2329562cc0 replace request.node with request.target.containingNode in more situations 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1050743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44852 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-02 00:41:20 +00:00
brianwilkerson@google.com 83c9fe01a6 Fix a null-pointer reference and minor clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1053723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44844 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-01 20:57:33 +00:00
danrubel@google.com caff47a011 add type completions after "on" in a try block 
BUG=dartbug.com/23028
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1053663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44839 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-01 19:29:57 +00:00
scheglov@google.com e154d7ac6a Tweaks for hover - local variables and methods. 
1. We don't need enclosing class and library for local elements.

2. None of the elements other than methods append class name in toString(), so remove it there too.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1050983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44838 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-01 18:24:16 +00:00
scheglov@google.com 8bf13093b1 Fix removing type annotations for const/final variables. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1051733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44836 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-01 18:08:28 +00:00
scheglov@google.com 44ce3ba66b Use parsed unit/class nodes instead of resolved in fixes. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1047673005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44821 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-31 20:43:41 +00:00
danrubel@google.com 39598962a0 fix NSM error when completing imported inherited private fields 
BUG=dartbug.com/23036
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1050483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44805 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-31 16:00:31 +00:00
danrubel@google.com 62d8532dc5 Gracefully degrade if no source for completion 
BUG=dartbug.com/22617
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1044463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44796 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 21:43:05 +00:00
brianwilkerson@google.com b396bc4c96 Support refresh of individual analysis roots (issue 22254) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1047733004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44791 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 21:07:23 +00:00
danrubel@google.com a8eb426282 add UNKNOWN_SOURCE error code and remove 2 unused legacy error codes 
BUG=dartbug.com/23039
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1042403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44787 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 20:12:29 +00:00
scheglov@google.com 028f13011e Issue 23027. Try to make priority files analyzable. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23027

Review URL: https://codereview.chromium.org//1044463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44786 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 19:50:10 +00:00
scheglov@google.com c4729ac121 Issue 22617. Add/remove overlay-only sources to their containing contexts. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22617

Review URL: https://codereview.chromium.org//1042923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44782 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 16:57:33 +00:00
paulberry@google.com 3f96c05547 Clean up analyzer hints. 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1042913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44781 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 16:54:02 +00:00
brianwilkerson@google.com 8c298b499e Recognize nested pubspecs (issue 22907) 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1042293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44780 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-30 16:01:03 +00:00