Joshua Litt
a73e8c2cf2
[dart2wasm] Support unmodifiable typed data views.
...
Also wires up a couple of missing APIs for some of the simd lists.
Change-Id: I9da5be59bc3b4553cb27c570f9d7c0b98b10409b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264890
Reviewed-by: Ömer Ağacan <omersa@google.com >
Commit-Queue: Joshua Litt <joshualitt@google.com >
2022-10-21 17:28:35 +00:00
Danny Tuppeny
27d417dc09
[analyzer] Fix setter in test
...
Change-Id: Ie5d31dcf300936690d9cf476bed64b8615474e8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265090
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-21 17:15:36 +00:00
Ahmed Ashour
3817a4ab66
[analysis_server] TransformSetManager to use cache
...
Fixes #50252
Change-Id: I0e29af6d5e718459c8dbf6bbce81a1652c1b51bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-21 17:04:05 +00:00
Konstantin Shcheglov
671bb192ab
Remove domain 'kythe' from DAS.
...
Change-Id: I66f0e538dce6eead6ba1c98b9cf0e3d747450130
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264895
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-21 17:03:29 +00:00
Danny Tuppeny
3e587da7f0
[analyzer] Add the ability to locate an Element from an ElementLocation
...
Change-Id: If2f3bfcdaa330dc1bcb9c1078500e982660ae8c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-21 15:26:46 +00:00
Johnni Winther
8995807b2b
[cfe] Create various matcher in the body builder
...
This add the Expression-, Binary-, Cast-, NullAssert-, NullCheck-, List-
and RelationalMatcher and creates these during body building. The
IfCaseStatement is added to support propagation of these to the
inference visitor.
Change-Id: Ia9add15e504cb06af711efc1697a00b8e235e1a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263128
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
2022-10-21 14:01:02 +00:00
Sam Rawlins
e7c590b137
Make some bool fields in nullability_node non-nullable
...
Change-Id: If50538f4e4c189d45af0a2c22e7a6a19a29c7f68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265080
Auto-Submit: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2022-10-21 13:23:57 +00:00
Konstantin Shcheglov
6c60f506c8
Resolve RecordPattern(s).
...
Change-Id: I229efb591cbb2d6cfe77b38155526f881fee7dbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264891
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-21 09:10:27 +00:00
Stephen Adams
b03b9c3712
Redo "[kernel] Create Source.sourceCode as view of the binary bytes"
...
Retrying now that https://github.com/dart-lang/sdk/issues/50206 is fixed.
Change-Id: I2612e53c845b2e906ab51bfe39db2fe775e10bca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264602
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2022-10-21 01:11:47 +00:00
Ahmed Ashour
470f394424
[analysis_server] don't remove empty statement when in dead code
...
Bug #50188
Change-Id: I19abc92900f6c939778e240e3df2d17ae4068967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-20 19:21:37 +00:00
Devon Carew
de55cba4d0
[pkg/analysis_server_client] refactor member sort test
...
This refactors the member sort test so that this package does not depend on unpublished packages
(analysis_server, ...). This makes it possible to publish this package without having to have
local (non-git) modifications.
Change-Id: I52bdaa459c2e219f38ac930468647b4d7c4165e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2022-10-20 18:44:15 +00:00
Lukas Klingsbo
6e4e12922a
DateTime copyWith extension
...
This change has been discussed for 8+ years and it would of course be preferred
to be added as an instance method, but since that is a breaking change I added it as an extension as discussed here:
https://github.com/dart-lang/sdk/issues/24644#issuecomment-1241695835
Change-Id: Iebb9f300e449920ae8891abac88f30b271321661
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258541
Commit-Queue: Lasse Nielsen <lrn@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
2022-10-20 10:50:25 +00:00
Sigmund Cherem
3719dbf671
[dart2js] cleanup after fix.
...
Now that type parameters can occur nested within type literals there
is no reason to special-case type parameters. Now that we don't
consider type literals to be always constant, it is safe to remove
this extra check and handle type parameters the same as a generic
type literal containing a type parameter.
Change-Id: I887d162e20fd29f3285d73149927e51e1f1d1753
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264894
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2022-10-19 23:18:54 +00:00
Sigmund Cherem
0f16027f86
[dart2js] Fix for deferred loading bug.
...
Long ago Dart didn't support generic type literals and the deferred
loading algorithm assumed that in the ConstantCollector visitor. Now that Dart supports them, we need to ignore them if they get encountered.
Fixes #49851
Change-Id: I637f70a74bbe5ca8fc76c2f8ff79e97eeac19182
Fixed: 49851
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264884
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2022-10-19 21:50:07 +00:00
Konstantin Shcheglov
76c8886ff5
Use NnbdMode.Strong for frontend_server/ binary protocol.
...
Bug: https://github.com/dart-lang/sdk/issues/50100
Change-Id: Ibbacffd90c49d1446df4a59fd718b53017dda0f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262441
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2022-10-19 21:40:13 +00:00
Konstantin Shcheglov
4461156b2e
Add a few more tests for extractor pattern resolution.
...
Change-Id: Ic0cb05ae0bbc958e0136f4c6abac9e72327c4f75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264888
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-19 20:43:47 +00:00
Devon Carew
93d2077a7d
[pkg/analysis_server_client] rev version in preparation for publishing
...
Change-Id: I60f9485bf0dd76123bb42214ece4030e0a8fd5c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264882
Commit-Queue: Devon Carew <devoncarew@google.com >
Auto-Submit: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-19 20:00:07 +00:00
Danny Tuppeny
1b38b7bb7b
[analysis_server] Move TestCode from analysis_server to analyzer
...
Change-Id: I81333240d7693b66416ce6bb308f980b264a2238
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-19 19:58:47 +00:00
Paul Berry
5349d8c602
Migration: account for generic bounds when determining whether null checks are necessary.
...
Previously, if a variable with a generic type was null-checked, and
the migration engine did not add a question mark to the type of the
variable itself, e.g.:
f<T extends Object?>(T x) {
if (x == null) { ... }
}
Then the migration tool would erroneously consider the null check
unnecessary. It failed to account for the fact that the bound on the
generic type might be nullable.
This change fixes the tool so that it now properly accounts for the
bound on the generic type variable.
Bug: https://b.corp.google.com/issues/247496662
Change-Id: I2b131e75b7e3fc5db0b668f1064340d404442c82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264501
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2022-10-19 19:44:20 +00:00
Sigmund Cherem
b8b81d4d19
[dart2js] migrate js_world_builder
...
Change-Id: I794a773e49f267d187af3ea76a596007a40224d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264343
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2022-10-19 19:39:03 +00:00
Sigmund Cherem
da689b6531
[dart2js] migrate universe/codegen_world_builder
...
Change-Id: Ia85fdc3b9b018475be29ab96e0e9928ba1b9a153
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264342
Reviewed-by: Nate Biggs <natebiggs@google.com >
2022-10-19 19:39:03 +00:00
Sigmund Cherem
71ff066c1e
[dart2js] Migrate js_world.dart.
...
This also fixes a couple nullability signatures in world.dart and class_set.dart
Change-Id: I11b383c312a2320ae4ea7bac36c46c3f80fb7e0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264341
Reviewed-by: Nate Biggs <natebiggs@google.com >
2022-10-19 19:39:03 +00:00
Sigmund Cherem
4990d73002
[dart2js] Migrate kernel strategy
...
Change-Id: Ib8b251bc69e42c414e6519595af75c10187abbef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264340
Reviewed-by: Nate Biggs <natebiggs@google.com >
2022-10-19 19:39:03 +00:00
Danny Tuppeny
eea14037e0
[analysis_server] Add support for range marker shorthand in TestCode
...
Change-Id: I70efc2fd32de128351aa9fd8c10555dbd1391da4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264864
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-19 18:13:57 +00:00
Konstantin Shcheglov
eea6fb106d
Look for BUILD.gn files to identify ContextRoot(s) with GnWorkspace.
...
This rehabilitates language server support for Fuchsia.
This makes GnWorkspace more like PubWorkspace, not like BlazeWorkspace. The workspace is the location of `BUILD.gn` file (and is identical to the package, although I did not change this in this CL). And there must be also `.jiri_root` somewhere above it.
We don't look for `pubspec.yaml` files to decide that we have a new `ContextRoot`, instead we rely on `.dart_tool/package_config.json` created by `Pub` from `pubspec.yaml`. For GN, I had to specialize it to look for `BUILD.gn` files.
With this change `BUILD.gn` takes preference over any other signal, so we don't care if there are `pubspec.yaml` files.
Fixed: fuchsia:109640
Change-Id: I2277336bd377abb9d8c8c33529183e21b2f51c4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-19 17:57:50 +00:00
Devon Carew
2dc6b5dd55
[pkg/js] update package:js changelog; prep for publishing
...
Change-Id: I9a9bdb94f9aeed1364f4905a4734fc7b2512c81d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264262
Reviewed-by: Joshua Litt <joshualitt@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2022-10-19 17:51:32 +00:00
Alexander Markov
671717b578
[vm/aot] Support dynamic record field access in TFA
...
TEST=language/records/simple/dynamic_field_access_test
Issue: https://github.com/dart-lang/sdk/issues/49719
Change-Id: I811db5c649988cbadf7ab29e5c4c70366f55e86b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262845
Reviewed-by: Slava Egorov <vegorov@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2022-10-19 17:49:47 +00:00
Konstantin Shcheglov
d923f69436
Resolve WhenClause in SwitchStatement cases.
...
Change-Id: I836d0bec357597490ad7302e90ff9e4740547810
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-19 17:27:38 +00:00
Danny Tuppeny
5b1ca7eef1
[analysis_server] Remove string_scanner dependency from TestCode
...
Change-Id: Ia31efb8b5fede64d91ed1669219d11014afe25c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-19 16:28:25 +00:00
Paul Berry
d9a5551af9
Front end logic for field promotion.
...
This is the common front end implementation of the new field promotion
feature (https://github.com/dart-lang/language/issues/2020 ).
There is no behavioral change yet unless the user activates field
promotion by enabling the experiment flag `inference-update-2`.
Change-Id: I0d1e0893af862c3af8a0ef4ea10e803606d48d7e
Bug: https://github.com/dart-lang/language/issues/2020
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260451
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2022-10-19 14:53:51 +00:00
Danny Tuppeny
f350c474e7
[analysis_server] Fix Windows test failures
...
Change-Id: I1f19b4a775c8bad217f88b9b3d272fed334f0dc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264843
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-19 14:50:56 +00:00
Alexander Thomas
0b26f4816b
[testing] Remove --compiler=none from test.py
...
* Use dartk as the default compiler for runtime=vm.
* Status file entries for checking for the `none` compiler now either
use dartk or are deleted.
Tested: Standard CQ and local testing.
Fixes: https://github.com/dart-lang/sdk/issues/50241
Change-Id: I7a08d3e491ae1c82a0348fb66ea7b557398f97e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264682
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2022-10-19 08:09:58 +00:00
Sigmund Cherem
9846309cf0
[ddc] use snapshot when running worker test.
...
The snapshot is already available in the build directory, this makes the
test save up 11 times all the parse and warmup costs of loading the
compiler in the VM.
In aggregate, this made the test run in 5 seconds instead of 2 and half
minutes on my local desktop.
Change-Id: Ic0f1ef030b06467999fd0178b599de697f8ccc94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264730
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2022-10-19 01:27:41 +00:00
Konstantin Shcheglov
f14aba03e7
Use shared analyzeIfStatement()
...
Change-Id: I9271fb21538faeacc0625e8c48f7add860f86e60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264726
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2022-10-19 00:40:47 +00:00
Konstantin Shcheglov
f42bb9dffc
Support for replacing WhenClauseImpl.expression
...
Change-Id: I0e19b5bdbc32b77ccb29bb40ffd8191c04ffa208
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264728
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-18 22:39:49 +00:00
Konstantin Shcheglov
5fc57dfbb3
Add commas to AST Impl where all named parameters.
...
So, that it is easier to find ones that don't use named parameters
yet with `^ \w*Impl\([^{]` regular expression.
Change-Id: I1621093e4d41ca43f781d63781dc5883fef12ab2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264729
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-18 22:34:41 +00:00
Konstantin Shcheglov
5a0f6c2aef
Remove released languge features from experiments.
...
Change-Id: I3b3398f8c7a932e2b4e0ceace20d10ff0d520150
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264727
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-18 22:31:46 +00:00
Brian Wilkerson
3785d6f59a
Convert RefactoringProducer to use coveringNode
...
Change-Id: Iab2296aeba88085b1ec97afd755e03d4bf8de002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264062
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-18 21:05:26 +00:00
Konstantin Shcheglov
e3f77e928f
Add BlazeWorkspace.forBuild()
...
Change-Id: I2b896716c7dc7f53c400e6ea516ecf0439e347b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264723
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-18 20:34:17 +00:00
Brian Wilkerson
c42ab25787
Refactor TestCode to prepare to move it to analyzer
...
This is the first phase of preparing it to be moved. The plan is for the
extensions to remain in this library along with an export of the new
library in the analyzer package.
The second phase will be to rewrite it to not use string_scanner so that
we don't have to add a dependency to the analyzer package.
Change-Id: I0d4e9c47bdcb7b825a9d3bfc76331a4e575ac664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-10-18 18:31:53 +00:00
Konstantin Shcheglov
138c956bcd
Parse CaseClause for IfElement.
...
Change-Id: Id0ea8da51b3492768d734884fee43d913f9c69ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-18 18:30:39 +00:00
Brian Wilkerson
1ded24ae31
Allow LintCode to override the default documentation URL
...
We need this in order to override the default as we start to migrate the
linter docs to the new format. We also need this for internal lints.
Change-Id: I9da7be2e6c657b390ae355cdfcd1e007c70769fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264061
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-10-18 17:57:41 +00:00
Srujan Gaddam
521cbcdd47
[pkg:js] Disallow external extension members with type parameters
...
Bug: https://github.com/dart-lang/sdk/issues/49350
Checks to see that external extension members on `@staticInterop` types
do not declare or use a type parameter.
Change-Id: Id8646b599094b748c5490810b64d872065676014
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254103
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Joshua Litt <joshualitt@google.com >
2022-10-18 17:47:29 +00:00
Srujan Gaddam
b6526beeab
[pkg:js] Disallow staticInterop generative constructors
...
Fixes https://github.com/dart-lang/sdk/issues/48730
Change-Id: I4c7f687ec8d2724de0e031aa5ebe887f93843761
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254101
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2022-10-18 17:47:29 +00:00
Joshua Litt
ea541423d0
[dart2wasm] Perform some missing runtime type normalizations.
...
This CL also changes the runtime algorithm to fully substitute
interface type parameters before performing type checks. This change is unfortunate, but necessary so that normalization of types works as expected. In the longer term we should cache generated types to avoid redundant work.
Change-Id: I9441ccdea8c6a9ac598cae043937cf683616d227
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262821
Commit-Queue: Joshua Litt <joshualitt@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2022-10-18 17:36:41 +00:00
Danny Tuppeny
ffe4a8c864
[analysis_server] Prevent convert method<->getter refactors on SDK/external package files
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4221 .
Change-Id: I1a017f098d3d72bc19c91cead4c68b2666c5fe01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-10-18 16:24:16 +00:00
Konstantin Shcheglov
8dc77f6fdc
Remove READONLY support from BlazeWorkspace.
...
It was deprecated in 2019.
https://sites.google.com/a/google.com/git5fordummies/Home
Change-Id: I0b2d4fb0624bc70b7952de5496d280c84172beb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264600
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-18 16:06:08 +00:00
Brian Wilkerson
b6d278be10
Clean up quotes in messages.yaml
...
Change-Id: If09b1b35830c659f3c5bd5615e9966190e5d4b48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263560
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-10-18 15:00:58 +00:00
Paul Berry
cf50ee8eb4
Prototype integration of shared type analysis logic with CFE.
...
This change replaces the InferenceVisitorImpl.visitSwitchStatement
with a call to the new shared type analyzer, and implements the
necessary callbacks to allow analysis to work end-to-end.
Change-Id: I73a9514428b4ce092762d3ea450545986d0e1ea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257491
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2022-10-18 14:33:18 +00:00
Ben Konyi
39168c9ef0
[ CLI ] Fix dart run --enable-experiment
...
Fixes issue where --enable-experiment options passed after `dart
run` weren't being handled by the VM.
Fixes https://github.com/dart-lang/sdk/issues/50205
TEST=pkg/dartdev/test/commands/run_test.dart
Change-Id: Ia9c585a16756fd4450cfd159a1b9864ebfb6d200
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264200
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-10-18 13:42:32 +00:00