dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

79322 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Johnni Winther 91be638a56 Add support for --verbosity in bazel/kernel_worker 
Change-Id: If1c1cd2feb1c5341c3b7631dfe12888ce7eac249
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182221
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2021-02-02 15:25:44 +00:00
Sam Rawlins 237c84249b Remove unnecessary imports in analyzer 
Change-Id: Ifb9a5c0a31cf3669febf2981b1d26b84f5b9d237
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180781
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-02-02 14:40:24 +00:00
Clement Skau ee2f0702e9 [VM] Removes #35505 status file exception. 
Issue #35505 has been closed, and the test is no longer failing.
This is causing test runs to fail because this test _isn't_ failing.

TEST=Tested previously failing test locally.

Bug: https://github.com/dart-lang/sdk/issues/35505
Change-Id: I0664683ec26e40a42ad60340718c78b1392b823d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182267
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Clement Skau <cskau@google.com>
 2021-02-02 13:55:24 +00:00
Vyacheslav Egorov d7a57a5df4 [vm] Add feature to connect AOT code to code comments via .debug_line 
Option --write_code_comments_as_synthetic_source_to=file tells AOT
compiler to create a file which contains code comments for all code
objects written into an ELF snapshot and then emit a DWARF line number
program into .debug_line section which attributes code to code comments
in a way similar to how our own disassembler does it.

This enables tools like objdump to display our code comments as part of
the disassembly.

This CL also tweaks ifdefs in such a way that IL printer and code comments
facilities is now included into PRODUCT gen_snapshot binary.

TEST=manually run product build with --print-flow-graph and --write_code_comments_as_synthetic_source_to

Change-Id: Id6741013d43e1733b4ddeb34891a4d2fc06b9313
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181380
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2021-02-02 11:35:00 +00:00
Vyacheslav Egorov e5e88fd3cc [vm] Add vm:unsafe:no-interrupts pragma to force remove all CheckStackOverflow 
For microbenchmarking it is good to be able to force VM to drop
all stack overflow checks in a given function to reduce overhead of the
measuring loop to the minimum.

This pragma might have other applications, e.g. to allow writing tight
loops in core libraries.

TEST=CheckStackOverflowElimination_NoInterruptsPragma

Change-Id: I07c7fec5c49a893bbb0e4f557d89f022b90be141
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181400
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2021-02-02 11:19:00 +00:00
Clement Skau 49398488da [VM] Fixes closure resolving in HandlesException 
TEST=vm-kernel-precomp-*

Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-android-release-arm64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-asan-linux-release-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm_x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-mac-release-simarm64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-simarm_x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-precomp-tsan-linux-release-x64-try,vm-kernel-precomp-ubsan-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try,vm-precomp-ffi-qemu-linux-release-arm-try
Change-Id: Icfcfbc73d00464d8c4e287bfb43a40432837b80f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182220
Auto-Submit: Clement Skau <cskau@google.com>
Reviewed-by: Clement Skau <cskau@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2021-02-02 09:20:00 +00:00
Clement Skau dfd5413952 [VM] Adds Debugger break for Future.catchError 
TEST=Added new Future.catchError pause-on-unhandled-exceptions test.

Bug: https://github.com/dart-lang/sdk/issues/37953
Change-Id: Ieb3cf834eacad4f9b98ab2db0e5813e9bfa09747
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180840
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2021-02-02 06:59:54 +00:00
Alexander Aprelev 6dffbdabf1 [vm/concurrency] Deoptimize active code on all threads when debugging/hot reloading. 
Issue dartbug.com/36097

TEST=existing vm test suite

Change-Id: I18951245b2c0f34e4b9a4babc0f859878c0f2109
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181560
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-02-02 02:58:23 +00:00
Konstantin Shcheglov cd54e90c78 Require null safe version of package_config and watcher 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I34809b0bb681a831486c078deaac8b291e620aa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182160
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-02 00:28:23 +00:00
Konstantin Shcheglov d129808d3e Extract FileState._getUnlinkedBytes 
So that we can avoid some null checks.

Change-Id: I2f798589e0dbae6802cfde879dfb73978c211728
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-01 23:41:11 +00:00
asiva 34f9734b41 Revert "[cfe] Handle conditional await in CFE" 
This reverts commit 14032a6209.

Reason for revert : Several customer flutter tests are failing because
of the change in behavior.

TEST=revert of previous CL.

Change-Id: Ia235aa93b9c81fbab066803dc0625856f93acceb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181860
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-02-01 23:41:01 +00:00
Ryan Macnak 1be6531474 [vm, compiler] Fold UnboxInt32(Constant(Mint)) and UnboxDouble(Constant(Mint)) to UnboxedConstant. 
ConstantPropagator_Regress35371 notices the former fails to happen with compressed Smis.

TEST=ci
Change-Id: I4d1e974deec8515469dac4db79dfb0521d3a6e7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181960
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-02-01 22:50:41 +00:00
Ben Konyi 8d99d295da [ VM / Service ] Report identity hash codes of objects at end of heap 
snapshot

TEST=pkg/vm_service/test/object_graph_identity_hash_test.dart

Change-Id: I71eff4e8bb2153d8ef1117bc90d078f678f358ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180484
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-02-01 22:37:21 +00:00
Ryan Macnak bbc7924586 [vm, arm64] Shorten some Smi tagging sequences using bit-field extract instructions. 
TEST=ci
Change-Id: Ifa7f869448573f14b7075c0ebbe5737961e5423c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181961
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-02-01 21:46:41 +00:00
Ryan Macnak 6681bce565 [vm, arm64] Remove dead load from Mint unboxing. 
TEST=ci
Change-Id: Icf0ff5b9b822df9184533fe7163965313b4ac1df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181962
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-02-01 21:14:51 +00:00
Konstantin Shcheglov ef9aea6800 Update recordStaticType to receive non-nullable type. 
Change-Id: Id7c6d4c3aa3da99b331965f9ad9b002b3dc12e29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-01 21:12:11 +00:00
Konstantin Shcheglov 0e4dab0b8b Attempt to fix StringSource on windows bot for dart_style 
Ideally we should stop using it at all.

R=brianwilkerson@google.com

Change-Id: Ifd891518561806794af809fe6ee4c1dbc4a722d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-01 21:04:31 +00:00
Alexander Aprelev 52dee1a66a [vm/concurrency] When deoptimizing, ensure mutators are stopped, then iterate over all threads stack marking the active code for deoptimization. 
TEST=existing ci test suite

Issue dartbug.com/36097.

Change-Id: I166f1ebb00406693b97701407858533556bf640b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181240
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2021-02-01 20:50:01 +00:00
Nicholas Shahan 2b4a3b082b [ddc] Merge remaining diffs in dart_library.js 
- Copy the internal version of dart_library.js without any changes.
- Unblocks syncing this file again.
- Update ddb script to use the dart2js preamble for d8 which includes
  assignment of a global `self` and the fake event loop for better
  error handling.

Change-Id: I01c2ad82fe7c36bb393f9eab897f558daabf6b8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181522
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2021-02-01 19:55:49 +00:00
Devon Carew f93a844060 [sdk docs] validate the sdk docs per commit 
Change-Id: I0521297a1da229b190eb7ec6c7615da445ed5685
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181000
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2021-02-01 19:39:49 +00:00
Konstantin Shcheglov 9f986d2501 Migrate package:analyzer to null safety. 
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-02-01 18:56:04 +00:00
Brian Wilkerson 3c02e96a00 Fix a bug in the calculation of the local variable distance feature 
This change has little or no impact on the relevance scores anywhere
else, but it does improve completion at the beginning of a statement by
1.017 points (in the inverse mrr).

Change-Id: I6b80d85ca13bb2240f466977489d243ee0a4aeb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-02-01 18:54:34 +00:00
pq 2ecc9b76c8 initial sdk API fix data 
Some simple SDK API changes codified in fix data w/ accompanying tests.

Tests are in `tests/lib/fix_data` and run on the pkg bots.

Sample run:

https://ci.chromium.org/ui/p/dart/builders/try/pkg-linux-release-try/46526/steps?succeeded=true&debug=false
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8856735093298466576/+/steps/validate_SDK_API_data-driven_fixes/0/stdout


Change-Id: Id0959d6cde4003f114056c21b9969f2792f21a6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180940
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-02-01 18:47:59 +00:00
Dmitry Stefantsov 425e4dbe09 [cfe] Sort type variables topologically before building the bounds 
Closes #44455.
Closes #34803.
Closes #42434.

Bug: https://github.com/dart-lang/sdk/issues/44455
Bug: https://github.com/dart-lang/sdk/issues/34803
Bug: https://github.com/dart-lang/sdk/issues/42434
Change-Id: I3be93b0d4a251de79c3bfe9829143f0fbec201ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181402
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2021-02-01 18:46:29 +00:00
Alexander Markov 97e2f3ddc5 [vm/aot] Avoid retaining inlined functions with --dwarf_stack_traces 
When --dwarf-stack-trace option is used, we don't use nor write inlined
functions information to the snapshot. However, we were retaining
Function objects corresponding to inlined functions.

On a large app, AOT-compiled in PRODUCT mode with
--dwarf-stack-traces on arm64:

Function objects in AOT snapshot -19.4%
Heap size used by objects in snapshot -4.45%
Total AOT snapshot size -2.35%

Flutter gallery AOT snapshot size
(release mode with --dwarf-stack-traces):
arm64 -1.1% (gzip -1.3%, brotli -1.4%)
arm -0.95% (gzip -1.2%, brotli -1.4%)

TEST=ci

Change-Id: Id2d7a2d6b6bff1a5929be97477b0e17a9afae475
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181700
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
 2021-02-01 18:26:29 +00:00
Brian Wilkerson 216b9d65d8 Change the range of values for features so that features are never disabled 
I believe that this approach will make it much easier for us to make
changes to the ranking order for some suggestions without significantly
changing the ranking order of others. In particular, adding a negative
feature for a subset of suggestions (such as decreasing the rank of
methods named 'noSuchMethod') currently has the effect of decreasing the
rank of everything that isn't a method. This solved that problem by
giving all features a baseline of zero and allowing features to either
increment or decrement the rank from there.

This CL has minimal overall impact on ranking except in the following
areas (values are the inverse mrr):
- keyword void, which regresses from 150.766 to 237.838 (87.071 points)
- local function, which regresses from 24.941 to 173.016 (148.075 points)
- prefix, which improves from 386.455 to 361.611 (24.844 points)
- type parameter, which improves from 269.235 to 249.489 (19.746 points)

The change to 'keyword void' largely shows up in return types of function
declarations, but interestingly enough has little impact on the return
type of method declarations. We might be able to offset this by treating
`void` (and `dynamic`) as types rather than as keywords. I've added that
work item to the list.

The change to local functions doesn't appear to impact any individual
location significantly, and might not be significantly detrimental
because local functions are probably not all that common.

Change-Id: Ifc7002cd6a9d656792ad4ffd76d96df2ab50e4a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-01 16:00:58 +00:00
Sam Rawlins 2caa4689f1 Analyzer: Allow optional 1st and 2nd params in Future.catchError callback 
Change-Id: I448c0e98ae6f86b14b773acb03b04e87c72cc79b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-02-01 15:49:58 +00:00
Jens Johansen 16a66c8902 [parser] Don't crash, try to recover from written out logical operators and and or 
Fixes #44785

Change-Id: I4c7198ea1c223900a58039c032ee303d7da2c14f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181580
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2021-02-01 09:30:48 +00:00
Konstantin Shcheglov 4506981ce5 Issue 44815. Fix for '?.' operator in PropertyAccess and binary AST. 
Bug: https://github.com/dart-lang/sdk/issues/44815
Change-Id: I9a15a2c13885bb8a9461191a4837a053ae08a34e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-01 02:06:08 +00:00
Konstantin Shcheglov 7ee6952828 Test that hover works for typedef, including non-function. 
R=brianwilkerson@google.com

Change-Id: I401e58e6121c55754e467aa25264997bf4082c3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-01 00:32:13 +00:00
Brian Wilkerson 1804309d9c Remove more dead code from server 
Change-Id: I99c58e87b8cc6e02dc9beab0ba9244e63ae1557c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-01 00:32:03 +00:00
Brian Wilkerson 8363ed81b0 Enhance the relevance table generator 
Add support for serializing and deserializing the data and for combining
data from multiple sources. The intent is for this to be used to allow
us to efficiently analyzer larger code bases to get more accurate values.

Change-Id: I89fe11bbfa7acc2cab56c2f06cb9ac06c2a4fb30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-01 00:24:08 +00:00
Brian Wilkerson d1882b6bea Remove the unused class DartContributionSorter 
This was used by the ML support, which has been removed.

Change-Id: Idedb04e31c7b859f8ac0e590fd722958ce40d9ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-01 00:23:59 +00:00
Brian Wilkerson 388b6ff746 Add failing tests for suggesting else in an if element 
Change-Id: I8e04fc190a598c812da68b328e5e5628afa01cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-30 21:09:17 +00:00
Brian Wilkerson 53f5179b45 Improve the placement of added named parameters 
Change-Id: I8ed588c14402a3d85d134dc75c324d9e3d96f532
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181820
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-29 19:33:56 +00:00
Alexander Thomas 48b9d645c0 [sdk] Mark List.empty as @Since("2.9") 
2.9.0 is the first release that included List.empty:
https://api.dart.dev/stable/2.8.4/dart-core/List/List.empty.html (404)
https://api.dart.dev/stable/2.9.0/dart-core/List/List.empty.html (200)

Change-Id: Iddccfd9a38032da6353667fb032fcfcca26c2664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181803
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2021-01-29 16:30:16 +00:00
William Hesse 4a39a9b9fe [infra] Disallow spaces in test configuration names 
Change-Id: Ibd96e414d9a8c76a36b4fc8360ceca3560f1dd91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181404
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2021-01-29 14:55:56 +00:00
Lasse R.H. Nielsen 60e001acf8 Add tests for the user-definable >>> operator. 
Change-Id: I485d8cae7499fd31a69f279c64c3f465241a474d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180843
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2021-01-29 12:49:46 +00:00
Lasse R.H. Nielsen bb5b0ff0ce Fix typed data views throwing. 
Fixes #43204

BUG= http://dartbug.com/43204

Change-Id: I93ee6931900b79ac6755431c90d2b203ccf94ff1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181401
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2021-01-29 09:24:45 +00:00
Konstantin Shcheglov 0c3696d76a Switch refactoring tests to 2.12 + non-function type aliases. 
Change-Id: Iaf366ba1ee5f05d47a6ae102a9c5f2daeb8112c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-29 01:32:35 +00:00
Anna Gringauze d6cf6b6bc9 Pass type parameters to expression evaluation function 
- Pass type parameters to the synthetic expression evaluation
  function
- Add tests

Closes: https://github.com/dart-lang/sdk/issues/44755
Change-Id: Ifbc859b72c616d8f47a76ad9de2cc2aeef67e636
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181660
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Anna Gringauze <annagrin@google.com>
 2021-01-29 01:24:05 +00:00
Liam Appelbe f7eaaf2ce1 [vm] Build configs for compressed pointers 
Change-Id: Ied0f17b2c314ce7e0b5e70989684b95b8e506ffc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181442
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-01-28 23:15:15 +00:00
Paul Berry d35cb900ca Expose _flowAnalysis from ResolverVisitor. 
This saves a lot of plumbing work in the analyzer, because it allows
the individual resolver components to access flow analysis via the
resolver field rather than needing to maintain their own field.  It
should be helpful in supporting the upcoming "why not promoted"
functionality (#38773), which will require flow analysis to be visible
to even more parts of the resolver.

Bug: https://github.com/dart-lang/sdk/issues/38773
Change-Id: Ibea0ec7e263461d6c512b3dad59f10622b2aac6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181661
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-01-28 23:00:05 +00:00
Konstantin Shcheglov 65f8699046 Fix for searching required named parameters, merge SearchTest. 
Change-Id: Iae337b68507bb2ae26bb7d872ca1bba8df329e08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-28 22:57:55 +00:00
Ben Konyi 9fe5f563f4 [ package:vm_service ] Fix some Instance fields not being parsed from JSON 
Fixes https://github.com/dart-lang/sdk/issues/44800

TEST=Manual testing

Change-Id: Id03bc8a6be57c8937c8fa850fbf82227bef8bafb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181720
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
 2021-01-28 22:25:35 +00:00
Alexander Markov 7f65bb475a [vm/snapshot] Add statistics for heap size of objects in snapshot 
This statistics is printed with --print_snapshot_sizes_verbose.
It is useful in order to figure out how much memory is consumed by
program structure objects without running an application.

TEST=manual testing with --print_snapshot_sizes_verbose

Change-Id: I6eeae7b303ecaf44806deb0f532058492c1d5808
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181444
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2021-01-28 21:48:05 +00:00
Daco Harkes 7fbbe4fca3 [vm/ffi] Migrate off .addressOf in tests 
Removes invocations of `.addressOf` in tests.

Removes the constructor from the Coordinate testing class which
has become useless with no access to the underlying pointer.

Removes the bare variant of Coordinate because it is identical to the
non-bare variant.

Issue: https://github.com/dart-lang/sdk/issues/40667

Change-Id: Ie26fa3a9cac38e794e93f5fadfec2562a814c1ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181403
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2021-01-28 21:40:15 +00:00
Daco Harkes 24a7e4387d [vm/ffi] Migrate off .addressOf in samples 
Removes invocations of `.addressOf` in samples.

Removes the constructor from the Coordinate testing class which
has become useless with no access to the underlying pointer.

Issue: https://github.com/dart-lang/sdk/issues/40667


Change-Id: I1e55a4b159662654e1d14b2d51b0b43d734d5010
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181405
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2021-01-28 21:32:55 +00:00
Alexander Aprelev 2525e44a46 [vm/concurrency] Weaken FixCallersTarget assert so it doesn't crash if target_code has been deactivated just now. 
TEST=standalone_2/io/shared_socket_test.dart

Fixes https://github.com/dart-lang/sdk/issues/44790

Issue dartbug.com/36097

Change-Id: I5abc17e7d133671a5a335d147a916559256859d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181520
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2021-01-28 21:16:05 +00:00
asiva 27deca1457 Revert "[vm] Defer object pools." and 
"[vm] Defer object pool entries in instructions bare mode."

This reverts commit 0bf8d38b3d and
             commit 63d17b0ad8.

Reason for revert : Performance regression, please see https://github.com/flutter/flutter/issues/73794

TEST=(none it is a revert).

Change-Id: I828734f00c55d5095f632b154d7f4ab27a184baf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181542
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-01-28 21:13:35 +00:00