Commit Graph

79322 Commits

Author SHA1 Message Date
Ryan Macnak 5a385890b9 [test] Apply simarm64 status file entries to simarm64c.
Remove references to the removed simarmv6 architecture.

TEST=ci
Change-Id: I10e9fc8291c3e5b6b9a4bd71ca05de95e53f22c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187500
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2021-02-25 21:18:02 +00:00
Konstantin Shcheglov 0e9f75c14c Fix for NPE in ReplaceIfElseWithConditional.
Saw it in crashes and was able to reproduce.

Change-Id: I6cb79b51319730636f1a0200ea0ba71e2ece015a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 21:10:27 +00:00
Ryan Macnak 20bc0a0ce1 [vm] Fix annotated pool references when disassembling in JIT mode.
FLAG_use_bare_instructions is vacuously true in JIT mode, so use GetObjectPool which additionally accounts for JIT versus AOT.

TEST=examine output of --disassemble in JIT, AOT compile and AOT runtime
Change-Id: Idae17b779f16a6b823cf702bf868b232ca0e03ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187521
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2021-02-25 21:09:57 +00:00
Konstantin Shcheglov 49642ffaa9 Prepare to publish analyzer 1.1.0 and _fe_analyzer_shared 17.0.0.
Change-Id: I8a79e77d70ad780f5c5b3c3b6cc08f993a5ff16e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187560
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 20:59:57 +00:00
Liam Appelbe 807874d51a [vm] Align compressed pointer allocations on windows.
Change-Id: I95ad0a2cf679a5918d42b12bb95f1503bb219fca
TEST=CI
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184846
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2021-02-25 20:48:07 +00:00
Konstantin Shcheglov f4bf9288cf Rename newAnalysisOptionsYamlFile() and newDotPackagesFile()
Change-Id: I1d11d5c8a7e7fc4f965cd797471dc84a5572fe9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 20:12:46 +00:00
Paul Berry 7d4da6691b Flow analysis: add "why not promoted" functionality for this
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: Ia42db3d9d84d7815e61444990805048c50d1c179
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187063
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2021-02-25 19:53:28 +00:00
Nicholas Shahan ab789de75b [ddc] Add full .dill uri to metadata
Change-Id: I0333b41298c5556d6ce72e339c9eec061b620866
Fixes: https://github.com/dart-lang/sdk/issues/43684
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181861
Reviewed-by: Anna Gringauze <annagrin@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2021-02-25 19:35:41 +00:00
Konstantin Shcheglov 34bec2f1a5 Deprecate AnalysisDriver.contextRoot
Change-Id: I2dfb7f2f751e3c3ba7cdc11c94b9dfa5ddd35670
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 19:35:11 +00:00
Konstantin Shcheglov 0039c061c9 Use ContextRoot.analyzedFiles() to find packages in available declarations.
Change-Id: I8828881af7e1cf55233797644ba411842654d62a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 19:27:36 +00:00
Konstantin Shcheglov daef0206d8 Remove AnalysisEngine.processRequiredPlugins()
Change-Id: I1b93729dea3e9d20c132fcdc523e6b1c3d40b0f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 19:27:06 +00:00
Konstantin Shcheglov 959adec89d Deprecate FunctionTypeAliasElement.
Change-Id: I52b49ecadc7217416341b7d7474ded5b36a8ca73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 19:08:36 +00:00
Danny Tuppeny 0e0118e280 Update yaml package to v3.1.0
Change-Id: I2686afe7bdd9f948b5002f583e1865776f5344a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187463
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2021-02-25 19:02:26 +00:00
Konstantin Shcheglov d15cca43f2 Update ContextRoot to consider any resource in .name folder as excluded.
Change-Id: I815fdf641e102fcea883cb0eed479678f5e9fa2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 18:56:26 +00:00
Lasse R.H. Nielsen ab6558280d Generic metadata test.
Change-Id: I4ce9379e32e90229efddb80f97bac88d5bdd21f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185583
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2021-02-25 18:51:36 +00:00
Martin Kustermann c78f12c550 [vm/concurrency] Allow caller of Thread::{Exit,Enter}Isolate to specify nesting
It's mainly hoisting an expression out of
IsolateGroup::{Increase,Decrease}MutatorCount to callers of it.

Right now we consider a Thread::{Exit,Enter} to be nested if there are
existing Dart frames on the stack. A future CL will have a case where
there's a nested exit&re-enter without Dart frames on the stack.

Trying to do this automatically by checking whether there's an
active api scope / zone on the thread fails due to some
asymmetry in our codebase.

Issue https://github.com/dart-lang/sdk/issues/36097

TEST=Refactoring of existing code.

Change-Id: Id70eda03efb2099487c5f0c8affd25ddff926553
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186287
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2021-02-25 18:44:16 +00:00
Danny Tuppeny 85aecd53f4 [analyzer] Seed overlay modification stamp with DateTime.now().millisecondsSinceEpoch
Fixes https://github.com/Dart-Code/Dart-Code/issues/3160.

Change-Id: If57d37796dc36c06ec4bbd986719cecbbc1a98a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2021-02-25 18:02:36 +00:00
William Hesse 137de39b7a [co19] Roll co19_2 to cf6eed0535e45413672bb5bb6e65df9f59846372
2021-02-25 sgrekhov@unipro.ru 1003. Isolate test fixed to not to be a racy
2020-12-24 sgrekhov@unipro.ru Fixes 496. Change tested date to 1 second instead of 1 day to reduce probability to change timezone on DST
2020-11-11 sgrekhov@unipro.ru Fixes 964. Fix path to the library which test runs
2020-10-08 sgrekhov@unipro.ru Fixes 541. Expect not null stack trace
2020-09-22 sgrekhov@unipro.ru Fixes 940. spawnUri_A05_t01 test fixed to not to be racy
2020-09-11 sgrekhov@unipro.ru Fixes 933. Compile time error fixed
2020-09-01 sgrekhov@unipro.ru Fixes 927. Expect error once on explicit extension invocation
2020-08-24 sgrekhov@unipro.ru Fix FileSystemMoveEventTests to not to fail if there is no Move event
2020-08-24 sgrekhov@unipro.ru Fix FileSystemMoveTests to not to fail if there is no Move event

Change-Id: Ieb94b218f707e0e88c61c45696ee9bba9e3db4b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187460
Reviewed-by: Jonas Termansen <sortie@google.com>
2021-02-25 18:02:20 +00:00
Sergey G. Grekhov d1ce159498 [co19] Enable type aliases tests
Change-Id: I64b9e03fcb883abafdb81e8ede4b2c49ef1c2562
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185082
Reviewed-by: William Hesse <whesse@google.com>
2021-02-25 18:00:50 +00:00
pq ecaabe591b prefer constants for fix kind priorities
Change-Id: I665bd9bab8e2ea54a3b1bf295135f4024f1b2440
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2021-02-25 17:33:36 +00:00
Danny Tuppeny 526e191a57 [analyzer] Return isQualified=true for the name of a constructor
Fixes https://github.com/dart-lang/sdk/issues/45105.

Change-Id: Ic7878bd14e6b9b9ee522b5b7d91f25137ab6f31f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2021-02-25 17:00:41 +00:00
Konstantin Shcheglov 46e4363df5 Enforce lint: always_use_package_imports
Change-Id: Ib7c9f2b4fe3d3d1a874f97f73def6ba1ffaf911e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187360
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 16:57:16 +00:00
Konstantin Shcheglov b3f5c31465 Analyze AndroidManifest.xml files in ContextRoot.analyzedFiles()
Change-Id: I30ceb3c714ffaa498b4f348ed5d3fdc62915feb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 16:52:36 +00:00
William Hesse 8b93898c95 [co19] Skip ffi tests on simarm vm architectures
Fixes: https://github.com/dart-lang/sdk/issues/45073
Change-Id: I87f1ed3d00a243dc3d67de8af6cee272ec2aeefc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186282
Reviewed-by: Daco Harkes <dacoharkes@google.com>
2021-02-25 15:21:17 +00:00
Jens Johansen 741336e40b [kernel] readAndPushTypeParameterList takes useGrowableLists into account
This means that when useGrowableLists is false all empty TypeParameter
lists are the same (unmodifiable) empty list.

When running dart2js in its "linker scenario" on a large internal app
this saves something along the lines of 30MB of memory.

Change-Id: Iee31016d238650de19db584a5617ca4a16889fe7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186940
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2021-02-25 12:02:16 +00:00
Erik Ernst 3d48edf1d6 Corrected unintended syntax error in constant_type_literal_test
Change-Id: I186119c2897e2cbbabed20c57cfed8405be7be0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187082
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
2021-02-25 10:42:36 +00:00
Aske Simon Christensen ead5e5c683 [kernel] Non-nullable enclosingClass for Constructor members
Change-Id: I2a31e4272f9119c229e1eea8a75114f5c2bf82b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186281
Auto-Submit: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2021-02-25 10:40:46 +00:00
Konstantin Shcheglov d54c201932 Fix handling of circular links in ContextRootImpl and ContextLocatorImpl.
Change-Id: Ib1de5a9f6bbf13e72024ddae6c83d3a73dcf24a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 06:01:00 +00:00
Konstantin Shcheglov 8b1c6632c5 Move remaining of file_paths from ContextLocatorImpl.
Change-Id: I7f2362494af731657e59f1189d68790f71d0fc2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 06:00:40 +00:00
Konstantin Shcheglov a629b48fdc Remove file name constants from AnalysisEngine.
Change-Id: I3457973212e704a0fedee20db17956c017ec91ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 05:52:56 +00:00
Konstantin Shcheglov 2c3d4c9d88 Use InstrumentationService instance where available.
Change-Id: I615faf1e74fdd5134a35f0d562c289d8f2d21a1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 05:52:35 +00:00
Konstantin Shcheglov 925df4601b Fix API signature computation when 'static' token moves.
Change-Id: Ice82e8cd06bd4fc5634c9aa8f8e9828e3b79a696
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187300
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-25 05:24:25 +00:00
Stephen Adams 6100737245 [tests] Copy comment from corelib_2/unsigned_shift_test to corelib
Accidentally omitted from https://dart-review.googlesource.com/c/sdk/+/186920

TBR=alexmarkov@google.com

Change-Id: I39d3942f411bc9987f4e817bd05932b460ceca2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187162
Auto-Submit: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2021-02-25 02:28:55 +00:00
pq 94f6b6ec94 migrate multi-fixes to unique fix kinds
Change-Id: If28b89ebeab3be8120cb9189d7c54eb1393beb6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186741
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2021-02-25 00:24:35 +00:00
asiva 02c1e2e56b Remove obsolete comment,
Full snapshots are generated from the clustered snapshot modules
and code in this file is used for only isolate messaging and the comment
about full snapshot does not apply here.

TEST=no tests, just a comment delete.

Change-Id: Ib2453514639aae1c99d3eab6bb120f0ec5ac9f4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186747
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2021-02-24 23:05:14 +00:00
Stephen Adams 6f18bce08d [dart2js] Fix unsigned_shift_test
Original test contains int literals that are illegal on web.

Change-Id: I87ba80ae273792dd5572e9890a339d4d3df34fb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186920
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2021-02-24 22:01:24 +00:00
Brian Wilkerson 71cd2eab85 Add support to the relevance table generator to generate multiple tables for comparison purposes
Change-Id: Iba8dc640540b1689d619a928cc7075c4b17555ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2021-02-24 21:36:34 +00:00
Ryan Macnak 9876de6838 [vm, x64] Cleanup BoxInteger32Instr to remove effects when not using compressed pointers.
TEST=ci
Change-Id: I28dd873a27d6ecc96855b810db55f568c71645ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186763
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
2021-02-24 21:23:54 +00:00
Konstantin Shcheglov 722fb9fbc6 Use file_paths.isAndroidManifestXml() instead of 'manifest.xml'
I am a bit surprised that there are no failing tests before or after.

Change-Id: Ie2f94ba6437f95a95c74ec301f2bcbad4ebd9b49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187100
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-24 21:13:14 +00:00
Konstantin Shcheglov c9332fb487 Renames for check/analyze non-Dart files.
Change-Id: I31d9b19429f73e4c9c40f95cf5e7a55ac4a5a09a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-24 21:10:06 +00:00
Konstantin Shcheglov fd81b73e67 Replace AnalysisEngine.isDartFileName() with file_paths.isDart()
Change-Id: Icf5d524945ffdb7087b96555968804946b4e5af4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-24 21:03:24 +00:00
Konstantin Shcheglov 4366ff1afd Tests and fixes for resolveSymbolicLinksSync()
Change-Id: Ic4266f4ad1f46e405e22986e3660a3889ec7016c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-02-24 21:02:04 +00:00
Stephen Adams 25ca4c490f [dart2js] Use StringInterner to share strings from binary files
Reduces heap in large link scenario by 850MB.

Change-Id: I9dd8c82868b4cc45e6389007348d8b6086c28ee1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186745
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2021-02-24 20:48:34 +00:00
Alexander Aprelev 203532a647 [vm/concurrency] Use SafepointMonitorLocker when enabling background compiler.
The way how BackgroundCompiler::Enable manipulates done_monitor_ lock should match how BackgroundCompiler::Disable manipulates it - by getting to a safepoint if needed.

TEST=Fixes flaky timeouts

Fixes https://github.com/dart-lang/sdk/issues/45108

Change-Id: Iac3e4b864951ccbe904a1031bc7f5a557faf3b41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187061
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2021-02-24 20:43:54 +00:00
Ryan Macnak 1a83a454dd [vm, arm64] Fix simulation of 32-bit clz.
TEST=ci
Change-Id: Ie9cd4d39ed95ec3c770b94c40362c5827ceb4a76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186460
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
2021-02-24 20:18:44 +00:00
Sam Rawlins f32575e43a analyzer: stop mixing WithNullSafety into tests extending PubPackageResolutionTest
Bug: https://github.com/dart-lang/sdk/issues/44666
Change-Id: I01aa8a5908b8a2f195859c4c9fd99e3127249e29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2021-02-24 17:41:44 +00:00
Kallen Tu a5f0e5983b Pipe const-functions flag to kernel/CFE.
Allowing usage of generated experiment flag in the expression_generator, body_builder and eventually, constant_evaluator.
Wanted to keep this CL relatively small and separated from the actual
usage of the flag. Will do that in an upcoming CL.

Change-Id: Ia7c51381496bbde6d25eb47ee1b5cba0e3d7e0cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186620
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
2021-02-24 16:34:34 +00:00
Jacob MacDonald f7e6dd5a18 update shelf, shelf_static, and shelf_packages_handler
Change-Id: I0f238bac68667dae1da2388a43fa4174d6f0e041
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187020
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2021-02-24 16:15:14 +00:00
Sam Rawlins 7718eb1163 analyzer: Remove unused enumElement testing function
Found while looking at call sites to TypeSystemImpl, which I am changing for
generic function types as type arguments.

Change-Id: I6c47f7cdcbe3b2f7051a77484ed904af8bfc67dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185960
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2021-02-24 14:40:54 +00:00
Erik Ernst 96ae7b357e Add type alias cyclicity test, with new syntax, generic function types
Change-Id: I3cf5fa5aeaf914951ceea46062c824c9e25ecbd8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186290
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2021-02-24 13:47:14 +00:00